[jira] [Commented] (HBASE-25494) Compilation failed due to conflict of plugin dependent packages

2021-01-13 Thread Xiaolin Ha (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264655#comment-17264655 ] Xiaolin Ha commented on HBASE-25494: Thanks,[~stack]. It fails on both branch-2 and master. My local

[GitHub] [hbase] virajjasani commented on a change in pull request #2866: HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint

2021-01-13 Thread GitBox
virajjasani commented on a change in pull request #2866: URL: https://github.com/apache/hbase/pull/2866#discussion_r557059396 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestRegionReplicaReplicationEndpoint.java ## @@ -122,7

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264634#comment-17264634 ] Viraj Jasani commented on HBASE-25279: -- >From historical context, One of the critical bugs to make

[GitHub] [hbase] Apache-HBase commented on pull request #2878: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase…

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2878: URL: https://github.com/apache/hbase/pull/2878#issuecomment-759616210 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Created] (HBASE-25504) [branch-2.4] Restore AccessController method removed by HBASE-25277

2021-01-13 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-25504: --- Summary: [branch-2.4] Restore AccessController method removed by HBASE-25277 Key: HBASE-25504 URL: https://issues.apache.org/jira/browse/HBASE-25504

[jira] [Commented] (HBASE-25503) HBase code download is failing on windows with invalid path error

2021-01-13 Thread Mohammad Arshad (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264320#comment-17264320 ] Mohammad Arshad commented on HBASE-25503: - Thanks [~stack] for merging the PR > HBase code

[jira] [Resolved] (HBASE-25504) [branch-2.4] Restore AccessController method removed by HBASE-25277

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell resolved HBASE-25504. - Resolution: Fixed > [branch-2.4] Restore AccessController method removed by

[jira] [Updated] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-25329: - Fix Version/s: (was: 2.4.2) (was: 2.3.5) (was:

[jira] [Updated] (HBASE-25504) [branch-2.4] Restore AccessController method removed by HBASE-25277

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25504: Issue Type: Bug (was: Improvement) > [branch-2.4] Restore AccessController

[GitHub] [hbase] christinefeng commented on pull request #2866: HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint

2021-01-13 Thread GitBox
christinefeng commented on pull request #2866: URL: https://github.com/apache/hbase/pull/2866#issuecomment-759596990 > Left few comments, looks good otherwise. @virajjasani Thanks for the feedback, I've addressed your comments and tested locally.

[GitHub] [hbase] saintstack merged pull request #2880: HBASE-25503: HBase code download is failing on windows with invalid path error

2021-01-13 Thread GitBox
saintstack merged pull request #2880: URL: https://github.com/apache/hbase/pull/2880 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (HBASE-25504) [branch-2.4] Restore AccessController method removed by HBASE-25277

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264322#comment-17264322 ] Andrew Kyle Purtell commented on HBASE-25504: - Fine for master and branch-2, but not

[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264345#comment-17264345 ] Viraj Jasani commented on HBASE-25329: -- Sure thing, let me commit and resolve this Jira. Will

[jira] [Resolved] (HBASE-25317) [github]rename HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf

2021-01-13 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar resolved HBASE-25317. -- Resolution: Duplicate HBASE-25503 fixed this issue. > [github]rename

[jira] [Commented] (HBASE-25503) HBase code download is failing on windows with invalid path error

2021-01-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264319#comment-17264319 ] Michael Stack commented on HBASE-25503: --- There are no references to this doc so rename looks safe.

[jira] [Resolved] (HBASE-25503) HBase code download is failing on windows with invalid path error

2021-01-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25503. --- Hadoop Flags: Reviewed Resolution: Fixed > HBase code download is failing on windows

[jira] [Updated] (HBASE-25504) [branch-2.4] Restore AccessController method removed by HBASE-25277

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25504: Description: We can't do this in a patch release on a LimitedPrivate interface:

[GitHub] [hbase] Apache-HBase commented on pull request #2866: HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2866: URL: https://github.com/apache/hbase/pull/2866#issuecomment-759617420 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264341#comment-17264341 ] Andrew Kyle Purtell commented on HBASE-25329: - [~vjasani][~caroliney14] If you want to make

[jira] [Updated] (HBASE-25504) [branch-2.4] Restore method removed by HBASE-25277 to LP(config) coprocessors

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25504: Summary: [branch-2.4] Restore method removed by HBASE-25277 to LP(config)

[jira] [Commented] (HBASE-24972) Wait for connection attempt to succeed before performing operations on ZK

2021-01-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-24972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264379#comment-17264379 ] Michael Stack commented on HBASE-24972: --- [~prathyu6] Any comment on above? > Wait for connection

[GitHub] [hbase] Apache-HBase commented on pull request #2870: HBASE-24972 Wait for connection attempt to succeed before performing operations on ZK

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2870: URL: https://github.com/apache/hbase/pull/2870#issuecomment-759707524 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[GitHub] [hbase] Apache-HBase commented on pull request #2870: HBASE-24972 Wait for connection attempt to succeed before performing operations on ZK

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2870: URL: https://github.com/apache/hbase/pull/2870#issuecomment-759708578 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2876: HBASE-25494 Compilation failed due to conflict of plugin dependent pa…

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2876: URL: https://github.com/apache/hbase/pull/2876#issuecomment-759738112 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25504) [branch-2.4] Restore method removed by HBASE-25277 to LP(CONFIG) coprocessors

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25504: Summary: [branch-2.4] Restore method removed by HBASE-25277 to LP(CONFIG)

[GitHub] [hbase] saintstack merged pull request #2879: HBASE-25502 IntegrationTestMTTR fails with TableNotFoundException

2021-01-13 Thread GitBox
saintstack merged pull request #2879: URL: https://github.com/apache/hbase/pull/2879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Resolved] (HBASE-25502) IntegrationTestMTTR fails with TableNotFoundException

2021-01-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25502. --- Fix Version/s: 2.4.2 2.3.5 3.0.0-alpha-1 Hadoop

[jira] [Commented] (HBASE-25494) Compilation failed due to conflict of plugin dependent packages

2021-01-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264373#comment-17264373 ] Michael Stack commented on HBASE-25494: --- What branch and what jdk? I'm trying to reproduce your

[jira] [Resolved] (HBASE-25495) fix comment error of admin.rb

2021-01-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-25495. --- Fix Version/s: 3.0.0-alpha-1 Hadoop Flags: Reviewed Resolution: Fixed Merged to

[jira] [Updated] (HBASE-25503) HBase code download is failing on windows with invalid path error

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25503: Fix Version/s: (was: 2.4.2) 2.4.1 > HBase code download is

[jira] [Updated] (HBASE-25502) IntegrationTestMTTR fails with TableNotFoundException

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25502: Fix Version/s: (was: 2.4.2) 2.4.1 > IntegrationTestMTTR

[GitHub] [hbase] Apache-HBase commented on pull request #2866: HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2866: URL: https://github.com/apache/hbase/pull/2866#issuecomment-759704335 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2870: HBASE-24972 Wait for connection attempt to succeed before performing operations on ZK

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2870: URL: https://github.com/apache/hbase/pull/2870#issuecomment-759707662 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Commented] (HBASE-25499) False-positive findbugs issue on branch-2.2

2021-01-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264402#comment-17264402 ] Hudson commented on HBASE-25499: Results for branch branch-2.2 [build #154 on

[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264440#comment-17264440 ] Hudson commented on HBASE-25329: Results for branch branch-2 [build #157 on

[jira] [Commented] (HBASE-25211) Rack awareness in region_mover

2021-01-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264439#comment-17264439 ] Hudson commented on HBASE-25211: Results for branch branch-2 [build #157 on

[jira] [Commented] (HBASE-25476) Enable error prone check in pre commit

2021-01-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264441#comment-17264441 ] Hudson commented on HBASE-25476: Results for branch branch-2 [build #157 on

[GitHub] [hbase] joshelser commented on a change in pull request #2878: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase…

2021-01-13 Thread GitBox
joshelser commented on a change in pull request #2878: URL: https://github.com/apache/hbase/pull/2878#discussion_r556755329 ## File path: hbase-common/src/main/resources/hbase-default.xml ## @@ -1461,15 +1461,15 @@ possible configurations would overwhelm and obscure the

[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264372#comment-17264372 ] Andrew Kyle Purtell commented on HBASE-25329: - Thanks [~vjasani]. Thanks for the

[GitHub] [hbase] saintstack merged pull request #2873: HBASE-25495 fix comment error of admin.rb

2021-01-13 Thread GitBox
saintstack merged pull request #2873: URL: https://github.com/apache/hbase/pull/2873 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] saintstack commented on pull request #2870: HBASE-24972 Wait for connection attempt to succeed before performing operations on ZK

2021-01-13 Thread GitBox
saintstack commented on pull request #2870: URL: https://github.com/apache/hbase/pull/2870#issuecomment-759672495 Rerunning build to see if failures related. This is an automated message from the Apache Git Service. To

[GitHub] [hbase] Apache-HBase commented on pull request #2876: HBASE-25494 Compilation failed due to conflict of plugin dependent pa…

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2876: URL: https://github.com/apache/hbase/pull/2876#issuecomment-759706662 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m

[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-13 Thread Caroline (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264369#comment-17264369 ] Caroline commented on HBASE-25329: -- Thanks [~vjasani] > Dump region hashes in logs for the regions

[GitHub] [hbase] Apache-HBase commented on pull request #2878: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase…

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2878: URL: https://github.com/apache/hbase/pull/2878#issuecomment-759659908 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[jira] [Updated] (HBASE-25476) Enable error prone check in pre commit

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25476: Fix Version/s: (was: 2.4.2) 2.4.1 > Enable error prone

[GitHub] [hbase] Apache-HBase commented on pull request #2866: HBASE-25478 - Implement retries when enabling tables in TestRegionReplicaReplicationEndpoint

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2866: URL: https://github.com/apache/hbase/pull/2866#issuecomment-759705539 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25482) Improve SimpleRegionNormalizer#getAverageRegionSizeMb

2021-01-13 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated HBASE-25482: - Fix Version/s: 2.4.2 3.0.0-alpha-1 > Improve

[jira] [Commented] (HBASE-25476) Enable error prone check in pre commit

2021-01-13 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264500#comment-17264500 ] Hudson commented on HBASE-25476: Results for branch branch-2.3 [build #150 on

[jira] [Commented] (HBASE-25317) [github]rename HBASE-18070-ROOT_hbase:meta_Region_Replicas.pdf

2021-01-13 Thread Michael Stack (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264503#comment-17264503 ] Michael Stack commented on HBASE-25317: --- Thanks [~pankajkumar] for doing the admin. >

[jira] [Updated] (HBASE-25476) Enable error prone check in pre commit

2021-01-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang updated HBASE-25476: -- Fix Version/s: 2.4.2 2.3.5 2.5.0

[jira] [Resolved] (HBASE-25476) Enable error prone check in pre commit

2021-01-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Duo Zhang resolved HBASE-25476. --- Hadoop Flags: Reviewed Resolution: Fixed Pushed to branch-2.3+. Thanks [~zghao] for

[GitHub] [hbase] virajjasani closed pull request #2763: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-13 Thread GitBox
virajjasani closed pull request #2763: URL: https://github.com/apache/hbase/pull/2763 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] virajjasani commented on pull request #2763: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-13 Thread GitBox
virajjasani commented on pull request #2763: URL: https://github.com/apache/hbase/pull/2763#issuecomment-759302288 This is already committed: https://github.com/apache/hbase/commit/f4ad0d09886b7e14d8aeb43e017b19b96d591ce5

[jira] [Commented] (HBASE-25329) Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-13 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17263990#comment-17263990 ] Viraj Jasani commented on HBASE-25329: -- PR#2761 is merged to master and it was cleanly applied to

[GitHub] [hbase] virajjasani commented on a change in pull request #2874: HBASE-25496 add get_namespace_rsgroup command

2021-01-13 Thread GitBox
virajjasani commented on a change in pull request #2874: URL: https://github.com/apache/hbase/pull/2874#discussion_r556362825 ## File path: hbase-shell/src/main/ruby/shell/commands/get_namespace_rsgroup.rb ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF)

[GitHub] [hbase] leyangyueshan commented on a change in pull request #2874: HBASE-25496 add get_namespace_rsgroup command

2021-01-13 Thread GitBox
leyangyueshan commented on a change in pull request #2874: URL: https://github.com/apache/hbase/pull/2874#discussion_r556365043 ## File path: hbase-shell/src/main/ruby/shell/commands/get_namespace_rsgroup.rb ## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation

[GitHub] [hbase] virajjasani commented on a change in pull request #2762: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-13 Thread GitBox
virajjasani commented on a change in pull request #2762: URL: https://github.com/apache/hbase/pull/2762#discussion_r556369037 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ## @@ -3538,18 +3538,31 @@ public void

[GitHub] [hbase] virajjasani commented on a change in pull request #2762: HBASE-25329 Dump region hashes in logs for the regions that are stuck in transition for more than a configured amount of time

2021-01-13 Thread GitBox
virajjasani commented on a change in pull request #2762: URL: https://github.com/apache/hbase/pull/2762#discussion_r556370161 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java ## @@ -3538,18 +3538,31 @@ public void

[jira] [Commented] (HBASE-25505) ZK watcher threads are daemonized; reconsider

2021-01-13 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264559#comment-17264559 ] Bharath Vissapragada commented on HBASE-25505: -- Agree with the opinion. Marking them as

[GitHub] [hbase] leyangyueshan commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …

2021-01-13 Thread GitBox
leyangyueshan commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759888910 > I think the type of this patch should be bug other than improvement, if it is true, maybe we'd better to update the related unit test, since it does not cover this case.

[GitHub] [hbase] leyangyueshan commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …

2021-01-13 Thread GitBox
leyangyueshan commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759889908 ![image](https://user-images.githubusercontent.com/21099711/104538049-1be37600-5656-11eb-8a73-76a50f54e7c6.png)

[GitHub] [hbase] Apache-HBase commented on pull request #2858: HBASE-25482 Improve SimpleRegionNormalizer#getAverageRegionSizeMb

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2858: URL: https://github.com/apache/hbase/pull/2858#issuecomment-759891756 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759892298 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759893985 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759894224 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] Apache-HBase commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759897924 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759899603 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m

[GitHub] [hbase] Apache-HBase commented on pull request #2875: HBASE-25497 move_namespaces_rsgroup should change hbase.rsgroup.name …

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2875: URL: https://github.com/apache/hbase/pull/2875#issuecomment-759899751 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[GitHub] [hbase] bharathv commented on a change in pull request #2769: HBASE-25032 Wait for region server to become online before adding it to online servers in Master

2021-01-13 Thread GitBox
bharathv commented on a change in pull request #2769: URL: https://github.com/apache/hbase/pull/2769#discussion_r557017830 ## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMaster.java ## @@ -100,6 +104,25 @@ public static void afterAllTests() throws

[GitHub] [hbase] pankaj72981 merged pull request #2779: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2021-01-13 Thread GitBox
pankaj72981 merged pull request #2779: URL: https://github.com/apache/hbase/pull/2779 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Comment Edited] (HBASE-23340) hmaster /hbase/replication/rs session expired (hbase replication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits i

2021-01-13 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264578#comment-17264578 ] Pankaj Kumar edited comment on HBASE-23340 at 1/14/21, 3:38 AM: Thanks

[jira] [Updated] (HBASE-23340) hmaster /hbase/replication/rs session expired (hbase replication default value is true, we don't use ) causes logcleaner can not clean oldWALs, which resulits in oldWA

2021-01-13 Thread Pankaj Kumar (Jira)
[ https://issues.apache.org/jira/browse/HBASE-23340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pankaj Kumar updated HBASE-23340: - Fix Version/s: 2.5.0 3.0.0-alpha-1 Resolution: Fixed

[GitHub] [hbase] petersomogyi merged pull request #2877: HBASE-25499 False-positive findbugs issue on branch-2.2

2021-01-13 Thread GitBox
petersomogyi merged pull request #2877: URL: https://github.com/apache/hbase/pull/2877 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hbase] Apache9 commented on a change in pull request #2861: HBASE-25455 Add trace support for HRegion read/write operation

2021-01-13 Thread GitBox
Apache9 commented on a change in pull request #2861: URL: https://github.com/apache/hbase/pull/2861#discussion_r556333417 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java ## @@ -6637,23 +6655,27 @@ protected RowLock

[jira] [Updated] (HBASE-25499) False-positive findbugs issue on branch-2.2

2021-01-13 Thread Peter Somogyi (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-25499: -- Fix Version/s: 2.2.7 Resolution: Fixed Status: Resolved (was: Patch

[GitHub] [hbase] shenshengli commented on pull request #2878: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase…

2021-01-13 Thread GitBox
shenshengli commented on pull request #2878: URL: https://github.com/apache/hbase/pull/2878#issuecomment-759855122 Thank you for your revision so that this change can proceed quickly. This is an automated message from the

[jira] [Updated] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-13 Thread shenshengli (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenshengli updated HBASE-25449: Description: I think this parameter is not suitable for in hbase-default.xml, because in this

[GitHub] [hbase] cuibo01 commented on pull request #2511: HBASE-24960 reduce invalid subprocedure task

2021-01-13 Thread GitBox
cuibo01 commented on pull request #2511: URL: https://github.com/apache/hbase/pull/2511#issuecomment-759859195 @saintstack pls review...thx This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] cuibo01 commented on pull request #2779: HBASE-23340 hmaster /hbase/replication/rs session expired (hbase repl…

2021-01-13 Thread GitBox
cuibo01 commented on pull request #2779: URL: https://github.com/apache/hbase/pull/2779#issuecomment-759860457 @Apache9 pls review,thx This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [hbase] cuibo01 commented on pull request #2690: HBASE-24395 Backport HBASE-20589 to branch-1

2021-01-13 Thread GitBox
cuibo01 commented on pull request #2690: URL: https://github.com/apache/hbase/pull/2690#issuecomment-759861104 @saintstack @pankaj72981 pls review,and merge. thx This is an automated message from the Apache Git Service. To

[GitHub] [hbase] cuibo01 commented on pull request #2843: HBASE-25461 when the cluster has many tables, UI can be opened quickly

2021-01-13 Thread GitBox
cuibo01 commented on pull request #2843: URL: https://github.com/apache/hbase/pull/2843#issuecomment-759862051 @Apache9 @saintstack @pankaj72981 pls review, thx This is an automated message from the Apache Git Service. To

[jira] [Updated] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-25279: --- Fix Version/s: (was: 2.4.2) > Non-daemon thread in ZKWatcher > -- >

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264533#comment-17264533 ] Andrew Kyle Purtell commented on HBASE-25279: - Don't commit it there, please. Not everyone

[jira] [Updated] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-25279: --- Fix Version/s: 2.4.2 > Non-daemon thread in ZKWatcher > -- > >

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Duo Zhang (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264534#comment-17264534 ] Duo Zhang commented on HBASE-25279: --- I think this is a bug fix, without the patch it is impossible to

[jira] [Comment Edited] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264535#comment-17264535 ] Josh Elser edited comment on HBASE-25279 at 1/14/21, 1:49 AM: -- bq. Don't

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264536#comment-17264536 ] Andrew Kyle Purtell commented on HBASE-25279: - [~elserj] [~bharathv] [~larsh] So what do

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264537#comment-17264537 ] Andrew Kyle Purtell commented on HBASE-25279: - Why is the watcher not being closed? That is

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264543#comment-17264543 ] Andrew Kyle Purtell commented on HBASE-25279: - I was going to wait until we have a proper

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264545#comment-17264545 ] Andrew Kyle Purtell commented on HBASE-25279: - Ok, I've thought about it, and I'm going to

[jira] [Updated] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell updated HBASE-25279: Fix Version/s: 2.4.1 > Non-daemon thread in ZKWatcher >

[jira] [Resolved] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Kyle Purtell resolved HBASE-25279. - Resolution: Fixed > Non-daemon thread in ZKWatcher >

[jira] [Commented] (HBASE-25279) Non-daemon thread in ZKWatcher

2021-01-13 Thread Andrew Kyle Purtell (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264547#comment-17264547 ] Andrew Kyle Purtell commented on HBASE-25279: - Filed HBASE-25505 for follow up > Non-daemon

[jira] [Created] (HBASE-25505) ZK watcher threads are daemonized; reconsider

2021-01-13 Thread Andrew Kyle Purtell (Jira)
Andrew Kyle Purtell created HBASE-25505: --- Summary: ZK watcher threads are daemonized; reconsider Key: HBASE-25505 URL: https://issues.apache.org/jira/browse/HBASE-25505 Project: HBase

[GitHub] [hbase] joshelser commented on pull request #2816: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-13 Thread GitBox
joshelser commented on pull request #2816: URL: https://github.com/apache/hbase/pull/2816#issuecomment-759883012 This was submitted, reverted due to breaking tests, but then resubmitted after fixing those tests in #2878

[GitHub] [hbase] joshelser closed pull request #2878: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase…

2021-01-13 Thread GitBox
joshelser closed pull request #2878: URL: https://github.com/apache/hbase/pull/2878 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hbase] joshelser closed pull request #2816: HBASE-25449 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-13 Thread GitBox
joshelser closed pull request #2816: URL: https://github.com/apache/hbase/pull/2816 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-13 Thread Josh Elser (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Josh Elser updated HBASE-25449: --- Resolution: Fixed Status: Resolved (was: Patch Available) Re-resolving. Hopefully this

[GitHub] [hbase] Apache-HBase commented on pull request #2858: HBASE-25482 Improve SimpleRegionNormalizer#getAverageRegionSizeMb

2021-01-13 Thread GitBox
Apache-HBase commented on pull request #2858: URL: https://github.com/apache/hbase/pull/2858#issuecomment-759853316 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m

[jira] [Updated] (HBASE-25449) 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml

2021-01-13 Thread shenshengli (Jira)
[ https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] shenshengli updated HBASE-25449: Description: I think this parameter is not suitable for in hbase-default.xml, because in this

  1   2   >