[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-09-26 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114941#comment-13114941 ] Lars Hofhansl commented on HBASE-4488: -- The fact that this has not tripped any test (

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-09-26 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114948#comment-13114948 ] Lars Hofhansl commented on HBASE-4488: -- Also removes two unused variables and an unus

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-09-26 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13114964#comment-13114964 ] Lars Hofhansl commented on HBASE-4335: -- @Stack... Not sure how you can test the actua

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-09-26 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115071#comment-13115071 ] Lars Hofhansl commented on HBASE-4335: -- @Joe... Understood. :) And you are right abou

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-09-26 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115075#comment-13115075 ] Lars Hofhansl commented on HBASE-4335: -- Ran all test. There are three failures locall

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-09-26 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115220#comment-13115220 ] Lars Hofhansl commented on HBASE-4488: -- Looking at the StoreScanner/ScanQueryMatcher

[jira] [Commented] (HBASE-4496) HFile V2 does not honor setCacheBlocks when scanning.

2011-09-27 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115706#comment-13115706 ] Lars Hofhansl commented on HBASE-4496: -- I'll come up with a patch. >

[jira] [Commented] (HBASE-4496) HFile V2 does not honor setCacheBlocks when scanning.

2011-09-27 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115775#comment-13115775 ] Lars Hofhansl commented on HBASE-4496: -- In a simple test this shaves about 20% of sca

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-09-27 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115805#comment-13115805 ] Lars Hofhansl commented on HBASE-4488: -- @Jon, so you gonna commit this? :)

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-09-27 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115877#comment-13115877 ] Lars Hofhansl commented on HBASE-4488: -- Not yet... :) > Store could

[jira] [Commented] (HBASE-3130) [replication] ReplicationSource can't recover from session expired on remote clusters

2011-09-27 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116072#comment-13116072 ] Lars Hofhansl commented on HBASE-3130: -- You sound like you are surprised :)

[jira] [Commented] (HBASE-4496) HFile V2 does not honor setCacheBlocks when scanning.

2011-09-27 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116101#comment-13116101 ] Lars Hofhansl commented on HBASE-4496: -- That sounds like a plan Jon. Let me know if y

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-09-28 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116547#comment-13116547 ] Lars Hofhansl commented on HBASE-4488: -- Looks like HBASE-4433 can potentially trigger

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-09-28 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13116572#comment-13116572 ] Lars Hofhansl commented on HBASE-4488: -- Nothing to worry once this is committed. Just

[jira] [Commented] (HBASE-3130) [replication] ReplicationSource can't recover from session expired on remote clusters

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117718#comment-13117718 ] Lars Hofhansl commented on HBASE-3130: -- +1 > [replication] Replicati

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117724#comment-13117724 ] Lars Hofhansl commented on HBASE-4335: -- I think when this is fixed we can mark HBASE-

[jira] [Commented] (HBASE-4501) [replication] Shutting down a stream leaves recovered sources running

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117752#comment-13117752 ] Lars Hofhansl commented on HBASE-4501: -- So is this just a matter of calling terminate

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117759#comment-13117759 ] Lars Hofhansl commented on HBASE-4335: -- I split up SplitTransaction.execute is three

[jira] [Commented] (HBASE-4422) Move block cache parameters and references into single CacheConf class

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117832#comment-13117832 ] Lars Hofhansl commented on HBASE-4422: -- Want me to take your latest patch and fold my

[jira] [Commented] (HBASE-4412) no need to retry scan operation on the same server in the case of RegionServerStoppedException

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4412?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117833#comment-13117833 ] Lars Hofhansl commented on HBASE-4412: -- +1 > no need to retry scan o

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-29 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117839#comment-13117839 ] Lars Hofhansl commented on HBASE-4487: -- How does that relate to the logic in HLog.syn

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-09-30 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118222#comment-13118222 ] Lars Hofhansl commented on HBASE-4487: -- @ramkrishna and @dhruba. I agree with ramkris

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-09-30 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118237#comment-13118237 ] Lars Hofhansl commented on HBASE-4335: -- Agreed that HBASE-4334 is important. At least

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-09-30 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118290#comment-13118290 ] Lars Hofhansl commented on HBASE-4334: -- I think the best way here is to check the sta

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-09-30 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118689#comment-13118689 ] Lars Hofhansl commented on HBASE-4334: -- Sigh... I think you're right. Probably a lot

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-09-30 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118691#comment-13118691 ] Lars Hofhansl commented on HBASE-4334: -- Actually it looks like only a single test was

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-10-01 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118918#comment-13118918 ] Lars Hofhansl commented on HBASE-4334: -- In turns out that coprocessor can - legitimat

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-10-01 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118942#comment-13118942 ] Lars Hofhansl commented on HBASE-4334: -- Ran all tests. Got this: Tests run: 1021, Fai

[jira] [Commented] (HBASE-4487) The increment operation can release the rowlock before sync-ing the Hlog

2011-10-01 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13118960#comment-13118960 ] Lars Hofhansl commented on HBASE-4487: -- Is this too risky for 0.92? I guess we have t

[jira] [Commented] (HBASE-4496) HFile V2 does not honor setCacheBlocks when scanning.

2011-10-02 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119062#comment-13119062 ] Lars Hofhansl commented on HBASE-4496: -- Tried Mikhail's patch with my test scenario.

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-10-03 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119458#comment-13119458 ] Lars Hofhansl commented on HBASE-4334: -- There's a thread on the mailing about a simil

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-10-03 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119459#comment-13119459 ] Lars Hofhansl commented on HBASE-4334: -- Wanna commit this Ted? > HRe

[jira] [Commented] (HBASE-4334) HRegion.get never validates row

2011-10-03 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119586#comment-13119586 ] Lars Hofhansl commented on HBASE-4334: -- Probably... Maybe let it bake in 0.92/trunk f

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-03 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119780#comment-13119780 ] Lars Hofhansl commented on HBASE-4536: -- @Andrew: Agree. There's no point really in se

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-03 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119923#comment-13119923 ] Lars Hofhansl commented on HBASE-4536: -- Started to look at the code. Scanning now ha

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-04 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119932#comment-13119932 ] Lars Hofhansl commented on HBASE-4536: -- There's a fourth scan type: 4. Memstore flush

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-04 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120469#comment-13120469 ] Lars Hofhansl commented on HBASE-4536: -- Turns out that currently it is not at all pos

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-04 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120603#comment-13120603 ] Lars Hofhansl commented on HBASE-4536: -- Re: "New config param". Wasn't sure in the be

[jira] [Commented] (HBASE-4501) [replication] Shutting down a stream leaves recovered sources running

2011-10-04 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120621#comment-13120621 ] Lars Hofhansl commented on HBASE-4501: -- +1 > [replication] Shutting

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-04 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120654#comment-13120654 ] Lars Hofhansl commented on HBASE-4536: -- @Ted, yep... That's what the parent is :)

[jira] [Commented] (HBASE-4422) Move block cache parameters and references into single CacheConf class

2011-10-04 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120655#comment-13120655 ] Lars Hofhansl commented on HBASE-4422: -- +1 as well, seems low risk.

[jira] [Commented] (HBASE-4479) TestMasterFailover failure in Hbase-0.92#17

2011-10-04 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120665#comment-13120665 ] Lars Hofhansl commented on HBASE-4479: -- +1 looks good to me > TestMa

[jira] [Commented] (HBASE-4541) [book] book.xml - claritying schema design section on versions

2011-10-05 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121103#comment-13121103 ] Lars Hofhansl commented on HBASE-4541: -- Looks good +1. NB: this may change slightly

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-05 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121166#comment-13121166 ] Lars Hofhansl commented on HBASE-4536: -- You are right. I have a new version of the p

[jira] [Commented] (HBASE-4241) Optimize flushing of the Store cache for max versions and (new) min versions

2011-10-05 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121568#comment-13121568 ] Lars Hofhansl commented on HBASE-4241: -- Hi Liyin, just seeing this now. Let me have a

[jira] [Commented] (HBASE-4241) Optimize flushing of the Store cache for max versions and (new) min versions

2011-10-05 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121594#comment-13121594 ] Lars Hofhansl commented on HBASE-4241: -- During memstore flush we only want to read fr

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-05 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121734#comment-13121734 ] Lars Hofhansl commented on HBASE-4536: -- Thinking about this a bit more. I think this

[jira] [Commented] (HBASE-4402) Retaining locality after restart broken

2011-10-05 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121741#comment-13121741 ] Lars Hofhansl commented on HBASE-4402: -- We just ran into this yesterday in our 0.92 b

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-05 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121762#comment-13121762 ] Lars Hofhansl commented on HBASE-4536: -- That might be getting hard to understand. min

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-06 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122322#comment-13122322 ] Lars Hofhansl commented on HBASE-4536: -- A simple option would be to only allow the "K

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-10-06 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122482#comment-13122482 ] Lars Hofhansl commented on HBASE-4488: -- I see that Store.compactStore does the same t

[jira] [Commented] (HBASE-4333) Client does not check for holes in .META.

2011-10-06 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122496#comment-13122496 ] Lars Hofhansl commented on HBASE-4333: -- I would prefer to have a log message on the s

[jira] [Commented] (HBASE-4462) Properly treating SocketTimeoutException

2011-10-06 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122515#comment-13122515 ] Lars Hofhansl commented on HBASE-4462: -- So this problem is fixed in 0.92 it seems. If

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-07 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122933#comment-13122933 ] Lars Hofhansl commented on HBASE-4536: -- Another option for the problem above is, to n

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-10-07 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123342#comment-13123342 ] Lars Hofhansl commented on HBASE-4335: -- I like those names. Will do. @Jon. Initially

[jira] [Commented] (HBASE-4333) Client does not check for holes in .META.

2011-10-07 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123360#comment-13123360 ] Lars Hofhansl commented on HBASE-4333: -- The standard ClientScanner will do the right

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-07 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123368#comment-13123368 ] Lars Hofhansl commented on HBASE-4536: -- Yet another option is to take the smallest ti

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-10-07 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123383#comment-13123383 ] Lars Hofhansl commented on HBASE-4488: -- I'll open another jira and fix all those.

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-10-07 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123384#comment-13123384 ] Lars Hofhansl commented on HBASE-4488: -- created HBASE-4556 > Store c

[jira] [Commented] (HBASE-4102) atomicAppend: A put that appends to the latest version of a cell; i.e. reads current value then adds the bytes offered by the client to the tail and writes out a new en

2011-10-08 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13123572#comment-13123572 ] Lars Hofhansl commented on HBASE-4102: -- I have this working now. But now I realized

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-10 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124372#comment-13124372 ] Lars Hofhansl commented on HBASE-4536: -- This issue is pretty resistant to all my atte

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-10 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124376#comment-13124376 ] Lars Hofhansl commented on HBASE-4536: -- and 3a. Have Store.java keep track of the ear

[jira] [Commented] (HBASE-4556) Fix all incorrect uses of InternalScanner.next(...)

2011-10-10 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124387#comment-13124387 ] Lars Hofhansl commented on HBASE-4556: -- Many scanners only return false when there ar

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-10 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124665#comment-13124665 ] Lars Hofhansl commented on HBASE-4536: -- That's what I concluded shortly after I poste

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-10-10 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124728#comment-13124728 ] Lars Hofhansl commented on HBASE-4335: -- Results : Tests run: 1031, Failures: 0, Erro

[jira] [Commented] (HBASE-4556) Fix all incorrect uses of InternalScanner.next(...)

2011-10-10 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124745#comment-13124745 ] Lars Hofhansl commented on HBASE-4556: -- I think we could use some tests that (somehow

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124768#comment-13124768 ] Lars Hofhansl commented on HBASE-4536: -- You mean set TTL to FOREVER and minVersions t

[jira] [Commented] (HBASE-4102) atomicAppend: A put that appends to the latest version of a cell; i.e. reads current value then adds the bytes offered by the client to the tail and writes out a new en

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125134#comment-13125134 ] Lars Hofhansl commented on HBASE-4102: -- All tests pass. > atomicAppe

[jira] [Commented] (HBASE-4102) atomicAppend: A put that appends to the latest version of a cell; i.e. reads current value then adds the bytes offered by the client to the tail and writes out a new en

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125374#comment-13125374 ] Lars Hofhansl commented on HBASE-4102: -- Agree with trunk only (otherwise never get 0.

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125399#comment-13125399 ] Lars Hofhansl commented on HBASE-4536: -- I think I'd like to keep the error, to avoid

[jira] [Commented] (HBASE-4556) Fix all incorrect uses of InternalScanner.next(...)

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125475#comment-13125475 ] Lars Hofhansl commented on HBASE-4556: -- Another pattern to use would be: {code} whil

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125482#comment-13125482 ] Lars Hofhansl commented on HBASE-4536: -- Converted to feature. > Allo

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-10-11 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125581#comment-13125581 ] Lars Hofhansl commented on HBASE-4335: -- Double checked that the failed test pass loca

[jira] [Commented] (HBASE-4102) atomicAppend: A put that appends to the latest version of a cell; i.e. reads current value then adds the bytes offered by the client to the tail and writes out a new en

2011-10-12 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126137#comment-13126137 ] Lars Hofhansl commented on HBASE-4102: -- At closer look Append and Put are subtly diff

[jira] [Commented] (HBASE-4488) Store could miss rows during flush

2011-10-12 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126185#comment-13126185 ] Lars Hofhansl commented on HBASE-4488: -- Let's do this as part of HBASE-4556.

[jira] [Commented] (HBASE-4102) atomicAppend: A put that appends to the latest version of a cell; i.e. reads current value then adds the bytes offered by the client to the tail and writes out a new en

2011-10-12 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126203#comment-13126203 ] Lars Hofhansl commented on HBASE-4102: -- Created HBASE-4583 for RWCC discussion.

[jira] [Commented] (HBASE-4556) Fix all incorrect uses of InternalScanner.next(...)

2011-10-12 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126260#comment-13126260 ] Lars Hofhansl commented on HBASE-4556: -- Running tests... Just to be sure... Will comm

[jira] [Commented] (HBASE-4556) Fix all incorrect uses of InternalScanner.next(...)

2011-10-12 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126339#comment-13126339 ] Lars Hofhansl commented on HBASE-4556: -- It turns out most of the test are written in

[jira] [Commented] (HBASE-4558) Refactor TestOpenedRegionHandler and TestOpenRegionHandler.

2011-10-13 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13126768#comment-13126768 ] Lars Hofhansl commented on HBASE-4558: -- I don't think the addendum needs to be mentio

[jira] [Commented] (HBASE-4335) Splits can create temporary holes in .META. that confuse clients and regionservers

2011-10-13 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127251#comment-13127251 ] Lars Hofhansl commented on HBASE-4335: -- Ted already pointed that out to me :)

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-15 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128305#comment-13128305 ] Lars Hofhansl commented on HBASE-4536: -- @Ted, I can change the order in which the che

[jira] [Commented] (HBASE-4562) When split doing offlineParentInMeta encounters error, it'll cause data loss

2011-10-15 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128348#comment-13128348 ] Lars Hofhansl commented on HBASE-4562: -- Are the attached patches the full story? I se

[jira] [Commented] (HBASE-4563) When split doing this.parent.close(false) occurs error,it'll cause the splited region cann't write & read

2011-10-15 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128350#comment-13128350 ] Lars Hofhansl commented on HBASE-4563: -- +1 on patches (pending all tests pass and Ted

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-15 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128355#comment-13128355 ] Lars Hofhansl commented on HBASE-4536: -- Fair enough. Was picking up on Stack's sugges

[jira] [Commented] (HBASE-3443) ICV optimization to look in memstore first and then store files (HBASE-3082) does not work when deletes are in the mix

2011-10-16 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-3443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128564#comment-13128564 ] Lars Hofhansl commented on HBASE-3443: -- I agree. I think delete handling is generally

[jira] [Commented] (HBASE-4562) When split doing offlineParentInMeta encounters error, it'll cause data loss

2011-10-16 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128573#comment-13128573 ] Lars Hofhansl commented on HBASE-4562: -- I see... Thanks Ted. > When

[jira] [Commented] (HBASE-4562) When split doing offlineParentInMeta encounters error, it'll cause data loss

2011-10-16 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128602#comment-13128602 ] Lars Hofhansl commented on HBASE-4562: -- +1 for latest patches (assuming all tests pas

[jira] [Commented] (HBASE-4563) When error occurs in this.parent.close(false) of split, the split region cannot write or read

2011-10-16 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128660#comment-13128660 ] Lars Hofhansl commented on HBASE-4563: -- @Ted... You wanna commit, or should I? I'm ha

[jira] [Commented] (HBASE-4562) When split doing offlineParentInMeta encounters error, it'll cause data loss

2011-10-16 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128675#comment-13128675 ] Lars Hofhansl commented on HBASE-4562: -- Committing this too. > When

[jira] [Commented] (HBASE-4562) When split doing offlineParentInMeta encounters error, it'll cause data loss

2011-10-16 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13128678#comment-13128678 ] Lars Hofhansl commented on HBASE-4562: -- 0.90 patch fails to apply. @bluedavy, could y

[jira] [Commented] (HBASE-4562) When split doing offlineParentInMeta encounters error, it'll cause data loss

2011-10-17 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129457#comment-13129457 ] Lars Hofhansl commented on HBASE-4562: -- No problem. Thanks for patch :)

[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte arrays...

2011-10-19 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131086#comment-13131086 ] Lars Hofhansl commented on HBASE-4626: -- Exactly! There are a bunch subclasses of Wri

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-19 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131168#comment-13131168 ] Lars Hofhansl commented on HBASE-4536: -- So we have three +1's now. Ted, Jonathan... a

[jira] [Commented] (HBASE-4536) Allow CF to retain deleted rows

2011-10-19 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131196#comment-13131196 ] Lars Hofhansl commented on HBASE-4536: -- @Ted, ah yes... Will do. @Jonathan, you mean

[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte arrays...

2011-10-19 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131203#comment-13131203 ] Lars Hofhansl commented on HBASE-4626: -- Also there are many more filters that do this

[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte arrays...

2011-10-19 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131354#comment-13131354 ] Lars Hofhansl commented on HBASE-4626: -- I will commit this to trunk tomorrow, unless

[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte arrays...

2011-10-19 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131358#comment-13131358 ] Lars Hofhansl commented on HBASE-4626: -- All tests pass BTW. (TestHFileBlock fails wit

[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte arrays...

2011-10-19 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13131360#comment-13131360 ] Lars Hofhansl commented on HBASE-4626: -- Well, actually... It is a performance improve

[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte arrays...

2011-10-20 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132299#comment-13132299 ] Lars Hofhansl commented on HBASE-4626: -- Committed to trunk. > Filter

[jira] [Commented] (HBASE-4626) Filters unnecessarily copy byte arrays...

2011-10-20 Thread Lars Hofhansl (Commented) (JIRA)
[ https://issues.apache.org/jira/browse/HBASE-4626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132318#comment-13132318 ] Lars Hofhansl commented on HBASE-4626: -- In the widest sense this could be considered

  1   2   3   4   5   6   7   8   9   10   >