[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[ https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033536#comment-14033536 ] Sergey Soldatov commented on HBASE-11069: - It seems that the failure of findbugs is not related to this patch and was introduced earlier. Decouple region merging from ZooKeeper -- Key: HBASE-11069 URL: https://issues.apache.org/jira/browse/HBASE-11069 Project: HBase Issue Type: Sub-task Components: Consensus, Zookeeper Reporter: Sergey Soldatov Assignee: Sergey Soldatov Attachments: HBASE-11069.patch, HBASE_11069-v2.patch, HBASE_11069-v3.patch, HBASE_11069-v4.patch, HBASE_11069-v5.patch, HBASE_11069-v6.patch Region Merge should be decoupled from ZK. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[ https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033706#comment-14033706 ] stack commented on HBASE-11069: --- [~sergey.soldatov] Is latest patch up in review board? Thank you. Decouple region merging from ZooKeeper -- Key: HBASE-11069 URL: https://issues.apache.org/jira/browse/HBASE-11069 Project: HBase Issue Type: Sub-task Components: Consensus, Zookeeper Reporter: Sergey Soldatov Assignee: Sergey Soldatov Attachments: HBASE-11069.patch, HBASE_11069-v2.patch, HBASE_11069-v3.patch, HBASE_11069-v4.patch, HBASE_11069-v5.patch, HBASE_11069-v6.patch Region Merge should be decoupled from ZK. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[ https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033713#comment-14033713 ] Sergey Soldatov commented on HBASE-11069: - Here it is https://reviews.apache.org/r/22680/ Decouple region merging from ZooKeeper -- Key: HBASE-11069 URL: https://issues.apache.org/jira/browse/HBASE-11069 Project: HBase Issue Type: Sub-task Components: Consensus, Zookeeper Reporter: Sergey Soldatov Assignee: Sergey Soldatov Attachments: HBASE-11069.patch, HBASE_11069-v2.patch, HBASE_11069-v3.patch, HBASE_11069-v4.patch, HBASE_11069-v5.patch, HBASE_11069-v6.patch Region Merge should be decoupled from ZK. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[ https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033895#comment-14033895 ] Hudson commented on HBASE-11069: SUCCESS: Integrated in HBase-TRUNK #5213 (See [https://builds.apache.org/job/HBase-TRUNK/5213/]) HBASE-11069 Decouple region merging from ZooKeeper (Sergey Soldatov) (stack: rev e476947d3f87708acce630372fef30bc13959b4c) * hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkRegionMergeCoordination.java * hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java * hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionMergeTransaction.java * hbase-server/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java * hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkCoordinatedStateManager.java * hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/RegionMergeCoordination.java * hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/BaseCoordinatedStateManager.java Decouple region merging from ZooKeeper -- Key: HBASE-11069 URL: https://issues.apache.org/jira/browse/HBASE-11069 Project: HBase Issue Type: Sub-task Components: Consensus, Zookeeper Reporter: Sergey Soldatov Assignee: Sergey Soldatov Fix For: 0.99.0 Attachments: 11069v7.txt, HBASE-11069.patch, HBASE_11069-v2.patch, HBASE_11069-v3.patch, HBASE_11069-v4.patch, HBASE_11069-v5.patch, HBASE_11069-v6.patch Region Merge should be decoupled from ZK. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[
https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032470#comment-14032470
]
Hadoop QA commented on HBASE-11069:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12650570/HBASE_11069-v5.patch
against trunk revision .
ATTACHMENT ID: 12650570
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:red}-1 patch{color}. The patch command could not apply the patch.
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9777//console
This message is automatically generated.
Decouple region merging from ZooKeeper
--
Key: HBASE-11069
URL: https://issues.apache.org/jira/browse/HBASE-11069
Project: HBase
Issue Type: Sub-task
Components: Consensus, Zookeeper
Reporter: Sergey Soldatov
Assignee: Sergey Soldatov
Attachments: HBASE-11069.patch, HBASE_11069-v2.patch,
HBASE_11069-v3.patch, HBASE_11069-v4.patch, HBASE_11069-v5.patch
Region Merge should be decoupled from ZK.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[ https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032519#comment-14032519 ] stack commented on HBASE-11069: --- [~sergey.soldatov] Do you need to rebase sir? Decouple region merging from ZooKeeper -- Key: HBASE-11069 URL: https://issues.apache.org/jira/browse/HBASE-11069 Project: HBase Issue Type: Sub-task Components: Consensus, Zookeeper Reporter: Sergey Soldatov Assignee: Sergey Soldatov Attachments: HBASE-11069.patch, HBASE_11069-v2.patch, HBASE_11069-v3.patch, HBASE_11069-v4.patch, HBASE_11069-v5.patch Region Merge should be decoupled from ZK. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[ https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14032556#comment-14032556 ] Sergey Soldatov commented on HBASE-11069: - Oops. I'll do it in a moment. Decouple region merging from ZooKeeper -- Key: HBASE-11069 URL: https://issues.apache.org/jira/browse/HBASE-11069 Project: HBase Issue Type: Sub-task Components: Consensus, Zookeeper Reporter: Sergey Soldatov Assignee: Sergey Soldatov Attachments: HBASE-11069.patch, HBASE_11069-v2.patch, HBASE_11069-v3.patch, HBASE_11069-v4.patch, HBASE_11069-v5.patch Region Merge should be decoupled from ZK. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[
https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14033276#comment-14033276
]
Hadoop QA commented on HBASE-11069:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12650675/HBASE_11069-v6.patch
against trunk revision .
ATTACHMENT ID: 12650675
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 findbugs{color}. The patch appears to introduce 1 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ server != null server.getCoordinatedStateManager() != null ?
((BaseCoordinatedStateManager) server
+ server != null server.getCoordinatedStateManager() != null ?
((BaseCoordinatedStateManager) server
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9780//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9780//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9780//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9780//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9780//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9780//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9780//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9780//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9780//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9780//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9780//console
This message is automatically generated.
Decouple region merging from ZooKeeper
--
Key: HBASE-11069
URL: https://issues.apache.org/jira/browse/HBASE-11069
Project: HBase
Issue Type: Sub-task
Components: Consensus, Zookeeper
Reporter: Sergey Soldatov
Assignee: Sergey Soldatov
Attachments: HBASE-11069.patch, HBASE_11069-v2.patch,
HBASE_11069-v3.patch, HBASE_11069-v4.patch, HBASE_11069-v5.patch,
HBASE_11069-v6.patch
Region Merge should be decoupled from ZK.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[
https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030937#comment-14030937
]
stack commented on HBASE-11069:
---
[~sergey.soldatov] nit, you should look at the below in generated javadoc...
+ * Coordination operations for region merge transaction. The operation should
be coordinated at the
+ * following stages:
+ * 1. startRegionMergeTransaction - all preparation/initialization for merge
region transaction
+ * 2. waitForRegionMergeTransaction - wait until coordination complete all
works related to merge
+ * 3. confirmRegionMergeTransaction - confirm that the merge could be
completed and none of
+ *merging regions moved somehow
+ * 4. completeRegionMergeTransaction - all steps that are required to complete
the transaction.
+ *Called after PONR (point of no return)
... to see how it displays (mangled).
That said, nice doc. Pity it doesn't diplay properly.
This works in java6?
+ /**
+ * Dummy interface for region merge transaction details.
+ */
+ public static interface RegionMergeDetails {
+ }
Otherwise patch looks good.
[~mantonov] You reviewed this?
Decouple region merging from ZooKeeper
--
Key: HBASE-11069
URL: https://issues.apache.org/jira/browse/HBASE-11069
Project: HBase
Issue Type: Sub-task
Components: Consensus, Zookeeper
Reporter: Sergey Soldatov
Assignee: Sergey Soldatov
Attachments: HBASE-11069.patch, HBASE_11069-v2.patch,
HBASE_11069-v3.patch, HBASE_11069-v4.patch
Region Merge should be decoupled from ZK.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[ https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14030998#comment-14030998 ] Mikhail Antonov commented on HBASE-11069: - [~stack] not the latest one yet, let me take a look. Decouple region merging from ZooKeeper -- Key: HBASE-11069 URL: https://issues.apache.org/jira/browse/HBASE-11069 Project: HBase Issue Type: Sub-task Components: Consensus, Zookeeper Reporter: Sergey Soldatov Assignee: Sergey Soldatov Attachments: HBASE-11069.patch, HBASE_11069-v2.patch, HBASE_11069-v3.patch, HBASE_11069-v4.patch Region Merge should be decoupled from ZK. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[ https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14031074#comment-14031074 ] Mikhail Antonov commented on HBASE-11069: - Looks good to me. I would be +1 - just a few tiny nits: - ZkRegionMergeCoordination and AssignementManger have unnecessary import, TestMasterFailover has unnecessary typecast - in the javadoc of RegionMergeCoordination may worth to add notes pointing where (Rs or master) each of key methods execute within. Decouple region merging from ZooKeeper -- Key: HBASE-11069 URL: https://issues.apache.org/jira/browse/HBASE-11069 Project: HBase Issue Type: Sub-task Components: Consensus, Zookeeper Reporter: Sergey Soldatov Assignee: Sergey Soldatov Attachments: HBASE-11069.patch, HBASE_11069-v2.patch, HBASE_11069-v3.patch, HBASE_11069-v4.patch Region Merge should be decoupled from ZK. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[
https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029112#comment-14029112
]
Hadoop QA commented on HBASE-11069:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12650031/HBASE_11069-v3.patch
against trunk revision .
ATTACHMENT ID: 12650031
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 6 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public ZkRegionMergeCoordination(CoordinatedStateManager
consensusProvider, ZooKeeperWatcher watcher) {
+ public void waitForRegionMergeTransaction(RegionServerServices services,
HRegionInfo mergedRegionInfo,
+if (consensus.getServer() == null ||
consensus.getServer().getCoordinatedStateManager() == null) {
+ } while (zrmd.getZnodeVersion() != -1
!consensus.getServer().isStopped() !services.isStopping());
+ zrmd.setZnodeVersion(ZKAssign.transitionNode(watcher, merged,
serverName, beginState, endState,
+((BaseCoordinatedStateManager)
server.getCoordinatedStateManager()).getRegionMergeCoordination()
+ server != null server.getCoordinatedStateManager() != null ?
((BaseCoordinatedStateManager) server
+
.getCoordinatedStateManager()).getRegionMergeCoordination().getDefaultDetails()
: null;
+ ((BaseCoordinatedStateManager)
server.getCoordinatedStateManager()).getRegionMergeCoordination()
+ server != null server.getCoordinatedStateManager() != null ?
((BaseCoordinatedStateManager) server
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 3 zombie test(s):
at
org.apache.hadoop.hbase.regionserver.TestHRegion.testWritesWhileGetting(TestHRegion.java:3500)
at
org.apache.hadoop.hbase.regionserver.TestHRegion.testWritesWhileScanning(TestHRegion.java:3299)
at
org.apache.hadoop.hbase.mapreduce.TestImportExport.testImport94Table(TestImportExport.java:230)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9756//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9756//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9756//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9756//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9756//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9756//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9756//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9756//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9756//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9756//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9756//console
This message is automatically generated.
Decouple region merging from ZooKeeper
--
Key: HBASE-11069
URL: https://issues.apache.org/jira/browse/HBASE-11069
Project: HBase
Issue Type: Sub-task
Components: Consensus, Zookeeper
Reporter: Sergey Soldatov
Assignee: Sergey Soldatov
Attachments: HBASE-11069.patch, HBASE_11069-v2.patch,
HBASE_11069-v3.patch
Region Merge should be decoupled from ZK.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[
https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14029622#comment-14029622
]
Hadoop QA commented on HBASE-11069:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12650084/HBASE_11069-v4.patch
against trunk revision .
ATTACHMENT ID: 12650084
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+if (consensus.getServer() == null ||
consensus.getServer().getCoordinatedStateManager() == null) {
+transitionMergingNode(merged, a, b, serverName, rmd, RS_ZK_REGION_MERGING,
RS_ZK_REGION_MERGING);
+ server != null server.getCoordinatedStateManager() != null ?
((BaseCoordinatedStateManager) server
+ server != null server.getCoordinatedStateManager() != null ?
((BaseCoordinatedStateManager) server
+ ((BaseCoordinatedStateManager)
server.getCoordinatedStateManager()).getRegionMergeCoordination()
+((BaseCoordinatedStateManager)
server.getCoordinatedStateManager()).getRegionMergeCoordination()
+ ((BaseCoordinatedStateManager)
server.getCoordinatedStateManager()).getRegionMergeCoordination().clean(
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9757//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9757//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9757//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9757//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9757//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9757//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9757//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9757//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9757//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9757//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9757//console
This message is automatically generated.
Decouple region merging from ZooKeeper
--
Key: HBASE-11069
URL: https://issues.apache.org/jira/browse/HBASE-11069
Project: HBase
Issue Type: Sub-task
Components: Consensus, Zookeeper
Reporter: Sergey Soldatov
Assignee: Sergey Soldatov
Attachments: HBASE-11069.patch, HBASE_11069-v2.patch,
HBASE_11069-v3.patch, HBASE_11069-v4.patch
Region Merge should be decoupled from ZK.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[ https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996800#comment-13996800 ] Mikhail Antonov commented on HBASE-11069: - A few comments: - merge consensus interface and impl class should be annotated as InterfaceAudience.Private - as discussed offline, in both split and merge consensus let's have clear designation (javadoc/method names?) as to where this code is running - HM or HRS. Decouple region merging from ZooKeeper -- Key: HBASE-11069 URL: https://issues.apache.org/jira/browse/HBASE-11069 Project: HBase Issue Type: Sub-task Components: Consensus, Zookeeper Reporter: Sergey Soldatov Attachments: HBASE-11069.patch, HBASE_11069-v2.patch Region Merge should be decoupled from ZK. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[ https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13995872#comment-13995872 ] Sergey Soldatov commented on HBASE-11069: - Could someone add me to the project contributors, so I will be assign it to me? Decouple region merging from ZooKeeper -- Key: HBASE-11069 URL: https://issues.apache.org/jira/browse/HBASE-11069 Project: HBase Issue Type: Sub-task Components: Consensus, Zookeeper Reporter: Sergey Soldatov Attachments: HBASE-11069.patch, HBASE_11069-v2.patch Region Merge should be decoupled from ZK. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[
https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13996045#comment-13996045
]
Hadoop QA commented on HBASE-11069:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12644525/HBASE_11069-v2.patch
against trunk revision .
ATTACHMENT ID: 12644525
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ rmd = server != null server.getConsensusProvider() != null ?
((BaseConsensusProvider) server
+ public void prepareForMerge(Server server, RegionServerServices services,
HRegionInfo mergedRegionInfo,
+ public void prepareForMerge(Server server, RegionServerServices services,
HRegionInfo mergedRegionInfo,
+ *
org.apache.hadoop.hbase.regionserver.consensus.RegionMergeConsensus#finishRegionMergeTransaction
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9510//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9510//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9510//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9510//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9510//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9510//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9510//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9510//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9510//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9510//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9510//console
This message is automatically generated.
Decouple region merging from ZooKeeper
--
Key: HBASE-11069
URL: https://issues.apache.org/jira/browse/HBASE-11069
Project: HBase
Issue Type: Sub-task
Components: Consensus, Zookeeper
Reporter: Sergey Soldatov
Attachments: HBASE-11069.patch, HBASE_11069-v2.patch
Region Merge should be decoupled from ZK.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[ https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13987251#comment-13987251 ] Mikhail Antonov commented on HBASE-11069: - linked jira about getting consensus provider instance from Server impl Decouple region merging from ZooKeeper -- Key: HBASE-11069 URL: https://issues.apache.org/jira/browse/HBASE-11069 Project: HBase Issue Type: Sub-task Components: Consensus, Zookeeper Reporter: Sergey Soldatov Attachments: HBASE-11069.patch Region Merge should be decoupled from ZK. -- This message was sent by Atlassian JIRA (v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[
https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980122#comment-13980122
]
Hadoop QA commented on HBASE-11069:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12641757/HBASE-11069.patch
against trunk revision .
ATTACHMENT ID: 12641757
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.regionserver.TestRegionMergeTransactionOnCluster
org.apache.hadoop.hbase.master.TestMasterFailover
org.apache.hadoop.hbase.snapshot.TestFlushSnapshotFromClient
org.apache.hadoop.hbase.util.TestHBaseFsck
{color:red}-1 core zombie tests{color}. There are 2 zombie test(s):
at
org.apache.hadoop.hbase.coprocessor.TestRegionServerObserver.testCoprocessorHooksInRegionsMerge(TestRegionServerObserver.java:97)
at
org.apache.hadoop.hbase.mapreduce.TestTableMapReduceBase.testMultiRegionTable(TestTableMapReduceBase.java:96)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/9392//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/9392//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/9392//console
This message is automatically generated.
Decouple region merging from ZooKeeper
--
Key: HBASE-11069
URL: https://issues.apache.org/jira/browse/HBASE-11069
Project: HBase
Issue Type: Sub-task
Components: Consensus, Zookeeper
Reporter: Sergey Soldatov
Attachments: HBASE-11069.patch
As part of HBASE-10296 Region Merge should be decoupled from Zookeeper.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[
https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980221#comment-13980221
]
Ted Yu commented on HBASE-11069:
Looks like the following was related to the patch:
{code}
2014-04-24 18:17:34,540 WARN [RS:1;asf002:56406-merges-1398363454525]
regionserver.RegionMergeRequest(96): Running rollback/cleanup of failed merge
of testCleanMergeReference,,1398363451973.2a35b85f67ff243c9be0988b4d837a51. and
testCleanMergeReference,testRow0020,1398363451973.773139e77db1c7fde5d4538e5233e378.;
null
java.lang.NullPointerException
at
org.apache.hadoop.hbase.regionserver.RegionMergeTransaction.stepsBeforePONR(RegionMergeTransaction.java:365)
at
org.apache.hadoop.hbase.regionserver.RegionMergeTransaction.createMergedRegion(RegionMergeTransaction.java:283)
at
org.apache.hadoop.hbase.regionserver.RegionMergeTransaction.execute(RegionMergeTransaction.java:240)
at
org.apache.hadoop.hbase.regionserver.RegionMergeRequest.run(RegionMergeRequest.java:86)
{code}
Decouple region merging from ZooKeeper
--
Key: HBASE-11069
URL: https://issues.apache.org/jira/browse/HBASE-11069
Project: HBase
Issue Type: Sub-task
Components: Consensus, Zookeeper
Reporter: Sergey Soldatov
Attachments: HBASE-11069.patch
As part of HBASE-10296 Region Merge should be decoupled from Zookeeper.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (HBASE-11069) Decouple region merging from ZooKeeper
[ https://issues.apache.org/jira/browse/HBASE-11069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13980386#comment-13980386 ] stack commented on HBASE-11069: --- Similar comments as those over on the split patch. We don't init and start the consensus on this one though: -if (RegionMergeTransaction.transitionMergingNode(watcher, p, +ConsensusProvider consensus = ConsensusProviderFactory.getConsensusProvider(server.getConfiguration()); +if (consensus.getRegionMergeConsensus().transitionMergingNode(watcher, p, hri_a, hri_b, sn, -1, EventType.RS_ZK_REQUEST_REGION_MERGE, Should the split and merge be symmetrical? And we are passing in zk: -createNodeMerging(server.getZooKeeper(), this.mergedRegionInfo, - server.getServerName(), region_a.getRegionInfo(), region_b.getRegionInfo()); + consensus.getRegionMergeConsensus().createNodeMerging(server.getZooKeeper(), +this.mergedRegionInfo, server.getServerName(), region_a.getRegionInfo(), +region_b.getRegionInfo()); when I'd expect it to be hidden behind the Interface buried in the implementation (if possible). Good stuff Sergey. Decouple region merging from ZooKeeper -- Key: HBASE-11069 URL: https://issues.apache.org/jira/browse/HBASE-11069 Project: HBase Issue Type: Sub-task Components: Consensus, Zookeeper Reporter: Sergey Soldatov Attachments: HBASE-11069.patch As part of HBASE-10296 Region Merge should be decoupled from Zookeeper. -- This message was sent by Atlassian JIRA (v6.2#6252)
