[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137881#comment-16137881 ] Hudson commented on HBASE-12349: FAILURE: Integrated in Jenkins build HBase-Trunk_matrix #3580 (See [https://builds.apache.org/job/HBase-Trunk_matrix/3580/]) HBASE-12349 Add custom error-prone module (mdrob: rev 51d458872d703acdd853dd7b3149794d585ba285) * (edit) hbase-common/pom.xml * (add) hbase-build-support/hbase-error-prone/pom.xml * (edit) hbase-external-blockcache/pom.xml * (edit) hbase-resource-bundle/pom.xml * (edit) hbase-client/pom.xml * (edit) hbase-shaded/pom.xml * (edit) hbase-spark-it/pom.xml * (edit) hbase-testing-util/pom.xml * (add) hbase-build-support/pom.xml * (edit) hbase-rsgroup/pom.xml * (edit) hbase-rest/pom.xml * (edit) hbase-spark/pom.xml * (edit) hbase-examples/pom.xml * (edit) hbase-hadoop-compat/pom.xml * (edit) hbase-thrift/pom.xml * (edit) hbase-prefix-tree/pom.xml * (edit) hbase-endpoint/pom.xml * (edit) hbase-protocol-shaded/pom.xml * (edit) hbase-server/pom.xml * (edit) hbase-assembly/pom.xml * (edit) hbase-hadoop2-compat/pom.xml * (add) hbase-build-support/hbase-error-prone/src/main/java/org/apache/hadoop/hbase/errorprone/AlwaysPasses.java * (edit) hbase-protocol/pom.xml * (edit) hbase-shell/pom.xml * (edit) hbase-annotations/pom.xml * (edit) pom.xml * (edit) hbase-procedure/pom.xml * (add) hbase-build-configuration/pom.xml * (edit) hbase-it/pom.xml * (edit) hbase-metrics/pom.xml * (edit) hbase-assembly/src/main/assembly/src.xml * (edit) hbase-metrics-api/pom.xml * (edit) hbase-archetypes/pom.xml > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob >Priority: Blocker > Fix For: 3.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch, > HBASE-12349.v6.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137444#comment-16137444 ] Mike Drob commented on HBASE-12349: --- [~busbey] - Filed HBASE-18655. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch, > HBASE-12349.v6.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16137432#comment-16137432 ] Hadoop QA commented on HBASE-12349: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 18s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 53s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m 38s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 40s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 7m 41s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 15m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m 53s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 11m 45s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 8m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 39s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 33m 47s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 18m 6s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 7m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 7s{color} | {color:green} hbase-build-support in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 8s{color} | {color:green} hbase-error-prone in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 6s{color} | {color:green} hbase-build-configuration in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 7s{color} | {color:green} hbase-resource-bundle in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 7s{color} | {color:green} hbase-annotations in the patch passed. {color} | | {color:green}+1{color} | {color:green}
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136840#comment-16136840 ] Sean Busbey commented on HBASE-12349: - mind doing a {{git bisect}} and making sure it's tracked? +1 on v6 > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch, > HBASE-12349.v6.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136144#comment-16136144 ] Mike Drob commented on HBASE-12349: --- org.apache.hadoop.hbase.client.TestAsyncClusterAdminApi2 fails locally for me without the patch as well. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch, > HBASE-12349.v6.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16136121#comment-16136121 ] Hadoop QA commented on HBASE-12349: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 18s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 53s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 27s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 7m 25s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 14m 7s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m 53s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 21s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 14m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 14m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m 36s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 10m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 58s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 39m 59s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 17m 21s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 9s{color} | {color:green} hbase-build-support in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 9s{color} | {color:green} hbase-error-prone in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 7s{color} | {color:green} hbase-build-configuration in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 7s{color} | {color:green} hbase-resource-bundle in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 9s{color} | {color:green} hbase-annotations in the patch passed. {color} | | {color:green}+1{color} | {color:green}
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134206#comment-16134206 ] Sean Busbey commented on HBASE-12349: - just a heads up, since I don't want to make this a blocker for the next alpha I may pull the addition of the hbase-build-configuration module into HBASE-17823 if it looks like that's going to land first. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134149#comment-16134149 ] Sean Busbey commented on HBASE-12349: - generated source tarball with: {code} $ git clean -xdfff $ mvn clean install -DskipTests assembly:single -Dassembly.file=hbase-assembly/src/main/assembly/src.xml -Prelease {code} Looks like it's got some extra cruft: {code} $ mkdir /tmp/hbase_cc0b245_src $ tar -C /tmp/hbase_cc0b245_src -xzf hbase-assembly/target/hbase-3.0.0-SNAPSHOT-src.tar.gz $ diff -r . /tmp/hbase_cc0b245_src/hbase-3.0.0-SNAPSHOT/ Only in .: .git Only in .: .gitattributes Only in .: .gitignore Only in .: .pylintrc Only in /tmp/hbase_cc0b245_src/hbase-3.0.0-SNAPSHOT/hbase-build-support/hbase-error-prone: target Only in .: hbase-native-client Only in /tmp/hbase_cc0b245_src/hbase-3.0.0-SNAPSHOT/hbase-protocol-shaded: dependency-reduced-pom.xml {code} Some of those have been around awhile, some are new-to-me. I think only the target directory in the hbase-error-prone module is from this patch. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16129713#comment-16129713 ] stack commented on HBASE-12349: --- Marking as blocker. Almost done... > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16125976#comment-16125976 ] Mike Drob commented on HBASE-12349: --- Missed your question earlier, [~stack]. The bin tarball doesn't have any hbase-build-support jar in it, it has all the other same things it did before though. The src tarball has the new modules though, and I verified that by building a new assembly from the generated assembly as suggested in the release docs (https://hbase.apache.org/book.html#maven.release) > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111979#comment-16111979 ] stack commented on HBASE-12349: --- This looks interesting Mr Drob. What does a tarball have in it? The jars are hbase-*.jar or hbase-build-support-*.jar? > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16100844#comment-16100844 ] Mike Drob commented on HBASE-12349: --- The 'errorProfile' profile existed before, I'm moving some stuff around for it though. I tested, everything still works with profile disabled. With profile enabled, compilation fails pretty early and we'll need follow on issues to work through the "new" errors. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16100788#comment-16100788 ] Andrew Purtell commented on HBASE-12349: +1 Skimmed the maven bits. I wouldn't know if they'd work unless I tried them, assuming it's been tested. Please advise otherwise. I see the new 'errorProne' profile enables this, and it's off by default. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16098518#comment-16098518 ] Mike Drob commented on HBASE-12349: --- Bump. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16093422#comment-16093422 ] Mike Drob commented on HBASE-12349: --- [~apurtell] - WDYT? > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16092278#comment-16092278 ] Hadoop QA commented on HBASE-12349: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 18s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 11s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 13m 0s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 59s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 8m 23s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 26s{color} | {color:red} hbase-protocol-shaded in master has 27 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 11s{color} | {color:red} hbase-server in master has 9 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 39s{color} | {color:red} hbase-rest in master has 3 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m 31s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 18s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 11m 17s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 7m 22s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 40s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 31m 4s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 18m 52s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 9m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 9s{color} | {color:green} hbase-build-support in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 9s{color} | {color:green} hbase-error-prone in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 6s{color} | {color:green} hbase-build-configuration in the
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091392#comment-16091392 ] Hadoop QA commented on HBASE-12349: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 17s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 28s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 3m 12s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 10m 20s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 19s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 6m 50s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 1m 58s{color} | {color:red} hbase-protocol-shaded in master has 27 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 39s{color} | {color:red} hbase-server in master has 9 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 32s{color} | {color:red} hbase-rest in master has 3 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 58s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 12m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 7m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 43s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 33m 41s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 8s{color} | {color:red} hbase-error-prone in the patch failed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m 1s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 10s{color} | {color:green} hbase-build-support in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 9s{color} | {color:green} hbase-error-prone in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 7s{color} | {color:green}
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088388#comment-16088388 ] Hadoop QA commented on HBASE-12349: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 21s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s{color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 5 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 47s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 39s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 13m 5s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 4m 2s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 8m 20s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 2m 29s{color} | {color:red} hbase-protocol-shaded in master has 27 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 3m 24s{color} | {color:red} hbase-server in master has 9 extant Findbugs warnings. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 38s{color} | {color:red} hbase-rest in master has 3 extant Findbugs warnings. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 57s{color} | {color:green} master passed {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 16s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 11m 58s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 11m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 11m 18s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 3m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 7m 35s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 39s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 33m 2s{color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha4. {color} | | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Skipped patched modules with no Java source: hbase-build-support hbase-build-configuration hbase-resource-bundle hbase-testing-util hbase-spark-it hbase-assembly hbase-shaded hbase-archetypes . {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 8s{color} | {color:red} hbase-error-prone in the patch failed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 8m 30s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 8s{color} | {color:green} hbase-build-support in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 7s{color} | {color:green} hbase-error-prone in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 6s{color} | {color:green} hbase-build-configuration in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 7s{color} |
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16077298#comment-16077298 ] Andrew Purtell commented on HBASE-12349: I don't think we want to do this by default but can turn on under the release profile for RCs and nightlies. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16076864#comment-16076864 ] Mike Drob commented on HBASE-12349: --- Was hacking around on this yesterday, it's a little bit tricky because if we create a new module and introduce a top-level dependency for javac on it then that model can't build because of the bootstrapping problem. Haven't figured out how to override that in just the module, I feel like there should be a maven incantation for it but I haven't found it yet. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell > Fix For: 2.0.0 > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075606#comment-16075606 ] Andrew Purtell commented on HBASE-12349: Oh that's great, because packaging up HBase build specific rules into a custom version was basically a nonstarter > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell > Fix For: 2.0.0 > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16075564#comment-16075564 ] Mike Drob commented on HBASE-12349: --- This might be easier now: {quote} Maven Starting in version 3.5, maven-compiler-plugin allows the processor path to be configured with the annotationProcessorPaths parameter. For a complete example, see: [examples/plugin/maven|https://github.com/google/error-prone/tree/master/examples/plugin/maven]. {quote} So I think we could add the additional bug checks without needing to fork or publish a custom error-prone version. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell > Fix For: 2.0.0 > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14500285#comment-14500285 ] Ding Yuan commented on HBASE-12349: --- Ping. Just checking if the custom error-prone has been integrated? Or if there is anything that I can further help? Add Maven build support module for a custom version of error-prone -- Key: HBASE-12349 URL: https://issues.apache.org/jira/browse/HBASE-12349 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Fix For: 2.0.0 Add a new Maven build support module that builds and publishes a custom error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14187656#comment-14187656 ] Andrew Purtell commented on HBASE-12349: Related discussion on enabling or disabling bugcheckers or promoting warnings to errors and vice versa by way of command line: https://groups.google.com/forum/#!topic/error-prone-discuss/v00Vr_pFxJg As long as we can set such options from the Maven compiler plugin configuration we should be able to eventually wrap all module compilations with error-prone without changing it such that a fork is necessary. Add Maven build support module for a custom version of error-prone -- Key: HBASE-12349 URL: https://issues.apache.org/jira/browse/HBASE-12349 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Fix For: 2.0.0 Add a new Maven build support module that builds and publishes a custom error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185318#comment-14185318 ] Andrew Purtell commented on HBASE-12349: [~d.yuan] kindly implemented the 'Aspirator' static analysis as a custom error-prone version based on 1.1.2, containing three new bugcheckers, and pushed this to: https://github.com/diy1/error-prone-aspirator The original error-prone source distribution was released by Google under the ASL 2.0 (https://code.google.com/p/error-prone/) The custom distribution mentioned above carries it forward (https://github.com/diy1/error-prone-aspirator/blob/master/COPYING) Any concerns with importing this wholesale into an HBase build support module? Add Maven build support module for a custom version of error-prone -- Key: HBASE-12349 URL: https://issues.apache.org/jira/browse/HBASE-12349 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Add a new Maven build support module that builds and publishes a custom error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185329#comment-14185329 ] Andrew Purtell commented on HBASE-12349: Ping the RM crew: [~enis] [~lhofhansl] [~stack] Add Maven build support module for a custom version of error-prone -- Key: HBASE-12349 URL: https://issues.apache.org/jira/browse/HBASE-12349 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Fix For: 2.0.0 Add a new Maven build support module that builds and publishes a custom error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185331#comment-14185331 ] Andrew Purtell commented on HBASE-12349: [~eclark], we talked before about tucking hbase-checkstyle under a common parent for build support modules, assuming that's still not a problem? (It worked for me previously.) Add Maven build support module for a custom version of error-prone -- Key: HBASE-12349 URL: https://issues.apache.org/jira/browse/HBASE-12349 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Fix For: 2.0.0 Add a new Maven build support module that builds and publishes a custom error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185339#comment-14185339 ] Elliott Clark commented on HBASE-12349: --- No, in fact it's great. Sorry I didn't get to it. Add Maven build support module for a custom version of error-prone -- Key: HBASE-12349 URL: https://issues.apache.org/jira/browse/HBASE-12349 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Fix For: 2.0.0 Add a new Maven build support module that builds and publishes a custom error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185351#comment-14185351 ] Andrew Purtell commented on HBASE-12349: BTW, another thing I'd like to do with a custom error-prone is add support for disabling certain bugcheckers at the package level, to address https://issues.apache.org/jira/browse/HBASE-11912?focusedCommentId=14176448page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14176448 along with suitably annotated package-info.java files (http://docs.oracle.com/javase/specs/jls/se7/html/jls-7.html#jls-7.4.1) in the protobuf 'generated' packages. Add Maven build support module for a custom version of error-prone -- Key: HBASE-12349 URL: https://issues.apache.org/jira/browse/HBASE-12349 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Fix For: 2.0.0 Add a new Maven build support module that builds and publishes a custom error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185354#comment-14185354 ] Andrew Purtell commented on HBASE-12349: Actually the above might work today, let me try it. If it works I'll propose the change in a new subtask of the parent of this issue Add Maven build support module for a custom version of error-prone -- Key: HBASE-12349 URL: https://issues.apache.org/jira/browse/HBASE-12349 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Fix For: 2.0.0 Add a new Maven build support module that builds and publishes a custom error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185378#comment-14185378 ] Lars Hofhansl commented on HBASE-12349: --- Sounds good to me. I assume 2.0.0 only? (At least in 0.94 this would not make much sense) Add Maven build support module for a custom version of error-prone -- Key: HBASE-12349 URL: https://issues.apache.org/jira/browse/HBASE-12349 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Fix For: 2.0.0 Add a new Maven build support module that builds and publishes a custom error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185419#comment-14185419 ] Andrew Purtell commented on HBASE-12349: It may not be necessary to fork error-prone if we just need to add additional custom bugcheckers. See https://groups.google.com/forum/#!topic/error-prone-discuss/WL-mNWt3R9M Add Maven build support module for a custom version of error-prone -- Key: HBASE-12349 URL: https://issues.apache.org/jira/browse/HBASE-12349 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Fix For: 2.0.0 Add a new Maven build support module that builds and publishes a custom error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185420#comment-14185420 ] Andrew Purtell commented on HBASE-12349: bq. Sounds good to me. I assume 2.0.0 only? Depending on how it goes in master, I'd like to eventually port this back to all active branches Add Maven build support module for a custom version of error-prone -- Key: HBASE-12349 URL: https://issues.apache.org/jira/browse/HBASE-12349 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Fix For: 2.0.0 Add a new Maven build support module that builds and publishes a custom error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14186138#comment-14186138 ] Andrew Purtell commented on HBASE-12349: bq. add support for disabling certain bugcheckers at the package level [...] along with suitably annotated package-info.java files in the protobuf 'generated' packages ... So much for that, the SuppressWarnings annotation type doesn't have a PACKAGE level target, on purpose (and see http://stackoverflow.com/questions/8910759/why-cant-i-suppresswarnings-on-a-package) Add Maven build support module for a custom version of error-prone -- Key: HBASE-12349 URL: https://issues.apache.org/jira/browse/HBASE-12349 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Fix For: 2.0.0 Add a new Maven build support module that builds and publishes a custom error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)