[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573024#comment-14573024 ] Hudson commented on HBASE-13658: FAILURE: Integrated in HBase-1.0 #946 (See [https://builds.apache.org/job/HBase-1.0/946/]) HBASE-13658 Improve the test run time for TestAccessController class (ssrungarapu: rev 9046b37ee6dfc2a276be2ff0eaebc445ee7cdc7c) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-branch-1.0.patch, HBASE-13658-branch-1.1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14573082#comment-14573082 ] Hudson commented on HBASE-13658: SUCCESS: Integrated in HBase-1.1 #523 (See [https://builds.apache.org/job/HBase-1.1/523/]) HBASE-13658 Improve the test run time for TestAccessController class (ssrungarapu: rev 205ed40f19e2fbf3eb2c1c254131a09d9b800cad) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-branch-1.0.patch, HBASE-13658-branch-1.1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570701#comment-14570701 ] Ashish Singhi commented on HBASE-13658: --- I have attached patches for those branches. Thanks Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.13, 1.2.0 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-branch-1.0.patch, HBASE-13658-branch-1.1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570354#comment-14570354 ] Srikanth Srungarapu commented on HBASE-13658: - Can you please upload the patches for those branches? Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.13, 1.2.0 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570063#comment-14570063 ] Hudson commented on HBASE-13658: FAILURE: Integrated in HBase-1.2 #128 (See [https://builds.apache.org/job/HBase-1.2/128/]) HBASE-13658 Improve the test run time for TestAccessController class (Ashish Singhi) (ssrungarapu: rev ce636701ff16e41e957c21c82356c732e9b2fcfb) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.13, 1.2.0 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14570318#comment-14570318 ] Ashish Singhi commented on HBASE-13658: --- Any reason why the changes did not push to branch-1.0 and branch-1.1 ? Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.13, 1.2.0 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14561577#comment-14561577 ] Andrew Purtell commented on HBASE-13658: Sorry about the Canary botch, that was me Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.13 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14560358#comment-14560358 ] Srikanth Srungarapu commented on HBASE-13658: - Will get this into branch-1 once HBASE-13764 gets resolved. Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.14 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14557995#comment-14557995 ] Ashish Singhi commented on HBASE-13658: --- Regarding 0.98 version patch. It is always passing to me locally. Looking at the stack trace you have pasted it looks like something related to canary. I think it is fixed as part of HBASE-13757 yesterday and it seems like it got introduced as part of HBASE-13712 which got committed to 0.98 after I posted my patch here so I could not find that failure. Will look into branch-1* now. Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14558023#comment-14558023 ] Srikanth Srungarapu commented on HBASE-13658: - Yeah, the tests are passing on 0.98 now. Pushed it. For branch-1.x, HBASE-13764 should take care of the test failures. Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14558104#comment-14558104 ] Hudson commented on HBASE-13658: FAILURE: Integrated in HBase-0.98 #1002 (See [https://builds.apache.org/job/HBase-0.98/1002/]) HBASE-13658 Improve the test run time for TestAccessController class (ssrungarapu: rev b7fcb356eb4d9b7e38dbd6950f65bc7ebfa77875) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14558228#comment-14558228 ] Hudson commented on HBASE-13658: FAILURE: Integrated in HBase-0.98-on-Hadoop-1.1 #953 (See [https://builds.apache.org/job/HBase-0.98-on-Hadoop-1.1/953/]) HBASE-13658 Improve the test run time for TestAccessController class (ssrungarapu: rev b7fcb356eb4d9b7e38dbd6950f65bc7ebfa77875) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14557405#comment-14557405 ] Ashish Singhi commented on HBASE-13658: --- Thanks a lot Srikanth for checking this. I am not sure how it is failing for you on 0.98 I ran locally 3 times it passed all time for me before uploading the patch and even QA did not report it. Anyways I will check this on all branches again on Monday as I am away from my computer this weekend. Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[
https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556901#comment-14556901
]
Srikanth Srungarapu commented on HBASE-13658:
-
The patch for 0.98 is failing on my local box with the following error, every
time I tried to run it.
{code}
---
T E S T S
---
Picked up JAVA_TOOL_OPTIONS: -Djava.awt.headless=false
Running org.apache.hadoop.hbase.security.access.TestAccessController
Tests run: 51, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 53.872 sec
FAILURE! - in org.apache.hadoop.hbase.security.access.TestAccessController
testBulkLoad(org.apache.hadoop.hbase.security.access.TestAccessController)
Time elapsed: 0.375 sec ERROR!
java.io.IOException: java.io.IOException: The connection has to be unmanaged.
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getTable(HConnectionManager.java:812)
at
org.apache.hadoop.hbase.client.HConnectionManager$HConnectionImplementation.getTable(HConnectionManager.java:796)
at org.apache.hadoop.hbase.tool.Canary.sniff(Canary.java:700)
at org.apache.hadoop.hbase.tool.Canary.sniff(Canary.java:685)
at org.apache.hadoop.hbase.tool.Canary.sniff(Canary.java:670)
at
org.apache.hadoop.hbase.HBaseTestingUtility.waitTableEnabled(HBaseTestingUtility.java:2767)
at
org.apache.hadoop.hbase.HBaseTestingUtility.waitTableEnabled(HBaseTestingUtility.java:2734)
at
org.apache.hadoop.hbase.security.access.TestAccessController$BulkLoadHelper.bulkLoadHFile(TestAccessController.java:929)
at
org.apache.hadoop.hbase.security.access.TestAccessController$BulkLoadHelper.access$900(TestAccessController.java:872)
at
org.apache.hadoop.hbase.security.access.TestAccessController$31.run(TestAccessController.java:853)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAs(Subject.java:415)
at
org.apache.hadoop.security.UserGroupInformation.doAs(UserGroupInformation.java:1491)
at
org.apache.hadoop.hbase.security.User$SecureHadoopUser.runAs(User.java:318)
at
org.apache.hadoop.hbase.security.access.SecureTestUtil.verifyAllowed(SecureTestUtil.java:157)
at
org.apache.hadoop.hbase.security.access.SecureTestUtil.verifyAllowed(SecureTestUtil.java:173)
at
org.apache.hadoop.hbase.security.access.TestAccessController.testBulkLoad(TestAccessController.java:862)
Results :
Tests in error:
TestAccessController.testBulkLoad:862-SecureTestUtil.verifyAllowed:173-SecureTestUtil.verifyAllowed:157
» IO
{code}
Improve the test run time for TestAccessController class
Key: HBASE-13658
URL: https://issues.apache.org/jira/browse/HBASE-13658
Project: HBase
Issue Type: Sub-task
Components: test
Affects Versions: 0.98.12
Reporter: Ashish Singhi
Assignee: Ashish Singhi
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1
Attachments: 13658.patch, HBASE-13658-0.98-1.patch,
HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch
Improve the test run time for TestAccessController class
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14557055#comment-14557055 ] Hudson commented on HBASE-13658: SUCCESS: Integrated in HBase-TRUNK #6510 (See [https://builds.apache.org/job/HBase-TRUNK/6510/]) HBASE-13658 Improve the test run time for TestAccessController class (Ashish Singhi) (ssrungarapu: rev 7662980798c82a239c4d446c290595836ed3a456) * hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestAccessController.java Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[
https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14557077#comment-14557077
]
Srikanth Srungarapu commented on HBASE-13658:
-
This patch applied on 1.0 related branches will fail {{testTruncatePerms}}.
Looks like HBASE-7782 can fix this. Following up there.
Improve the test run time for TestAccessController class
Key: HBASE-13658
URL: https://issues.apache.org/jira/browse/HBASE-13658
Project: HBase
Issue Type: Sub-task
Components: test
Affects Versions: 0.98.12
Reporter: Ashish Singhi
Assignee: Ashish Singhi
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1
Attachments: 13658.patch, HBASE-13658-0.98-1.patch,
HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch
Improve the test run time for TestAccessController class
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556145#comment-14556145 ] Ashish Singhi commented on HBASE-13658: --- Thanks for +1s. Attached 0.98 patch. Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: 13658.patch, HBASE-13658-0.98-1.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[
https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14556432#comment-14556432
]
Hadoop QA commented on HBASE-13658:
---
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12734824/HBASE-13658-0.98-1.patch
against 0.98 branch at commit f8893e0012031a8c623d9da3839e757006878396.
ATTACHMENT ID: 12734824
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
25 warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ verifyDenied(getGlobalPermissionsAction, USER_CREATE, USER_OWNER,
USER_RW, USER_RO, USER_NONE);
+ grantOnTable(TEST_UTIL, tblUser.getShortName(), tableName, null, null,
Permission.Action.READ);
+ verifyAllowed(getTableDescAction, SUPERUSER, USER_ADMIN, USER_CREATE,
USER_OWNER, TABLE_ADMIN);
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 5 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14155//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14155//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14155//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14155//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14155//console
This message is automatically generated.
Improve the test run time for TestAccessController class
Key: HBASE-13658
URL: https://issues.apache.org/jira/browse/HBASE-13658
Project: HBase
Issue Type: Sub-task
Components: test
Affects Versions: 0.98.12
Reporter: Ashish Singhi
Assignee: Ashish Singhi
Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1
Attachments: 13658.patch, HBASE-13658-0.98-1.patch,
HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch
Improve the test run time for TestAccessController class
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554731#comment-14554731 ] Andrew Purtell commented on HBASE-13658: Ok, thanks, +1 on the v2 patch Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 Attachments: 13658.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[
https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554219#comment-14554219
]
Hadoop QA commented on HBASE-13658:
---
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12734398/HBASE-13658-v2.patch
against master branch at commit d69807663c0be25dd8cb61a32068a6d0bd86291a.
ATTACHMENT ID: 12734398
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 protoc{color}. The applied patch does not increase the
total number of protoc compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/14143//testReport/
Release Findbugs (version 2.0.3)warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/14143//artifact/patchprocess/newFindbugsWarnings.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/14143//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/14143//console
This message is automatically generated.
Improve the test run time for TestAccessController class
Key: HBASE-13658
URL: https://issues.apache.org/jira/browse/HBASE-13658
Project: HBase
Issue Type: Sub-task
Components: test
Affects Versions: 0.98.12
Reporter: Ashish Singhi
Assignee: Ashish Singhi
Fix For: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1
Attachments: 13658.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch,
HBASE-13658.patch
Improve the test run time for TestAccessController class
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[
https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14554066#comment-14554066
]
Ashish Singhi commented on HBASE-13658:
---
Thanks [~apurtell] for the review.
bq. ◾The table delete for cleaning up after testMergeRegions should be in the
finally part of a try-finally wrapping the code after table create succeeds.
Addressed.
bq. ◾The disable and re-enable of the test table at the end of testBulkLoad
should be in the finally part of a try-finally that wraps the unit test code.
Addressed.
bq. ◾testPostGrantRevoke, testPostGrantRevokeAtQualifierLevel, and
testPermissionList are still creating its own table for the test. Want to fix
that too?
Done.
{quote}
◾Changes made by testGrantRevoke, testPostGrantRevoke,
testPostGrantRevokeAtQualifierLevel, testPermissionList,
testAccessControlClientGlobalGrantRevoke,
testAccessControlClientGrantRevokeOnNamespace, testCoprocessorExec should be
cleaned up in a finally block
{quote}
For testPostGrantRevoke, testPostGrantRevokeAtQualifierLevel, and
testPermissionList as per the above comment the table will be deleted at the
end so no other explicit cleanup is required I think.
Improve the test run time for TestAccessController class
Key: HBASE-13658
URL: https://issues.apache.org/jira/browse/HBASE-13658
Project: HBase
Issue Type: Sub-task
Components: test
Affects Versions: 0.98.12
Reporter: Ashish Singhi
Assignee: Ashish Singhi
Fix For: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1
Attachments: 13658.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch,
HBASE-13658.patch
Improve the test run time for TestAccessController class
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14555422#comment-14555422 ] Srikanth Srungarapu commented on HBASE-13658: - +1 from here too. Will commit this tomorrow unless objection. Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.14, 1.0.2, 1.2.0, 1.1.1 Attachments: 13658.patch, HBASE-13658-v1.patch, HBASE-13658-v2.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14553324#comment-14553324 ] Andrew Purtell commented on HBASE-13658: Hi [~ashishujjain], the v1 patch is better. Some comments: - The table delete for cleaning up after testMergeRegions should be in the finally part of a try-finally wrapping the code after table create succeeds. - The disable and re-enable of the test table at the end of testBulkLoad should be in the finally part of a try-finally that wraps the unit test code. - testPostGrantRevoke, testPostGrantRevokeAtQualifierLevel, and testPermissionList are still creating its own table for the test. Want to fix that too? - Changes made by testGrantRevoke, testPostGrantRevoke, testPostGrantRevokeAtQualifierLevel, testPermissionList, testAccessControlClientGlobalGrantRevoke, testAccessControlClientGrantRevokeOnNamespace, testCoprocessorExec should be cleaned up in a finally block Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Affects Versions: 0.98.12 Reporter: Ashish Singhi Assignee: Ashish Singhi Fix For: 2.0.0, 0.98.13, 1.0.2, 1.2.0, 1.1.1 Attachments: 13658.patch, HBASE-13658-v1.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-13658) Improve the test run time for TestAccessController class
[ https://issues.apache.org/jira/browse/HBASE-13658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14545184#comment-14545184 ] Ashish Singhi commented on HBASE-13658: --- [~andrew.purt...@gmail.com] can you review v1 patch. Improve the test run time for TestAccessController class Key: HBASE-13658 URL: https://issues.apache.org/jira/browse/HBASE-13658 Project: HBase Issue Type: Sub-task Components: test Reporter: Ashish Singhi Assignee: Ashish Singhi Attachments: 13658.patch, HBASE-13658-v1.patch, HBASE-13658.patch Improve the test run time for TestAccessController class -- This message was sent by Atlassian JIRA (v6.3.4#6332)
