[jira] [Commented] (HBASE-17231) Region#getCellCompartor sp?
[ https://issues.apache.org/jira/browse/HBASE-17231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15719298#comment-15719298 ] Hudson commented on HBASE-17231: SUCCESS: Integrated in Jenkins build HBase-Trunk_matrix #2068 (See [https://builds.apache.org/job/HBase-Trunk_matrix/2068/]) HBASE-17231 Region#getCellCompartor -> Region#getCellComparator (stack: rev 42ff4a7164fccf10b18b60301e8e4039c7ffc0db) * (edit) hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScannerHeartbeatMessages.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/Region.java * (edit) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java > Region#getCellCompartor sp? > --- > > Key: HBASE-17231 > URL: https://issues.apache.org/jira/browse/HBASE-17231 > Project: HBase > Issue Type: Bug >Reporter: John Leach >Assignee: John Leach >Priority: Trivial > Fix For: 2.0.0 > > Attachments: HBASE-17231.patch > > > Region#getCellCompartor -> Region#getCellComparator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17231) Region#getCellCompartor sp?
[ https://issues.apache.org/jira/browse/HBASE-17231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717870#comment-15717870 ] ramkrishna.s.vasudevan commented on HBASE-17231: Then could be done I think without depreciation cycle. > Region#getCellCompartor sp? > --- > > Key: HBASE-17231 > URL: https://issues.apache.org/jira/browse/HBASE-17231 > Project: HBase > Issue Type: Bug >Reporter: John Leach >Assignee: John Leach >Priority: Trivial > Attachments: HBASE-17231.patch > > > Region#getCellCompartor -> Region#getCellComparator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17231) Region#getCellCompartor sp?
[ https://issues.apache.org/jira/browse/HBASE-17231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717869#comment-15717869 ] ramkrishna.s.vasudevan commented on HBASE-17231: Urgh!!! Silly. My bad. Apologies. > Region#getCellCompartor sp? > --- > > Key: HBASE-17231 > URL: https://issues.apache.org/jira/browse/HBASE-17231 > Project: HBase > Issue Type: Bug >Reporter: John Leach >Assignee: John Leach >Priority: Trivial > Attachments: HBASE-17231.patch > > > Region#getCellCompartor -> Region#getCellComparator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17231) Region#getCellCompartor sp?
[ https://issues.apache.org/jira/browse/HBASE-17231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717624#comment-15717624 ] Anoop Sam John commented on HBASE-17231: HBASE-10800 is committed only in 2.0 so we can correct the method name with out deprecation? Seems branch-1 not having this change? > Region#getCellCompartor sp? > --- > > Key: HBASE-17231 > URL: https://issues.apache.org/jira/browse/HBASE-17231 > Project: HBase > Issue Type: Bug >Reporter: John Leach >Assignee: John Leach >Priority: Trivial > Attachments: HBASE-17231.patch > > > Region#getCellCompartor -> Region#getCellComparator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17231) Region#getCellCompartor sp?
[ https://issues.apache.org/jira/browse/HBASE-17231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15717625#comment-15717625 ] Anoop Sam John commented on HBASE-17231: HBASE-10800 is committed only in 2.0 so we can correct the method name with out deprecation? Seems branch-1 not having this change? > Region#getCellCompartor sp? > --- > > Key: HBASE-17231 > URL: https://issues.apache.org/jira/browse/HBASE-17231 > Project: HBase > Issue Type: Bug >Reporter: John Leach >Assignee: John Leach >Priority: Trivial > Attachments: HBASE-17231.patch > > > Region#getCellCompartor -> Region#getCellComparator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17231) Region#getCellCompartor sp?
[ https://issues.apache.org/jira/browse/HBASE-17231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15716020#comment-15716020 ] stack commented on HBASE-17231: --- Issue has been there a long time: commit 977f867439e960c668ee6311e47c904efc40f219 Author: ramkrishna Date: Tue May 5 11:38:10 2015 +0530 HBASE-10800 - Use CellComparator instead of KVComparator (Ram) Yeah, probably needs deprecation cycle at this stage. Its CPs so safe to remove in 2.0. A deprecation would be nice to have. I think this issue too trivial to for a deprecation. Will take a while to do deprecation. > Region#getCellCompartor sp? > --- > > Key: HBASE-17231 > URL: https://issues.apache.org/jira/browse/HBASE-17231 > Project: HBase > Issue Type: Bug >Reporter: John Leach >Assignee: John Leach >Priority: Trivial > Attachments: HBASE-17231.patch > > > Region#getCellCompartor -> Region#getCellComparator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17231) Region#getCellCompartor sp?
[ https://issues.apache.org/jira/browse/HBASE-17231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15715305#comment-15715305 ] John Leach commented on HBASE-17231: Makes sense. Let me know, I can slap patches up. Is there a labeling approach for the different branches or do I have to create different jiras? Thanks, John > Region#getCellCompartor sp? > --- > > Key: HBASE-17231 > URL: https://issues.apache.org/jira/browse/HBASE-17231 > Project: HBase > Issue Type: Bug >Reporter: John Leach >Assignee: John Leach >Priority: Trivial > Attachments: HBASE-17231.patch > > > Region#getCellCompartor -> Region#getCellComparator -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (HBASE-17231) Region#getCellCompartor sp?
[ https://issues.apache.org/jira/browse/HBASE-17231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714584#comment-15714584 ] Hadoop QA commented on HBASE-17231: --- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 12m 7s {color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} hbaseanti {color} | {color:green} 0m 0s {color} | {color:green} Patch does not have any anti-patterns. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s {color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s {color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 52s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 31s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 44s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 17s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 29s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 29s {color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 36s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 30s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 30s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 38s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 13s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s {color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} hadoopcheck {color} | {color:green} 24m 8s {color} | {color:green} Patch does not cause any errors with Hadoop 2.6.1 2.6.2 2.6.3 2.6.4 2.6.5 2.7.1 2.7.2 2.7.3 or 3.0.0-alpha1. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 40s {color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 25s {color} | {color:green} the patch passed {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 87m 56s {color} | {color:red} hbase-server in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s {color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 138m 15s {color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=1.12.3 Server=1.12.3 Image:yetus/hbase:8d52d23 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12841417/HBASE-17231.patch | | JIRA Issue | HBASE-17231 | | Optional Tests | asflicense javac javadoc unit findbugs hadoopcheck hbaseanti checkstyle compile | | uname | Linux afca11f428fd 4.4.0-43-generic #63-Ubuntu SMP Wed Oct 12 13:48:03 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/component/dev-support/hbase-personality.sh | | git revision | master / 3b72b69 | | Default Java | 1.8.0_111 | | findbugs | v3.0.0 | | unit | https://builds.apache.org/job/PreCommit-HBASE-Build/4754/artifact/patchprocess/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/PreCommit-HBASE-Build/4754/testReport/ | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/4754/console | | Powered by | Apache Yetus 0.3.0 http://yetus.apache.org | This message was automatically generated. > Region#getCellCompartor sp? > --- > > Key: HBASE-17231 > URL: https://issues.apache.org/jira/browse/HBASE-17231 > Project: HBase > Issue Type: Bug >Reporter: John Leach >Assignee: John Leach >Priority: Trivial > Attachments: HBASE-17231.patch > >
[jira] [Commented] (HBASE-17231) Region#getCellCompartor sp?
[ https://issues.apache.org/jira/browse/HBASE-17231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15714370#comment-15714370 ] Anoop Sam John commented on HBASE-17231: Ah... That is bad! But pls note that Region is not private interface but exposed to CPs ( @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.COPROC) ) We need a deprecation way? Or may be deprecate in branch-1 and remove in master? cc [~saint@gmail.com], [~enis] > Region#getCellCompartor sp? > --- > > Key: HBASE-17231 > URL: https://issues.apache.org/jira/browse/HBASE-17231 > Project: HBase > Issue Type: Bug >Reporter: John Leach >Assignee: John Leach >Priority: Trivial > Attachments: HBASE-17231.patch > > > Region#getCellCompartor -> Region#getCellComparator -- This message was sent by Atlassian JIRA (v6.3.4#6332)