[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804375#comment-16804375
]
Ankit Singhal commented on HBASE-21456:
---
bq, I see a lot of changes where we just pass down null,
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803280#comment-16803280
]
Josh Elser commented on HBASE-21456:
{noformat}
- reader = WALFactory.createReader(fs, edits,
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802451#comment-16802451
]
Hadoop QA commented on HBASE-21456:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802378#comment-16802378
]
Hadoop QA commented on HBASE-21456:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802240#comment-16802240
]
Ankit Singhal commented on HBASE-21456:
---
.003 should fix the test failures and checkstyle errors.
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788524#comment-16788524
]
Hadoop QA commented on HBASE-21456:
---
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788294#comment-16788294
]
Josh Elser commented on HBASE-21456:
[~an...@apache.org], actually, this doesn't apply against
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788293#comment-16788293
]
Josh Elser commented on HBASE-21456:
Fine by me. Let me land this one quick to unblock you :)
>
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788279#comment-16788279
]
Ankit Singhal commented on HBASE-21456:
---
{quote}Why have both a public constructor and the static
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786364#comment-16786364
]
Reid Chan commented on HBASE-21456:
---
+1, let's make some progress.
> Make WALFactory only used for
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784778#comment-16784778
]
Josh Elser commented on HBASE-21456:
Looking back at the 001 patch,
* Why have both a public
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745470#comment-16745470
]
Josh Elser commented on HBASE-21456:
{quote}Just wondering if a write-up/plan/spec to consult to
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741397#comment-16741397
]
stack commented on HBASE-21456:
---
I'm good w/ it all. Just wondering if a write-up/plan/spec to consult to
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16740883#comment-16740883
]
Ankit Singhal commented on HBASE-21456:
---
{quote}Do we reach a consensus, or any info i needed to
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739017#comment-16739017
]
stack commented on HBASE-21456:
---
[~an...@apache.org] See [~reidchan]'s note above sir.
I have similar
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16738752#comment-16738752
]
Ankit Singhal commented on HBASE-21456:
---
Thanks [~elserj] for taking a look.
bq. what if we
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16737437#comment-16737437
]
Josh Elser commented on HBASE-21456:
Glanced at the WIP patch briefly: only thing that jumped out at
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733680#comment-16733680
]
Ankit Singhal commented on HBASE-21456:
---
Uploading wip patch, as there are some test failures
[
https://issues.apache.org/jira/browse/HBASE-21456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16683874#comment-16683874
]
Reid Chan commented on HBASE-21456:
---
Looks like Ted is working on it, but still in HBASE-21246.
Do we
19 matches
Mail list logo
