[jira] [Commented] (HBASE-25745) Deprecate/Rename config `hbase.normalizer.min.region.count` to `hbase.normalizer.merge.min.region.count`

2021-05-29 Thread Hudson (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-25745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17353826#comment-17353826
 ] 

Hudson commented on HBASE-25745:


Results for branch branch-2
[build #264 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/264/]:
 (/) *{color:green}+1 overall{color}*

details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/264/General_20Nightly_20Build_20Report/]




(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/264/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]


(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/264/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/branch-2/264/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> Deprecate/Rename config `hbase.normalizer.min.region.count` to 
> `hbase.normalizer.merge.min.region.count`
> 
>
> Key: HBASE-25745
> URL: https://issues.apache.org/jira/browse/HBASE-25745
> Project: HBase
>  Issue Type: Improvement
>  Components: master, Normalizer
>Affects Versions: 3.0.0-alpha-1, 2.5.0
>Reporter: Nick Dimiduk
>Assignee: Baiqiang Zhao
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.5.0
>
>
> After HBASE-24416, {{hbase.normalizer.min.region.count}} only applies to 
> merge plans. Let's deprecate/rename the configuration key so that it is clear 
> in what context it applies, and so that it matches the configuration 
> structure of related keys.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-25745) Deprecate/Rename config `hbase.normalizer.min.region.count` to `hbase.normalizer.merge.min.region.count`

2021-05-25 Thread Baiqiang Zhao (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-25745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17351469#comment-17351469
 ] 

Baiqiang Zhao commented on HBASE-25745:
---

Put up a PR for branch-2.

> Deprecate/Rename config `hbase.normalizer.min.region.count` to 
> `hbase.normalizer.merge.min.region.count`
> 
>
> Key: HBASE-25745
> URL: https://issues.apache.org/jira/browse/HBASE-25745
> Project: HBase
>  Issue Type: Improvement
>  Components: master, Normalizer
>Affects Versions: 3.0.0-alpha-1, 2.5.0
>Reporter: Nick Dimiduk
>Assignee: Baiqiang Zhao
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> After HBASE-24416, {{hbase.normalizer.min.region.count}} only applies to 
> merge plans. Let's deprecate/rename the configuration key so that it is clear 
> in what context it applies, and so that it matches the configuration 
> structure of related keys.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-25745) Deprecate/Rename config `hbase.normalizer.min.region.count` to `hbase.normalizer.merge.min.region.count`

2021-04-09 Thread Baiqiang Zhao (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-25745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317752#comment-17317752
 ] 

Baiqiang Zhao commented on HBASE-25745:
---

Thanks [~ndimiduk], put up a PR for master branch. By the way, I find that the 
following log always prints when BLOCKCACHE_BLOCKSIZE_KEY is configured but 
DEPRECATED_BLOCKCACHE_BLOCKSIZE_KEY is not configured in the conf file.
{code:java}
if (conf.get(DEPRECATED_BLOCKCACHE_BLOCKSIZE_KEY) != null) {
  LOG.warn("The config key {} is deprecated now, instead please use {}. In 
future release "
  + "we will remove the deprecated config.", 
DEPRECATED_BLOCKCACHE_BLOCKSIZE_KEY,
BLOCKCACHE_BLOCKSIZE_KEY);
}
{code}
I think this is not up to expectations. The reason for this phenomenon is that 
the following code:
{code:java}
Configuration.addDeprecation(DEPRECATED_BLOCKCACHE_BLOCKSIZE_KEY, 
BLOCKCACHE_BLOCKSIZE_KEY);
{code}

> Deprecate/Rename config `hbase.normalizer.min.region.count` to 
> `hbase.normalizer.merge.min.region.count`
> 
>
> Key: HBASE-25745
> URL: https://issues.apache.org/jira/browse/HBASE-25745
> Project: HBase
>  Issue Type: Improvement
>  Components: master, Normalizer
>Affects Versions: 3.0.0-alpha-1, 2.5.0
>Reporter: Nick Dimiduk
>Assignee: Baiqiang Zhao
>Priority: Minor
>
> After HBASE-24416, {{hbase.normalizer.min.region.count}} only applies to 
> merge plans. Let's deprecate/rename the configuration key so that it is clear 
> in what context it applies, and so that it matches the configuration 
> structure of related keys.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-25745) Deprecate/Rename config `hbase.normalizer.min.region.count` to `hbase.normalizer.merge.min.region.count`

2021-04-08 Thread Nick Dimiduk (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-25745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17317425#comment-17317425
 ] 

Nick Dimiduk commented on HBASE-25745:
--

Please, help yourself, [~DeanZ]!

> Deprecate/Rename config `hbase.normalizer.min.region.count` to 
> `hbase.normalizer.merge.min.region.count`
> 
>
> Key: HBASE-25745
> URL: https://issues.apache.org/jira/browse/HBASE-25745
> Project: HBase
>  Issue Type: Improvement
>  Components: master, Normalizer
>Affects Versions: 3.0.0-alpha-1, 2.5.0
>Reporter: Nick Dimiduk
>Priority: Minor
>
> After HBASE-24416, {{hbase.normalizer.min.region.count}} only applies to 
> merge plans. Let's deprecate/rename the configuration key so that it is clear 
> in what context it applies, and so that it matches the configuration 
> structure of related keys.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (HBASE-25745) Deprecate/Rename config `hbase.normalizer.min.region.count` to `hbase.normalizer.merge.min.region.count`

2021-04-08 Thread Baiqiang Zhao (Jira) 


[ 
https://issues.apache.org/jira/browse/HBASE-25745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17316906#comment-17316906
 ] 

Baiqiang Zhao commented on HBASE-25745:
---

Hi [~ndimiduk], are you doing this work? If not, can I do it?

> Deprecate/Rename config `hbase.normalizer.min.region.count` to 
> `hbase.normalizer.merge.min.region.count`
> 
>
> Key: HBASE-25745
> URL: https://issues.apache.org/jira/browse/HBASE-25745
> Project: HBase
>  Issue Type: Improvement
>  Components: master, Normalizer
>Affects Versions: 3.0.0-alpha-1, 2.5.0
>Reporter: Nick Dimiduk
>Priority: Minor
>
> After HBASE-24416, {{hbase.normalizer.min.region.count}} only applies to 
> merge plans. Let's deprecate/rename the configuration key so that it is clear 
> in what context it applies, and so that it matches the configuration 
> structure of related keys.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)