[jira] [Commented] (HBASE-5709) Move active master and backup master znodes to use pbs
[ https://issues.apache.org/jira/browse/HBASE-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13248645#comment-13248645 ] Hudson commented on HBASE-5709: --- Integrated in HBase-TRUNK #2721 (See [https://builds.apache.org/job/HBase-TRUNK/2721/]) HBASE-5709 Move active master and backup master znodes to use pbs (Revision 1310553) Result = SUCCESS stack : Files : * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/HMaster.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java * /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java * /hbase/trunk/src/main/protobuf/ZooKeeper.proto * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java * /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java Move active master and backup master znodes to use pbs -- Key: HBASE-5709 URL: https://issues.apache.org/jira/browse/HBASE-5709 Project: HBase Issue Type: Task Reporter: stack Assignee: stack Fix For: 0.96.0 Attachments: 5709.txt, 5709v2.txt, 5709v3.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5709) Move active master and backup master znodes to use pbs
[ https://issues.apache.org/jira/browse/HBASE-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246358#comment-13246358 ] jirapos...@reviews.apache.org commented on HBASE-5709: -- bq. On 2012-04-04 00:21:57, Jimmy Xiang wrote: bq. For ServerName, port and startcode are unassigned in pb, how do you handle those -1 default values? For example, hbck uses -1 port. Am I not creating a ServerName passing port and startcode? This code just does what the old code does. It did not intercept -1s, etc., so neither does this patch. I think I'm not understanding. Help me out. Give it another go Jimmy. - Michael --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4630/#review6667 --- On 2012-04-03 23:38:15, Michael Stack wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4630/ bq. --- bq. bq. (Updated 2012-04-03 23:38:15) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. --- bq. bq. Serialize active master using pb. Do same for backup masters. bq. bq. D src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java bq.Moved under zookeeper. All other Trackers are under zookeeper but this one. bq. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java bq.Use new utility method for getting current master that is over in MasterAddressTracker. bq. M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java bq.Move dup code out into a new handle function. bq.watcher.masterAddressZNode is no longer public. Use accessor. bq.Use new setMasterAddress,getMasterAddress function on bq.MasterAddressTracker for setting znode and backup master znode. bq. M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java bq.Generated code. bq. M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java bq.Fix up import because MasterAddressTracker moved. bq. A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java bq.Add back MasterAddressTracker here. Add some utility functions for setting bq.and getting the master address. bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java bq.Move dataToServerName into ZKUtil. Its useful beyond this class only. bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java bq.Go via accessor to get master znode path and use new utility method bq.to get current master address. dataToServerName moved here from bq.RootRegionTracker. bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java bq.Shutdown access to masterAddressZNode. Add an accessor method. bq. M src/main/protobuf/ZooKeeper.proto bq.Add new master message class. bq. M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java bq. M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java bq.Go via new accessor and use utility over in MasterAddressTracker. bq. M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java bq.Fix import to point at new location. bq. bq. bq. This addresses bug hbase-5709. bq. https://issues.apache.org/jira/browse/hbase-5709 bq. bq. bq. Diffs bq. - bq. bq.src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java a246abe bq.src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969 bq.src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java ef19cb9 bq. src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe bq.src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999 bq. src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java PRE-CREATION bq.src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57 bq.src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 037e354 bq.src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655 bq.src/main/protobuf/ZooKeeper.proto 20f8eb0 bq. src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java 05f6b1a bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java e91d83c bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 8478260 bq. bq. Diff: https://reviews.apache.org/r/4630/diff bq. bq. bq. Testing bq. --- bq. bq. bq. Thanks, bq. bq. Michael bq. bq. Move active master
[jira] [Commented] (HBASE-5709) Move active master and backup master znodes to use pbs
[ https://issues.apache.org/jira/browse/HBASE-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246427#comment-13246427 ] jirapos...@reviews.apache.org commented on HBASE-5709: -- bq. On 2012-04-04 00:21:57, Jimmy Xiang wrote: bq. For ServerName, port and startcode are unassigned in pb, how do you handle those -1 default values? For example, hbck uses -1 port. bq. bq. Michael Stack wrote: bq. Am I not creating a ServerName passing port and startcode? This code just does what the old code does. It did not intercept -1s, etc., so neither does this patch. bq. bq. I think I'm not understanding. Help me out. Give it another go Jimmy. This patch is good to me. What I was thinking about is the region transition data. Sorry for the confusion. - Jimmy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4630/#review6667 --- On 2012-04-03 23:38:15, Michael Stack wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4630/ bq. --- bq. bq. (Updated 2012-04-03 23:38:15) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. --- bq. bq. Serialize active master using pb. Do same for backup masters. bq. bq. D src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java bq.Moved under zookeeper. All other Trackers are under zookeeper but this one. bq. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java bq.Use new utility method for getting current master that is over in MasterAddressTracker. bq. M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java bq.Move dup code out into a new handle function. bq.watcher.masterAddressZNode is no longer public. Use accessor. bq.Use new setMasterAddress,getMasterAddress function on bq.MasterAddressTracker for setting znode and backup master znode. bq. M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java bq.Generated code. bq. M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java bq.Fix up import because MasterAddressTracker moved. bq. A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java bq.Add back MasterAddressTracker here. Add some utility functions for setting bq.and getting the master address. bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java bq.Move dataToServerName into ZKUtil. Its useful beyond this class only. bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java bq.Go via accessor to get master znode path and use new utility method bq.to get current master address. dataToServerName moved here from bq.RootRegionTracker. bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java bq.Shutdown access to masterAddressZNode. Add an accessor method. bq. M src/main/protobuf/ZooKeeper.proto bq.Add new master message class. bq. M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java bq. M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java bq.Go via new accessor and use utility over in MasterAddressTracker. bq. M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java bq.Fix import to point at new location. bq. bq. bq. This addresses bug hbase-5709. bq. https://issues.apache.org/jira/browse/hbase-5709 bq. bq. bq. Diffs bq. - bq. bq.src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java a246abe bq.src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969 bq.src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java ef19cb9 bq. src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe bq.src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999 bq. src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java PRE-CREATION bq.src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57 bq.src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 037e354 bq.src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655 bq.src/main/protobuf/ZooKeeper.proto 20f8eb0 bq. src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java 05f6b1a bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java e91d83c bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 8478260 bq. bq. Diff:
[jira] [Commented] (HBASE-5709) Move active master and backup master znodes to use pbs
[ https://issues.apache.org/jira/browse/HBASE-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246503#comment-13246503 ] Hadoop QA commented on HBASE-5709: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521332/5709v2.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.master.TestMasterShutdown org.apache.hadoop.hbase.client.TestFromClientSide org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper org.apache.hadoop.hbase.master.TestActiveMasterManager org.apache.hadoop.hbase.master.TestMasterFailover org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapreduce.TestTableMapReduce Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1384//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1384//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1384//console This message is automatically generated. Move active master and backup master znodes to use pbs -- Key: HBASE-5709 URL: https://issues.apache.org/jira/browse/HBASE-5709 Project: HBase Issue Type: Task Reporter: stack Assignee: stack Attachments: 5709.txt, 5709v2.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5709) Move active master and backup master znodes to use pbs
[ https://issues.apache.org/jira/browse/HBASE-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13246689#comment-13246689 ] Hadoop QA commented on HBASE-5709: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521369/5709v3.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper org.apache.hadoop.hbase.mapreduce.TestImportTsv org.apache.hadoop.hbase.mapred.TestTableMapReduce org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat org.apache.hadoop.hbase.mapreduce.TestTableMapReduce Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1389//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1389//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1389//console This message is automatically generated. Move active master and backup master znodes to use pbs -- Key: HBASE-5709 URL: https://issues.apache.org/jira/browse/HBASE-5709 Project: HBase Issue Type: Task Reporter: stack Assignee: stack Attachments: 5709.txt, 5709v2.txt, 5709v3.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5709) Move active master and backup master znodes to use pbs
[ https://issues.apache.org/jira/browse/HBASE-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245893#comment-13245893 ] jirapos...@reviews.apache.org commented on HBASE-5709: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4630/ --- Review request for hbase. Summary --- Serialize active master using pb. Do same for backup masters. D src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java Moved under zookeeper. All other Trackers are under zookeeper but this one. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java Use new utility method for getting current master that is over in MasterAddressTracker. M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java Move dup code out into a new handle function. watcher.masterAddressZNode is no longer public. Use accessor. Use new setMasterAddress,getMasterAddress function on MasterAddressTracker for setting znode and backup master znode. M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java Generated code. M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java Fix up import because MasterAddressTracker moved. A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java Add back MasterAddressTracker here. Add some utility functions for setting and getting the master address. M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java Move dataToServerName into ZKUtil. Its useful beyond this class only. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java Go via accessor to get master znode path and use new utility method to get current master address. dataToServerName moved here from RootRegionTracker. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java Shutdown access to masterAddressZNode. Add an accessor method. M src/main/protobuf/ZooKeeper.proto Add new master message class. M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java Go via new accessor and use utility over in MasterAddressTracker. M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java Fix import to point at new location. This addresses bug hbase-5709. https://issues.apache.org/jira/browse/hbase-5709 Diffs - src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java a246abe src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969 src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java ef19cb9 src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999 src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java PRE-CREATION src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57 src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 037e354 src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655 src/main/protobuf/ZooKeeper.proto 20f8eb0 src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java 05f6b1a src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java e91d83c src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 8478260 Diff: https://reviews.apache.org/r/4630/diff Testing --- Thanks, Michael Move active master and backup master znodes to use pbs -- Key: HBASE-5709 URL: https://issues.apache.org/jira/browse/HBASE-5709 Project: HBase Issue Type: Task Reporter: stack Assignee: stack Attachments: 5709.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5709) Move active master and backup master znodes to use pbs
[ https://issues.apache.org/jira/browse/HBASE-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245903#comment-13245903 ] Hadoop QA commented on HBASE-5709: -- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12521241/5709.txt against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 9 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. -1 javac. The patch appears to cause mvn compile goal to fail. -1 findbugs. The patch appears to cause Findbugs (version 1.3.9) to fail. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these unit tests: Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1382//testReport/ Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1382//console This message is automatically generated. Move active master and backup master znodes to use pbs -- Key: HBASE-5709 URL: https://issues.apache.org/jira/browse/HBASE-5709 Project: HBase Issue Type: Task Reporter: stack Assignee: stack Attachments: 5709.txt -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5709) Move active master and backup master znodes to use pbs
[ https://issues.apache.org/jira/browse/HBASE-5709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13245922#comment-13245922 ] jirapos...@reviews.apache.org commented on HBASE-5709: -- --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4630/#review6667 --- For ServerName, port and startcode are unassigned in pb, how do you handle those -1 default values? For example, hbck uses -1 port. - Jimmy On 2012-04-03 23:38:15, Michael Stack wrote: bq. bq. --- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4630/ bq. --- bq. bq. (Updated 2012-04-03 23:38:15) bq. bq. bq. Review request for hbase. bq. bq. bq. Summary bq. --- bq. bq. Serialize active master using pb. Do same for backup masters. bq. bq. D src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java bq.Moved under zookeeper. All other Trackers are under zookeeper but this one. bq. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java bq.Use new utility method for getting current master that is over in MasterAddressTracker. bq. M src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java bq.Move dup code out into a new handle function. bq.watcher.masterAddressZNode is no longer public. Use accessor. bq.Use new setMasterAddress,getMasterAddress function on bq.MasterAddressTracker for setting znode and backup master znode. bq. M src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java bq.Generated code. bq. M src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java bq.Fix up import because MasterAddressTracker moved. bq. A src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java bq.Add back MasterAddressTracker here. Add some utility functions for setting bq.and getting the master address. bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java bq.Move dataToServerName into ZKUtil. Its useful beyond this class only. bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java bq.Go via accessor to get master znode path and use new utility method bq.to get current master address. dataToServerName moved here from bq.RootRegionTracker. bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java bq.Shutdown access to masterAddressZNode. Add an accessor method. bq. M src/main/protobuf/ZooKeeper.proto bq.Add new master message class. bq. M src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java bq. M src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java bq.Go via new accessor and use utility over in MasterAddressTracker. bq. M src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java bq.Fix import to point at new location. bq. bq. bq. This addresses bug hbase-5709. bq. https://issues.apache.org/jira/browse/hbase-5709 bq. bq. bq. Diffs bq. - bq. bq.src/main/java/org/apache/hadoop/hbase/MasterAddressTracker.java a246abe bq.src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java aa30969 bq.src/main/java/org/apache/hadoop/hbase/master/ActiveMasterManager.java ef19cb9 bq. src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java 8ff87fe bq.src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java 4f80999 bq. src/main/java/org/apache/hadoop/hbase/zookeeper/MasterAddressTracker.java PRE-CREATION bq.src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java 6b2ea57 bq.src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 037e354 bq.src/main/java/org/apache/hadoop/hbase/zookeeper/ZooKeeperWatcher.java 0f83655 bq.src/main/protobuf/ZooKeeper.proto 20f8eb0 bq. src/test/java/org/apache/hadoop/hbase/master/TestActiveMasterManager.java 05f6b1a bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestMasterAddressManager.java e91d83c bq. src/test/java/org/apache/hadoop/hbase/regionserver/TestRSStatusServlet.java 8478260 bq. bq. Diff: https://reviews.apache.org/r/4630/diff bq. bq. bq. Testing bq. --- bq. bq. bq. Thanks, bq. bq. Michael bq. bq. Move active master and backup master znodes to use pbs -- Key: HBASE-5709 URL: https://issues.apache.org/jira/browse/HBASE-5709 Project: HBase Issue Type: Task Reporter: stack
