[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13544404#comment-13544404 ] Hudson commented on HBASE-5898: --- Integrated in HBase-0.94-security-on-Hadoop-23 #10 (See

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13531533#comment-13531533 ] Shrijeet Paliwal commented on HBASE-5898: - After putting UseMembar in GC opts we

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13531555#comment-13531555 ] Lars Hofhansl commented on HBASE-5898: -- Thanks Shrijeet. How reliably have you seen

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13531575#comment-13531575 ] Shrijeet Paliwal commented on HBASE-5898: - Lars, we saw this twice in two days

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529300#comment-13529300 ] Lars Hofhansl commented on HBASE-5898: -- One interesting behavior I saw was that HBase

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529517#comment-13529517 ] Lars Hofhansl commented on HBASE-5898: -- I tracked it down to locking on istream in

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529536#comment-13529536 ] Lars Hofhansl commented on HBASE-5898: -- Why is there only one reader/fsinput stream

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529546#comment-13529546 ] Lars Hofhansl commented on HBASE-5898: -- When read short circuiting is enabled: One

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529547#comment-13529547 ] Lars Hofhansl commented on HBASE-5898: -- Last comment (I promise). Note: That this all

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529577#comment-13529577 ] Shrijeet Paliwal commented on HBASE-5898: - Hello Lars, Do not mean to sidetrack

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529608#comment-13529608 ] Shrijeet Paliwal commented on HBASE-5898: - Lars, I had put the stack trace here

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529612#comment-13529612 ] Lars Hofhansl commented on HBASE-5898: -- Sorry... Missed the jstack there. I can see

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529629#comment-13529629 ] Elliott Clark commented on HBASE-5898: -- That's what we saw too (I can't remember the

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529637#comment-13529637 ] stack commented on HBASE-5898: -- [~lhofhansl] Can we make a new issue w/ your important

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529640#comment-13529640 ] Lars Hofhansl commented on HBASE-5898: -- Was just about to file a new bug. Will repost

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13529695#comment-13529695 ] ramkrishna.s.vasudevan commented on HBASE-5898: --- Agree with Elliot here. It

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496044#comment-13496044 ] Hudson commented on HBASE-5898: --- Integrated in HBase-0.94 #582 (See

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496049#comment-13496049 ] Hudson commented on HBASE-5898: --- Integrated in HBase-TRUNK #3534 (See

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496081#comment-13496081 ] Hudson commented on HBASE-5898: --- Integrated in HBase-0.94-security #83 (See

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496192#comment-13496192 ] Hudson commented on HBASE-5898: --- Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #258 (See

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495472#comment-13495472 ] Lars Hofhansl commented on HBASE-5898: -- OK... Will commit in the next hour.

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495570#comment-13495570 ] Lars Hofhansl commented on HBASE-5898: -- Actually... Which metric is measures via JMX?

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495676#comment-13495676 ] Lars Hofhansl commented on HBASE-5898: -- Yeah, just verified that

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495694#comment-13495694 ] Lars Hofhansl commented on HBASE-5898: -- BTW. It also turns out that HFileReaderVx

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495699#comment-13495699 ] Lars Hofhansl commented on HBASE-5898: -- same for metaLoads and blockLoads. Both are

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495786#comment-13495786 ] Lars Hofhansl commented on HBASE-5898: -- Any comments? Would like to commit and do a

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495919#comment-13495919 ] stack commented on HBASE-5898: -- The repeat is a bit strange but it is at least easy to follow

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495947#comment-13495947 ] Lars Hofhansl commented on HBASE-5898: -- Will update the comment. I would like to get

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495962#comment-13495962 ] Lars Hofhansl commented on HBASE-5898: -- Triggered HadoopQA directly through jenkins.

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495979#comment-13495979 ] Hadoop QA commented on HBASE-5898: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495982#comment-13495982 ] Hadoop QA commented on HBASE-5898: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13496003#comment-13496003 ] Lars Hofhansl commented on HBASE-5898: -- TestDrainingServer passes locally. TestShell

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495013#comment-13495013 ] Hadoop QA commented on HBASE-5898: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495032#comment-13495032 ] Lars Hofhansl commented on HBASE-5898: -- TestStoreFile fails because it checks

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495053#comment-13495053 ] Hadoop QA commented on HBASE-5898: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13495098#comment-13495098 ] stack commented on HBASE-5898: -- Seems fine by me Lars. Consider

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13492728#comment-13492728 ] Hadoop QA commented on HBASE-5898: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13492790#comment-13492790 ] Elliott Clark commented on HBASE-5898: -- Looks like the patch has gone stale after the

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491732#comment-13491732 ] Lars Hofhansl commented on HBASE-5898: -- If nobody is willing to sponsor this (by

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491781#comment-13491781 ] stack commented on HBASE-5898: -- This patch was difference between a stalling sick cluster and

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491971#comment-13491971 ] Lars Hofhansl commented on HBASE-5898: -- Wanna commit Stack? :)

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491999#comment-13491999 ] Lars Hofhansl commented on HBASE-5898: -- In the light of HBASE-6852, even saving

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490784#comment-13490784 ] Lars Hofhansl commented on HBASE-5898: -- Gentlemen, what should we do with this? :) I

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490821#comment-13490821 ] Jean-Daniel Cryans commented on HBASE-5898: --- If we want to get people testing it

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490880#comment-13490880 ] Lars Hofhansl commented on HBASE-5898: -- Let's commit it, and add to the release notes

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13491166#comment-13491166 ] Lars Hofhansl commented on HBASE-5898: -- OK. Somebody who wants this committed should

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13490454#comment-13490454 ] Lars Hofhansl commented on HBASE-5898: -- I wonder whether HBASE-6032 helps with this.

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13488011#comment-13488011 ] Jean-Daniel Cryans commented on HBASE-5898: --- bq. The most likely explanation for

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13488028#comment-13488028 ] Lars Hofhansl commented on HBASE-5898: -- You wanna just commit it? It won't do any

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13488069#comment-13488069 ] ramkrishna.s.vasudevan commented on HBASE-5898: --- I think we can commit this.

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13488470#comment-13488470 ] Lars Hofhansl commented on HBASE-5898: -- Offtopic: Is the offheap cache even working

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13488477#comment-13488477 ] stack commented on HBASE-5898: -- The offheap cache is being used by no one -- its unusable in

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13488478#comment-13488478 ] stack commented on HBASE-5898: -- [~eclark] Elliott, you get any more data on the hung up case

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13488479#comment-13488479 ] Lars Hofhansl commented on HBASE-5898: -- Yeah, offheap caching for diskblocks always

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13487542#comment-13487542 ] Lars Hofhansl commented on HBASE-5898: -- What should we do with this one? @Ram:

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484734#comment-13484734 ] ramkrishna.s.vasudevan commented on HBASE-5898: --- We have recently hit this

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484739#comment-13484739 ] stack commented on HBASE-5898: -- [~ram_krish] How you mean Ram? It was stuck where in

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484856#comment-13484856 ] ramkrishna.s.vasudevan commented on HBASE-5898: --- I can attach some parts of

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485155#comment-13485155 ] stack commented on HBASE-5898: -- I've seen that thread dump before! [~eclark] has a program

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485313#comment-13485313 ] Lars Hofhansl commented on HBASE-5898: -- Sounds like a missed notify or a deadlock.

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485328#comment-13485328 ] Lars Hofhansl commented on HBASE-5898: -- Clearly this can happen when HDFS has a

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485339#comment-13485339 ] Lars Hofhansl commented on HBASE-5898: -- I think we should commit this fix (after

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485341#comment-13485341 ] stack commented on HBASE-5898: -- [~lhofhansl] When you say different scenarios, are you

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485348#comment-13485348 ] Lars Hofhansl commented on HBASE-5898: -- Something like this. I don't think the patch

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485354#comment-13485354 ] stack commented on HBASE-5898: -- Onus is on us to show you the thread dumps where no thread

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13485356#comment-13485356 ] ramkrishna.s.vasudevan commented on HBASE-5898: --- bq.@Ram: Which version of

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484290#comment-13484290 ] Lars Hofhansl commented on HBASE-5898: -- Instead of checking {{blockReadTryCount !=

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484292#comment-13484292 ] Lars Hofhansl commented on HBASE-5898: -- I meant it is {{false}} when

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484297#comment-13484297 ] Lars Hofhansl commented on HBASE-5898: -- Otherwise looks good. I think the double

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484544#comment-13484544 ] Hadoop QA commented on HBASE-5898: -- {color:red}-1 overall{color}. Here are the results

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13484549#comment-13484549 ] Lars Hofhansl commented on HBASE-5898: -- Test failure is suspicious :)

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13482856#comment-13482856 ] Lars Hofhansl commented on HBASE-5898: -- I'd be still worried about checking the cache

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13482866#comment-13482866 ] Elliott Clark commented on HBASE-5898: -- Since it's possible that the thread blocked

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13482949#comment-13482949 ] Lars Hofhansl commented on HBASE-5898: -- That's a good theory :) I guess the worst

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13480566#comment-13480566 ] Lars Hofhansl commented on HBASE-5898: -- [~saint@gmail.com] mentioned today that

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272534#comment-13272534 ] Mikhail Bautin commented on HBASE-5898: --- Todd: where do we increment those

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272543#comment-13272543 ] Todd Lipcon commented on HBASE-5898: Mikhail: whenever we insert something into the

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272561#comment-13272561 ] Mikhail Bautin commented on HBASE-5898: --- Is there any way to avoid messing up cache

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13272716#comment-13272716 ] Todd Lipcon commented on HBASE-5898: Yep, I agree we need to fix the metrics messup

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271791#comment-13271791 ] Jean-Daniel Cryans commented on HBASE-5898: --- bq. Can you do a test where much

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13271901#comment-13271901 ] Todd Lipcon commented on HBASE-5898: Shouldn't be hard to get that CPU time back -- we

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13270801#comment-13270801 ] stack commented on HBASE-5898: -- Can you do a test where much lower hit ratio? Any way to

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=1325#comment-1325 ] stack commented on HBASE-5898: -- j-d Can you run your blockcache cache checker against this?

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13267005#comment-13267005 ] Jean-Daniel Cryans commented on HBASE-5898: --- A not too scientific comparison.

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266045#comment-13266045 ] Jean-Daniel Cryans commented on HBASE-5898: --- Once this is fixed I think we can

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266054#comment-13266054 ] Todd Lipcon commented on HBASE-5898: Really? I don't think this solves the same

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266059#comment-13266059 ] stack commented on HBASE-5898: -- @Todd Double-checked locking should ...should usually be

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266064#comment-13266064 ] Todd Lipcon commented on HBASE-5898: bq. @Todd Double-checked locking should ...should

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266090#comment-13266090 ] Todd Lipcon commented on HBASE-5898: The downside is that for a workload with a lower

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266101#comment-13266101 ] stack commented on HBASE-5898: -- Thanks for the prescription Todd. Consider

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266123#comment-13266123 ] Jean-Daniel Cryans commented on HBASE-5898: --- bq. This addresses the case where

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13266149#comment-13266149 ] Jean-Daniel Cryans commented on HBASE-5898: --- bq. The downside is that for a

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13264456#comment-13264456 ] Zhihong Yu commented on HBASE-5898: --- Interesting idea. Minor comments: The indentation

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13264468#comment-13264468 ] Todd Lipcon commented on HBASE-5898: this isn't meant to be a final patch - I'm just

[jira] [Commented] (HBASE-5898) Consider double-checked locking for block cache lock

[ https://issues.apache.org/jira/browse/HBASE-5898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13264470#comment-13264470 ] Zhihong Yu commented on HBASE-5898: --- Consider the case where off heap cache is enabled.