[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Resolution: Fixed Fix Version/s: (was: 2.0.0) 3.0.0 Status: Resolved (was: Patch Available) Pushed to master. I don't think we need this on the older branches since we'll probably end up backporting the individual fixes anyway. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob >Priority: Blocker > Fix For: 3.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch, > HBASE-12349.v6.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Status: Patch Available (was: Open) > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch, > HBASE-12349.v6.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[
https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated HBASE-12349:
--
Attachment: HBASE-12349.v6.patch
v6.
So... the reason that the hbase-error-prone/target shows up and something like
hbase-shaded-client/target doesn't is because error-prone module is built
before the assembly, while shaded-client is built after. Updated the exclude
set to {{**/target/}} to capture sub-directories.
I don't know what is up with hbase-protocol-shaded/dependency-reduced-pom.xml
> Add Maven build support module for a custom version of error-prone
> --
>
> Key: HBASE-12349
> URL: https://issues.apache.org/jira/browse/HBASE-12349
> Project: HBase
> Issue Type: Sub-task
>Reporter: Andrew Purtell
>Assignee: Mike Drob
>Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: HBASE-12349.patch, HBASE-12349.v2.patch,
> HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch,
> HBASE-12349.v6.patch
>
>
> Add a new Maven build support module that builds and publishes a custom
> error-prone artifact for use by the rest of the build.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12349: -- Priority: Blocker (was: Critical) > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob >Priority: Blocker > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] stack updated HBASE-12349: -- Priority: Critical (was: Major) > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob >Priority: Critical > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Attachment: HBASE-12349.v5.patch v5: rebased on latest master > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Status: Open (was: Patch Available) > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch, HBASE-12349.v5.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Attachment: HBASE-12349.v4.patch v4: Fix findbugs declaration for new modules. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Status: Open (was: Patch Available) > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Status: Patch Available (was: Open) > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch, HBASE-12349.v4.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Status: Patch Available (was: Open) > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Attachment: HBASE-12349.v3.patch v3: Back out changes related to actually fixing the error-prone bugs, so this is purely a packaging and organizational change. error-prone fixes can be tackled in the future. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch, > HBASE-12349.v3.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Status: Open (was: Patch Available) > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Attachment: HBASE-12349.v2.patch Got this into a workable state, finally. * Create new hbase-build-support module to hold hbase-error-prone. ** We need this so that we can separate the compilation configurations to compile our rules using plain javac and compile the rest using javac+rules ** Eventually, we would move hbase-checkstyle and hbase-resource-bundle into there also, I think. * Created hbase-build-configuration module to hold the error-prone profile. Moved all other modules to inherit from it instead of hbase-root. ** This can have other configurations in it that we don't want affecting the build support modules, but I don't know what they'd be at this point. Even without them, this is kind of clunky but still necessary, I think. * While testing this, I ended up fixing a few error-prone bugs to make sure that the results are actually correct. I can back them out and include them separately, but it seems fine to include them. There's still plenty more follow on work to be done. * Added a placeholder custom error-prone rule that never fails. Can remove this when we have other rules in place, but I wanted to have some java source available. Future work we will want to add @Generated to all of the protoc code, this will speed up error-prone-javac a bit, and also start chopping away the reported errors and then the warnings. There's plenty of work to do, unsure how much is false positives and how much is true, but it's a non zero amount of actual bugs. test-patch is very very likely to fail, we'll see if there's something I can iterate on in this patch or wait until the next one. > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Status: Patch Available (was: Open) > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell >Assignee: Mike Drob > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch, HBASE-12349.v2.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mike Drob updated HBASE-12349: -- Attachment: HBASE-12349.patch Progress update: have some ugly hacks on this. I know I'm missing license headers, and have hard-coded plugin version in maven, but I'm almost to a place where this works. Big issue now is that compiling protoc goes from ~15s to ~5m which I consider a deal breaker. Maybe not to commit, but to turning error-prone on by default. I started to do a few fixups on the code based on errors that were getting reported, but stopped when the protoc issue made the process take way too long. [~apurtell] - care to take a look at what's here so far and provide thoughts? > Add Maven build support module for a custom version of error-prone > -- > > Key: HBASE-12349 > URL: https://issues.apache.org/jira/browse/HBASE-12349 > Project: HBase > Issue Type: Sub-task >Reporter: Andrew Purtell > Fix For: 2.0.0 > > Attachments: HBASE-12349.patch > > > Add a new Maven build support module that builds and publishes a custom > error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (HBASE-12349) Add Maven build support module for a custom version of error-prone
[ https://issues.apache.org/jira/browse/HBASE-12349?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Purtell updated HBASE-12349: --- Fix Version/s: 2.0.0 Add Maven build support module for a custom version of error-prone -- Key: HBASE-12349 URL: https://issues.apache.org/jira/browse/HBASE-12349 Project: HBase Issue Type: Sub-task Reporter: Andrew Purtell Fix For: 2.0.0 Add a new Maven build support module that builds and publishes a custom error-prone artifact for use by the rest of the build. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
