Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

gvprathyusha6 commented on code in PR #5834: URL: https://github.com/apache/hbase/pull/5834#discussion_r1578844461 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java: ## @@ -119,12 +120,13 @@ public class StoreFileInfo implements Configurable

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

gvprathyusha6 commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2064857989 > Checked the POC, overall good. > > It is a pain that we need to touch the MOB related code. > > Anyway, I think first we could first do some refactorings, to move the

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

gvprathyusha6 commented on code in PR #5834: URL: https://github.com/apache/hbase/pull/5834#discussion_r1571045154 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java: ## @@ -822,22 +825,25 @@ private class StoreFileSplitter

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

gvprathyusha6 commented on code in PR #5834: URL: https://github.com/apache/hbase/pull/5834#discussion_r1571011511 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java: ## @@ -666,8 +666,9 @@ private Pair, List>

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

gvprathyusha6 commented on code in PR #5834: URL: https://github.com/apache/hbase/pull/5834#discussion_r1571005337 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerBase.java: ## @@ -189,6 +202,107 @@ public final

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

gvprathyusha6 commented on code in PR #5834: URL: https://github.com/apache/hbase/pull/5834#discussion_r1571002658 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/DefaultStoreFileTracker.java: ## @@ -55,12 +65,49 @@ protected void

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

gvprathyusha6 commented on code in PR #5834: URL: https://github.com/apache/hbase/pull/5834#discussion_r1570996949 ## hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java: ## @@ -119,12 +120,13 @@ public class StoreFileInfo implements Configurable

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

Apache9 commented on code in PR #5834: URL: https://github.com/apache/hbase/pull/5834#discussion_r1569899833 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java: ## @@ -666,8 +666,9 @@ private Pair, List> splitStoreFiles(final

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062421730 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s |

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062411590 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s |

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062405932 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s |

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062398860 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062321856 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s |

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062319814 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s |

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062313555 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s |

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062297695 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s |

Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]

gvprathyusha6 commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062158504 > Modifies HStoreFile/StoreFileInfo constructors to take SFT interface as a parameter. Refactors direct interactions of Reference/HFileLink creations to SFT interface. Also moves