Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1578844461
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java:
##
@@ -119,12 +120,13 @@ public class StoreFileInfo implements Configurable {
* @param primaryReplica true if this is a store file for primary replica,
otherwise false.
*/
public StoreFileInfo(final Configuration conf, final FileSystem fs, final
Path initialPath,
-final boolean primaryReplica) throws IOException {
-this(conf, fs, null, initialPath, primaryReplica);
+final boolean primaryReplica, final StoreFileTracker sft) throws
IOException {
Review Comment:
@Apache9 Should we also have the HStoreFile created using SFT apis then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2064857989 > Checked the POC, overall good. > > It is a pain that we need to touch the MOB related code. > > Anyway, I think first we could first do some refactorings, to move the reference file related logic to StoreFileTracker, without changing any real logic. And then, another refactoring to move HFileLink, and back reference files related logic to StoreFileTracker. And finally, we start to change the implementation of StoreFileTracker, to implement the special logic for FileBasedStoreFileTracker, and also consider how to migrate between different store file tracker implementions. > > WDYT? > > Thanks. > Checked the POC, overall good. > > It is a pain that we need to touch the MOB related code. > > Anyway, I think first we could first do some refactorings, to move the reference file related logic to StoreFileTracker, without changing any real logic. And then, another refactoring to move HFileLink, and back reference files related logic to StoreFileTracker. And finally, we start to change the implementation of StoreFileTracker, to implement the special logic for FileBasedStoreFileTracker, and also consider how to migrate between different store file tracker implementions. > > WDYT? > > Thanks. Totally agree, we can target them 1 pr at a time. - to move the reference file related logic to StoreFileTracker - then, another refactoring to move HFileLink, and back reference files - then we start to change the implementation of StoreFileTracker, to implement the special logic for FileBasedStoreFileTracker to create virtual links - and commit all the ref files as part of split in 1 go Thanks a lot for the review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1571045154
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java:
##
@@ -822,22 +825,25 @@ private class StoreFileSplitter implements
Callable> {
private final HRegionFileSystem regionFs;
private final byte[] family;
private final HStoreFile sf;
+private final StoreFileTracker tracker;
/**
* Constructor that takes what it needs to split
* @param regionFs the file system
* @param family Family that contains the store file
* @param sf which file
*/
-public StoreFileSplitter(HRegionFileSystem regionFs, byte[] family,
HStoreFile sf) {
+public StoreFileSplitter(HRegionFileSystem regionFs, StoreFileTracker
tracker, byte[] family,
+ HStoreFile sf) {
this.regionFs = regionFs;
this.sf = sf;
this.family = family;
+ this.tracker = tracker;
}
@Override
public Pair call() throws IOException {
- return splitStoreFile(regionFs, family, sf);
+ return splitStoreFile(regionFs, tracker, family, sf);
Review Comment:
Yes if we can add this api as well in SFT, it will be easier to choose if
where we want multi threading, but both impls might still need multi threading
while initiating reader for all the parent store files while reading metadata
for first/lastkeys.
But yes, we can get to it in detail as part of our last phase of
[implementation](https://docs.google.com/document/d/18aHEv7w0RExV6nJbJaVnTR6NIqbiWHIVUvU7v9rvXAk/edit#heading=h.4tx7yijt3qa1)
may be, where we want to commit all the ref/links in 1 go
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on code in PR #5834: URL: https://github.com/apache/hbase/pull/5834#discussion_r1571011511 ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java: ## @@ -666,8 +666,9 @@ private Pair, List> splitStoreFiles(final MasterProcedureEnv en // table dir. In case of failure, the proc would go through this again, already existing // region dirs and split files would just be ignored, new split files should get created. int nbFiles = 0; -final Map> files = - new HashMap>(htd.getColumnFamilyCount()); +final Map, StoreFileTracker>> files = Review Comment: No we have a StoreFileTracker per column family, we refactored current struct which contains [columnFamilyName] ---> [ Collection(StoreFileInfo) ] to [columnFamilyName] ---> [ Collection(StoreFileInfo) + sft ] ## hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java: ## @@ -666,8 +666,9 @@ private Pair, List> splitStoreFiles(final MasterProcedureEnv en // table dir. In case of failure, the proc would go through this again, already existing // region dirs and split files would just be ignored, new split files should get created. int nbFiles = 0; -final Map> files = - new HashMap>(htd.getColumnFamilyCount()); +final Map, StoreFileTracker>> files = Review Comment: No we have a StoreFileTracker per column family here, we refactored current struct which contains [columnFamilyName] ---> [ Collection(StoreFileInfo) ] to [columnFamilyName] ---> [ Collection(StoreFileInfo) + sft ] -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1571005337
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerBase.java:
##
@@ -189,6 +202,107 @@ public final StoreFileWriter
createWriter(CreateStoreFileWriterParams params) th
return builder.build();
}
+ @Override
+ public String createHFileLink(CreateHFileLinkParams params) throws
IOException {
+String name = HFileLink.createHFileLinkName(params.getLinkedTable(),
params.getLinkedRegion(),
+ params.getHfileName());
+String refName =
+ HFileLink.createBackReferenceName(params.getDstTableName(),
params.getDstRegionName());
+
+// Make sure the destination directory exists
+params.getFs().mkdirs(params.getDstFamilyPath());
+
+// Make sure the FileLink reference directory exists
+Path archiveStoreDir = HFileArchiveUtil.getStoreArchivePath(conf,
params.getLinkedTable(),
+ params.getLinkedRegion(), params.getFamilyName());
+Path backRefPath = null;
+if (params.isCreateBackRef()) {
+ Path backRefssDir = HFileLink.getBackReferencesDir(archiveStoreDir,
params.getHfileName());
+ params.getFs().mkdirs(backRefssDir);
+
+ // Create the reference for the link
+ backRefPath = new Path(backRefssDir, refName);
+ params.getFs().createNewFile(backRefPath);
+}
+try {
+ // Create the link
+ if (params.getFs().createNewFile(new Path(params.getDstFamilyPath(),
name))) {
+return name;
+ }
+} catch (IOException e) {
+ LOG.error("couldn't create the link=" + name + " for " +
params.getDstFamilyPath(), e);
+ // Revert the reference if the link creation failed
+ if (params.isCreateBackRef()) {
+params.getFs().delete(backRefPath, false);
+ }
+ throw e;
+}
+throw new IOException(
+ "File link=" + name + " already exists under " +
params.getDstFamilyPath() + " folder.");
+ }
+
+ @Override
+ public Reference createReference(Reference reference, Path path) throws
IOException {
Review Comment:
Yes thats correct, we will move it respective impl classes once we have the
implementation of virtual links ready in FSFT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1571002658
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/DefaultStoreFileTracker.java:
##
@@ -55,12 +65,49 @@ protected void
doAddCompactionResults(Collection compactedFiles,
@Override
protected List doLoadStoreFiles(boolean readOnly) throws
IOException {
-List files =
-
ctx.getRegionFileSystem().getStoreFiles(ctx.getFamily().getNameAsString());
+List files =
getStoreFiles(ctx.getFamily().getNameAsString(), true);
return files != null ? files : Collections.emptyList();
}
@Override
protected void doSetStoreFiles(Collection files) throws
IOException {
}
+
+ /**
+ * Returns the store files available for the family. This methods performs
the filtering based on
+ * the valid store files.
+ * @param familyName Column Family Name
+ * @return a set of {@link StoreFileInfo} for the specified family.
+ */
+ public List getStoreFiles(final String familyName, final
boolean validate)
Review Comment:
This is only helper method used as part of SFT#load() impl of
DefaultStoreFileTracker, this was moved from
[HRegionFileSystem](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java#L274)
to here. This is not a new API we are adding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1570996949
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java:
##
@@ -119,12 +120,13 @@ public class StoreFileInfo implements Configurable {
* @param primaryReplica true if this is a store file for primary replica,
otherwise false.
*/
public StoreFileInfo(final Configuration conf, final FileSystem fs, final
Path initialPath,
-final boolean primaryReplica) throws IOException {
-this(conf, fs, null, initialPath, primaryReplica);
+final boolean primaryReplica, final StoreFileTracker sft) throws
IOException {
Review Comment:
you mean, we move the creation of StoreFileInfo itself to SFT, like
SFT.getStoreFileInfo(path, primaryReplica) something like that right? yes this
does look better to me.
Couple of trivial constructors like
[these](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java#L214)
we can have in StoreFileInfo and rest we can move to SFT interface
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache9 commented on code in PR #5834:
URL: https://github.com/apache/hbase/pull/5834#discussion_r1569899833
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java:
##
@@ -666,8 +666,9 @@ private Pair, List> splitStoreFiles(final
MasterProcedureEnv en
// table dir. In case of failure, the proc would go through this again,
already existing
// region dirs and split files would just be ignored, new split files
should get created.
int nbFiles = 0;
-final Map> files =
- new HashMap>(htd.getColumnFamilyCount());
+final Map, StoreFileTracker>> files
=
Review Comment:
We need a separate StoreFileTracker for every StoreFile? Seems strange...
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java:
##
@@ -119,12 +120,13 @@ public class StoreFileInfo implements Configurable {
* @param primaryReplica true if this is a store file for primary replica,
otherwise false.
*/
public StoreFileInfo(final Configuration conf, final FileSystem fs, final
Path initialPath,
-final boolean primaryReplica) throws IOException {
-this(conf, fs, null, initialPath, primaryReplica);
+final boolean primaryReplica, final StoreFileTracker sft) throws
IOException {
Review Comment:
I guess a better choice is to move these logics into StoreFileTracker, and
make the constructor of StoreFileInfo simpler, so we do not need to pass so
many parameters in...
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/DefaultStoreFileTracker.java:
##
@@ -55,12 +65,49 @@ protected void
doAddCompactionResults(Collection compactedFiles,
@Override
protected List doLoadStoreFiles(boolean readOnly) throws
IOException {
-List files =
-
ctx.getRegionFileSystem().getStoreFiles(ctx.getFamily().getNameAsString());
+List files =
getStoreFiles(ctx.getFamily().getNameAsString(), true);
return files != null ? files : Collections.emptyList();
}
@Override
protected void doSetStoreFiles(Collection files) throws
IOException {
}
+
+ /**
+ * Returns the store files available for the family. This methods performs
the filtering based on
+ * the valid store files.
+ * @param familyName Column Family Name
+ * @return a set of {@link StoreFileInfo} for the specified family.
+ */
+ public List getStoreFiles(final String familyName, final
boolean validate)
Review Comment:
Why putting this method here and there is no `@Override` annotation? It is
for DefaultStoreFileTracker only? Who will call it?
##
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java:
##
@@ -822,22 +825,25 @@ private class StoreFileSplitter implements
Callable> {
private final HRegionFileSystem regionFs;
private final byte[] family;
private final HStoreFile sf;
+private final StoreFileTracker tracker;
/**
* Constructor that takes what it needs to split
* @param regionFs the file system
* @param family Family that contains the store file
* @param sf which file
*/
-public StoreFileSplitter(HRegionFileSystem regionFs, byte[] family,
HStoreFile sf) {
+public StoreFileSplitter(HRegionFileSystem regionFs, StoreFileTracker
tracker, byte[] family,
+ HStoreFile sf) {
this.regionFs = regionFs;
this.sf = sf;
this.family = family;
+ this.tracker = tracker;
}
@Override
public Pair call() throws IOException {
- return splitStoreFile(regionFs, family, sf);
+ return splitStoreFile(regionFs, tracker, family, sf);
Review Comment:
I think here we need to abstract at a higer level. As if we use file based
store file tracker, we do not need multi threading. So we'd better abstract a
method for splitting multiple store files in the store file tracker interface,
and in the implementation, we are free to choose whether to use multi threading.
##
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/StoreFileTrackerBase.java:
##
@@ -189,6 +202,107 @@ public final StoreFileWriter
createWriter(CreateStoreFileWriterParams params) th
return builder.build();
}
+ @Override
+ public String createHFileLink(CreateHFileLinkParams params) throws
IOException {
+String name = HFileLink.createHFileLinkName(params.getLinkedTable(),
params.getLinkedRegion(),
+ params.getHfileName());
+String refName =
+ HFileLink.createBackReferenceName(params.getDstTableName(),
params.getDstRegionName());
+
+// Make sure the destination directory exists
+params.getFs().mkdirs(params.getDstFamilyPath());
+
+// Make sure the FileLink reference directory exists
+Path archiveStoreDir = HFileArchiveUtil.getStoreArchivePath(conf,
params.getLinkedTable(),
+ params.getLinkedRegion(),
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062421730 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 38s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 6m 43s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 29s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 54s | root in the patch failed. | | -1 :x: | compile | 0m 51s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 51s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 5m 1s | patch has 612 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 30s | hbase-server generated 4 new + 93 unchanged - 3 fixed = 97 total (was 96) | ||| _ Other Tests _ | | -1 :x: | unit | 1m 2s | hbase-server in the patch failed. | | | | 22m 43s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 993919b8a98e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/testReport/ | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062411590 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 39s | master passed | | +1 :green_heart: | compile | 3m 9s | master passed | | +1 :green_heart: | checkstyle | 0m 55s | master passed | | +1 :green_heart: | spotless | 0m 54s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 59s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 2m 3s | root in the patch failed. | | -1 :x: | compile | 1m 11s | hbase-server in the patch failed. | | -0 :warning: | javac | 1m 11s | hbase-server in the patch failed. | | -0 :warning: | checkstyle | 0m 40s | hbase-server: The patch generated 2 new + 55 unchanged - 2 fixed = 57 total (was 57) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | hadoopcheck | 2m 16s | The patch causes 612 errors with Hadoop v3.3.6. | | +1 :green_heart: | spotless | 0m 47s | patch has no errors when running spotless:check. | | -1 :x: | spotbugs | 0m 50s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 20m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 468a939842f1 5.4.0-176-generic #196-Ubuntu SMP Fri Mar 22 16:46:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-general-check/output/patch-javac-3.3.6.txt | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt | | Max. process+thread count | 78 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062405932 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 26s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 11s | master passed | | +1 :green_heart: | compile | 0m 52s | master passed | | +1 :green_heart: | shadedjars | 5m 37s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 35s | root in the patch failed. | | -1 :x: | compile | 0m 50s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 50s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 4m 14s | patch has 612 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 25s | hbase-server generated 5 new + 48 unchanged - 0 fixed = 53 total (was 48) | ||| _ Other Tests _ | | -1 :x: | unit | 0m 51s | hbase-server in the patch failed. | | | | 19m 26s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux baf4aa312f52 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-17.0.10+7 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk17-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/testReport/ | | Max. process+thread count | 82 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062398860 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 44s | master passed | | +1 :green_heart: | compile | 0m 40s | master passed | | +1 :green_heart: | shadedjars | 5m 41s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 25s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 13s | root in the patch failed. | | -1 :x: | compile | 0m 36s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 36s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 4m 8s | patch has 616 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 22s | hbase-server generated 3 new + 22 unchanged - 0 fixed = 25 total (was 22) | ||| _ Other Tests _ | | -1 :x: | unit | 0m 36s | hbase-server in the patch failed. | | | | 17m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux da1b2ecb9d00 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Temurin-1.8.0_352-b08 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/testReport/ | | Max. process+thread count | 64 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/2/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062321856 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 46s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 12s | master passed | | +1 :green_heart: | compile | 1m 0s | master passed | | +1 :green_heart: | shadedjars | 6m 44s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 32s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 2m 6s | root in the patch failed. | | -1 :x: | compile | 0m 58s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 58s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 5m 2s | patch has 612 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 30s | hbase-server generated 4 new + 93 unchanged - 3 fixed = 97 total (was 96) | ||| _ Other Tests _ | | -1 :x: | unit | 1m 1s | hbase-server in the patch failed. | | | | 24m 0s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 3a024ff851a8 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk11-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/testReport/ | | Max. process+thread count | 78 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062319814 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 21s | master passed | | +1 :green_heart: | compile | 1m 7s | master passed | | +1 :green_heart: | shadedjars | 6m 9s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 27s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 48s | root in the patch failed. | | -1 :x: | compile | 0m 58s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 58s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 4m 37s | patch has 612 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 31s | hbase-server generated 5 new + 48 unchanged - 0 fixed = 53 total (was 48) | ||| _ Other Tests _ | | -1 :x: | unit | 0m 59s | hbase-server in the patch failed. | | | | 22m 37s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 419a9e836c0c 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-17.0.10+7 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk17-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/testReport/ | | Max. process+thread count | 82 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062313555 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | master passed | | +1 :green_heart: | compile | 3m 18s | master passed | | +1 :green_heart: | checkstyle | 0m 57s | master passed | | +1 :green_heart: | spotless | 1m 6s | branch has no errors when running spotless:check. | | +1 :green_heart: | spotbugs | 1m 53s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 2m 7s | root in the patch failed. | | -1 :x: | compile | 1m 19s | hbase-server in the patch failed. | | -0 :warning: | javac | 1m 19s | hbase-server in the patch failed. | | -0 :warning: | checkstyle | 0m 42s | hbase-server: The patch generated 2 new + 55 unchanged - 2 fixed = 57 total (was 57) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | -1 :x: | hadoopcheck | 2m 26s | The patch causes 612 errors with Hadoop v3.3.6. | | +1 :green_heart: | spotless | 0m 50s | patch has no errors when running spotless:check. | | -1 :x: | spotbugs | 0m 48s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 10s | The patch does not generate ASF License warnings. | | | | 21m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.45 ServerAPI=1.45 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti spotless checkstyle compile | | uname | Linux 6fd68976b686 5.4.0-176-generic #196-Ubuntu SMP Fri Mar 22 16:46:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Eclipse Adoptium-11.0.17+8 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-general-check/output/patch-compile-hbase-server.txt | | checkstyle | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt | | spotbugs | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-general-check/output/patch-spotbugs-hbase-server.txt | | Max. process+thread count | 79 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/console | | versions | git=2.34.1 maven=3.8.6 spotbugs=4.7.3 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
Apache-HBase commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062297695 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 27s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 2m 47s | master passed | | +1 :green_heart: | compile | 0m 39s | master passed | | +1 :green_heart: | shadedjars | 5m 32s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 24s | master passed | ||| _ Patch Compile Tests _ | | -1 :x: | mvninstall | 1m 14s | root in the patch failed. | | -1 :x: | compile | 0m 36s | hbase-server in the patch failed. | | -0 :warning: | javac | 0m 36s | hbase-server in the patch failed. | | -1 :x: | shadedjars | 4m 7s | patch has 616 errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 22s | hbase-server generated 3 new + 22 unchanged - 0 fixed = 25 total (was 22) | ||| _ Other Tests _ | | -1 :x: | unit | 0m 36s | hbase-server in the patch failed. | | | | 17m 39s | | | Subsystem | Report/Notes | |--:|:-| | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/5834 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cbb4cdc31d98 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / d7f9ba6548 | | Default Java | Temurin-1.8.0_352-b08 | | mvninstall | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk8-hadoop3-check/output/patch-mvninstall-root.txt | | compile | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | javac | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk8-hadoop3-check/output/patch-compile-hbase-server.txt | | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk8-hadoop3-check/output/patch-shadedjars.txt | | javadoc | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk8-hadoop3-check/output/diff-javadoc-javadoc-hbase-server.txt | | unit | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/testReport/ | | Max. process+thread count | 67 (vs. ulimit of 3) | | modules | C: hbase-server U: hbase-server | | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-5834/1/console | | versions | git=2.34.1 maven=3.8.6 | | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org | This message was automatically generated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] HBASE-27826 Refactor code to move creation of Ref files to SFT interface apis [hbase]
gvprathyusha6 commented on PR #5834: URL: https://github.com/apache/hbase/pull/5834#issuecomment-2062158504 > Modifies HStoreFile/StoreFileInfo constructors to take SFT interface as a parameter. Refactors direct interactions of Reference/HFileLink creations to SFT interface. Also moves getStoreFiles/hasReferences from HRegionFS to SFT impls. Use the SFT interface to list files of store everywhere instead of using FS objects directly This POC PR is primarily to get a high level overview of the list of changes and is intended to be broken once the initial review is done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
