[jira] [Commented] (HIVE-10643) Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)
[
https://issues.apache.org/jira/browse/HIVE-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14540265#comment-14540265
]
Aihua Xu commented on HIVE-10643:
-
Thanks.
Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers
(1 for number of preceding and 1 for number of following)
---
Key: HIVE-10643
URL: https://issues.apache.org/jira/browse/HIVE-10643
Project: Hive
Issue Type: Sub-task
Components: PTF-Windowing
Affects Versions: 1.3.0
Reporter: Aihua Xu
Assignee: Aihua Xu
Priority: Minor
Fix For: 1.3.0
Attachments: HIVE-10643.patch
The functionality should not be affected. Instead of passing 2 numbers (1 for
# of preceding rows and 1 for # of following rows), we will pass
WindowFrameDef object around. In the following subtasks, it will be used to
support additional window like {{rows between x preceding and y preceding}}
and {{rows between x following and y following}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-10643) Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)
[
https://issues.apache.org/jira/browse/HIVE-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14539844#comment-14539844
]
Aihua Xu commented on HIVE-10643:
-
Unrelated failures.
Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers
(1 for number of preceding and 1 for number of following)
---
Key: HIVE-10643
URL: https://issues.apache.org/jira/browse/HIVE-10643
Project: Hive
Issue Type: Sub-task
Components: PTF-Windowing
Affects Versions: 1.3.0
Reporter: Aihua Xu
Assignee: Aihua Xu
Priority: Minor
Attachments: HIVE-10643.patch
The functionality should not be affected. Instead of passing 2 numbers (1 for
# of preceding rows and 1 for # of following rows), we will pass
WindowFrameDef object around. In the following subtasks, it will be used to
support additional window like {{rows between x preceding and y preceding}}
and {{rows between x following and y following}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-10643) Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)
[
https://issues.apache.org/jira/browse/HIVE-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537955#comment-14537955
]
Aihua Xu commented on HIVE-10643:
-
All of the failures seem to be unrelated.
Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers
(1 for number of preceding and 1 for number of following)
---
Key: HIVE-10643
URL: https://issues.apache.org/jira/browse/HIVE-10643
Project: Hive
Issue Type: Sub-task
Components: PTF-Windowing
Reporter: Aihua Xu
Assignee: Aihua Xu
Priority: Minor
Attachments: HIVE-10643.patch
The functionality should not be affected. Instead of passing 2 numbers (1 for
# of preceding rows and 1 for # of following rows), we will pass
WindowFrameDef object around. In the following subtasks, it will be used for
the cases of {{rows between x preceding and y preceding}} and {{rows between
x following and y following}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-10643) Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)
[
https://issues.apache.org/jira/browse/HIVE-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14537973#comment-14537973
]
Aihua Xu commented on HIVE-10643:
-
[~ashutoshc], can you help review the code? This is the first step with just
refactoring the code. In the patch, we will pass WindowFrameDef around now,
that will be used in the next tasks.
I only did refactoring for sum() related stuff and later will work on sum() fix
first since I believe the work for other UDAF functions should be similar to
it. So I would prefer to work on one function first rather than refactoring
everything at once.
Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers
(1 for number of preceding and 1 for number of following)
---
Key: HIVE-10643
URL: https://issues.apache.org/jira/browse/HIVE-10643
Project: Hive
Issue Type: Sub-task
Components: PTF-Windowing
Reporter: Aihua Xu
Assignee: Aihua Xu
Priority: Minor
Attachments: HIVE-10643.patch
The functionality should not be affected. Instead of passing 2 numbers (1 for
# of preceding rows and 1 for # of following rows), we will pass
WindowFrameDef object around. In the following subtasks, it will be used to
support additional window like {{rows between x preceding and y preceding}}
and {{rows between x following and y following}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-10643) Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)
[
https://issues.apache.org/jira/browse/HIVE-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538397#comment-14538397
]
Ashutosh Chauhan commented on HIVE-10643:
-
Mostly looks good. Left few comments on RB.
Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers
(1 for number of preceding and 1 for number of following)
---
Key: HIVE-10643
URL: https://issues.apache.org/jira/browse/HIVE-10643
Project: Hive
Issue Type: Sub-task
Components: PTF-Windowing
Affects Versions: 1.3.0
Reporter: Aihua Xu
Assignee: Aihua Xu
Priority: Minor
Attachments: HIVE-10643.patch
The functionality should not be affected. Instead of passing 2 numbers (1 for
# of preceding rows and 1 for # of following rows), we will pass
WindowFrameDef object around. In the following subtasks, it will be used to
support additional window like {{rows between x preceding and y preceding}}
and {{rows between x following and y following}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-10643) Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)
[
https://issues.apache.org/jira/browse/HIVE-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14538817#comment-14538817
]
Hive QA commented on HIVE-10643:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12731994/HIVE-10643.patch
{color:red}ERROR:{color} -1 due to 2 failed/errored test(s), 8921 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_vectorized_timestamp_funcs
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver_encryption_insert_partition_static
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3852/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3852/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3852/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 2 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12731994 - PreCommit-HIVE-TRUNK-Build
Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers
(1 for number of preceding and 1 for number of following)
---
Key: HIVE-10643
URL: https://issues.apache.org/jira/browse/HIVE-10643
Project: Hive
Issue Type: Sub-task
Components: PTF-Windowing
Affects Versions: 1.3.0
Reporter: Aihua Xu
Assignee: Aihua Xu
Priority: Minor
Attachments: HIVE-10643.patch
The functionality should not be affected. Instead of passing 2 numbers (1 for
# of preceding rows and 1 for # of following rows), we will pass
WindowFrameDef object around. In the following subtasks, it will be used to
support additional window like {{rows between x preceding and y preceding}}
and {{rows between x following and y following}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HIVE-10643) Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers (1 for number of preceding and 1 for number of following)
[
https://issues.apache.org/jira/browse/HIVE-10643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14536731#comment-14536731
]
Hive QA commented on HIVE-10643:
{color:red}Overall{color}: -1 at least one tests failed
Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12731529/HIVE-10643.patch
{color:red}ERROR:{color} -1 due to 5 failed/errored test(s), 8920 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.cli.TestEncryptedHDFSCliDriver.testCliDriver_encryption_insert_partition_static
org.apache.hadoop.hive.metastore.txn.TestCompactionTxnHandler.testRevokeTimedOutWorkers
org.apache.hive.spark.client.TestSparkClient.testJobSubmission
org.apache.hive.spark.client.TestSparkClient.testMetricsCollection
org.apache.hive.spark.client.TestSparkClient.testSyncRpc
{noformat}
Test results:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3828/testReport
Console output:
http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/3828/console
Test logs:
http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-3828/
Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 5 tests failed
{noformat}
This message is automatically generated.
ATTACHMENT ID: 12731529 - PreCommit-HIVE-TRUNK-Build
Refactoring Windowing for sum() to pass WindowFrameDef instead of two numbers
(1 for number of preceding and 1 for number of following)
---
Key: HIVE-10643
URL: https://issues.apache.org/jira/browse/HIVE-10643
Project: Hive
Issue Type: Sub-task
Components: PTF-Windowing
Reporter: Aihua Xu
Assignee: Aihua Xu
Priority: Minor
Attachments: HIVE-10643.patch
The functionality should not be affected. Instead of passing 2 numbers (1 for
# of preceding rows and 1 for # of following rows), we will pass
WindowFrameDef object around. In the following subtasks, it will be used for
the cases of {{rows between x preceding and y preceding}} and {{rows between
x following and y following}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
