[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875466#comment-15875466
]
Sankar Hariappan commented on HIVE-15910:
-
Thanks a lot [~thejas] and [~wzheng]!
> Improvements
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875467#comment-15875467
]
ASF GitHub Bot commented on HIVE-15910:
---
Github user sankarh closed the pull request at:
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15875455#comment-15875455
]
Thejas M Nair commented on HIVE-15910:
--
+1
> Improvements in Hive Unit Test by using In-memory
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873736#comment-15873736
]
Sankar Hariappan commented on HIVE-15910:
-
[~wzheng]
Currently, I didn't check the performance
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15872741#comment-15872741
]
Wei Zheng commented on HIVE-15910:
--
The code change looks good. Btw, did we do any performance analysis
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15871999#comment-15871999
]
Hive QA commented on HIVE-15910:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870462#comment-15870462
]
Alan Gates commented on HIVE-15910:
---
Getting a new TxnHandler each time is good, as that will be sure to
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870399#comment-15870399
]
Thejas M Nair commented on HIVE-15910:
--
In addition, I think we should look at the methods called in
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870372#comment-15870372
]
Thejas M Nair commented on HIVE-15910:
--
Added a comment in github pull request. Its simpler to just
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870293#comment-15870293
]
Wei Zheng commented on HIVE-15910:
--
Thanks [~sankarh] for finding this out! It makes sense.
Seems you
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15870004#comment-15870004
]
Hive QA commented on HIVE-15910:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869058#comment-15869058
]
Hive QA commented on HIVE-15910:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15869009#comment-15869009
]
Hive QA commented on HIVE-15910:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868548#comment-15868548
]
Hive QA commented on HIVE-15910:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866715#comment-15866715
]
Hive QA commented on HIVE-15910:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866405#comment-15866405
]
Wei Zheng commented on HIVE-15910:
--
Btw TestWorker tests all passed locally. Keep looking..
>
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866361#comment-15866361
]
Wei Zheng commented on HIVE-15910:
--
We do start new thread which is common for these tests. Let me debug
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866271#comment-15866271
]
Thejas M Nair commented on HIVE-15910:
--
[~wzheng] [~sankarh]
TestWorker failures seem to be new and
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865748#comment-15865748
]
Hive QA commented on HIVE-15910:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865657#comment-15865657
]
ASF GitHub Bot commented on HIVE-15910:
---
GitHub user sankarh opened a pull request:
[
https://issues.apache.org/jira/browse/HIVE-15910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865655#comment-15865655
]
Sankar Hariappan commented on HIVE-15910:
-
[~thejas] [~wzheng]
Can you please review the patch
21 matches
Mail list logo