[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048850#comment-16048850
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: really thanks for review.
> Refactor
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048841#comment-16048841
]
Rui Li commented on HIVE-16600:
---
+1
> Refactor SetSparkReducerParallelism#needSetParallelism to enable
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048827#comment-16048827
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048690#comment-16048690
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]:
bq. yeah we can update it when HIVE-6348 is
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048643#comment-16048643
]
Rui Li commented on HIVE-16600:
---
[~kellyzly], yeah we can update it when HIVE-6348 is fixed. Right now we
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047392#comment-16047392
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046413#comment-16046413
]
Rui Li commented on HIVE-16600:
---
Thanks for updating [~kellyzly]. Patch looks good overall. I've left some
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16046372#comment-16046372
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041764#comment-16041764
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: after HIVE-6384, there will not be order
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040540#comment-16040540
]
Rui Li commented on HIVE-16600:
---
If the order by in sub query is followed by limit, it won't be removed. But
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040535#comment-16040535
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: what i am very confused is order by will be
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040512#comment-16040512
]
Rui Li commented on HIVE-16600:
---
With HIVE-6348, we won't have such an order by in sub queries - multi
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040438#comment-16040438
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: v1 patch( with tranversing to the final FS)
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16040423#comment-16040423
]
Rui Li commented on HIVE-16600:
---
Hi [~kellyzly], basically I meant we can fall back to v1 patch, combined
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038321#comment-16038321
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16038276#comment-16038276
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: sorry for reply late.
bq.I prefer to fall
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034519#comment-16034519
]
Rui Li commented on HIVE-16600:
---
[~kellyzly], sorry for the delay.
bq. what i am confused is above case is
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16034074#comment-16034074
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: appreciate to get some comments about
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032067#comment-16032067
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: thanks for review. I think my algorithm in v9
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031007#comment-16031007
]
Rui Li commented on HIVE-16600:
---
Hi [~kellyzly], thanks for the example. As I said, I agree disabling
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027207#comment-16027207
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: actually the algorithms in HIVE-16600.9.patch
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027194#comment-16027194
]
Rui Li commented on HIVE-16600:
---
[~kellyzly], one example of non multi insert having branches is dynamic
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16027139#comment-16027139
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: the algorithms you provided seems ok except 1
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026089#comment-16026089
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026055#comment-16026055
]
Rui Li commented on HIVE-16600:
---
Hi [~kellyzly], quick question, is the v9 patch logically different from
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026027#comment-16026027
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: help review HIVE-16600.9.patch
> Refactor
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16026023#comment-16026023
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: thanks for your algorithm. I change the
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022736#comment-16022736
]
Rui Li commented on HIVE-16600:
---
[~kellyzly], I think there's a bug in latest patch. Suppose we have OP tree
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022458#comment-16022458
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021627#comment-16021627
]
Xuefu Zhang commented on HIVE-16600:
Yeah, I agree with [~lirui] that multi-insert operator tree
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020960#comment-16020960
]
Rui Li commented on HIVE-16600:
---
[~kellyzly], I tried some multi cases and they don't necessarily branch at
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020655#comment-16020655
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: any comment about HIVE-16600.7.patch?
>
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017161#comment-16017161
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16017081#comment-16017081
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: one thing you proposed in review board
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16016859#comment-16016859
]
Rui Li commented on HIVE-16600:
---
Thanks [~xuefuz] for your input. That's inline with my understanding.
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16015616#comment-16015616
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014389#comment-16014389
]
Xuefu Zhang commented on HIVE-16600:
Hi [~lirui], For your example, my understanding is that the
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013480#comment-16013480
]
Rui Li commented on HIVE-16600:
---
Hi [~xuefuz], I'd like to confirm what the standard says about this case.
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16013478#comment-16013478
]
Rui Li commented on HIVE-16600:
---
[~kellyzly], thanks for the update. Just curious, have you tried adding
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011923#comment-16011923
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011854#comment-16011854
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]:
1 question for:
bq.For orderBy + Limit query,
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011763#comment-16011763
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]:
bq. For orderBy + Limit query, we have two
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009970#comment-16009970
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009958#comment-16009958
]
Rui Li commented on HIVE-16600:
---
[~kellyzly], my point is the behavior is different between multi insert and
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009144#comment-16009144
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007027#comment-16007027
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006945#comment-16006945
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006117#comment-16006117
]
Rui Li commented on HIVE-16600:
---
[~kellyzly], it's not possible for Stage-2 to have extra reduce stage
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006077#comment-16006077
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui] : thanks for review.
bq.Why do we need
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006069#comment-16006069
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: i did not copy all the plan of mr. but in the
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16006065#comment-16006065
]
Rui Li commented on HIVE-16600:
---
[~kellyzly], what does the {{Stage: Stage-4}} do in the file you uploaded?
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004328#comment-16004328
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: the build fail is not caused by my patch.
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004325#comment-16004325
]
Rui Li commented on HIVE-16600:
---
Hi [~kellyzly], please check your patch, seems it doesn't build.
Meanwhile,
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004081#comment-16004081
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16004074#comment-16004074
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: the object of multi_insert_parallel_order.q
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16002260#comment-16002260
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]: thanks for review.
bq.I remember you
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16001991#comment-16001991
]
Rui Li commented on HIVE-16600:
---
Thanks [~kellyzly] for working on this. I don't think test failures are
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000392#comment-16000392
]
liyunzhang_intel commented on HIVE-16600:
-
[~lirui]:
in my local environment(based on 54dbca6),
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16000237#comment-16000237
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-16600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15999582#comment-15999582
]
Hive QA commented on HIVE-16600:
Here are the results of testing the latest attachment:
60 matches
Mail list logo