[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295895#comment-16295895
]
Alan Gates commented on HIVE-17981:
---
Looks like I messed up and took the yetus build for the tests. My
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295802#comment-16295802
]
Hive QA commented on HIVE-17981:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295794#comment-16295794
]
Alan Gates commented on HIVE-17981:
---
Created HIVE-18297 for builders for objects not covered in this
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295764#comment-16295764
]
ASF GitHub Bot commented on HIVE-17981:
---
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295742#comment-16295742
]
Hive QA commented on HIVE-17981:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16295630#comment-16295630
]
Hive QA commented on HIVE-17981:
Here are the results of testing the latest attachment:
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283927#comment-16283927
]
Peter Vary commented on HIVE-17981:
---
Agreed
+1
> Create a set of builders for Thrift classes
>
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283911#comment-16283911
]
Alan Gates commented on HIVE-17981:
---
ColumnStatistics were pretty in depth and I didn't need them for
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283521#comment-16283521
]
Peter Vary commented on HIVE-17981:
---
Hi [~alangates],
Thanks for the patch!
These Builders are quite
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282270#comment-16282270
]
Alan Gates commented on HIVE-17981:
---
[~pvary] reviewers are always welcome, no need to ask. Also note
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16282267#comment-16282267
]
ASF GitHub Bot commented on HIVE-17981:
---
GitHub user alanfgates opened a pull request:
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281689#comment-16281689
]
Peter Vary commented on HIVE-17981:
---
[~alangates]: Can we help with reviewing this patch? As I see this
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239086#comment-16239086
]
Peter Vary commented on HIVE-17981:
---
I strongly agree with the intention of moving the tests, and even
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239040#comment-16239040
]
Alan Gates commented on HIVE-17981:
---
I don't know what your timeline looks like, but waiting might mean
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239027#comment-16239027
]
Peter Vary commented on HIVE-17981:
---
[~alangates]: We were stared to draw some drafts for enhancing the
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16239021#comment-16239021
]
Peter Vary commented on HIVE-17981:
---
CC: [~kuczoram]
> Create a set of builders for Thrift classes
>
[
https://issues.apache.org/jira/browse/HIVE-17981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16238590#comment-16238590
]
Alan Gates commented on HIVE-17981:
---
Committed to standalone-metastore branch.
> Create a set of
17 matches
Mail list logo