[GitHub] [incubator-iceberg] manishmalhotrawork commented on issue #279: Transforming timestamp to date should produce date

manishmalhotrawork commented on issue #279: Transforming timestamp to date should produce date URL: https://github.com/apache/incubator-iceberg/issues/279#issuecomment-522346066 @rdblue thanks for the answer. Just saw messages, before that I also drafted the patch, waiting for internal

[GitHub] [incubator-iceberg] jun-he commented on a change in pull request #357: Add in and not in predicates

jun-he commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r315006503 ## File path: api/src/main/java/org/apache/iceberg/expressions/Literals.java ## @@ -109,6 +110,26 @@ public T valu

[GitHub] [incubator-iceberg] jun-he commented on a change in pull request #357: Add in and not in predicates

jun-he commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r315006529 ## File path: api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java ## @@ -125,13 +154,38 @@ pub

[GitHub] [incubator-iceberg] jun-he commented on a change in pull request #357: Add in and not in predicates

jun-he commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r315006537 ## File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetDictionaryRowGroupFilter.java ## @@ -285,12

[GitHub] [incubator-iceberg] jun-he commented on a change in pull request #357: Add in and not in predicates

jun-he commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r315006857 ## File path: api/src/main/java/org/apache/iceberg/expressions/Expressions.java ## @@ -109,16 +111,46 @@ public st

[GitHub] [incubator-iceberg] jun-he commented on a change in pull request #357: Add in and not in predicates

jun-he commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r315006857 ## File path: api/src/main/java/org/apache/iceberg/expressions/Expressions.java ## @@ -109,16 +111,46 @@ public st

[GitHub] [incubator-iceberg] jun-he commented on a change in pull request #357: Add in and not in predicates

jun-he commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r315007006 ## File path: api/src/main/java/org/apache/iceberg/expressions/LiteralSet.java ## @@ -0,0 +1,140 @@ +/* + * Licens

[GitHub] [incubator-iceberg] jun-he commented on a change in pull request #357: Add in and not in predicates

jun-he commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r315009526 ## File path: api/src/main/java/org/apache/iceberg/expressions/UnboundPredicate.java ## @@ -125,13 +180,65 @@ pub

[GitHub] [incubator-iceberg] jun-he commented on a change in pull request #357: Add in and not in predicates

jun-he commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r315009493 ## File path: api/src/main/java/org/apache/iceberg/util/CharSequenceWrapper.java ## @@ -49,21 +50,22 @@ public boo

[GitHub] [incubator-iceberg] jun-he commented on a change in pull request #357: Add in and not in predicates

jun-he commented on a change in pull request #357: Add in and not in predicates URL: https://github.com/apache/incubator-iceberg/pull/357#discussion_r315009996 ## File path: api/src/main/java/org/apache/iceberg/expressions/ExpressionVisitors.java ## @@ -89,12 +93,12 @@ pub