[jira] [Commented] (IGNITE-1353) PortableContext.typeId() incorrectly resolves type ID for predefined system types.
[ https://issues.apache.org/jira/browse/IGNITE-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14730634#comment-14730634 ] ASF GitHub Bot commented on IGNITE-1353: Github user dmagda closed the pull request at: https://github.com/apache/ignite/pull/59 > PortableContext.typeId() incorrectly resolves type ID for predefined system > types. > -- > > Key: IGNITE-1353 > URL: https://issues.apache.org/jira/browse/IGNITE-1353 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: ignite-1.4 >Reporter: Vladimir Ozerov >Assignee: Denis Magda >Priority: Critical > Fix For: ignite-1.5 > > > See PortableContext.typeId() method. > First it checks whether type is "system", and only then try picking > predefiend ID. As a result, predefined types like IgniteBiTuple are written > with wrong IDs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-1353) PortableContext.typeId() incorrectly resolves type ID for predefined system types.
[
https://issues.apache.org/jira/browse/IGNITE-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14728686#comment-14728686
]
Denis Magda commented on IGNITE-1353:
-
Alex, thanks for the review!
Eventually did the following:
- removed predefined classes set from portable context;
- removed the map from portable writer that kept info whether the optimized
marshaller have to be used instead of the portable one during object
marshalling/unmarshalling;
- removed confusing {{PortableContext.typeId(Class)}} method;
- class descriptor is used now for achieving the same functionality.
Checking the changes with TC.
> PortableContext.typeId() incorrectly resolves type ID for predefined system
> types.
> --
>
> Key: IGNITE-1353
> URL: https://issues.apache.org/jira/browse/IGNITE-1353
> Project: Ignite
> Issue Type: Bug
> Components: general
>Affects Versions: ignite-1.4
>Reporter: Vladimir Ozerov
>Assignee: Denis Magda
>Priority: Critical
> Fix For: ignite-1.4
>
>
> See PortableContext.typeId() method.
> First it checks whether type is "system", and only then try picking
> predefiend ID. As a result, predefined types like IgniteBiTuple are written
> with wrong IDs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (IGNITE-1353) PortableContext.typeId() incorrectly resolves type ID for predefined system types.
[ https://issues.apache.org/jira/browse/IGNITE-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727712#comment-14727712 ] Denis Magda commented on IGNITE-1353: - The bug, reported by this issue, wasn't reproduced in Java because a system type ID were used for a predefined type during serialization/deserialization and this was absolutely OK since the tests are using only Java nodes. However, if the tests had been running in a cluster with both Java and platform (.Net, C++) notes we would have caught failures. In any case I've added a test that will check that this bug will not appear in the future. > PortableContext.typeId() incorrectly resolves type ID for predefined system > types. > -- > > Key: IGNITE-1353 > URL: https://issues.apache.org/jira/browse/IGNITE-1353 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 1.1.4 >Reporter: Vladimir Ozerov >Assignee: Denis Magda >Priority: Critical > Fix For: ignite-1.4 > > > See PortableContext.typeId() method. > First it checks whether type is "system", and only then try picking > predefiend ID. As a result, predefined types like IgniteBiTuple are written > with wrong IDs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (IGNITE-1353) PortableContext.typeId() incorrectly resolves type ID for predefined system types.
[ https://issues.apache.org/jira/browse/IGNITE-1353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14727345#comment-14727345 ] Denis Magda commented on IGNITE-1353: - Fixed conflicts between system, predefined and user types resolution. Also found one more issue that required changes in the protocol - IGNITE-1358. Implemented workaround as a part of this task until IGNITE-1358 is fixed. Checking the changes with TC. > PortableContext.typeId() incorrectly resolves type ID for predefined system > types. > -- > > Key: IGNITE-1353 > URL: https://issues.apache.org/jira/browse/IGNITE-1353 > Project: Ignite > Issue Type: Bug > Components: general >Affects Versions: 1.1.4 >Reporter: Vladimir Ozerov >Assignee: Denis Magda >Priority: Critical > Fix For: ignite-1.4 > > > See PortableContext.typeId() method. > First it checks whether type is "system", and only then try picking > predefiend ID. As a result, predefined types like IgniteBiTuple are written > with wrong IDs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
