[jira] [Commented] (IGNITE-4750) SQL: Support GROUP_CONCAT function
[ https://issues.apache.org/jira/browse/IGNITE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622169#comment-16622169 ] ASF GitHub Bot commented on IGNITE-4750: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/3185 > SQL: Support GROUP_CONCAT function > -- > > Key: IGNITE-4750 > URL: https://issues.apache.org/jira/browse/IGNITE-4750 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Denis Magda >Assignee: Taras Ledkov >Priority: Major > Labels: sql-engine > Fix For: 2.7 > > > GROUP_CONCAT function is not supported at the moment. Makes sense to fill > this gap: > http://apache-ignite-users.70518.x6.nabble.com/GROUP-CONCAT-function-is-unsupported-td10757.html > Presently the function doc is hidden: > https://apacheignite-sql.readme.io/docs/group_concat > Open it up once the ticket is released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-4750) SQL: Support GROUP_CONCAT function
[ https://issues.apache.org/jira/browse/IGNITE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611772#comment-16611772 ] Taras Ledkov commented on IGNITE-4750: -- [~jooger], [~vozerov] - tests for DISTINCT is added. - documentation ticket is linked; - TC tests are OK. > SQL: Support GROUP_CONCAT function > -- > > Key: IGNITE-4750 > URL: https://issues.apache.org/jira/browse/IGNITE-4750 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Denis Magda >Assignee: Taras Ledkov >Priority: Major > Labels: sql-engine > Fix For: 2.7 > > > GROUP_CONCAT function is not supported at the moment. Makes sense to fill > this gap: > http://apache-ignite-users.70518.x6.nabble.com/GROUP-CONCAT-function-is-unsupported-td10757.html > Presently the function doc is hidden: > https://apacheignite-sql.readme.io/docs/group_concat > Open it up once the ticket is released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-4750) SQL: Support GROUP_CONCAT function
[ https://issues.apache.org/jira/browse/IGNITE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607205#comment-16607205 ] Taras Ledkov commented on IGNITE-4750: -- [~vozerov], the test configuration is fixed. TC run is OK. > SQL: Support GROUP_CONCAT function > -- > > Key: IGNITE-4750 > URL: https://issues.apache.org/jira/browse/IGNITE-4750 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Denis Magda >Assignee: Taras Ledkov >Priority: Major > Labels: sql-engine > Fix For: 2.7 > > > GROUP_CONCAT function is not supported at the moment. Makes sense to fill > this gap: > http://apache-ignite-users.70518.x6.nabble.com/GROUP-CONCAT-function-is-unsupported-td10757.html > Presently the function doc is hidden: > https://apacheignite-sql.readme.io/docs/group_concat > Open it up once the ticket is released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-4750) SQL: Support GROUP_CONCAT function
[ https://issues.apache.org/jira/browse/IGNITE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435539#comment-16435539 ] Taras Ledkov commented on IGNITE-4750: -- [~xionghao], thanks for the comment. The described case have been fixed. [~vozerov], [~al.psc] please review the changes. Tests are OK. > SQL: Support GROUP_CONCAT function > -- > > Key: IGNITE-4750 > URL: https://issues.apache.org/jira/browse/IGNITE-4750 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Denis Magda >Assignee: Taras Ledkov >Priority: Major > Labels: sql-engine > Fix For: 2.6 > > > GROUP_CONCAT function is not supported at the moment. Makes sense to fill > this gap: > http://apache-ignite-users.70518.x6.nabble.com/GROUP-CONCAT-function-is-unsupported-td10757.html > Presently the function doc is hidden: > https://apacheignite-sql.readme.io/docs/group_concat > Open it up once the ticket is released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-4750) SQL: Support GROUP_CONCAT function
[ https://issues.apache.org/jira/browse/IGNITE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16435267#comment-16435267 ] Taras Ledkov commented on IGNITE-4750: -- [~xionghao], thanks a lot for the comment. I've fixed the described case. > SQL: Support GROUP_CONCAT function > -- > > Key: IGNITE-4750 > URL: https://issues.apache.org/jira/browse/IGNITE-4750 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Denis Magda >Assignee: Taras Ledkov >Priority: Major > Labels: sql-engine > Fix For: 2.6 > > > GROUP_CONCAT function is not supported at the moment. Makes sense to fill > this gap: > http://apache-ignite-users.70518.x6.nabble.com/GROUP-CONCAT-function-is-unsupported-td10757.html > Presently the function doc is hidden: > https://apacheignite-sql.readme.io/docs/group_concat > Open it up once the ticket is released. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-4750) SQL: Support GROUP_CONCAT function
[
https://issues.apache.org/jira/browse/IGNITE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16330184#comment-16330184
]
liu xionghao commented on IGNITE-4750:
--
It occurs errors when using +count(*distinct* ...)+ and +group_concat(...)+ in
same select clause. But if key word +*distinct*+ omited, it works.
example:
{code:java}
// code placeholder
select count(distinct a) as num, group_concat(a) as strs
from test
group by b{code}
where `test` schema:
||id (int)||a (varchar)||b (varchar)||
|1|1|2|
|2|3|2|
|3|1|3|
error:
{code:java}
[18-Jan-2018 15:23:11][ERROR][client-connector-#54][JdbcRequestHandler] Failed
to execute SQL query [reqId=0, req=JdbcQueryExecuteRequest [schemaName=PUBLIC,
pageSize=1024, maxRows=0, sqlQry=select count(distinct a) as num,
group_concat(a) as strs
from test
group by b, args=[], stmtType=ANY_STATEMENT_TYPE]]
javax.cache.CacheException: Failed to run map query remotely.
at
org.apache.ignite.internal.processors.query.h2.twostep.GridReduceQueryExecutor.query(GridReduceQueryExecutor.java:747)
at
org.apache.ignite.internal.processors.query.h2.IgniteH2Indexing$8.iterator(IgniteH2Indexing.java:1282)
at
org.apache.ignite.internal.processors.cache.QueryCursorImpl.iterator(QueryCursorImpl.java:95)
{code}
> SQL: Support GROUP_CONCAT function
> --
>
> Key: IGNITE-4750
> URL: https://issues.apache.org/jira/browse/IGNITE-4750
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Denis Magda
>Assignee: Taras Ledkov
>Priority: Major
> Fix For: 2.5
>
>
> GROUP_CONCAT function is not supported at the moment. Makes sense to fill
> this gap:
> http://apache-ignite-users.70518.x6.nabble.com/GROUP-CONCAT-function-is-unsupported-td10757.html
> Presently the function doc is hidden:
> https://apacheignite-sql.readme.io/docs/group_concat
> Open it up once the ticket is released.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-4750) SQL: Support GROUP_CONCAT function
[
https://issues.apache.org/jira/browse/IGNITE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287427#comment-16287427
]
Taras Ledkov commented on IGNITE-4750:
--
[~al.psc], you right {{sql}} member is used as argument for {{CAST}} and
{{TABLE}} functions. Fixed.
> SQL: Support GROUP_CONCAT function
> --
>
> Key: IGNITE-4750
> URL: https://issues.apache.org/jira/browse/IGNITE-4750
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Denis Magda
>Assignee: Taras Ledkov
> Fix For: 2.4
>
>
> GROUP_CONCAT function is not supported at the moment. Makes sense to fill
> this gap:
> http://apache-ignite-users.70518.x6.nabble.com/GROUP-CONCAT-function-is-unsupported-td10757.html
> Presently the function doc is hidden:
> https://apacheignite-sql.readme.io/docs/group_concat
> Open it up once the ticket is released.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4750) SQL: Support GROUP_CONCAT function
[
https://issues.apache.org/jira/browse/IGNITE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287402#comment-16287402
]
Alexander Paschenko commented on IGNITE-4750:
-
[~tledkov-gridgain],
Right, but {{GridSqlType}} is also associated with SQL keyword for
corresponding type, and, although it does not affect current task, we should
use right keyword which is {{VARCHAR}}.
> SQL: Support GROUP_CONCAT function
> --
>
> Key: IGNITE-4750
> URL: https://issues.apache.org/jira/browse/IGNITE-4750
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Denis Magda
>Assignee: Taras Ledkov
> Fix For: 2.4
>
>
> GROUP_CONCAT function is not supported at the moment. Makes sense to fill
> this gap:
> http://apache-ignite-users.70518.x6.nabble.com/GROUP-CONCAT-function-is-unsupported-td10757.html
> Presently the function doc is hidden:
> https://apacheignite-sql.readme.io/docs/group_concat
> Open it up once the ticket is released.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4750) SQL: Support GROUP_CONCAT function
[
https://issues.apache.org/jira/browse/IGNITE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287396#comment-16287396
]
Taras Ledkov commented on IGNITE-4750:
--
[~al.psc], thanks a lot! Fixed all comments except *p.7*. {{GridSqlType}} is
mapped to H2 types. See more
[{{org.h2.value.Value}}|https://github.com/h2database/h2database/blob/f2d27a3ae44e2fa24c59b3cfeb431216da9c572c/h2/src/main/org/h2/value/Value.java#L43]
> SQL: Support GROUP_CONCAT function
> --
>
> Key: IGNITE-4750
> URL: https://issues.apache.org/jira/browse/IGNITE-4750
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Denis Magda
>Assignee: Taras Ledkov
> Fix For: 2.4
>
>
> GROUP_CONCAT function is not supported at the moment. Makes sense to fill
> this gap:
> http://apache-ignite-users.70518.x6.nabble.com/GROUP-CONCAT-function-is-unsupported-td10757.html
> Presently the function doc is hidden:
> https://apacheignite-sql.readme.io/docs/group_concat
> Open it up once the ticket is released.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4750) SQL: Support GROUP_CONCAT function
[
https://issues.apache.org/jira/browse/IGNITE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287363#comment-16287363
]
Alexander Paschenko commented on IGNITE-4750:
-
[~tledkov-gridgain], my comments:
{{GridSqlAggregateFunction}}:
1. Please don't use strings addition together with {{StatementBuilder}} - use
{{append}} instead.
2. Please use {{resetCount()}} before {{appendExceptFirst()}} - these
operations are looking at the same counter, and therefore it should be reset
every time you use {{appendExceptFirst()}}.
3. Methods {{setGroupConcat*}} have way too wordy param names, like this:
{{setGroupConcatSeparator(groupConcatSeparator)}} - there's redundancy, you can
use simply {{separator}} for param name without losing any clarity.
4. {{GridSqlQueryParser}}: Code conventions are violated - long lines.
{{GridSqlQuerySplitter}}:
5. Please throw {{IgniteSqlException}} instead of {{IgniteException}}, error
code should be {{UNSUPPORTED_OPERATION}}.
6. Here: {{rdcAgg = aggregate(false, agg.type())}} please use {{GROUP_CONCAT}}
as the second arg for clarity.
7. {{GridSqlType}}: I believe SQL keyword for strings is {{VARCHAR}}, not
{{STRING}}, isn't it?
8. {{IgniteSqlGroupConcatCollocatedTest}}: please fix long lines.
> SQL: Support GROUP_CONCAT function
> --
>
> Key: IGNITE-4750
> URL: https://issues.apache.org/jira/browse/IGNITE-4750
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Denis Magda
>Assignee: Taras Ledkov
> Fix For: 2.4
>
>
> GROUP_CONCAT function is not supported at the moment. Makes sense to fill
> this gap:
> http://apache-ignite-users.70518.x6.nabble.com/GROUP-CONCAT-function-is-unsupported-td10757.html
> Presently the function doc is hidden:
> https://apacheignite-sql.readme.io/docs/group_concat
> Open it up once the ticket is released.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (IGNITE-4750) SQL: Support GROUP_CONCAT function
[ https://issues.apache.org/jira/browse/IGNITE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283792#comment-16283792 ] Denis Magda commented on IGNITE-4750: - [~taras.ledkov], please make the function's documentation visible or reassign the ticket on me to do this once the improvement is released: https://apacheignite-sql.readme.io/docs/group_concat Presently the doc is hidden and the can come across it only if he guesses the URL. > SQL: Support GROUP_CONCAT function > -- > > Key: IGNITE-4750 > URL: https://issues.apache.org/jira/browse/IGNITE-4750 > Project: Ignite > Issue Type: Task > Components: sql >Reporter: Denis Magda >Assignee: Taras Ledkov > Fix For: 2.4 > > > GROUP_CONCAT function is not supported at the moment. Makes sense to fill > this gap: > http://apache-ignite-users.70518.x6.nabble.com/GROUP-CONCAT-function-is-unsupported-td10757.html > Presently the function doc is hidden: > https://apacheignite-sql.readme.io/docs/group_concat > Open it up once the ticket is released. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (IGNITE-4750) SQL: Support GROUP_CONCAT function
[
https://issues.apache.org/jira/browse/IGNITE-4750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16283710#comment-16283710
]
Taras Ledkov commented on IGNITE-4750:
--
[~vozerov], [~al.psc], [~skalashnikov] I need in primary review for the patch.
Please take a look.
I guess tow ways to support GROUP_CONCAT in not collocated mode is
1. Use our own aggregate functions for map and reduce query. On map step:
accumulates values in collection and returns collection. On reduce step:
accumulates map's collection in reduce collection and returns sorted /
distinct.
The problem is complex {{ORDER BY}} expression inside {{GROUP_CONCAT}} function.
2. Use H2 {{GROUP_CONCAT}} function on reduce step and not-aggregated select
for map step.
The problem: query can support other aggregate functions.
> SQL: Support GROUP_CONCAT function
> --
>
> Key: IGNITE-4750
> URL: https://issues.apache.org/jira/browse/IGNITE-4750
> Project: Ignite
> Issue Type: Task
> Components: sql
>Reporter: Denis Magda
>Assignee: Taras Ledkov
>
> GROUP_CONCAT function is not supported at the moment. Makes sense to fill
> this gap:
> http://apache-ignite-users.70518.x6.nabble.com/GROUP-CONCAT-function-is-unsupported-td10757.html
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
