[jira] [Commented] (IGNITE-7749) testDiscoCacheReuseOnNodeJoin fails on TC
[
https://issues.apache.org/jira/browse/IGNITE-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372566#comment-16372566
]
ASF GitHub Bot commented on IGNITE-7749:
Github user asfgit closed the pull request at:
https://github.com/apache/ignite/pull/3540
> testDiscoCacheReuseOnNodeJoin fails on TC
> -
>
> Key: IGNITE-7749
> URL: https://issues.apache.org/jira/browse/IGNITE-7749
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.5
>Reporter: Pavel Kovalenko
>Assignee: Alexey Goncharuk
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Fix For: 2.5
>
>
> {code:java}
> java.lang.ClassCastException:
> org.apache.ignite.internal.util.GridConcurrentHashSet cannot be cast to
> java.lang.String
> at
> org.apache.ignite.spi.discovery.IgniteDiscoveryCacheReuseSelfTest.assertDiscoCacheReuse(IgniteDiscoveryCacheReuseSelfTest.java:93)
> at
> org.apache.ignite.spi.discovery.IgniteDiscoveryCacheReuseSelfTest.testDiscoCacheReuseOnNodeJoin(IgniteDiscoveryCacheReuseSelfTest.java:64)
> {code}
> There are 2 problems in the test.
> 1) We don't wait for final topology version is set on all nodes and start
> checking discovery caches immediately after grids starting. It leads to
> possible NullPointerException while accessing to discovery caches history.
> 2) We don't use explicit assertEquals(String, Object, Object) related to
> comparing Objects, while Java can choose assertEquals(String, String) method
> to compare discovery cache fields which we're getting in runtime using
> reflection.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7749) testDiscoCacheReuseOnNodeJoin fails on TC
[
https://issues.apache.org/jira/browse/IGNITE-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372565#comment-16372565
]
Alexey Goncharuk commented on IGNITE-7749:
--
Pavel, changes look good to me. Merged to master.
> testDiscoCacheReuseOnNodeJoin fails on TC
> -
>
> Key: IGNITE-7749
> URL: https://issues.apache.org/jira/browse/IGNITE-7749
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Affects Versions: 2.5
>Reporter: Pavel Kovalenko
>Assignee: Alexey Goncharuk
>Priority: Major
> Labels: MakeTeamcityGreenAgain
> Fix For: 2.5
>
>
> {code:java}
> java.lang.ClassCastException:
> org.apache.ignite.internal.util.GridConcurrentHashSet cannot be cast to
> java.lang.String
> at
> org.apache.ignite.spi.discovery.IgniteDiscoveryCacheReuseSelfTest.assertDiscoCacheReuse(IgniteDiscoveryCacheReuseSelfTest.java:93)
> at
> org.apache.ignite.spi.discovery.IgniteDiscoveryCacheReuseSelfTest.testDiscoCacheReuseOnNodeJoin(IgniteDiscoveryCacheReuseSelfTest.java:64)
> {code}
> There are 2 problems in the test.
> 1) We don't wait for final topology version is set on all nodes and start
> checking discovery caches immediately after grids starting. It leads to
> possible NullPointerException while accessing to discovery caches history.
> 2) We don't use explicit assertEquals(String, Object, Object) related to
> comparing Objects, while Java can choose assertEquals(String, String) method
> to compare discovery cache fields which we're getting in runtime using
> reflection.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-7749) testDiscoCacheReuseOnNodeJoin fails on TC
[
https://issues.apache.org/jira/browse/IGNITE-7749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368981#comment-16368981
]
ASF GitHub Bot commented on IGNITE-7749:
GitHub user Jokser opened a pull request:
https://github.com/apache/ignite/pull/3540
IGNITE-7749 Fixed testDiscoCacheReuseOnNodeJoin test.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-7749
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/3540.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3540
commit 5233269ea684e4cff8d4a7d46d3ce1dc343dd5f1
Author: Pavel Kovalenko
Date: 2018-02-19T10:46:26Z
IGNITE-7749 Fixed testDiscoCacheReuseOnNodeJoin test.
> testDiscoCacheReuseOnNodeJoin fails on TC
> -
>
> Key: IGNITE-7749
> URL: https://issues.apache.org/jira/browse/IGNITE-7749
> Project: Ignite
> Issue Type: Bug
> Components: cache
>Reporter: Pavel Kovalenko
>Assignee: Pavel Kovalenko
>Priority: Major
> Labels: MakeTeamcityGreenAgain
>
> {code:java}
> java.lang.ClassCastException:
> org.apache.ignite.internal.util.GridConcurrentHashSet cannot be cast to
> java.lang.String
> at
> org.apache.ignite.spi.discovery.IgniteDiscoveryCacheReuseSelfTest.assertDiscoCacheReuse(IgniteDiscoveryCacheReuseSelfTest.java:93)
> at
> org.apache.ignite.spi.discovery.IgniteDiscoveryCacheReuseSelfTest.testDiscoCacheReuseOnNodeJoin(IgniteDiscoveryCacheReuseSelfTest.java:64)
> {code}
> There are 2 problems in the test.
> 1) We don't wait for final topology version is set on all nodes and start
> checking discovery caches immediately after grids starting. It leads to
> possible NullPointerException while accessing to discovery caches history.
> 2) We don't use explicit assertEquals(String, Object, Object) related to
> comparing Objects, while Java can choose assertEquals(String, String) method
> to compare discovery cache fields which we're getting in runtime using
> reflection.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
