[jira] [Commented] (IGNITE-8149) MVCC TX: Size method should use tx snapshot
[ https://issues.apache.org/jira/browse/IGNITE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613411#comment-16613411 ] ASF GitHub Bot commented on IGNITE-8149: Github user pavlukhin closed the pull request at: https://github.com/apache/ignite/pull/4743 > MVCC TX: Size method should use tx snapshot > --- > > Key: IGNITE-8149 > URL: https://issues.apache.org/jira/browse/IGNITE-8149 > Project: Ignite > Issue Type: Task > Components: cache, mvcc >Reporter: Igor Seliverstov >Assignee: Ivan Pavlukhin >Priority: Major > Fix For: 2.7 > > > Currently cache.size() returns number of entries in cache trees while there > can be several versions of one key-value pairs. > We should use tx snapshot and count all passed mvcc filter entries instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8149) MVCC TX: Size method should use tx snapshot
[ https://issues.apache.org/jira/browse/IGNITE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613270#comment-16613270 ] ASF GitHub Bot commented on IGNITE-8149: GitHub user pavlukhin opened a pull request: https://github.com/apache/ignite/pull/4743 IGNITE-8149: fix for CI Fail DataStreamProcessorMvccSeflTest referring to IGNITE-9451 and mention same ticket in GridDhtPartitionsStateValidator. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8149-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4743.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4743 commit 1fecf7bf7360f231778bb91a4d49b90693167119 Author: ipavlukhin Date: 2018-09-13T09:46:33Z fail DataStreamProcessorMvccSeflTest referring to IGNITE-9451 and mention same ticket in GridDhtPartitionsStateValidator > MVCC TX: Size method should use tx snapshot > --- > > Key: IGNITE-8149 > URL: https://issues.apache.org/jira/browse/IGNITE-8149 > Project: Ignite > Issue Type: Task > Components: cache, mvcc >Reporter: Igor Seliverstov >Assignee: Ivan Pavlukhin >Priority: Major > Fix For: 2.7 > > > Currently cache.size() returns number of entries in cache trees while there > can be several versions of one key-value pairs. > We should use tx snapshot and count all passed mvcc filter entries instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8149) MVCC TX: Size method should use tx snapshot
[ https://issues.apache.org/jira/browse/IGNITE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607103#comment-16607103 ] ASF GitHub Bot commented on IGNITE-8149: Github user asfgit closed the pull request at: https://github.com/apache/ignite/pull/4654 > MVCC TX: Size method should use tx snapshot > --- > > Key: IGNITE-8149 > URL: https://issues.apache.org/jira/browse/IGNITE-8149 > Project: Ignite > Issue Type: Task > Components: cache, mvcc >Reporter: Igor Seliverstov >Assignee: Ivan Pavlukhin >Priority: Major > Fix For: 2.7 > > > Currently cache.size() returns number of entries in cache trees while there > can be several versions of one key-value pairs. > We should use tx snapshot and count all passed mvcc filter entries instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8149) MVCC TX: Size method should use tx snapshot
[
https://issues.apache.org/jira/browse/IGNITE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601999#comment-16601999
]
Ivan Pavlukhin commented on IGNITE-8149:
Additionally some problems were found which needs to be fixed. Attention must
be put on:
{{org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManager#mvccRemoveAll}}
{{org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManager.CacheDataStore#mvccInitialValue}}
> MVCC TX: Size method should use tx snapshot
> ---
>
> Key: IGNITE-8149
> URL: https://issues.apache.org/jira/browse/IGNITE-8149
> Project: Ignite
> Issue Type: Task
> Components: cache, mvcc
>Reporter: Igor Seliverstov
>Assignee: Ivan Pavlukhin
>Priority: Major
> Fix For: 2.7
>
>
> Currently cache.size() returns number of entries in cache trees while there
> can be several versions of one key-value pairs.
> We should use tx snapshot and count all passed mvcc filter entries instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8149) MVCC TX: Size method should use tx snapshot
[ https://issues.apache.org/jira/browse/IGNITE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598492#comment-16598492 ] Igor Seliverstov commented on IGNITE-8149: -- [~vozerov], could you look at? > MVCC TX: Size method should use tx snapshot > --- > > Key: IGNITE-8149 > URL: https://issues.apache.org/jira/browse/IGNITE-8149 > Project: Ignite > Issue Type: Task > Components: cache, mvcc >Reporter: Igor Seliverstov >Assignee: Ivan Pavlukhin >Priority: Major > Fix For: 2.7 > > > Currently cache.size() returns number of entries in cache trees while there > can be several versions of one key-value pairs. > We should use tx snapshot and count all passed mvcc filter entries instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8149) MVCC TX: Size method should use tx snapshot
[ https://issues.apache.org/jira/browse/IGNITE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597610#comment-16597610 ] ASF GitHub Bot commented on IGNITE-8149: GitHub user pavlukhin opened a pull request: https://github.com/apache/ignite/pull/4654 IGNITE-8149: MVCC TX: Size method should use tx snapshot You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-8149 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/4654.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #4654 commit b5ea6e1b5b072995f8e97a19183ebebfbae6cf20 Author: ipavlukhin Date: 2018-08-30T16:00:08Z IGNITE-8149 Cache.size is updated on MVCC transaction commit > MVCC TX: Size method should use tx snapshot > --- > > Key: IGNITE-8149 > URL: https://issues.apache.org/jira/browse/IGNITE-8149 > Project: Ignite > Issue Type: Task > Components: cache, mvcc >Reporter: Igor Seliverstov >Assignee: Ivan Pavlukhin >Priority: Major > Fix For: 2.7 > > > Currently cache.size() returns number of entries in cache trees while there > can be several versions of one key-value pairs. > We should use tx snapshot and count all passed mvcc filter entries instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8149) MVCC TX: Size method should use tx snapshot
[ https://issues.apache.org/jira/browse/IGNITE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597520#comment-16597520 ] Ivan Pavlukhin commented on IGNITE-8149: 4 - updatedCachePartitions -> touchedCachePartitions > MVCC TX: Size method should use tx snapshot > --- > > Key: IGNITE-8149 > URL: https://issues.apache.org/jira/browse/IGNITE-8149 > Project: Ignite > Issue Type: Task > Components: cache, mvcc >Reporter: Igor Seliverstov >Assignee: Ivan Pavlukhin >Priority: Major > Fix For: 2.7 > > > Currently cache.size() returns number of entries in cache trees while there > can be several versions of one key-value pairs. > We should use tx snapshot and count all passed mvcc filter entries instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8149) MVCC TX: Size method should use tx snapshot
[ https://issues.apache.org/jira/browse/IGNITE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597508#comment-16597508 ] Igor Seliverstov commented on IGNITE-8149: -- [~Pavlukhin], "updated rows" sounds natural, but I cant say the same about "updated partitions". I would insist to rename the method. > MVCC TX: Size method should use tx snapshot > --- > > Key: IGNITE-8149 > URL: https://issues.apache.org/jira/browse/IGNITE-8149 > Project: Ignite > Issue Type: Task > Components: cache, mvcc >Reporter: Igor Seliverstov >Assignee: Ivan Pavlukhin >Priority: Major > Fix For: 2.7 > > > Currently cache.size() returns number of entries in cache trees while there > can be several versions of one key-value pairs. > We should use tx snapshot and count all passed mvcc filter entries instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8149) MVCC TX: Size method should use tx snapshot
[ https://issues.apache.org/jira/browse/IGNITE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597507#comment-16597507 ] Ivan Pavlukhin commented on IGNITE-8149: 6, 7 - tests added > MVCC TX: Size method should use tx snapshot > --- > > Key: IGNITE-8149 > URL: https://issues.apache.org/jira/browse/IGNITE-8149 > Project: Ignite > Issue Type: Task > Components: cache, mvcc >Reporter: Igor Seliverstov >Assignee: Ivan Pavlukhin >Priority: Major > Fix For: 2.7 > > > Currently cache.size() returns number of entries in cache trees while there > can be several versions of one key-value pairs. > We should use tx snapshot and count all passed mvcc filter entries instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8149) MVCC TX: Size method should use tx snapshot
[ https://issues.apache.org/jira/browse/IGNITE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597477#comment-16597477 ] Ivan Pavlukhin commented on IGNITE-8149: 1 - 3 - done 4 - _involvedPartitions_ name reflects semantics improperly, because only _updated_ ones are tracked here 5 - replaced with lazily initialized volatile 6, 7 - in progress 8 - done 9 - done > MVCC TX: Size method should use tx snapshot > --- > > Key: IGNITE-8149 > URL: https://issues.apache.org/jira/browse/IGNITE-8149 > Project: Ignite > Issue Type: Task > Components: cache, mvcc >Reporter: Igor Seliverstov >Assignee: Ivan Pavlukhin >Priority: Major > Fix For: 2.7 > > > Currently cache.size() returns number of entries in cache trees while there > can be several versions of one key-value pairs. > We should use tx snapshot and count all passed mvcc filter entries instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8149) MVCC TX: Size method should use tx snapshot
[ https://issues.apache.org/jira/browse/IGNITE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597443#comment-16597443 ] Ivan Pavlukhin commented on IGNITE-8149: 1 - 3 fixed > MVCC TX: Size method should use tx snapshot > --- > > Key: IGNITE-8149 > URL: https://issues.apache.org/jira/browse/IGNITE-8149 > Project: Ignite > Issue Type: Task > Components: cache, mvcc >Reporter: Igor Seliverstov >Assignee: Ivan Pavlukhin >Priority: Major > Fix For: 2.7 > > > Currently cache.size() returns number of entries in cache trees while there > can be several versions of one key-value pairs. > We should use tx snapshot and count all passed mvcc filter entries instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (IGNITE-8149) MVCC TX: Size method should use tx snapshot
[
https://issues.apache.org/jira/browse/IGNITE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597429#comment-16597429
]
Igor Seliverstov commented on IGNITE-8149:
--
[~Pavlukhin], see my comments below:
1) Move {{applyAndCollectLocalUpdateCounters()}} and
{{txCounters().updateCounters(updCntrs)}} to
{{org.apache.ignite.internal.processors.cache.transactions.IgniteTxLocalAdapter#applyTxCounters}}
2) Inline
{{org.apache.ignite.internal.processors.cache.distributed.GridDistributedTxRemoteAdapter#applyUpdateCounters}}
method
3) Inline
{{org.apache.ignite.internal.processors.cache.transactions.IgniteTxAdapter#applyCacheSizeDeltas}}
method
4)
{{org.apache.ignite.internal.processors.cache.transactions.IgniteTxLocalState#updatedCachePartitions}}
- involvedPartitions, I think, much better name
5)
{{org.apache.ignite.internal.processors.cache.transactions.IgniteTxLocalStateAdapter#updCacheParts}}
has no sense for non-mvcc transactions and should be initialized lazily
6) What about changes, made by DataStreamer? Appropriate tests are needed.
7) There are no tests for size consistency after just joined node is fully
rebalanced.
8) Inline
{{org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl.CacheDataStoreImpl#updateSize0}}
and use
{{org.apache.ignite.internal.processors.cache.IgniteCacheOffheapManagerImpl.CacheDataStoreImpl#updateSize}}
instead
9) Check imports.
> MVCC TX: Size method should use tx snapshot
> ---
>
> Key: IGNITE-8149
> URL: https://issues.apache.org/jira/browse/IGNITE-8149
> Project: Ignite
> Issue Type: Task
> Components: cache, mvcc
>Reporter: Igor Seliverstov
>Assignee: Ivan Pavlukhin
>Priority: Major
> Fix For: 2.7
>
>
> Currently cache.size() returns number of entries in cache trees while there
> can be several versions of one key-value pairs.
> We should use tx snapshot and count all passed mvcc filter entries instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (IGNITE-8149) MVCC TX: Size method should use tx snapshot
[ https://issues.apache.org/jira/browse/IGNITE-8149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593465#comment-16593465 ] Ivan Pavlukhin commented on IGNITE-8149: Basic idea of size calculation is based on following points: * Introduced TxCounters entity is used for accumulation various counters of running transaction. * During transaction execution size delta is accumulated in TxCounters by mutating operations. * Size changes become visible in the end of transaction. > MVCC TX: Size method should use tx snapshot > --- > > Key: IGNITE-8149 > URL: https://issues.apache.org/jira/browse/IGNITE-8149 > Project: Ignite > Issue Type: Task > Components: cache, mvcc >Reporter: Igor Seliverstov >Assignee: Ivan Pavlukhin >Priority: Major > Fix For: 2.7 > > > Currently cache.size() returns number of entries in cache trees while there > can be several versions of one key-value pairs. > We should use tx snapshot and count all passed mvcc filter entries instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
