https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
Philippe Mouawad changed:
What|Removed |Added
Resolution|WONTFIX |DUPLICATE
--- Comment #19 from
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
Philippe Mouawad changed:
What|Removed |Added
Status|NEEDINFO|RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #17 from Philippe Mouawad ---
(In reply to Alan Silva from comment #16)
> (In reply to Philippe Mouawad from comment #10)
> > (In reply to Alan Silva from comment #9)
> > > Oh yes. You're absolutely right @Philippe Mouawad.
> > >
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #16 from Alan Silva ---
(In reply to Philippe Mouawad from comment #10)
> (In reply to Alan Silva from comment #9)
> > Oh yes. You're absolutely right @Philippe Mouawad.
> >
> > The patch should haven been an if/else. My mistake.
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #15 from Artem Fedorov ---
Benchmark results:
# Run complete. Total time: 00:37:59
Benchmark (index) Mode Cnt Score Error Units
StringBenchmark.compareToBenchmark0 thrpt 20 0.823 ±
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #14 from Artem Fedorov ---
Created attachment 36260
--> https://bz.apache.org/bugzilla/attachment.cgi?id=36260=edit
Benchmark test class
I created a benchmark test for equals and compareTo methods.
Dependencies:
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #13 from Artem Fedorov ---
(In reply to Felix Schumacher from comment #12)
> (In reply to Artem Fedorov from comment #11)
> > Hi
> > I added a PR https://github.com/apache/jmeter/pull/429
> > Also I use compareTo() instead of
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #12 from Felix Schumacher ---
(In reply to Artem Fedorov from comment #11)
> Hi
> I added a PR https://github.com/apache/jmeter/pull/429
> Also I use compareTo() instead of equals() for string comparison.
> Performance comparison
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #11 from Artem Fedorov ---
Hi
I added a PR https://github.com/apache/jmeter/pull/429
Also I use compareTo() instead of equals() for string comparison. Performance
comparison of these functions I got from
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #10 from Philippe Mouawad ---
(In reply to Alan Silva from comment #9)
> Oh yes. You're absolutely right @Philippe Mouawad.
>
> The patch should haven been an if/else. My mistake.
>
> In any case, as I said in my previous
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #9 from Alan Silva ---
Oh yes. You're absolutely right @Philippe Mouawad.
The patch should haven been an if/else. My mistake.
In any case, as I said in my previous comment:
Calling addSubResult(SampleResult subResult, false) is
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #8 from Philippe Mouawad ---
(In reply to Artem Fedorov from comment #7)
> Hi all,
>
> I agree with attached fix, but it can throw NPE, because it skip check for
> null
>
>
> if(subResult == null) {
> // see
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
--- Comment #7 from Artem Fedorov ---
Hi all,
I agree with attached fix, but it can throw NPE, because it skip check for null
if(subResult == null) {
// see https://bz.apache.org/bugzilla/show_bug.cgi?id=54778
return;
}
The other
https://bz.apache.org/bugzilla/show_bug.cgi?id=62887
Philippe Mouawad changed:
What|Removed |Added
OS|Linux |All
Summary|SampleLabel
14 matches
Mail list logo
