hit-lacus commented on pull request #1649:
URL: https://github.com/apache/kylin/pull/1649#issuecomment-863784689
Thanks @Ted-Jiang !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
hit-lacus merged pull request #1649:
URL: https://github.com/apache/kylin/pull/1649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
zhangayqian edited a comment on pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#issuecomment-863869542
When testing this patch, I encountered the following error in the first step
of the build job:
https://user-images.githubusercontent.com/31064237/122533007-ab50e300-d
hit-lacus merged pull request #1665:
URL: https://github.com/apache/kylin/pull/1665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
hit-lacus commented on a change in pull request #1644:
URL: https://github.com/apache/kylin/pull/1644#discussion_r654171671
##
File path:
server-base/src/main/java/org/apache/kylin/rest/service/JobService.java
##
@@ -435,6 +438,26 @@ private void checkAllowBuilding(CubeInstanc
zhangayqian commented on pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#issuecomment-863869542
When testing this patch, I encountered the following error in the first step
of the build job:
https://user-images.githubusercontent.com/31064237/122533007-ab50e300-d053-11e
codecov-commenter commented on pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#issuecomment-864712270
#
[Codecov](https://codecov.io/gh/apache/kylin/pull/1568?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
zzcclp commented on a change in pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#discussion_r655075865
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkExecutable.java
##
@@ -382,6 +387,8 @@ protected
zzcclp commented on a change in pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#discussion_r655075865
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkExecutable.java
##
@@ -382,6 +387,8 @@ protected
hit-lacus commented on a change in pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#discussion_r655089493
##
File path:
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##
@@ -3125,4 +3125,32 @@ public int getRepartitionNumAfterEncode()
hit-lacus commented on a change in pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#discussion_r655089493
##
File path:
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##
@@ -3125,4 +3125,32 @@ public int getRepartitionNumAfterEncode()
hit-lacus commented on a change in pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#discussion_r655095614
##
File path:
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##
@@ -3125,4 +3125,32 @@ public int getRepartitionNumAfterEncode()
hit-lacus commented on a change in pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#discussion_r655095908
##
File path:
core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java
##
@@ -3125,4 +3125,32 @@ public int getRepartitionNumAfterEncode()
tianhui5 commented on a change in pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#discussion_r655118840
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkExecutable.java
##
@@ -382,6 +387,8 @@ protecte
hit-lacus commented on a change in pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#discussion_r655121075
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/builder/CubeTableEncoder.scala
##
@@ -61,15 +66,59 @@ o
hit-lacus commented on a change in pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#discussion_r655165882
##
File path:
kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/dict/NBucketDictionary.java
##
@@ -49,6 +56,15 @@
this.
hit-lacus commented on pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#issuecomment-864870861
Would you like to enable this feature in IT, so IT can cover this feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
tianhui5 opened a new pull request #1666:
URL: https://github.com/apache/kylin/pull/1666
## Proposed changes
JIRA: https://issues.apache.org/jira/browse/KYLIN-5013
## Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking
nickSoul commented on a change in pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#discussion_r655776336
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/builder/CubeTableEncoder.scala
##
@@ -61,15 +66,59 @@ ob
nickSoul commented on a change in pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#discussion_r655776336
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/builder/CubeTableEncoder.scala
##
@@ -61,15 +66,59 @@ ob
hit-lacus merged pull request #1666:
URL: https://github.com/apache/kylin/pull/1666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
zhangayqian commented on pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#issuecomment-865654489
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
zhengshengjun commented on pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#issuecomment-865660927
@hit-lacus fixed, thanks for you suggestions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
hit-lacus commented on a change in pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#discussion_r655121075
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/builder/CubeTableEncoder.scala
##
@@ -61,15 +66,59 @@ o
tianhui5 commented on a change in pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#discussion_r655118840
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/java/org/apache/kylin/engine/spark/job/NSparkExecutable.java
##
@@ -382,6 +387,8 @@ protecte
hit-lacus merged pull request #1666:
URL: https://github.com/apache/kylin/pull/1666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
zhengshengjun commented on pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#issuecomment-865660927
@hit-lacus fixed, thanks for you suggestions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
nickSoul commented on a change in pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#discussion_r655776336
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/kylin/engine/spark/builder/CubeTableEncoder.scala
##
@@ -61,15 +66,59 @@ ob
hit-lacus commented on pull request #1662:
URL: https://github.com/apache/kylin/pull/1662#issuecomment-864870861
Would you like to enable this feature in IT, so IT can cover this feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
zhangayqian commented on pull request #1568:
URL: https://github.com/apache/kylin/pull/1568#issuecomment-865654489
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
martin-g commented on pull request #1558:
URL: https://github.com/apache/kylin/pull/1558#issuecomment-865898669
@hit-lacus I was able to run the Docker image on Linux ARM64 with these
changes:
https://github.com/apache/kylin/compare/master...martin-g:KYLIN-4864-add-support-for-aarch64-to-D
martin-g edited a comment on pull request #1558:
URL: https://github.com/apache/kylin/pull/1558#issuecomment-865898669
@hit-lacus I was able to run the Docker image on Linux ARM64 with these
changes:
https://github.com/apache/kylin/compare/master...martin-g:KYLIN-4864-add-support-for-aarch
martin-g edited a comment on pull request #1558:
URL: https://github.com/apache/kylin/pull/1558#issuecomment-865898669
@hit-lacus I was able to run the Docker image on Linux ARM64 with these
changes:
https://github.com/apache/kylin/compare/master...martin-g:KYLIN-4864-add-support-for-aarch
zhangayqian merged pull request #1568:
URL: https://github.com/apache/kylin/pull/1568
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, plea
martin-g commented on pull request #1558:
URL: https://github.com/apache/kylin/pull/1558#issuecomment-865972469
I've created `apache-kylin-3.1.3-SNAPSHOT-bin.tar.gz` by using `./build/*`
and `./tool/target/kylin-tool-3.1.3-SNAPSHOT.jar`. But when starting Kylin it
fails with `Please set ky
liukun4515 opened a new pull request #1667:
URL: https://github.com/apache/kylin/pull/1667
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
zhangayqian opened a new pull request #1668:
URL: https://github.com/apache/kylin/pull/1668
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
lgtm-com[bot] commented on pull request #1668:
URL: https://github.com/apache/kylin/pull/1668#issuecomment-866613289
This pull request **introduces 2 alerts** when merging
f2a08b8ab2a4a2e798ce0ec7349a3b87778844c6 into
25080df65fae347edc28ebf73167fae7689aa561 - [view on
LGTM.com](https://l
lgtm-com[bot] commented on pull request #1668:
URL: https://github.com/apache/kylin/pull/1668#issuecomment-866658345
This pull request **introduces 2 alerts** when merging
1693c9929a7723ffd68a0f497bf107431a65beeb into
25080df65fae347edc28ebf73167fae7689aa561 - [view on
LGTM.com](https://l
lgtm-com[bot] commented on pull request #1668:
URL: https://github.com/apache/kylin/pull/1668#issuecomment-866712721
This pull request **introduces 1 alert** when merging
81f9d7f30dfbf80bc9776ad73bfa8a01a5edefc8 into
25080df65fae347edc28ebf73167fae7689aa561 - [view on
LGTM.com](https://lg
liukun4515 opened a new pull request #1669:
URL: https://github.com/apache/kylin/pull/1669
Add constraint for getRequireRemotePersistSegments() to avoid deleting
segments unexpectedly
## Proposed changes
Describe the big picture of your changes here to communicate to the
main
codecov-commenter commented on pull request #1668:
URL: https://github.com/apache/kylin/pull/1668#issuecomment-866764212
#
[Codecov](https://codecov.io/gh/apache/kylin/pull/1668?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
zzcclp commented on a change in pull request #1601:
URL: https://github.com/apache/kylin/pull/1601#discussion_r657063364
##
File path:
kylin-spark-project/kylin-spark-common/src/main/spark31/org/apache/spark/sql/execution/KylinJoinSelection.scala
##
@@ -0,0 +1,285 @@
+/*
+ * L
codecov-commenter edited a comment on pull request #1601:
URL: https://github.com/apache/kylin/pull/1601#issuecomment-846865473
#
[Codecov](https://codecov.io/gh/apache/kylin/pull/1601?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=T
liukun4515 commented on a change in pull request #1644:
URL: https://github.com/apache/kylin/pull/1644#discussion_r657576904
##
File path:
server-base/src/main/java/org/apache/kylin/rest/service/JobService.java
##
@@ -435,6 +438,26 @@ private void checkAllowBuilding(CubeInstan
liukun4515 opened a new pull request #1670:
URL: https://github.com/apache/kylin/pull/1670
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
zzcclp commented on pull request #1668:
URL: https://github.com/apache/kylin/pull/1668#issuecomment-867689467
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For quer
zzcclp merged pull request #1668:
URL: https://github.com/apache/kylin/pull/1668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please co
woyumen4597 opened a new pull request #1671:
URL: https://github.com/apache/kylin/pull/1671
## Proposed changes
Avoid npe issue in rdbms pushdown
## Types of changes
- [x] Bugfix (non-breaking change which fixes an issue)
## Checklist
- [x] I have create an
zzcclp commented on pull request #1601:
URL: https://github.com/apache/kylin/pull/1601#issuecomment-869019077
LGTM, thank you for your contribution, this feature is great.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
zzcclp merged pull request #1601:
URL: https://github.com/apache/kylin/pull/1601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr..
pan3793 commented on pull request #1601:
URL: https://github.com/apache/kylin/pull/1601#issuecomment-869091995
Why put classes of `package org.apache.spark.memory` into folder
`org/apache/spark/monitor`?
--
This is an automated message from the Apache Git Service.
To respond to the messa
zzcclp commented on pull request #1601:
URL: https://github.com/apache/kylin/pull/1601#issuecomment-869096384
@pan3793 Thanks for your mentioning, I will check later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
hit-lacus merged pull request #1644:
URL: https://github.com/apache/kylin/pull/1644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
hit-lacus merged pull request #1663:
URL: https://github.com/apache/kylin/pull/1663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
hit-lacus merged pull request #1671:
URL: https://github.com/apache/kylin/pull/1671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
hit-lacus merged pull request #1662:
URL: https://github.com/apache/kylin/pull/1662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
hit-lacus merged pull request #1664:
URL: https://github.com/apache/kylin/pull/1664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
zhangayqian opened a new pull request #1672:
URL: https://github.com/apache/kylin/pull/1672
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
zhangayqian merged pull request #1672:
URL: https://github.com/apache/kylin/pull/1672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsub
liukun4515 opened a new pull request #1673:
URL: https://github.com/apache/kylin/pull/1673
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
zhangayqian merged pull request #1672:
URL: https://github.com/apache/kylin/pull/1672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsub
zhangayqian opened a new pull request #1674:
URL: https://github.com/apache/kylin/pull/1674
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
zhangayqian merged pull request #1674:
URL: https://github.com/apache/kylin/pull/1674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsub
zhangayqian opened a new pull request #1675:
URL: https://github.com/apache/kylin/pull/1675
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
zhangayqian opened a new pull request #1676:
URL: https://github.com/apache/kylin/pull/1676
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
zhangayqian merged pull request #1676:
URL: https://github.com/apache/kylin/pull/1676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsub
hit-lacus opened a new pull request #1677:
URL: https://github.com/apache/kylin/pull/1677
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be s
hit-lacus commented on pull request #1677:
URL: https://github.com/apache/kylin/pull/1677#issuecomment-873371589
## Design
[ design
](https://www.notion.so/xxyu/Dev-Diary-KYLIN-5023-Kylin-4-deployMode-Cluster-80c269b757a74f9892551701e252ceec)
## Configuration
Enable st
hit-lacus edited a comment on pull request #1677:
URL: https://github.com/apache/kylin/pull/1677#issuecomment-873371589
## Design
[ design
](https://www.notion.so/xxyu/Dev-Diary-KYLIN-5023-Kylin-4-deployMode-Cluster-80c269b757a74f9892551701e252ceec)
## Configuration
En
hit-lacus commented on pull request #1677:
URL: https://github.com/apache/kylin/pull/1677#issuecomment-873382691
## Test Case
Kill the Driver while the spark application is running
It is clear that when Driver status is not the same as the spark application.
![image](https
hit-lacus edited a comment on pull request #1677:
URL: https://github.com/apache/kylin/pull/1677#issuecomment-873371589
## Design
[ root cause and new design Chinese
](https://www.notion.so/xxyu/Dev-Diary-KYLIN-5023-Kylin-4-deployMode-Cluster-80c269b757a74f9892551701e252ceec)
hit-lacus edited a comment on pull request #1677:
URL: https://github.com/apache/kylin/pull/1677#issuecomment-873371589
# Design Doc
[ root cause and new design Chinese
](https://www.notion.so/xxyu/Dev-Diary-KYLIN-5023-Kylin-4-deployMode-Cluster-80c269b757a74f9892551701e252ceec)
hit-lacus merged pull request #1675:
URL: https://github.com/apache/kylin/pull/1675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
zhengshengjun commented on a change in pull request #1677:
URL: https://github.com/apache/kylin/pull/1677#discussion_r663519186
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/spark/deploy/StandaloneAppClient.scala
##
@@ -0,0 +1,116 @@
+/*
+ * Li
zhengshengjun commented on a change in pull request #1677:
URL: https://github.com/apache/kylin/pull/1677#discussion_r663609349
##
File path:
kylin-spark-project/kylin-spark-engine/src/main/scala/org/apache/spark/deploy/StandaloneAppClient.scala
##
@@ -0,0 +1,116 @@
+/*
+ * Li
liukun4515 opened a new pull request #1678:
URL: https://github.com/apache/kylin/pull/1678
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request,
martin-g commented on pull request #1558:
URL: https://github.com/apache/kylin/pull/1558#issuecomment-874054281
@hit-lacus Ping!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
hit-lacus opened a new pull request #1679:
URL: https://github.com/apache/kylin/pull/1679
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be s
hit-lacus merged pull request #1679:
URL: https://github.com/apache/kylin/pull/1679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
tianhui5 opened a new pull request #1680:
URL: https://github.com/apache/kylin/pull/1680
## Proposed changes
JIRA: https://issues.apache.org/jira/browse/KYLIN-5021
## Types of changes
- [x ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-bre
hit-lacus opened a new pull request #1681:
URL: https://github.com/apache/kylin/pull/1681
Reverts apache/kylin#1679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
hit-lacus merged pull request #1681:
URL: https://github.com/apache/kylin/pull/1681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
xiacongling commented on a change in pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#discussion_r664348908
##
File path:
kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/execution/datasource/FilePruner.scala
##
@@ -330,7 +330,7 @@ c
codecov-commenter commented on pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#issuecomment-874641285
#
[Codecov](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
hit-lacus merged pull request #1679:
URL: https://github.com/apache/kylin/pull/1679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
martin-g commented on pull request #1558:
URL: https://github.com/apache/kylin/pull/1558#issuecomment-874054281
@hit-lacus Ping!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
hit-lacus merged pull request #1681:
URL: https://github.com/apache/kylin/pull/1681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
codecov-commenter commented on pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#issuecomment-874641285
#
[Codecov](https://codecov.io/gh/apache/kylin/pull/1680?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apac
xiacongling commented on a change in pull request #1680:
URL: https://github.com/apache/kylin/pull/1680#discussion_r664348908
##
File path:
kylin-spark-project/kylin-spark-common/src/main/scala/org/apache/spark/sql/execution/datasource/FilePruner.scala
##
@@ -330,7 +330,7 @@ c
zhangayqian opened a new pull request #1682:
URL: https://github.com/apache/kylin/pull/1682
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
liukun4515 commented on pull request #1678:
URL: https://github.com/apache/kylin/pull/1678#issuecomment-874784628
@hit-lacus PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
xiacongling opened a new pull request #1683:
URL: https://github.com/apache/kylin/pull/1683
KYLIN-5029 set metrics refresh interval to a smaller value to make sure
tests always passed
## Proposed changes
Describe the big picture of your changes here to communicate to the
ma
xiacongling commented on pull request #1682:
URL: https://github.com/apache/kylin/pull/1682#issuecomment-874856024
Hi, @zhangayqian. Compilation failed for Spark3 compatibility. To resolve
the problem, L495 of `KylinExpressions` may be changed like the following:
https://github.com/
xiacongling commented on pull request #1677:
URL: https://github.com/apache/kylin/pull/1677#issuecomment-874860967
Hi, @hit-lacus. Similar with https://github.com/apache/kylin/pull/1682,
compilation failed for Spark3 compatibility. To resolve the problem, L495 of
KylinExpressions may be ch
hit-lacus commented on pull request #1677:
URL: https://github.com/apache/kylin/pull/1677#issuecomment-875253866
> Hi, @hit-lacus. Similar with #1682, compilation failed for Spark3
compatibility. To resolve the problem, L495 of KylinExpressions may be changed
like the following:
>
>
liukun4515 opened a new pull request #1684:
URL: https://github.com/apache/kylin/pull/1684
## Proposed changes
Describe the big picture of your changes here to communicate to the
maintainers why we should accept this pull request. If it fixes a bug or
resolves a feature request, be
tianhui5 closed pull request #1353:
URL: https://github.com/apache/kylin/pull/1353
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
hit-lacus merged pull request #1682:
URL: https://github.com/apache/kylin/pull/1682
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubsc
Ted-Jiang opened a new pull request #1685:
URL: https://github.com/apache/kylin/pull/1685
## Proposed changes
There are two project in Kylin: project1, project2.
Cube1 is in project1 now.
1.Some one is in project2 (In KYLIN-UI)
2.edit cube1 with url https:///kylin
1 - 100 of 9871 matches
Mail list logo