MarcusSorealheis commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-668407860
I suppose I should convert this back to draft. I don't think it all the
comments makes sense, but there is one place I think it does make sense to
preserve the
noblepaul commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-668414016
+1 to @tflobbe
We should make the change not break rolling restarts. I like the suggestion
This
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170621#comment-17170621
]
Marcus Eagan commented on SOLR-14702:
-
This was not addressed here in the Jira but Tomas raised a
murblanc commented on pull request #1684:
URL: https://github.com/apache/lucene-solr/pull/1684#issuecomment-668454886
> So, please feel free to ignore #1714 . You can use #1694 in your
framework, if you like it. If not, you go ahead .
Thanks @noblepaul! It's still a bit hard for me
tflobbe commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464818931
##
File path: solr/solr-ref-guide/src/replication-screen.adoc
##
@@ -16,10 +16,10 @@
// specific language governing permissions and limitations
//
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464823586
##
File path: solr/core/src/java/org/apache/solr/handler/CdcrRequestHandler.java
##
@@ -733,12 +733,12 @@ private void
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464823056
##
File path: solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java
##
@@ -239,7 +239,7 @@ final private void replicate(String
tflobbe commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-668412102
One way to get back compatibility and rolling upgrades could be to make 9.x
code be able to read previous formats, but write new format, and make 8.x
(since 8.7) read new
MarcusSorealheis commented on pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711#issuecomment-668441665
@chatman and @tflobbe this one is clean and ready to go almost ready to go
(waiting on tests, and will fix any broken ones before converting from draft).
MarcusSorealheis commented on pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711#issuecomment-668441771
that way we can support rolling upgrades
This is an automated message from the Apache Git Service.
anshumg commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r464870231
##
File path: solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
##
@@ -668,4 +694,9 @@ public void close() {
public void
MarcusSorealheis commented on pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711#issuecomment-668455706
![image](https://user-images.githubusercontent.com/2353608/89270722-9d87a000-d5f0-11ea-9235-855cfc598797.png)
Feel free to review it. I may not get to the back
tflobbe commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464820825
##
File path: solr/solr-ref-guide/src/cloud-screens.adoc
##
@@ -23,7 +23,7 @@ This screen provides status information about each collection
& node
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464826399
##
File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java
##
@@ -236,27 +236,27 @@ public
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464826083
##
File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java
##
@@ -236,27 +236,27 @@ public
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464826670
##
File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java
##
@@ -404,35 +404,35 @@ IndexFetchResult
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464841858
##
File path: solr/solr-ref-guide/src/cloud-screens.adoc
##
@@ -23,7 +23,7 @@ This screen provides status information about each collection
MarcusSorealheis commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-668462213
Closing this PR in favor of the other:
https://github.com/apache/lucene-solr/pull/1711
This is an
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464817633
##
File path: solr/core/src/java/org/apache/solr/cloud/ReplicateFromLeader.java
##
@@ -76,12 +76,12 @@ public void startReplication(boolean
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464818639
##
File path: solr/solr-ref-guide/src/cloud-screens.adoc
##
@@ -23,7 +23,7 @@ This screen provides status information about each collection
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464823056
##
File path: solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java
##
@@ -239,7 +239,7 @@ final private void replicate(String
MarcusSorealheis commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-668418177
PLEASE DO NOT MERGE — I've reverted back to the initial approach of using
Leader/Follower because of various dependencies.
MarcusSorealheis commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-668463295
@tflobbe I like the suggestion. Can we save it for the subsequent PR?
This is an automated message
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464817908
##
File path: solr/solr-ref-guide/src/replication-screen.adoc
##
@@ -16,10 +16,10 @@
// specific language governing permissions and
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464817727
##
File path: solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java
##
@@ -239,7 +239,7 @@ final private void replicate(String
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170575#comment-17170575
]
Tomas Eduardo Fernandez Lobbe edited comment on SOLR-14702 at 8/4/20, 6:05 AM:
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464842743
##
File path: solr/solr-ref-guide/src/cloud-screens.adoc
##
@@ -23,7 +23,7 @@ This screen provides status information about each collection
MarcusSorealheis commented on a change in pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#discussion_r464863669
##
File path: solr/core/src/java/org/apache/solr/handler/IndexFetcher.java
##
@@ -404,35 +404,35 @@ IndexFetchResult
chatman commented on pull request #1639:
URL: https://github.com/apache/lucene-solr/pull/1639#issuecomment-668466207
It was merged with 8.6. Thanks.
This is an automated message from the Apache Git Service.
To respond to the
chatman closed pull request #1639:
URL: https://github.com/apache/lucene-solr/pull/1639
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
atris commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-668469871
Thanks @anshumg . Fixed the same.
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170668#comment-17170668
]
Andrew commented on SOLR-13973:
---
We are using Solr as a full-text indexing sub-system and the key feature
[
https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170668#comment-17170668
]
Andrew edited comment on SOLR-13973 at 8/4/20, 9:15 AM:
We are using Solr as a
atris commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r464892774
##
File path: solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
##
@@ -377,6 +385,20 @@ public void doFilter(ServletRequest _request,
[
https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilan Ginzburg reassigned SOLR-14613:
Assignee: Ilan Ginzburg
> Provide a clean API for pluggable replica assignment
[
https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170668#comment-17170668
]
Andrew edited comment on SOLR-13973 at 8/4/20, 9:17 AM:
We are using Solr as a
[
https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170668#comment-17170668
]
Andrew edited comment on SOLR-13973 at 8/4/20, 9:16 AM:
We are using Solr as a
[
https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170668#comment-17170668
]
Andrew edited comment on SOLR-13973 at 8/4/20, 9:16 AM:
We are using Solr as a
[
https://issues.apache.org/jira/browse/SOLR-14604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170678#comment-17170678
]
ASF subversion and git services commented on SOLR-14604:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ishan Chattopadhyaya updated SOLR-14604:
Fix Version/s: 8.7
> Uninstall Command for the Plugin Framework
>
[
https://issues.apache.org/jira/browse/SOLR-14604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ishan Chattopadhyaya updated SOLR-14604:
Priority: Major (was: Minor)
> Uninstall Command for the Plugin Framework
>
[
https://issues.apache.org/jira/browse/SOLR-14604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ishan Chattopadhyaya updated SOLR-14604:
Affects Version/s: (was: master (9.0))
> Uninstall Command for the Plugin
[
https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170703#comment-17170703
]
Ishan Chattopadhyaya commented on SOLR-13973:
-
Thanks for your insights, Andrew.
bq. having
atris commented on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-668466869
@anshumg Thank you so much for the review. I have updated per your comments
-- please see and let me know your thoughts and comments.
MarcusSorealheis edited a comment on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-668463295
@tflobbe I like the suggestion. Can we save it for the subsequent PR? Will
be. Much easier to read a review in that case. I'll set up a standalone 8_x
[
https://issues.apache.org/jira/browse/SOLR-14604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170681#comment-17170681
]
ASF subversion and git services commented on SOLR-14604:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14604?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ishan Chattopadhyaya resolved SOLR-14604.
-
Resolution: Fixed
> Uninstall Command for the Plugin Framework
>
anshumg commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r464895760
##
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
noblepaul commented on pull request #1715:
URL: https://github.com/apache/lucene-solr/pull/1715#issuecomment-668475345
@gus-asf is it possible to have some more information on the PR title?
This is an automated message from
[
https://issues.apache.org/jira/browse/SOLR-13973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170668#comment-17170668
]
Andrew edited comment on SOLR-13973 at 8/4/20, 9:22 AM:
We are using Solr as a
atris edited a comment on pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#issuecomment-668121187
@madrob I spent some time thinking and decided that we should not be
blocking rejected requests but instead returning them immediately with 429 (Too
Many Requests)
[
https://issues.apache.org/jira/browse/SOLR-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170707#comment-17170707
]
Ishan Chattopadhyaya commented on SOLR-14704:
-
Can we just have the command as:
{code}
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171215#comment-17171215
]
Ankur edited comment on LUCENE-9444 at 8/5/20, 1:40 AM:
Thanks for your response
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171215#comment-17171215
]
Ankur edited comment on LUCENE-9444 at 8/5/20, 1:38 AM:
Thanks for your response
[
https://issues.apache.org/jira/browse/SOLR-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171206#comment-17171206
]
Ishan Chattopadhyaya edited comment on SOLR-14704 at 8/5/20, 1:13 AM:
[
https://issues.apache.org/jira/browse/SOLR-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171206#comment-17171206
]
Ishan Chattopadhyaya commented on SOLR-14704:
-
I think I miss the motivation for this issue.
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171215#comment-17171215
]
Ankur commented on LUCENE-9444:
---
Thanks for your response [~mikemccand]
Yes, having _dim_ as additional
[
https://issues.apache.org/jira/browse/SOLR-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171212#comment-17171212
]
Gus Heck commented on SOLR-14704:
-
This is being added because the current script presently only unpacks
[
https://issues.apache.org/jira/browse/SOLR-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171205#comment-17171205
]
Gus Heck edited comment on SOLR-14704 at 8/5/20, 1:10 AM:
--
I had gone for simply
[
https://issues.apache.org/jira/browse/SOLR-14704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171205#comment-17171205
]
Gus Heck commented on SOLR-14704:
-
I had gone for simply downloading from a specified url, for
tflobbe commented on pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711#issuecomment-668911650
Added a test for legacy configuration. Also, made it so that sometimes we
use legacy params in the requests. Pleas take a look
[
https://issues.apache.org/jira/browse/LUCENE-9444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171215#comment-17171215
]
Ankur edited comment on LUCENE-9444 at 8/5/20, 1:41 AM:
Thanks for your response
tflobbe commented on pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711#issuecomment-668889913
@MarcusSorealheis, please see
https://github.com/MarcusSorealheis/lucene-solr/pull/5 (PR against your
branch). Some minor changes, including an attempt to read legacy conf
[
https://issues.apache.org/jira/browse/SOLR-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171256#comment-17171256
]
Gus Heck commented on SOLR-14706:
-
I tested the PR and I found
A) Collection creation no longer fails
gus-asf commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r465461582
##
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##
@@ -34,17 +34,24 @@ Detailed steps for upgrading a Solr cluster are in the
section
gus-asf commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r465461582
##
File path: solr/solr-ref-guide/src/solr-upgrade-notes.adoc
##
@@ -34,17 +34,24 @@ Detailed steps for upgrading a Solr cluster are in the
section
[
https://issues.apache.org/jira/browse/SOLR-14557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171265#comment-17171265
]
David Smiley commented on SOLR-14557:
-
Wouldn't something like this work?:
{noformat}
q= {!join
[
https://issues.apache.org/jira/browse/LUCENE-9446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand updated LUCENE-9446:
-
Fix Version/s: 8.7
> Boolean rewrite could remove more MatchAllDocsQuery filters
>
jpountz commented on pull request #1709:
URL: https://github.com/apache/lucene-solr/pull/1709#issuecomment-668657783
FYI I backported to 8.7 and moved the CHANGES entry from 9.0 to 8.7.
This is an automated message from the
[
https://issues.apache.org/jira/browse/SOLR-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman reassigned SOLR-14706:
-
Assignee: Houston Putman
> Upgrading 8.6.0 to 8.6.1 causes collection creation to fail
atris commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465219397
##
File path: solr/core/src/java/org/apache/solr/servlet/RateLimitManager.java
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache Software Foundation
anshumg commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465245982
##
File path: solr/core/src/java/org/apache/solr/servlet/RequestRateLimiter.java
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/SOLR-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170871#comment-17170871
]
Houston Putman commented on SOLR-14706:
---
Ok, reverting the reverts to the Clause.java file seem to
madrob commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465122951
##
File path: solr/solr-ref-guide/src/rate-limiters.adoc
##
@@ -0,0 +1,116 @@
+= Request Rate Limiters
+// Licensed to the Apache Software Foundation
tflobbe commented on pull request #1711:
URL: https://github.com/apache/lucene-solr/pull/1711#issuecomment-668726808
Thanks Marcus, I'll try to take a look tonight
This is an automated message from the Apache Git Service.
To
anshumg commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465246594
##
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/SOLR-14706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Houston Putman updated SOLR-14706:
--
Affects Version/s: 8.7
> Upgrading 8.6.0 to 8.6.1 causes collection creation to fail
>
[
https://issues.apache.org/jira/browse/SOLR-14708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17171037#comment-17171037
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14708:
--
Yes, testing this will be
HoustonPutman commented on a change in pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716#discussion_r465146599
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/cloud/autoscaling/Clause.java
##
@@ -686,7 +686,7 @@ boolean isShardAbsent() {
HoustonPutman opened a new pull request #1716:
URL: https://github.com/apache/lucene-solr/pull/1716
https://issues.apache.org/jira/browse/SOLR-14706
This is to introduce backwards compatibility for the default autoscaling
policy that was removed in 8.6.1 (and 8.7).
The
madrob commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465207154
##
File path: solr/core/src/java/org/apache/solr/servlet/SolrDispatchFilter.java
##
@@ -377,6 +386,19 @@ public void doFilter(ServletRequest _request,
[
https://issues.apache.org/jira/browse/LUCENE-9446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170869#comment-17170869
]
ASF subversion and git services commented on LUCENE-9446:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170867#comment-17170867
]
ASF subversion and git services commented on LUCENE-9446:
-
Commit
Atri Sharma created SOLR-14709:
--
Summary: Priority Based Model for Slot Borrowing in Request Rate
Limiting
Key: SOLR-14709
URL: https://issues.apache.org/jira/browse/SOLR-14709
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-14702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17169479#comment-17169479
]
Marcus Eagan edited comment on SOLR-14702 at 8/4/20, 5:40 PM:
--
Atri Sharma created SOLR-14710:
--
Summary: Finer Grained Rate Limiting
Key: SOLR-14710
URL: https://issues.apache.org/jira/browse/SOLR-14710
Project: Solr
Issue Type: Improvement
Security
madrob commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465147161
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java
##
@@ -358,7 +358,11 @@ protected HttpRequestBase
madrob commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465175702
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java
##
@@ -624,6 +641,12 @@ private
atris commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465222811
##
File path: solr/core/src/java/org/apache/solr/servlet/RateLimitManager.java
##
@@ -0,0 +1,148 @@
+/*
+ * Licensed to the Apache Software Foundation
atris commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465239352
##
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
atris commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465239114
##
File path:
solr/core/src/test/org/apache/solr/servlet/TestRequestRateLimiter.java
##
@@ -0,0 +1,185 @@
+/*
+ * Licensed to the Apache Software
madrob commented on a change in pull request #1686:
URL: https://github.com/apache/lucene-solr/pull/1686#discussion_r465175333
##
File path:
solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpSolrClient.java
##
@@ -98,6 +99,8 @@
private static final Charset
jpountz merged pull request #1709:
URL: https://github.com/apache/lucene-solr/pull/1709
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/LUCENE-9446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170863#comment-17170863
]
ASF subversion and git services commented on LUCENE-9446:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani resolved LUCENE-9446.
--
Resolution: Fixed
> Boolean rewrite could remove more MatchAllDocsQuery filters
>
ErickErickson commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-668558126
Marcus:
Also, that _particular_ test started failing a lot more recently, see:
https://issues.apache.org/jira/browse/SOLR-14684
So I wouldn’t worry about
ErickErickson commented on pull request #1712:
URL: https://github.com/apache/lucene-solr/pull/1712#issuecomment-668557229
About non-reproducible test failures. See:
http://fucit.org/solr-jenkins-reports/failure-report.html
Hoss rolls up the last 7 day’s failures from various
[
https://issues.apache.org/jira/browse/SOLR-13413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17170796#comment-17170796
]
Cassandra Targett commented on SOLR-13413:
--
Removed 8.1.2 version since there was never an 8.1.2
[
https://issues.apache.org/jira/browse/SOLR-13413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Cassandra Targett updated SOLR-13413:
-
Fix Version/s: (was: 8.1.2)
> jetty IdleTimeout bugs with Http2SolrClient, cause
gus-asf commented on pull request #1715:
URL: https://github.com/apache/lucene-solr/pull/1715#issuecomment-668606267
Yeah, good point commit message that it came from could have been better
too.
Basic idea here is to allow this script to curl a tarball from a URL rather
than
1 - 100 of 103 matches
Mail list logo