CaoManhDat commented on pull request #2112:
URL: https://github.com/apache/lucene-solr/pull/2112#issuecomment-736940948
LGTM! That is a nice idea to move thing here.
This is an automated message from the Apache Git Service.
[
https://issues.apache.org/jira/browse/SOLR-14934?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-14934:
--
Attachment: SOLR-14934.poc.patch
Assignee: Chris M. Hostetter
Status:
zhaih commented on a change in pull request #2095:
URL: https://github.com/apache/lucene-solr/pull/2095#discussion_r533822276
##
File path: lucene/CHANGES.txt
##
@@ -84,6 +84,8 @@ API Changes
Improvements
+* LUCENE-9618: Do not call IntervalIterator.nextInterval after
[
https://issues.apache.org/jira/browse/SOLR-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242070#comment-17242070
]
ASF subversion and git services commented on SOLR-14942:
Commit
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242094#comment-17242094
]
Pavithra Dhakshinamurthy edited comment on SOLR-4735 at 12/2/20, 6:56 AM:
Julie Tibshirani created LUCENE-9628:
Summary: Make sure to account for ScoreMode.TOP_DOCS in queries
Key: LUCENE-9628
URL: https://issues.apache.org/jira/browse/LUCENE-9628
Project: Lucene - Core
[
https://issues.apache.org/jira/browse/LUCENE-9628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Julie Tibshirani updated LUCENE-9628:
-
Description:
I noticed a few places where we are directly check the {{ScoreMode}} type
shalinmangar merged pull request #2112:
URL: https://github.com/apache/lucene-solr/pull/2112
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
[
https://issues.apache.org/jira/browse/SOLR-4735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242094#comment-17242094
]
Pavithra Dhakshinamurthy commented on SOLR-4735:
Hi Team,
We have around 200 collections
[
https://issues.apache.org/jira/browse/SOLR-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242032#comment-17242032
]
ASF subversion and git services commented on SOLR-14942:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241948#comment-17241948
]
Chris M. Hostetter commented on SOLR-14981:
---
I'm confused by this issue -- i understand that
[
https://issues.apache.org/jira/browse/SOLR-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar resolved SOLR-14942.
--
Resolution: Fixed
Thanks, David for the feedback and to you and Dat for the
HoustonPutman opened a new pull request #34:
URL: https://github.com/apache/lucene-site/pull/34
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
HoustonPutman merged pull request #34:
URL: https://github.com/apache/lucene-site/pull/34
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241852#comment-17241852
]
ASF subversion and git services commented on SOLR-14197:
Commit
dsmiley merged pull request #2107:
URL: https://github.com/apache/lucene-solr/pull/2107
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-15017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241851#comment-17241851
]
ASF subversion and git services commented on SOLR-15017:
Commit
mikemccand commented on pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-736781955
> I am not sure we can guarantee anything on an OOM?
Yeah I suppose that is essentially nearly hopeless, sigh -- this is why
`IndexWriter` aborts on OOME.
>
s1monw commented on pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-736804034
> I think this method serves an important purpose/use-case: it lets you
efficiently clear the whole index, transactionally, so that e.g. searchers can
see the old index, and
[
https://issues.apache.org/jira/browse/SOLR-15017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241855#comment-17241855
]
ASF subversion and git services commented on SOLR-15017:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241856#comment-17241856
]
ASF subversion and git services commented on SOLR-14197:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-15017.
-
Fix Version/s: 8.8
Resolution: Fixed
Thanks again!
> The core's lib/ folder content is
[
https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ilan Ginzburg resolved SOLR-14613.
--
Resolution: Fixed
> Provide a clean API for pluggable replica assignment implementations
>
murblanc merged pull request #2110:
URL: https://github.com/apache/lucene-solr/pull/2110
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/SOLR-15004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241811#comment-17241811
]
ASF subversion and git services commented on SOLR-15004:
Commit
[
https://issues.apache.org/jira/browse/SOLR-14992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241735#comment-17241735
]
Erick Erickson commented on SOLR-14992:
---
Figured it was something like that, I'll see what I can do
[
https://issues.apache.org/jira/browse/SOLR-14839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241589#comment-17241589
]
Mark Robert Miller commented on SOLR-14839:
---
This may get pushed back - there is some impl
[
https://issues.apache.org/jira/browse/SOLR-14842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Robert Miller reassigned SOLR-14842:
-
Assignee: Mark Robert Miller
> Address Tolerant search feature and tests.
>
[
https://issues.apache.org/jira/browse/SOLR-14842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Robert Miller resolved SOLR-14842.
---
Resolution: Fixed
This is complete.
> Address Tolerant search feature and tests.
>
[
https://issues.apache.org/jira/browse/SOLR-14815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241593#comment-17241593
]
Mark Robert Miller commented on SOLR-14815:
---
Very close here. I'm leaving ignores for some more
[
https://issues.apache.org/jira/browse/SOLR-14992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241640#comment-17241640
]
Erick Erickson commented on SOLR-14992:
---
A couple of things:
1> the failure talks about numshards,
[
https://issues.apache.org/jira/browse/SOLR-14992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241715#comment-17241715
]
Tomas Eduardo Fernandez Lobbe commented on SOLR-14992:
--
bq. the failure talks about
[
https://issues.apache.org/jira/browse/SOLR-14251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241889#comment-17241889
]
Gézapeti commented on SOLR-14251:
-
We've ran into this issue as well. Unfortunately where this check
[
https://issues.apache.org/jira/browse/SOLR-14992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241896#comment-17241896
]
Mike Drob commented on SOLR-14992:
--
I'm taking a look at this as well, but I can't get ant to run the
[
https://issues.apache.org/jira/browse/SOLR-15013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241390#comment-17241390
]
ASF subversion and git services commented on SOLR-15013:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241387#comment-17241387
]
ASF subversion and git services commented on SOLR-15013:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer updated SOLR-15013:
---
Issue Type: Test (was: Bug)
> Reproducing test failure TestFieldCacheSort 8x
>
[
https://issues.apache.org/jira/browse/LUCENE-9619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241416#comment-17241416
]
Ignacio Vera commented on LUCENE-9619:
--
Not sure if this API allows to be wrapped as a
tmortagne commented on pull request #2107:
URL: https://github.com/apache/lucene-solr/pull/2107#issuecomment-736366636
Unit test added following TestConfig#testLib() but with a different config.
This is an automated message
[
https://issues.apache.org/jira/browse/SOLR-15013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer resolved SOLR-15013.
Assignee: Simon Willnauer
Resolution: Fixed
I pushed a fix...
> Reproducing test
dweiss commented on pull request #2094:
URL: https://github.com/apache/lucene-solr/pull/2094#issuecomment-737053701
Hey. Just wanted to say I backtrack from the idea of having
byte-order-conscious stream delegates. I still think it's a good idea and it'd
provide a more efficient
[
https://issues.apache.org/jira/browse/SOLR-14981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17242123#comment-17242123
]
Dawid Weiss commented on SOLR-14981:
Hi Chris. The old version (Solr plugin) has deficiencies which I
cammiemw commented on pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-736443177
An alternative to touching so many low-level lucene classes would be to
create a separate interface with only the smoothingScore method. Then the only
Lucene class that I
cammiemw edited a comment on pull request #2097:
URL: https://github.com/apache/lucene-solr/pull/2097#issuecomment-736443177
Thanks for your comments and quick response time @mikemccand! I think I
have addressed and replied to each one.
An alternative to touching so many
shalinmangar opened a new pull request #2112:
URL: https://github.com/apache/lucene-solr/pull/2112
This addresses review feedback [1] from David Smiley on Jira. It moves the
request registration to the ContentStreamHandlerBase class instead of doing a
hack-ish instanceof check inside
[
https://issues.apache.org/jira/browse/SOLR-14942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shalin Shekhar Mangar reopened SOLR-14942:
--
Reopening to address review feedback from David.
Thanks, David for the feedback.
sigram commented on a change in pull request #2110:
URL: https://github.com/apache/lucene-solr/pull/2110#discussion_r533365701
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##
@@ -0,0 +1,577 @@
+/*
+ * Licensed to the
dsmiley commented on pull request #2107:
URL: https://github.com/apache/lucene-solr/pull/2107#issuecomment-736561913
Excellent. Please add to solr/CHANGES.txt in the 8.8 bug fix section at the
end, the following:
```
* SOLR-15017: Core lib directories were not being recognized
timatbw opened a new pull request #2111:
URL: https://github.com/apache/lucene-solr/pull/2111
…t field access.
# Description
Enable custom aggregate functions by opening up FacetContext field access.
# Solution
Prior to this change, it was not
s1monw commented on pull request #2088:
URL: https://github.com/apache/lucene-solr/pull/2088#issuecomment-736559445
> Well, that is spooky -- this looks like a pre-existing bug in
IndexWriter's abort! But I don't think we must fix that before committing this
fix? Can you open a new issue
murblanc opened a new pull request #2110:
URL: https://github.com/apache/lucene-solr/pull/2110
Co-authored-by: Andrzej Bialecki
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/SOLR-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241456#comment-17241456
]
Tim Owen commented on SOLR-8673:
Hi, yes sure (I prefer GH PRs to patch files).. see
muse-dev[bot] commented on a change in pull request #2110:
URL: https://github.com/apache/lucene-solr/pull/2110#discussion_r533361109
##
File path:
solr/core/src/java/org/apache/solr/cluster/placement/plugins/AffinityPlacementFactory.java
##
@@ -0,0 +1,577 @@
+/*
+ * Licensed
[
https://issues.apache.org/jira/browse/SOLR-14825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Robert Miller resolved SOLR-14825.
---
Resolution: Fixed
This is essentially complete - likely still some improvements that
[
https://issues.apache.org/jira/browse/SOLR-14825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Robert Miller reassigned SOLR-14825:
-
Assignee: Mark Robert Miller
> Wrap up async issues and tests.
>
[
https://issues.apache.org/jira/browse/SOLR-14613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17241685#comment-17241685
]
Andrzej Bialecki commented on SOLR-14613:
-
[~noble.paul] tests are added in SOLR-15004. [~ilan] I
tmortagne commented on pull request #2107:
URL: https://github.com/apache/lucene-solr/pull/2107#issuecomment-736598539
Fix the conflict with solr/CHANGES.txt.
This is an automated message from the Apache Git Service.
To
[
https://issues.apache.org/jira/browse/SOLR-14839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Robert Miller updated SOLR-14839:
--
Priority: Minor (was: Major)
> Address Alias impl.
> ---
>
>
58 matches
Mail list logo
