iverase opened a new pull request #123:
URL: https://github.com/apache/lucene/pull/123
Left over from #107, we should read / write checksums using big endian in
the NRT replicator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/LUCENE-9047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338222#comment-17338222
]
ASF subversion and git services commented on LUCENE-9047:
-
Commit
iverase merged pull request #123:
URL: https://github.com/apache/lucene/pull/123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
[
https://issues.apache.org/jira/browse/LUCENE-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338500#comment-17338500
]
Michael McCandless commented on LUCENE-9945:
+1, this would enable more advanced use-cases.
[
https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338436#comment-17338436
]
ASF subversion and git services commented on LUCENE-9188:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338443#comment-17338443
]
Robert Muir commented on LUCENE-9948:
-
Thanks [~gsmiller] for taking care of this!
> Automatically
uschindler edited a comment on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831406221
> Are our Jenkins builds publishing the Jacoco reports somewhere accessible?
Sure: https://ci-builds.apache.org/job/Lucene/job/Lucene-Coverage-main/
I
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831406221
> Are our Jenkins builds publishing the Jacoco reports somewhere accessible?
Sure: https://ci-builds.apache.org/job/Lucene/job/Lucene-Coverage-main/
I described
rmuir commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831425688
There is a relevant jacoco issue: https://github.com/jacoco/jacoco/issues/324
It points to another issue (filtering feature), where you can see filtering
asserts looks like an
rmuir commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831442536
Thanks @uschindler . @mikemccand we could add a simple link to
https://ci-builds.apache.org/job/Lucene/job/Lucene-Coverage-main/jacoco/ to
luceneutil html, with Uwe's changes, it
[
https://issues.apache.org/jira/browse/LUCENE-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338589#comment-17338589
]
Greg Miller commented on LUCENE-9945:
-
Thanks [~mikemccand] for the feedback! This should be simple
dweiss commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r625331360
##
File path: gradle/validation/jar-checks.gradle
##
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums,
[
https://issues.apache.org/jira/browse/LUCENE-9334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338591#comment-17338591
]
Dawid Weiss commented on LUCENE-9334:
-
TestPerFieldConsistency has been failing on and off recently
[
https://issues.apache.org/jira/browse/LUCENE-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338586#comment-17338586
]
Greg Miller commented on LUCENE-9944:
-
Thanks for the feedback [~mikemccand]. I'll work up a proper
gautamworah96 commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r625325022
##
File path: gradle/validation/jar-checks.gradle
##
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums,
[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jack Conradson updated LUCENE-9843:
---
Attachment: LUCENE-9843.patch
> Remove compression option on doc values
>
[
https://issues.apache.org/jira/browse/LUCENE-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Greg Miller updated LUCENE-9945:
Description:
The {{DrillSideways}} logic currently encapsulates, 1) the creation of multiple
[
https://issues.apache.org/jira/browse/LUCENE-9843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338626#comment-17338626
]
Jack Conradson commented on LUCENE-9843:
I have attached a patch ([^LUCENE-9843.patch]) that
mikemccand commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831394750
Awesome, thank you @uschindler!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831408328
Jenkins "documentation":
rmuir commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831430500
> This looks awesome!
>
> Are our Jenkins builds publishing the Jacoco reports somewhere accessible?
>
> > Maybe I can work with @mikemccand to add reports to
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831436885
> but I don't know how far it looks back (seems like only a few builds?)
Maybe it just needs tweaking. If it doesn't serve our purposes, I think there
is also a Rest API to
[
https://issues.apache.org/jira/browse/LUCENE-9944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338503#comment-17338503
]
Michael McCandless commented on LUCENE-9944:
+1 to decouple concurrent versus not-concurrent
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831439203
On ASF Jenkins I made the "Coverage" build to only run "daily". For testing
purposes it was "hourly".
--
This is an automated message from the Apache Git Service.
To respond
rmuir commented on pull request #122:
URL: https://github.com/apache/lucene/pull/122#issuecomment-831319155
one TODO i want to try for fun, is to look at output from `gradlew -p
lucene/facet coverage` and see if all the e.g. optimized cases here are really
tested
[
https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-9948.
-
Fix Version/s: main (9.0)
Resolution: Fixed
> Automatically detect multi- vs.
[
https://issues.apache.org/jira/browse/LUCENE-9188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338429#comment-17338429
]
ASF subversion and git services commented on LUCENE-9188:
-
Commit
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831347167
I backported the fixes. But I can tell you: It was only a master problm, 8.x
was fine. I still backported Dawid's fixes.
--
This is an automated message from the Apache Git
mikemccand commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831398047
This looks awesome!
Are our Jenkins builds publishing the Jacoco reports somewhere accessible?
> Maybe I can work with @mikemccand to add reports to luceneutil, or
[
https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338524#comment-17338524
]
Greg Miller commented on LUCENE-9948:
-
Yep, thanks for the suggestion [~rcmuir]!
> Automatically
[
https://issues.apache.org/jira/browse/LUCENE-9946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338523#comment-17338523
]
Greg Miller commented on LUCENE-9946:
-
I took a look at the SSDV implementations this morning and
Greg Miller created LUCENE-9950:
---
Summary: Support both single- and multi-value string fields in
facet counting (non-taxonomy based approaches)
Key: LUCENE-9950
URL:
rmuir commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831439579
I also tried to dig and see if I could change the `Lucene: Passing` badge in
the github README.md to instead show the coverage percentage just as an easily
available tracker :) I
rmuir commented on pull request #122:
URL: https://github.com/apache/lucene/pull/122#issuecomment-831327039
Looks good: [
](url)
--
This is an
mikemccand commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831414606
Thanks @uschindler!
Do we disable assertions when running the Jacoco coverage? I see the
`assert` statements are yellow e.g. here:
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831428448
Another tip: Never click on methods! Just go to "class" level and then
scroll down (the problem is that the many method links make you automatically
click on them). Jacoco also
uschindler commented on pull request #119:
URL: https://github.com/apache/lucene/pull/119#issuecomment-831441152
> On ASF Jenkins I made the "Coverage" build to only run "daily". For
testing purposes it was "hourly".
I also changed to keep last 30 *days* of builds, instead of 5
rmuir merged pull request #122:
URL: https://github.com/apache/lucene/pull/122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
[
https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338420#comment-17338420
]
ASF subversion and git services commented on LUCENE-9948:
-
Commit
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831351741
the suppressAccessChecks permission got lost in master, so the NRT tests
were not able to crush the test server with SIGSEGV. It's now working in both
master and 8.x. I ran the
[
https://issues.apache.org/jira/browse/LUCENE-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338712#comment-17338712
]
ASF subversion and git services commented on LUCENE-4198:
-
Commit
[
https://issues.apache.org/jira/browse/LUCENE-9889?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rahul Goswami updated LUCENE-9889:
--
Description:
If one of the existing segment files is opened by another (say a 3rd party)
gautamworah96 closed pull request #108:
URL: https://github.com/apache/lucene/pull/108
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
gautamworah96 commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r625420416
##
File path: gradle/validation/jar-checks.gradle
##
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums,
gautamworah96 commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r625420416
##
File path: gradle/validation/jar-checks.gradle
##
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums,
mocobeta merged pull request #115:
URL: https://github.com/apache/lucene/pull/115
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
uschindler edited a comment on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831209602
Hi @iverase
the merge broke tests: We fixed over the weekend the NRT tests. They had a
bug in the security policy, so no NRT Test wasn't running at all. So you did
uschindler commented on pull request #107:
URL: https://github.com/apache/lucene/pull/107#issuecomment-831209886
Hi @iverase
the merge broke tests: We fixed over the weekend the NRT tests. They had a
bug in the security policy, so no NRT Test is running at all. So you did not
see the
uschindler edited a comment on pull request #107:
URL: https://github.com/apache/lucene/pull/107#issuecomment-831209886
Hi @iverase
the merge broke tests: We fixed over the weekend the NRT tests. They had a
bug in the security policy, so no NRT Test wasn't running at all. So you did
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831257258
It will be funny, when Solr picks the new snapshot builds!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mikemccand commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831263447
> The NRT tests were not running since now YEARS!
OH NO!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
iverase commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831237759
Thanks @uschindler, yikes that explain it all :)
This fix seems to work, I run the test with the nightly flag and it seems
happy:
```
./gradlew
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831256482
What did you change, or was the test failures on Jenkins only because of the
first merge on the directory API and this one fixed it?
This explains why you opened THIS
uschindler commented on pull request #123:
URL: https://github.com/apache/lucene/pull/123#issuecomment-831209602
Hi @iverase
the merge broke tests: We fixed over the weekend the NRT tests. They had a
bug in the security policy, so no NRT Test is running at all. So you did not
see the
uschindler commented on pull request #107:
URL: https://github.com/apache/lucene/pull/107#issuecomment-831262001
This is great - by the way!
I will make a new PR based on
https://github.com/apache/lucene-solr/pull/2176 to check how the little endian
by default improves the new
[
https://issues.apache.org/jira/browse/LUCENE-9948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17338376#comment-17338376
]
Greg Miller commented on LUCENE-9948:
-
Thanks [~rcmuir], much easier (and cleaner) change if not
56 matches
Mail list logo
