gautamworah96 commented on a change in pull request #108:
URL: https://github.com/apache/lucene/pull/108#discussion_r625420416
##########
File path: gradle/validation/jar-checks.gradle
##########
@@ -242,62 +206,14 @@ subprojects {
}
}
- licenses.dependsOn validateJarChecksums, validateJarLicenses
+ licenses.dependsOn validateJarLicenses
}
// Add top-project level tasks validating dangling files
// and regenerating dependency checksums.
configure(project(":lucene")) {
def validationTasks = subprojects.collectMany { it.tasks.matching { it.name
== "licenses" } }
- def jarInfoTasks = subprojects.collectMany { it.tasks.matching { it.name ==
"collectJarInfos" } }
-
- // Update dependency checksums.
- task updateLicenses() {
Review comment:
My understanding was that `check` was a superset of almost every other
configuration. In case, we wanted to add other detached configurations we could
[`disableDependencyVerification()`](https://docs.gradle.org/6.8.1/userguide/dependency_verification.html#sub:disabling-specific-verification)
for them.
However, this seems like too much work for something so simple :)
I'll close this PR and wait silently until gradle adds an option for
verifying just some select configurations. Or maybe work on adding it :p
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
