Re: [I] Test failure in TestHnswFloatVectorGraph [lucene]

2023-12-15 Thread via GitHub
msokolov commented on issue #12945: URL: https://github.com/apache/lucene/issues/12945#issuecomment-1858117628 I spent a while staring at the previous refactor commit, and: (1) I am convinced the refactor you did is way cleaner.(2) it was a lot to do in a refactor and it is hard to

Re: [I] Test failure in TestHnswFloatVectorGraph [lucene]

2023-12-15 Thread via GitHub
msokolov commented on issue #12945: URL: https://github.com/apache/lucene/issues/12945#issuecomment-1858052541 one weird thing I noticed is the failing test seed only fails when `-Ptests.directory=MMapDirectory` is present -- This is an automated message from the Apache Git Service. To

Re: [I] Test failure in TestHnswFloatVectorGraph [lucene]

2023-12-14 Thread via GitHub
benwtrent commented on issue #12945: URL: https://github.com/apache/lucene/issues/12945#issuecomment-1856557362 Bumping the searched vectors to 70 from 60 makes the test pass, but this still bugs be a bit as that commit shouldn't have changed any behavior... -- This is an automated

Re: [I] Test failure in TestHnswFloatVectorGraph [lucene]

2023-12-14 Thread via GitHub
benwtrent commented on issue #12945: URL: https://github.com/apache/lucene/issues/12945#issuecomment-1856480501 This is interesting, that commit shouldn't have changed anything, just a refactor. I have confirmed I can repeat it (after several attempts), but cannot when going to the

Re: [I] Test failure in TestHnswFloatVectorGraph [lucene]

2023-12-14 Thread via GitHub
msokolov commented on issue #12945: URL: https://github.com/apache/lucene/issues/12945#issuecomment-1856057317 Here, `git bisect` identifies [18bb826564bb16fde70bab3c06a167280b6cc632] Extract the hnsw graph merging from being part of the vector writer (#12657) as the commit where this test