[GitHub] hboutemy commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena?

2017-11-07 Thread GitBox
hboutemy commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena? URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342725018 Hi Josh, Thank you for your help: I'm very interested to merge. But I don't understand what this

[GitHub] hboutemy commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena?

2017-11-07 Thread GitBox
hboutemy commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena? URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342725018 Hi Josh, Thank you for your help: I'm very interested to merge. But I don't understand what this

[GitHub] hboutemy commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena?

2017-11-07 Thread GitBox
hboutemy commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena? URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342725018 Hi Josh, Thank you for your help: I'm very interested to merge. But I don't understand what this

[GitHub] joshelser commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena?

2017-11-07 Thread GitBox
joshelser commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena? URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342601761 Old (unsubmitted) PR was apache/maven-skins#4 for those interested in the lineage.

[GitHub] joshelser commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena?

2017-11-08 Thread GitBox
joshelser commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena? URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342918748 > To test, I understand that any rendering of the skin with a nav bar in a little screen should be used: we

[GitHub] joshelser commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena?

2017-11-08 Thread GitBox
joshelser commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena? URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342886972 Thanks, Herv?! > But I don't understand what this change does: can you describe a little bit the

[GitHub] hboutemy commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena?

2017-11-08 Thread GitBox
hboutemy commented on issue #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena? URL: https://github.com/apache/maven-fluido-skin/pull/1#issuecomment-342916660 thanks fo the explanation: now I know what a hamburger menu is :) To test, I understand that any rendering

[GitHub] joshelser opened a new pull request #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena?

2017-11-07 Thread GitBox
joshelser opened a new pull request #1: MSKINS-137 Make the hamburger menu work with the top-navigation ena? URL: https://github.com/apache/maven-fluido-skin/pull/1 ?bled and sidebar-navigation disabled Original work done in

[GitHub] chonton commented on issue #1: fix DeployAtEnd failures

2017-12-10 Thread GitBox
chonton commented on issue #1: fix DeployAtEnd failures URL: https://github.com/apache/maven-deploy-plugin/pull/1#issuecomment-350582953 Same PR as https://github.com/apache/maven-plugins/pull/138. This is an automated

[GitHub] chonton opened a new pull request #1: fix DeployAtEnd failures

2017-12-10 Thread GitBox
chonton opened a new pull request #1: fix DeployAtEnd failures URL: https://github.com/apache/maven-deploy-plugin/pull/1 MDEPLOY-226: DeployAtEnd fails when module has extension MDEPLOY-225: DeployAtEnd fails when overriding skip MDEPLOY-224: Overriding deployAtEnd fails

[GitHub] olamy closed pull request #9: upgrade to ASM 6.1.1

2018-05-04 Thread GitBox
olamy closed pull request #9: upgrade to ASM 6.1.1 URL: https://github.com/apache/maven-plugin-tools/pull/9 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-04 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386728323 @Tibor17 Can you please integrate the last two commits as well? The build was successful on my machine and before I

[GitHub] khmarbaise commented on issue #9: upgrade to ASM 6.1.1

2018-05-04 Thread GitBox
khmarbaise commented on issue #9: upgrade to ASM 6.1.1 URL: https://github.com/apache/maven-plugin-tools/pull/9#issuecomment-386714132 Hi, could you please squash your commits and make a commit message like: ``` [MPLUGIN-335] - Support JDK 10 for plugin generation o More

[GitHub] michael-o commented on a change in pull request #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows

2018-05-04 Thread GitBox
michael-o commented on a change in pull request #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows URL: https://github.com/apache/maven-scm/pull/30#discussion_r186231262 ## File path:

[GitHub] michael-o commented on issue #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows

2018-05-04 Thread GitBox
michael-o commented on issue #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows URL: https://github.com/apache/maven-scm/pull/30#issuecomment-386751463 The line in question produces: Results : Failed tests:

[GitHub] aldaris commented on issue #9: upgrade to ASM 6.1.1

2018-05-04 Thread GitBox
aldaris commented on issue #9: upgrade to ASM 6.1.1 URL: https://github.com/apache/maven-plugin-tools/pull/9#issuecomment-386712591 Here you go: https://issues.apache.org/jira/browse/MPLUGIN-335 This is an automated message

[GitHub] don-vip commented on issue #9: upgrade to ASM 6.1.1

2018-05-04 Thread GitBox
don-vip commented on issue #9: upgrade to ASM 6.1.1 URL: https://github.com/apache/maven-plugin-tools/pull/9#issuecomment-386717150 Done. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] asfgit closed pull request #67: [SCM-869] fix gitexe list() implemented incorrectly

2018-05-04 Thread GitBox
asfgit closed pull request #67: [SCM-869] fix gitexe list() implemented incorrectly URL: https://github.com/apache/maven-scm/pull/67 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186258276 ## File path:

[GitHub] aldaris opened a new pull request #13: [MPLUGIN-335] - Fix build and tests

2018-05-05 Thread GitBox
aldaris opened a new pull request #13: [MPLUGIN-335] - Fix build and tests URL: https://github.com/apache/maven-plugin-tools/pull/13 The previous PR ignored JDK<9 builds and caused test failures on JDK9+. This PR should address these.

[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186258276 ## File path:

[GitHub] sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186260085 ## File path:

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386793374 Make it three commits.  This is an automated

[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186258477 ## File path:

[GitHub] sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186260157 ## File path:

[GitHub] sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186260157 ## File path:

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386799705 I think, we may get rid of integration test class `JUnit5IT` as it refers to the soon deprecated

[GitHub] olamy closed pull request #13: [MPLUGIN-335] - Fix build and tests

2018-05-05 Thread GitBox
olamy closed pull request #13: [MPLUGIN-335] - Fix build and tests URL: https://github.com/apache/maven-plugin-tools/pull/13 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] zregvart opened a new pull request #5: Don't resolve any dependencies

2018-05-07 Thread GitBox
zregvart opened a new pull request #5: Don't resolve any dependencies URL: https://github.com/apache/maven-checkstyle-plugin/pull/5 Not sure why resolving dependencies is needed for running Checkstyle, it does slow down the build considerably. For Apache Camel this makes a ten fold

[GitHub] michael-o commented on issue #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows

2018-05-07 Thread GitBox
michael-o commented on issue #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows URL: https://github.com/apache/maven-scm/pull/30#issuecomment-387057165 @murinrad This is the last open issue for the next release. I'd like to have a comment on the

[GitHub] timdvail commented on issue #43: Fix for Windows by changing literal newlines to backslash followed by n.

2018-05-13 Thread GitBox
timdvail commented on issue #43: Fix for Windows by changing literal newlines to backslash followed by n. URL: https://github.com/apache/maven-scm/pull/43#issuecomment-388701208 Finally got to setting up a JIRA issue. SCM-888 has been created referencing this. Thanks a bunch!

[GitHub] joekienzle commented on issue #112: Adding support for externally passed random seed and printing used seed on console

2018-05-14 Thread GitBox
joekienzle commented on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-388826070 We would like this feature as well. Please update this pr

[GitHub] McFoggy opened a new pull request #72: [SCM-885] second implementation with new API

2018-05-14 Thread GitBox
McFoggy opened a new pull request #72: [SCM-885] second implementation with new API URL: https://github.com/apache/maven-scm/pull/72 this PR is a fix for SCM-885 which keeps the git exe implementation backard compatible but thus introduces a new command parameter: START_FROM_ROOT

[GitHub] Tibor17 commented on issue #112: Adding support for externally passed random seed and printing used seed on console

2018-05-14 Thread GitBox
Tibor17 commented on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-388873766 @joekienzle I need to read all this through after 2 years. @cardil Can you meanwhile

[GitHub] aharui commented on issue #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows

2018-05-14 Thread GitBox
aharui commented on issue #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows URL: https://github.com/apache/maven-scm/pull/30#issuecomment-388942413 Is there an ETA for the release? Are there pre-release builds available we can try?

[GitHub] McLuck closed pull request #41: SCM-714 fix git commit when command line got too long

2018-05-14 Thread GitBox
McLuck closed pull request #41: SCM-714 fix git commit when command line got too long URL: https://github.com/apache/maven-scm/pull/41 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] pono closed pull request #117: [MNG-5756] Java home output in mvn -v is misleading

2018-05-07 Thread GitBox
pono closed pull request #117: [MNG-5756] Java home output in mvn -v is misleading URL: https://github.com/apache/maven/pull/117 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] rfscholte commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml

2018-05-07 Thread GitBox
rfscholte commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-387209745 Looks interesting. It also looks more efficient. I would like to avoid `effectiveSettings` here, because effective

[GitHub] asfgit closed pull request #115: Change out JAVA_HOME. Add JRE used. JRE used print /jre and JAVA_HOME…

2018-05-07 Thread GitBox
asfgit closed pull request #115: Change out JAVA_HOME. Add JRE used. JRE used print /jre and JAVA_HOME… URL: https://github.com/apache/maven/pull/115 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jkatada commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml

2018-05-07 Thread GitBox
jkatada commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-387263748 @rfscholte I changed the variable name. Please check.

[GitHub] murinrad opened a new pull request #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows

2018-05-08 Thread GitBox
murinrad opened a new pull request #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows URL: https://github.com/apache/maven-scm/pull/30 This is a fix for SCM-714 This fix changes the behaviour of git add on Windows machines. The git add is

[GitHub] murinrad commented on issue #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows

2018-05-08 Thread GitBox
murinrad commented on issue #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows URL: https://github.com/apache/maven-scm/pull/30#issuecomment-387337756 @michael-o seems I accidentaly closed this PR while commiting the fixes. Indeed the git add

[GitHub] murinrad closed pull request #71: SCM-714: mvn release:prepare fails if the command line is too long on…

2018-05-08 Thread GitBox
murinrad closed pull request #71: SCM-714: mvn release:prepare fails if the command line is too long on… URL: https://github.com/apache/maven-scm/pull/71 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] murinrad closed pull request #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows

2018-05-08 Thread GitBox
murinrad closed pull request #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows URL: https://github.com/apache/maven-scm/pull/30 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] murinrad opened a new pull request #71: SCM-714: mvn release:prepare fails if the command line is too long on…

2018-05-08 Thread GitBox
murinrad opened a new pull request #71: SCM-714: mvn release:prepare fails if the command line is too long on… URL: https://github.com/apache/maven-scm/pull/71 … windows Submitted by: Radovan Murin A workaround for the Windows terminal command limit This fix changes

[GitHub] Tibor17 commented on issue #183: junit5

2018-04-28 Thread GitBox
Tibor17 commented on issue #183: junit5 URL: https://github.com/apache/maven-surefire/pull/183#issuecomment-385167895 @sormuras I want to talk with you in private, pls send me an e-mail, thx. BR, Tibor This is an

[GitHub] asfgit closed pull request #112: Fix snapshot regular expression

2018-05-10 Thread GitBox
asfgit closed pull request #112: Fix snapshot regular expression URL: https://github.com/apache/maven/pull/112 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] Tibor17 commented on issue #164: SUREFIRE-1383: Split IT569 in to multiple lifecycles

2018-05-09 Thread GitBox
Tibor17 commented on issue #164: SUREFIRE-1383: Split IT569 in to multiple lifecycles URL: https://github.com/apache/maven-surefire/pull/164#issuecomment-387940764 @owenfarrell This feature was merged and will be released in version 2.22.0. You can close the PR.

[GitHub] Tibor17 commented on issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverage Classpath Elements

2018-05-09 Thread GitBox
Tibor17 commented on issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverage Classpath Elements URL: https://github.com/apache/maven-surefire/pull/157#issuecomment-387940702 @owenfarrell This feature was merged and will be released in version 2.22.0. You can close the PR.

[GitHub] Tibor17 commented on issue #173: [SUREFIRE-1004] Support full gavtc format for dependenciesToScan

2018-05-09 Thread GitBox
Tibor17 commented on issue #173: [SUREFIRE-1004] Support full gavtc format for dependenciesToScan URL: https://github.com/apache/maven-surefire/pull/173#issuecomment-387941555 @bindul The issue `SUREFIRE-1383` was pushed to master. Please rebase your fork on master and update the

[GitHub] michael-o commented on issue #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows

2018-05-10 Thread GitBox
michael-o commented on issue #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows URL: https://github.com/apache/maven-scm/pull/30#issuecomment-388150355 Looks better now. I asking myself what the pupose of the removed else block was. Commiiting

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-10 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388186209 Rebased onto https://github.com/apache/maven-surefire/commits/master and merged gitbox-1330 changes

[GitHub] Tibor17 commented on issue #173: [SUREFIRE-1004] Support full gavtc format for dependenciesToScan

2018-05-12 Thread GitBox
Tibor17 commented on issue #173: [SUREFIRE-1004] Support full gavtc format for dependenciesToScan URL: https://github.com/apache/maven-surefire/pull/173#issuecomment-388550148 @bindul We want to make release in May. Would you have spare time to continue on this PR?

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-11 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388527807 No, didn't do it yet. Just wanted get the changes I made on gitbox-1330 to show up here as "Polishing".

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-12 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388533551 See the log again. There must be a reason. Last days the compiler failed on linux and it was not our problem:

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-12 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388533450 Restarting the build didn't help... This is an

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-12 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388533788 I saw this error too and it happened because I triggered the branch 1338 and master in parallel:

[GitHub] sormuras commented on a change in pull request #4: Introduce white-box testing modules

2018-05-12 Thread GitBox
sormuras commented on a change in pull request #4: Introduce white-box testing modules URL: https://github.com/apache/maven-compiler-plugin/pull/4#discussion_r187774685 ## File path: src/it/jpms_compile-test-modules/src/test/java/foo/FooTests.java ## @@ -0,0 +1,37 @@ +/*

[GitHub] sormuras commented on a change in pull request #4: Introduce white-box testing modules

2018-05-12 Thread GitBox
sormuras commented on a change in pull request #4: Introduce white-box testing modules URL: https://github.com/apache/maven-compiler-plugin/pull/4#discussion_r187774737 ## File path: src/it/jpms_compile-test-modules/verify.groovy ## @@ -0,0 +1,30 @@ +/* + * Licensed to

[GitHub] sormuras commented on a change in pull request #4: Introduce white-box testing modules

2018-05-12 Thread GitBox
sormuras commented on a change in pull request #4: Introduce white-box testing modules URL: https://github.com/apache/maven-compiler-plugin/pull/4#discussion_r187774737 ## File path: src/it/jpms_compile-test-modules/verify.groovy ## @@ -0,0 +1,30 @@ +/* + * Licensed to

[GitHub] michael-o commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option.

2018-05-12 Thread GitBox
michael-o commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option. URL: https://github.com/apache/maven/pull/164#discussion_r187785443 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java

[GitHub] michael-o commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option.

2018-05-13 Thread GitBox
michael-o commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option. URL: https://github.com/apache/maven/pull/164#discussion_r187798863 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-11 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388527807 No, didn't do it yet. Just wanted get the changes I made on bitbox-1330 to show up here as "Polishing". Will reset

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-11 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388529278 What happend on the [`linux-jdk7-maven3.5.x`](https://builds.apache.org/job/maven-box/job/maven-surefire/job/1330/)

[GitHub] splatch commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option.

2018-05-13 Thread GitBox
splatch commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option. URL: https://github.com/apache/maven/pull/164#discussion_r18787 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java

[GitHub] michael-o commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option.

2018-05-13 Thread GitBox
michael-o commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option. URL: https://github.com/apache/maven/pull/164#discussion_r187800865 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java

[GitHub] splatch commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option.

2018-05-13 Thread GitBox
splatch commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option. URL: https://github.com/apache/maven/pull/164#discussion_r187792949 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java

[GitHub] slachiewicz commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option.

2018-05-13 Thread GitBox
slachiewicz commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option. URL: https://github.com/apache/maven/pull/164#discussion_r187793176 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java

[GitHub] minfrin opened a new pull request #5: Switch from XhtmlSink to Xhtml5Sink as the default site renderer.

2018-05-13 Thread GitBox
minfrin opened a new pull request #5: Switch from XhtmlSink to Xhtml5Sink as the default site renderer. URL: https://github.com/apache/maven-doxia-sitetools/pull/5 This is an automated message from the Apache Git Service.

[GitHub] sormuras commented on issue #4: [MCOMPILER-341] Compile module descriptors with TestCompilerMojo

2018-05-13 Thread GitBox
sormuras commented on issue #4: [MCOMPILER-341] Compile module descriptors with TestCompilerMojo URL: https://github.com/apache/maven-compiler-plugin/pull/4#issuecomment-388637929 2 black-box and 1 white-box integration tests implemented:

[GitHub] splatch commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option.

2018-05-13 Thread GitBox
splatch commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option. URL: https://github.com/apache/maven/pull/164#discussion_r187815567 ## File path: maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java

[GitHub] michael-o commented on issue #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows

2018-05-11 Thread GitBox
michael-o commented on issue #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows URL: https://github.com/apache/maven-scm/pull/30#issuecomment-388293992 Thanks for the PR, everything is fine now and merged. I plan to release soon.

[GitHub] murinrad commented on issue #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows

2018-05-11 Thread GitBox
murinrad commented on issue #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows URL: https://github.com/apache/maven-scm/pull/30#issuecomment-388293296 @michael-o Correct, however with the way I coded the fix previously that method was always

[GitHub] splatch opened a new pull request #165: [MNG-6028] Include current goals in resume suggestion

2018-05-11 Thread GitBox
splatch opened a new pull request #165: [MNG-6028] Include current goals in resume suggestion URL: https://github.com/apache/maven/pull/165 This PR is small improvement which allows to simply pick up returned sugestion and restart the build. JIRA issue:

[GitHub] splatch opened a new pull request #166: [MNG-6410] Clean suggestion on build resume.

2018-05-11 Thread GitBox
splatch opened a new pull request #166: [MNG-6410] Clean suggestion on build resume. URL: https://github.com/apache/maven/pull/166 Make sure that resume suggestion contains a valid value for restarting the build, as same artifact name might occur in different places of multi-module

[GitHub] splatch opened a new pull request #164: [MNG-6411] Improve readability of project list for resume option.

2018-05-11 Thread GitBox
splatch opened a new pull request #164: [MNG-6411] Improve readability of project list for resume option. URL: https://github.com/apache/maven/pull/164 This pull request aims to improve usability of error message returned when invalid value for resume from option is passed:

[GitHub] asfgit closed pull request #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows

2018-05-10 Thread GitBox
asfgit closed pull request #30: Fix for SCM-714: mvn release:prepare fails if the command line is too long on windows URL: https://github.com/apache/maven-scm/pull/30 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the

[GitHub] michael-o commented on issue #41: SCM-714 fix git commit when command line got too long

2018-05-10 Thread GitBox
michael-o commented on issue #41: SCM-714 fix git commit when command line got too long URL: https://github.com/apache/maven-scm/pull/41#issuecomment-388227835 @McLuck Please close this has been merged. This is an automated

[GitHub] michael-o commented on issue #49: SCM-797: Workaround for Windows command line length limitation

2018-05-10 Thread GitBox
michael-o commented on issue #49: SCM-797: Workaround for Windows command line length limitation URL: https://github.com/apache/maven-scm/pull/49#issuecomment-388227873 @atomicknight Please close this has been merged. This

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-11 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388503837 @sormuras The CI https://builds.apache.org/job/maven-box/job/maven-surefire/job/1330/ does not see the branch

[GitHub] dconneely closed pull request #140: Add org.slf4j.event to exported packages

2018-05-08 Thread GitBox
dconneely closed pull request #140: Add org.slf4j.event to exported packages URL: https://github.com/apache/maven/pull/140 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] dconneely commented on issue #140: Add org.slf4j.event to exported packages

2018-05-08 Thread GitBox
dconneely commented on issue #140: Add org.slf4j.event to exported packages URL: https://github.com/apache/maven/pull/140#issuecomment-387385557 @michael-o Yep - same fix  This is an automated message from the Apache Git

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-08 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387447111 I have reported a bug for PowerMock due to JDK 11 https://github.com/powermock/powermock/issues/904 Another

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-08 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387449015 I may look into the JDK 11 issues later... but as it is still early-access state, we and other tools have some

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-08 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387450662 It seems we have to avoid one more machine, windows-2016-1, see https://issues.apache.org/jira/browse/INFRA-16491

[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186267506 ## File path:

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386828650 JDK 10 seems okay now. JDK 7 still chokes on "--target 1.8" options...

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386828650 JDK 10 seems okay now. JDK 7 still chokes on "--target 1.8" options...

[GitHub] michael-o commented on issue #140: Add org.slf4j.event to exported packages

2018-05-05 Thread GitBox
michael-o commented on issue #140: Add org.slf4j.event to exported packages URL: https://github.com/apache/maven/pull/140#issuecomment-386833306 @dconneely Please see MNG-6360. This seems to be overcome already. Can you confirm?

[GitHub] michael-o commented on a change in pull request #160: Fix links to Apache/CDDL/MIT licenses

2018-05-05 Thread GitBox
michael-o commented on a change in pull request #160: Fix links to Apache/CDDL/MIT licenses URL: https://github.com/apache/maven/pull/160#discussion_r186272200 ## File path: apache-maven/src/main/appended-resources/META-INF/LICENSE.vm ## @@ -21,19 +21,23 @@ Apache Maven

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386825239 > ... You have to squash all commits ... Losing history and reasoning is okay?

[GitHub] michael-o commented on issue #126: Update code style quikstart-arhetype

2018-05-05 Thread GitBox
michael-o commented on issue #126: Update code style quikstart-arhetype URL: https://github.com/apache/maven/pull/126#issuecomment-386833015 Please close. This is an automated message from the Apache Git Service. To respond

[GitHub] michael-o commented on issue #157: [MNG-6360] adding org.slf4j.event in exported packages

2018-05-05 Thread GitBox
michael-o commented on issue #157: [MNG-6360] adding org.slf4j.event in exported packages URL: https://github.com/apache/maven/pull/157#issuecomment-386833261 @rmannibucau As discussed on JIRA, this can be closed. Do you agree?

[GitHub] asfgit closed pull request #132: Fix the Javadoc to use a proper @link tag when pointing to ProjectBuilder

2018-05-05 Thread GitBox
asfgit closed pull request #132: Fix the Javadoc to use a proper @link tag when pointing to ProjectBuilder URL: https://github.com/apache/maven/pull/132 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] rmannibucau commented on issue #157: [MNG-6360] adding org.slf4j.event in exported packages

2018-05-05 Thread GitBox
rmannibucau commented on issue #157: [MNG-6360] adding org.slf4j.event in exported packages URL: https://github.com/apache/maven/pull/157#issuecomment-386835055 No more blocking This is an automated message from the Apache

[GitHub] rmannibucau closed pull request #157: [MNG-6360] adding org.slf4j.event in exported packages

2018-05-05 Thread GitBox
rmannibucau closed pull request #157: [MNG-6360] adding org.slf4j.event in exported packages URL: https://github.com/apache/maven/pull/157 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-08 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387402535 @sormuras Regarding the `plexus-java:0.9.8` I pushed the commit to the branch `1518` and additionally second

[GitHub] dconneely commented on issue #140: Add org.slf4j.event to exported packages

2018-05-08 Thread GitBox
dconneely commented on issue #140: Add org.slf4j.event to exported packages URL: https://github.com/apache/maven/pull/140#issuecomment-387385557 @michael-o Yep - same fix is in #157  This is an automated message from the

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-08 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387406286 @sormuras I added `JDK 11 b8 (early access build)` to test on the branch `1518`. So we should way especially for

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-08 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387460149 https://issues.apache.org/jira/browse/INFRA-16500

  1   2   3   4   5   6   7   8   9   10   >