[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-12 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388533788 I saw this error too and it happened because I triggered the branch 1338 and master in parallel:

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-12 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388533551 See the log again. There must be a reason. Last days the compiler failed on linux and it was not our problem:

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-11 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388503837 @sormuras The CI https://builds.apache.org/job/maven-box/job/maven-surefire/job/1330/ does not see the branch

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-08 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387460149 https://issues.apache.org/jira/browse/INFRA-16500

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-08 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387450662 It seems we have to avoid one more machine, windows-2016-1, see https://issues.apache.org/jira/browse/INFRA-16491

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-08 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387447111 I have reported a bug for PowerMock due to JDK 11 https://github.com/powermock/powermock/issues/904 Another

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-08 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387406286 @sormuras I added `JDK 11 b8 (early access build)` to test on the branch `1518`. So we should way especially for

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-08 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387402535 @sormuras Regarding the `plexus-java:0.9.8` I pushed the commit to the branch `1518` and additionally second

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-06 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386861453 @sormuras Try to use your PC. The build takes few minutes with only your ITs. It is just only about adding

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-06 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386861279 It may happen that version of `junit-platform-launcher` would be too low after years? Therefore I asked about

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-06 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386860668 I think it will work even without is( greaterThanOrEqualTo( "1.8" ) ). I have initially designed the Jenkinsfile

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841297 Now I see, you used the build process JDK `${java.home}/bin/java` Very well!

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841327 That's exactly why we have two JDKs. This is an

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841297 Noe I see, you used the build process JDK `${java.home}/bin/java` Very well!

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841131 @sormuras How did you skip tests on `surefire-junit-platform` with JDK 1.7?

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386840975 @sormuras Did you also have a problem with JaCoCO:0.7.9 on JDK10? Do we need to have `scope=compile` on the

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386822137 I will have a look to the sniffer plugin in the evening and I will try to run the build.

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-05 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386821219 @sormuras Did you override the branch `1330`? Because I squashed last cca 5 commits to one. You have to squash

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-03 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386425187 @sormuras The branch contains all your changes now.

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

2018-05-03 Thread GitBox
Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386396527 @sormuras I should perhaps squash all 4 commits in the branch