[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388533788
 
 
   I saw this error too and it happened because I triggered the branch 1338
   and master in parallel:
   
   java.io.IOException: Failed to mkdirs:
   
/home/jenkins/jenkins-slave/workspace/ven-box_maven-surefire_1330-TSMLOBV5ENRMCK6YV52ANAULUWOG4OYEMBRTFOGSINEWTK45IYLQ
at hudson.FilePath.mkdirs(FilePath.java:1170)
at 
org.jenkinsci.plugins.workflow.steps.CoreStep$Execution.run(CoreStep.java:79)
   
   
   
   On Sat, May 12, 2018 at 6:34 AM, Christian Stein 
   wrote:
   
   > What happend on the linux-jdk7-maven3.5.x
   > 
   > build?
   >
   > [linux-jdk7-maven3.5.x] Tests run: 58, Failures: 0, Errors: 0, Skipped: 0, 
Time elapsed: 2.858 sec
   > [linux-jdk7-maven3.5.x]
   > [linux-jdk7-maven3.5.x] Results :
   > [linux-jdk7-maven3.5.x]
   > [linux-jdk7-maven3.5.x] Tests run: 58, Failures: 0, Errors: 0, Skipped: 0
   > [linux-jdk7-maven3.5.x]
   > [linux-jdk7-maven3.5.x] [INFO]
   > [linux-jdk7-maven3.5.x] [INFO] --- maven-jar-plugin:3.0.0:jar 
(default-jar) @ surefire-booter ---
   > [linux-jdk7-maven3.5.x] [INFO] Building jar: 
/home/jenkins/jenkins-slave/workspace/ven-box_maven-surefire_1330-TSMLOBV5ENRMCK6YV52ANAULUWOG4OYEMBRTFOGSINEWTK45IYLQ/surefire-booter/target/surefire-booter-3.0.0-SNAPSHOT.jar
   > [linux-jdk7-maven3.5.x] [INFO]
   > [linux-jdk7-maven3.5.x] [INFO] --- maven-site-plugin:3.4:attach-descriptor 
(attach-descriptor) @ surefire-booter ---
   > [linux-jdk7-maven3.5.x] [INFO]
   > [linux-jdk7-maven3.5.x] [INFO] --- maven-shade-plugin:3.1.0:shade 
(default) @ surefire-booter ---
   > [linux-jdk7-maven3.5.x] [INFO] Excluding 
org.apache.maven.surefire:surefire-api:jar:3.0.0-SNAPSHOT from the shaded jar.
   > [linux-jdk7-maven3.5.x] [INFO] Excluding 
org.apache.maven.surefire:surefire-logger-api:jar:3.0.0-SNAPSHOT from the 
shaded jar.
   > [linux-jdk7-maven3.5.x] [INFO] Including 
org.apache.commons:commons-lang3:jar:3.5 in the shaded jar.
   > [linux-jdk7-maven3.5.x] [INFO] Including commons-io:commons-io:jar:2.5 in 
the shaded jar.
   > [linux-jdk7-maven3.5.x] [INFO] Minimizing jar 
org.apache.maven.surefire:surefire-booter:jar:3.0.0-SNAPSHOT
   > [linux-jdk7-maven3.5.x] [INFO] 

   > [linux-jdk7-maven3.5.x] [INFO] Reactor Summary:
   > [linux-jdk7-maven3.5.x] [INFO]
   > [linux-jdk7-maven3.5.x] [INFO] Apache Maven Surefire 
.. SUCCESS [ 13.605 s]
   > [linux-jdk7-maven3.5.x] [INFO] SureFire Logger API 
 SUCCESS [  3.933 s]
   > [linux-jdk7-maven3.5.x] [INFO] SureFire API 
... SUCCESS [ 12.695 s]
   > [linux-jdk7-maven3.5.x] [INFO] ShadeFire JUnit3 Provider 
.. SUCCESS [  1.921 s]
   > [linux-jdk7-maven3.5.x] [INFO] SureFire Booter 
 FAILURE [ 10.408 s]
   > [linux-jdk7-maven3.5.x] [INFO] Maven Surefire Test-Grouping Support 
... SKIPPED
   > [...]
   >
   > windows-jdk7-maven3.5.x build was doing fine.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or mute the thread
   > 

   > .
   >
   
   
   
   -- 
   Cheers
   Tibor
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388533551
 
 
   See the log again. There must be a reason.
   Last days the compiler failed on linux and it was not our problem:
   TestsToRunTest.java:[113,4] error: error while writing TestsToRunTest.T1:
   could not create parent directories
   
   On Sat, May 12, 2018 at 8:16 AM, Christian Stein 
   wrote:
   
   > Restarting the build didn't help...
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or mute the thread
   > 

   > .
   >
   
   
   
   -- 
   Cheers
   Tibor
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-388503837
 
 
   @sormuras 
   The CI https://builds.apache.org/job/maven-box/job/maven-surefire/job/1330/ 
does not see the branch after you have rebased 1330 on master. Did you push it 
to a new branch? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387460149
 
 
   https://issues.apache.org/jira/browse/INFRA-16500


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387450662
 
 
   It seems we have to avoid one more machine, windows-2016-1, see
   https://issues.apache.org/jira/browse/INFRA-16491
   It is actually the most fast Windows machine ;-(


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387447111
 
 
   I have reported a bug for PowerMock due to JDK 11
   https://github.com/powermock/powermock/issues/904
   Another problem is on Windows:
   16:38:38 [windows-jdk11-maven3.5.x] The system cannot find the path 
specified.
   
https://builds.apache.org/job/maven-box/job/maven-surefire/job/1518/8/consoleFull
   So we have a real problem to test with JDK 11.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387406286
 
 
   @sormuras 
   I added `JDK 11 b8 (early access build)` to test on the branch `1518`. So we 
should way especially for the outcome from JDK 11.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-387402535
 
 
   @sormuras 
   Regarding the `plexus-java:0.9.8` I pushed the commit to the branch `1518` 
and additionally second commit in Jenkinsfile where I excluded machine 
`windows-2012-3`. See the Jenkins job status:
   https://builds.apache.org/job/maven-box/job/maven-surefire/job/1518
   We have 4 Windows machines altogether and excluded one which is not that bad 
but the build may take 3 hours to complete on master. The machine 
`windows-2012-3` must have some problems with long Windows path because of the 
Compilation failures - the compiler does not reach the files. I repored this 
issue already to our INFRA team.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386861453
 
 
   @sormuras 
   Try to use your PC. The build takes few minutes with only your ITs.
   It is just only about adding system property on commandline 
`-Djdk.home=/path/to/jdk1.7`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386861279
 
 
   It may happen that version of `junit-platform-launcher` would be too low 
after years?
   Therefore I asked about different scope.
   The `junit-platform-launcher` is dependent on `junit-platform-engine` which 
means for us that JUnit5 should guarantee backwards compatibility of platform 
engine for long time.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386860668
 
 
   I think it will work even without is( greaterThanOrEqualTo( "1.8" ) ).
   I have initially designed the Jenkinsfile with two JDK which is why we did
   not use the build that Maven core uses.
   Now we can utilize and run the unit tests on the top of JDK 1.8.
   The build process always runs with JDK 1.8. The unit and integration tests
   run with JDK 1.7 - 10 except for JUnit5 Provider and therefore the
   condition in setUp() should be always satisfied.
   
   On Sun, May 6, 2018 at 9:14 AM, Christian Stein 
   wrote:
   
   > Did you also have a problem with JaCoCO:0.7.9 on JDK10?
   >
   > According to https://github.com/jacoco/jacoco/releases 0.8.1 introduced
   > JDK 10 support. Thus, 0.7.9 had to fail.
   >
   > Do we need to have scope=compile on the dependency junit-platform-launcher
   > in our provider POM? What will happen if it would be scope provided?
   >
   > 99% yes, the provider needs it at compile time. That's what JUnit Platform
   > is all about. It's the API for tools (build tools, IDEs, ...) to get "JUnit
   > 5" *(technically, there's no JUnit 5)* running. See this import
   > statements in org.apache.maven.surefire.junitplatform.
   > JUnitPlatformProvider:
   >
   > import org.junit.platform.launcher.Launcher;import 
org.junit.platform.launcher.LauncherDiscoveryRequest;import 
org.junit.platform.launcher.TagFilter;import 
org.junit.platform.launcher.core.LauncherDiscoveryRequestBuilder;import 
org.junit.platform.launcher.core.LauncherFactory;
   >
   > And recall the "JUnit 5" architecture layout:
   >
   >
   > 

   >
   > Just move the *junit-platform-surefire-provider* from the bottom-left out
   > off the red *PLATFORM* box into the *IDEs/Build Tool* bubble at the
   > bottom. Here be dragons, Gradle, Surefire, IDEA, Eclipse, etc...
   >
   > 1% no, perhaps there's some Maven-trick to achieve the same with provided
   > scope?
   >
   > How did you skip tests on surefire-junit-platform with JDK 1.7?
   >
   > Mh, if it is because of ${java.home}/bin/java then @britter
   >  did it.
   > At test runtime, the assumption declared in JUnitPlatformIT ensures that
   > a JDK 1.8+ is at work:
   >
   > @Beforepublic void setUp()
   > {
   > assumeThat( "java.specification.version: ",
   > getProperty( "java.specification.version" ),
   > is( greaterThanOrEqualTo( "1.8" ) ) );
   > }
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > ,
   > or mute the thread
   > 

   > .
   >
   
   
   
   -- 
   Cheers
   Tibor
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841297
 
 
   Now I see, you used the build process JDK
   `${java.home}/bin/java`
   Very well!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841327
 
 
   That's exactly why we have two JDKs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841297
 
 
   Noe I see, you used the build process JDK
   `${java.home}/bin/java`
   Very well!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841131
 
 
   @sormuras 
   How did you skip tests on `surefire-junit-platform` with JDK 1.7?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386840975
 
 
   @sormuras 
   Did you also have a problem with JaCoCO:0.7.9 on JDK10?
   Do we need to have `scope=compile` on the dependency 
`junit-platform-launcher` in our provider POM? What 
will happen if it would be scope `provided`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386822137
 
 
   I will have a look to the sniffer plugin in the evening and I will try to 
run the build.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386821219
 
 
   @sormuras 
   Did you override the branch `1330`? Because I squashed last cca 5 commits to 
one.
   You have to squash all commits b83121..0633293 in one commit with this 
command
   `git rebase -i HEAD~11` amend the resulting commit message to
   `[SUREFIRE-1330] JUnit 5 surefire-provider code donation`
   and then force push itself branch
   `git push origin +1330:1330`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386425187
 
 
   @sormuras 
   The branch contains all your changes now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386396527
 
 
   @sormuras 
   I should perhaps squash all 4 commits in the branch 
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/1330
 and add the last commit `4d9173e `.
   Do you have permissions in ASF git?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services