[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116434#comment-16116434 ] Michael Musgrove commented on SUREFIRE-1265: Thanks [~tibor17] for the fix. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.20.1 > > Attachments: j9test.tar, Java9Example.zip > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116423#comment-16116423 ] Tibor Digana commented on SUREFIRE-1265: [~eolivelli] [~rfscholte] I have created SUREFIRE-1403. Made a fix and the test passed. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.20.1 > > Attachments: j9test.tar, Java9Example.zip > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15996082#comment-15996082
]
Tibor Digana commented on SUREFIRE-1265:
Thx [~rfscholte], all these can be done quite easily. Although we have several
pending branches to push, we can provide a new branch in version {{2.20.1}}.
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Fix For: 2.20.1
>
> Attachments: j9test.tar, Java9Example.zip
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995714#comment-15995714
]
Robert Scholte commented on SUREFIRE-1265:
--
http://download.java.net/java/jigsaw/docs/api/java/lang/ClassLoader.html#findClass-java.lang.String-java.lang.String-
So I think we should also use this method to find a class, i.e.
{{findClass("java.se.ee", name);}} with reflection
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Fix For: 2.20.1
>
> Attachments: j9test.tar, Java9Example.zip
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995703#comment-15995703 ] Tibor Digana commented on SUREFIRE-1265: [~rfscholte] If it has to be added by Surefire, then how? > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.20.1 > > Attachments: j9test.tar, Java9Example.zip > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995684#comment-15995684 ] Robert Scholte commented on SUREFIRE-1265: -- compiling works fine, if must be passed by surefire > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.20.1 > > Attachments: j9test.tar, Java9Example.zip > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995675#comment-15995675
]
Tibor Digana commented on SUREFIRE-1265:
[~rfscholte]
You mean in {{javac}} argument or {{MAVEN_OPTS}} ?
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Fix For: 2.20.1
>
> Attachments: j9test.tar, Java9Example.zip
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995614#comment-15995614
]
Robert Scholte commented on SUREFIRE-1265:
--
well, I was too fast. It is a very simple Test which doesn't use any specific
Java 9 features, 2.5.1 is good enough.
What needs to be done is activate the javax.se.ee module using {{--add-modules
java.se.ee}}. See also
[SO|http://stackoverflow.com/questions/43574426/how-to-resolve-java-lang-noclassdeffounderror-javax-xml-bind-jaxbexception-in-j]
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Fix For: 2.20.1
>
> Attachments: j9test.tar, Java9Example.zip
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995604#comment-15995604
]
Tibor Digana commented on SUREFIRE-1265:
[~eolivelli]
As Robert said, use {{maven-compiler-plugin:3.6.1}}. If it works you may want
to open a pull request in GitHub with an update of {{Surefire1265Java9IT}} and
the POM, and open a new jira issue as a task. In the IT we should use another
java.home for jdk9.
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Fix For: 2.20.1
>
> Attachments: j9test.tar, Java9Example.zip
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15995267#comment-15995267 ] Robert Scholte commented on SUREFIRE-1265: -- [~eolivelli] you must use at least maven-compiler-plugin 3.6.1 to make it work > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.20.1 > > Attachments: j9test.tar, Java9Example.zip > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994746#comment-15994746
]
Tibor Digana commented on SUREFIRE-1265:
[~eolivelli]
I will wait for [~rfscholte] or we will discuss it on mailing list.
Our problem is that a parent {{ClassLoader}}, which is {{PlatformClassLoader}},
of {{IsolatedClassLoader}} does not provide us with full Java stack in JDK.
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Fix For: 2.20.1
>
> Attachments: j9test.tar, Java9Example.zip
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994592#comment-15994592
]
Enrico Olivelli commented on SUREFIRE-1265:
---
I'm really sorry
Acutally I have to use with Java8 to compile se ruite
mvn clean install -Dit.test=Surefire1265Java9IT
Than in order to kick the it tests in I have to use this:
JAVA_HOME=~/dev/jdk-9 mvn verify -Dit.test=Surefire1265Java9IT
but compilation fails
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:testCompile
(default-testCompile) on project surefire-1265: Compilation failure:
Compilation failure:
[ERROR]
/home/diennea.lan/enrico.olivelli/dev/eolivelli/maven-surefire/surefire-integration-tests/target/Surefire1265Java9IT_shouldRunInPluginJava9/src/test/java/J9Test.java:[2,16]
error: package javax.xml.ws is not visible
[ERROR] (package javax.xml.ws is declared in module java.xml.ws, which is not
in the module graph)
[ERROR]
/home/diennea.lan/enrico.olivelli/dev/eolivelli/maven-surefire/surefire-integration-tests/target/Surefire1265Java9IT_shouldRunInPluginJava9/src/test/java/J9Test.java:[18,17]
error: package javax.xml.ws is not visible
[ERROR] (package javax.xml.ws is declared in module java.xml.ws, which is not
in the module graph)
[ERROR]
/home/diennea.lan/enrico.olivelli/dev/eolivelli/maven-surefire/surefire-integration-tests/target/Surefire1265Java9IT_shouldRunInPluginJava9/src/test/java/J9Test.java:[18,58]
error: package javax.xml.ws is not visible
[ERROR] -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:2.5.1:testCompile
(default-testCompile) on project surefire-1265: Compilation failure
{code}
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Fix For: 2.20.1
>
> Attachments: j9test.tar, Java9Example.zip
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994570#comment-15994570
]
Tibor Digana commented on SUREFIRE-1265:
[~eolivelli]
Surefire1265Java9IT can be easily written in command line like {{mvn test}}.
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Fix For: 2.20.1
>
> Attachments: j9test.tar, Java9Example.zip
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994555#comment-15994555
]
Tibor Digana commented on SUREFIRE-1265:
[~eolivelli]
You can use {{it.test}} property or replace {{*IT*}} with
{{Surefire1265Java9IT}} in {{surefire-integration-tests/pom.xml}}.
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Fix For: 2.20.1
>
> Attachments: j9test.tar, Java9Example.zip
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994545#comment-15994545
]
Tibor Digana commented on SUREFIRE-1265:
[~rfscholte]
Should be put {{module-info.class}} in to the jar file or artifact which uses
{{IsolatedClassLoader}}?
Unfortunately this would be {{surefire-booter}}.
The ideal situation would be to have it in plugin's jar only and export all
modules in {{module-info.java}}:
module surefire.xyz {
java.activation, java.xml.bind, java.xml.ws,jdk.xml.bind
}
Should it be imported, or optional?
The whole problem is that isloated CL is used in plugin and ClassLoader does
not have any API call to extend the PlatformClassLoader with all JDK modules.
These modules would be nice to have as optional, means if the classes (tests)
in CL need to load them on the fly.
What can we do about this?
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Fix For: 2.20.1
>
> Attachments: j9test.tar, Java9Example.zip
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994534#comment-15994534 ] Tibor Digana commented on SUREFIRE-1265: Try to copy it to another directory on your file system and run it as a regular project. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.20.1 > > Attachments: j9test.tar, Java9Example.zip > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994486#comment-15994486
]
Enrico Olivelli commented on SUREFIRE-1265:
---
Thank you [~tibor17]
Is the test case good for you in order to see the failure ?
Otherwise I will try to add a test case to surefire-1265
IMHO This will be enough
{code}
public class J9Test {
@Test
public void test_sql_mod() throws java.sql.SQLException {
System.out.println(System.getProperty("java.specification.version"));
}
@Test
public void test_corba_mod() /*throws org.omg.CORBA.BAD_INV_ORDER*/ {
}
@Test
public void test_javaws() {
javax.xml.ws.Holder holder = new javax.xml.ws.Holder("test");
holder.value = "test";
}
}
{code}
is there any way to launch a single test (Surefire1265Java9IT) of the IT of
surefire ? I am using -Dtest= but it does not work, the architecture is
quite complex, if you give me some pointer I will come at speed to the problem
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Fix For: 2.20.1
>
> Attachments: j9test.tar, Java9Example.zip
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994480#comment-15994480 ] Tibor Digana commented on SUREFIRE-1265: [~eolivelli] This is caused by cxf plugin. So this is not the way to go. We have to setup JDK in JAVA_HOME for the particular IT test with JDK 9 via toolchain and run the IT in fork mode mean not embedded mode. Nevertheless you must build the project with JDK 8 and run the example project with JDK 9. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.20.1 > > Attachments: j9test.tar, Java9Example.zip > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994440#comment-15994440 ] Enrico Olivelli commented on SUREFIRE-1265: --- Im trying to add the test case to surefire-1265 anyway > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.20.1 > > Attachments: j9test.tar, Java9Example.zip > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994439#comment-15994439
]
Enrico Olivelli commented on SUREFIRE-1265:
---
I have checked out your last commit
JAVA_HOME=~/jdk-9 mvn clean install -DskipTests
the build of failsafe plugin is still broken
{code}
[ERROR] /home/diennea.lan/enrico.olivelli/dev/eolivelli/maven-surefire/null
[-1:-1]: Failed to create model
com.sun.istack.SAXParseException2; Failed to create model
at com.sun.tools.xjc.ErrorReceiver.error(ErrorReceiver.java:94)
at
org.apache.cxf.maven_plugin.XSDToJavaRunner.loadModel(XSDToJavaRunner.java:233)
at
org.apache.cxf.maven_plugin.XSDToJavaRunner.run(XSDToJavaRunner.java:169)
at
org.apache.cxf.maven_plugin.AbstractXSDToJavaMojo.run(AbstractXSDToJavaMojo.java:336)
at
org.apache.cxf.maven_plugin.AbstractXSDToJavaMojo.execute(AbstractXSDToJavaMojo.java:238)
at
org.apache.cxf.maven_plugin.XSDToJavaMojo.execute(XSDToJavaMojo.java:41)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:563)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: java.lang.reflect.InvocationTargetException
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:563)
at
org.apache.cxf.maven_plugin.XSDToJavaRunner.loadModel(XSDToJavaRunner.java:229)
... 26 more
Caused by: java.lang.NoClassDefFoundError: javax/activation/DataSource
at
com.sun.xml.bind.v2.model.impl.RuntimeBuiltinLeafInfoImpl.(RuntimeBuiltinLeafInfoImpl.java:470)
at
com.sun.xml.bind.v2.model.impl.RuntimeTypeInfoSetImpl.(RuntimeTypeInfoSetImpl.java:63)
at
com.sun.xml.bind.v2.model.impl.RuntimeModelBuilder.createTypeInfoSet(RuntimeModelBuilder.java:128)
at
com.sun.xml.bind.v2.model.impl.RuntimeModelBuilder.createTypeInfoSet(RuntimeModelBuilder.java:84)
at
com.sun.xml.bind.v2.model.impl.ModelBuilder.(ModelBuilder.java:162)
at
com.sun.xml.bind.v2.model.impl.RuntimeModelBuilder.(RuntimeModelBuilder.java:92)
at
com.sun.xml.bind.v2.runtime.JAXBContextImpl.getTypeInfoSet(JAXBContextImpl.java:444)
at
com.sun.xml.bind.v2.runtime.JAXBContextImpl.(JAXBContextImpl.java:292)
at
com.sun.xml.bind.v2.runtime.JAXBContextImpl.(JAXBContextImpl.java:139)
at
com.sun.xml.bind.v2.runtime.JAXBContextImpl$JAXBContextBuilder.build(JAXBContextImpl.java:1138)
at
com.sun.xml.bind.v2.ContextFactory.createContext(ContextFactory.java:162)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994390#comment-15994390 ] Tibor Digana commented on SUREFIRE-1265: [~eolivelli] I committed a change yesterday. There should not be such limitation in enforcer anymore. Pls try again. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.20.1 > > Attachments: j9test.tar, Java9Example.zip > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993992#comment-15993992 ] Tibor Digana commented on SUREFIRE-1265: [~eolivelli] Would you post a project to reproduce this issue? > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.20.1 > > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15993099#comment-15993099
]
Enrico Olivelli commented on SUREFIRE-1265:
---
I am trying current trunk but I get this error
java version "9-ea"
Java(TM) SE Runtime Environment (build 9-ea+163)
Java HotSpot(TM) 64-Bit Server VM (build 9-ea+163, mixed mode)
Surefire config (set on parent's pom.xml) :
{code}
org.apache.maven.plugins
maven-surefire-plugin
2.21-SNAPSHOT
1
false
600
-Xmx2G -XX:+UseG1GC
-Djava.io.tmpdir=${project.build.directory}
true
{code}
Git commit id:
{code}
commit cba4adb1b93002c5b4bb2d2f22f461cc53bd8738
Author: Tibor17
Date: Thu Apr 20 21:07:55 2017 +0200
[SUREFIRE-1265] reuseForks=false fails on jdk-9-ea builds
{code}
error:
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.21-SNAPSHOT:test
(default-test) on project herddb-core: Execution default-test of goal
org.apache.maven.plugins:maven-surefire-plugin:2.21-SNAPSHOT:test failed:
java.lang.NoClassDefFoundError: javax/xml/ws/Holder: javax.xml.ws.Holder ->
[Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-surefire-plugin:2.21-SNAPSHOT:test
(default-test) on project herddb-core: Execution default-test of goal
org.apache.maven.plugins:maven-surefire-plugin:2.21-SNAPSHOT:test failed:
java.lang.NoClassDefFoundError: javax/xml/ws/Holder
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:563)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
default-test of goal
org.apache.maven.plugins:maven-surefire-plugin:2.21-SNAPSHOT:test failed:
java.lang.NoClassDefFoundError: javax/xml/ws/Holder
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:145)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
... 20 more
Caused by: org.apache.maven.surefire.util.SurefireReflectionException:
java.lang.NoClassDefFoundError: javax/xml/ws/Holder
at
org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray(ReflectionUtils.java:193)
at
org.apache.maven.surefire.util.ReflectionUtils.invokeGetter(ReflectionUtils.java:72)
at
org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.getSuites(ProviderFactory.java:144)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.getSuitesIterator(ForkStarter.java:711)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.runSuitesForkPerTestSet(ForkStarter.java:405)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:295)
at
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977693#comment-15977693 ] Hudson commented on SUREFIRE-1265: -- SUCCESS: Integrated in Jenkins build maven-surefire #1696 (See [https://builds.apache.org/job/maven-surefire/1696/]) [SUREFIRE-1265] reuseForks=false fails on jdk-9-ea builds (tibor17: [http://git-wip-us.apache.org/repos/asf/?p=maven-surefire.git=commit=cba4adb1b93002c5b4bb2d2f22f461cc53bd8738]) * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/Classpath.java * (add) surefire-integration-tests/src/test/resources/surefire-1265/src/test/java/J9Test.java * (add) surefire-integration-tests/src/test/resources/surefire-1265/pom.xml * (add) surefire-api/src/main/java/org/apache/maven/surefire/util/internal/SystemUtils.java * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/ClasspathConfiguration.java * (add) surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/jiras/Surefire1265Java9IT.java * (edit) surefire-api/src/test/java/org/apache/maven/JUnit4SuiteTest.java * (add) surefire-api/src/test/java/org/apache/maven/surefire/util/internal/SystemUtilsTest.java > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.20.1 > > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15976142#comment-15976142
]
Tibor Digana commented on SUREFIRE-1265:
[~mmusgrov]
[~jpoth]
[~rfscholte]
I fixed this bug by passing platform ClassLoader to IsolatedClassLoader.
I will provide a branch to code review on Maven Dev Mailing List and then push
it to master.
{code}
parent = (ClassLoader) ClassLoader.class.getMethod( "getPlatformClassLoader"
).invoke( null )
new IsolatedClassLoader( parent, childDelegation, roleName );
{code}
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Fix For: 2.20.1
>
> Attachments: j9test.tar
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973502#comment-15973502
]
Tibor Digana commented on SUREFIRE-1265:
[~mmusgrov]
[~jpoth]
Can you extract all jar files which should appear on classpath of tests and
check it again if they contain {{module-info.class}}?
{{module-info.class}} is produced by javac.
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Fix For: 2.20.1
>
> Attachments: j9test.tar
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924372#comment-15924372 ] John Poth commented on SUREFIRE-1265: - I just ran into the same problem with Caused by: java.lang.ClassNotFoundException: javax.sql.DataSource. Luckily setting reuseForks=true works :) let me know if you want a reproducer. This happened with Java 9 build 159. Cheers! > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: Backlog > > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621800#comment-15621800
]
Tibor Digana commented on SUREFIRE-1265:
[~mmusgrov]
[~zhfeng]
I absolutely do not understand these jdk9 switches {{--upgrade-module-path}},
{{--add-exports}}, {{--add-modules}}.
Although need to know from you guys correct concept in Surefire, what's going
on, why and what we can do about it.
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Attachments: j9test.tar
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15621768#comment-15621768 ] Michael Musgrove commented on SUREFIRE-1265: Thanks Amos. That is a workaround but it forces all maven modules to run with the same setting which is not ideal. Notice also that we do use this approach in our build.sh script: bq. MAVEN_OPTS="$MAVEN_OPTS --upgrade-module-path target/upgrademodulepath --add-modules java.corba --add-exports java.corba/com.sun.corba.se.spi.orb=ALL-UNNAMED --add-exports java.corba/com.sun.corba.se.spi.ior=ALL-UNNAMED --add-exports java.corba/com.sun.corba.se.impl.ior=ALL-UNNAMED" but we would prefer a proper fix. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15616103#comment-15616103 ] Zheng Feng commented on SUREFIRE-1265: -- Hi Mike, it can work by adding the MAVEN_OPT="-addmods java.corba" . I had tried bq. MAVEN_OPT="-addmods java.corba" mvn clean test -DreuseForks=false -DchildDelegation=true both tests pass > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433443#comment-15433443 ] Tibor Digana commented on SUREFIRE-1265: Just a moment, this is maybe a workaround but do you have rational explanation for this configuration? If this is a real bug then other user has problem. We can still talk about this issue however I am preparing a new release next few days. -- Cheers Tibor > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433194#comment-15433194
]
Michael Musgrove commented on SUREFIRE-1265:
I tried using version 2.19.1 of the surefire plugin together with the surefire
configuration property:
{quote}
true
{quote}
together with
{quote}
1
false
{quote}
and it works just fine. I think it is safe to close this JIRA as not a bug.
Thank [~tibor17] and [~rfscholte] for your attention and help on helping me get
to the bottom of this issue.
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Attachments: j9test.tar
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15431113#comment-15431113 ] Robert Scholte commented on SUREFIRE-1265: -- I think we should try to revert this. Michael said the issue is somewhere else. If that fixes his issue, then no need to keep this change. I would expect that the SystemClassloader is indeed we want. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430824#comment-15430824 ] Tibor Digana commented on SUREFIRE-1265: [~rfscholte] What do you think about this change. Shall we keep it in master? https://github.com/apache/maven-surefire/commit/c9b0914116cb49fb082ffa7d3af0ce0314f8fbc1 > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430553#comment-15430553
]
Tibor Digana commented on SUREFIRE-1265:
[~mmusgrov]
I have to remove the milestone 2.19.2 from this issue because of this
misunderstanding.
I think the surefire concept regarding {{getSuitesIterator()}} should change
but not now since we do not have much time.
I last time made big change which introduced communication between java
processes using commands and this has emitted issue {{SUREFIRE-1255}}. So I
don't want to go straight ahead with another big change in parallel. First of
all I want to fix {{SUREFIRE-1255}} and mark surefire as stable a then I would
change the concept of {{getSuitesIterator()}}. The problem is that this method
operates with classes and the reason we are doing so is that we are filtering
out classes which are not real JUnit test classes. IMHO this mechanism should
be part of {{SurefireProvider}} and the main process should only filter classes
on file-name level. And then we need to somehow differentiate between class
which is not really annotated as test and filtered tests using
{{org.junit.runner.manipulation.Filter}} because even if both result in zero
tests the behavior might be different.
To reach the goal we would need to have the commands and fully stable, which
means again no reason to continue with this issue unless commands are fully
working on Mac.
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Attachments: j9test.tar
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430433#comment-15430433 ] Michael Musgrove commented on SUREFIRE-1265: [~tibor17] "The issue is that org.apache.maven.plugin.surefire.booterclient.ForkStarter#getSuitesIterator() tries to load classes before forking the JVM that will run the tests" which means that any jdk-9 switches I set via are ignored. See my earlier comment from 1st Aug. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.19.2 > > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430378#comment-15430378 ] Hudson commented on SUREFIRE-1265: -- SUCCESS: Integrated in Jenkins build maven-surefire #1595 (See [https://builds.apache.org/job/maven-surefire/1595/]) SUREFIRE-1265] reuseForks=false fails on jdk-9-ea builds (tibor17: rev c9b0914116cb49fb082ffa7d3af0ce0314f8fbc1) * (edit) surefire-booter/src/main/java/org/apache/maven/surefire/booter/IsolatedClassLoader.java > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.19.2 > > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15430313#comment-15430313
]
Tibor Digana commented on SUREFIRE-1265:
commit c9b0914116cb49fb082ffa7d3af0ce0314f8fbc1
[~mmusgrov]
Please wait until Jenkins says {{SUCCESS: Integrated in Jenkins build
maven-surefire}} in next comment in Jira. This may take one hour.
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
>Assignee: Tibor Digana
> Labels: jigsaw
> Fix For: 2.19.2
>
> Attachments: j9test.tar
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426551#comment-15426551 ] Michael Musgrove commented on SUREFIRE-1265: Thanks [~tibor17]. Yes I will test it out as soon as you are ready. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.19.2 > > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426194#comment-15426194 ] Tibor Digana commented on SUREFIRE-1265: This seems to be related to SUREFIRE-1262. Assigned both to 2.19.2. [~mmusgrov] I will commit an update. Would you be able to check it out with 2.19.2-SNAPSHOT after I have finished, I let you know. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove >Assignee: Tibor Digana > Labels: jigsaw > Fix For: 2.19.2 > > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15426138#comment-15426138 ] Michael Musgrove commented on SUREFIRE-1265: This issue is a blocker for our projects JDK 9 work because many of our tests (and we have a lot of them) leave state hanging around so we really do need to fork a new JVM for each test class. Can you advise whether there is a workaround or when the team could investigate the problem? If there is a workaround or suggested fix then I don't mind making code changes in my own clone of surefire while we wait for an official fix. I did have a go at fixing it but it seem to necessitate making breaking API changes. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove > Labels: jigsaw > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402394#comment-15402394 ] Michael Musgrove commented on SUREFIRE-1265: The issue is that org.apache.maven.plugin.surefire.booterclient.ForkStarter#getSuitesIterator() tries to load classes *before* forking the JVM that will run the tests but I am using the surefire argLine property to tell the modular jdk which module the missing classes belong to (in my case java.corba). This happens in surefire-booter method org.apache.maven.surefire.booter.ProviderFactory#getSuites() and the provider it uses to find the testSuites is org.apache.maven.surefire.junit4.JUnit4Provider and IsolatedClassLoader#loadClass() throws an exception if it cannot load a requested class. > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove > Labels: jigsaw > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399178#comment-15399178
]
Robert Scholte commented on SUREFIRE-1265:
--
IIUC we need to do some reflection. If the
{{ClassLoader.getPlatformClassLoader()}} exists, use this as the classloader.
Otherwise fall back on the {{ClassLoader.getSystemClassLoader()}}, since we're
using a pre-Java9 version.
Something like:
{code}
private ClassLoader getParent()
{
ClassLoader parent;
Method mthd = ReflectionUtils.tryGetMethod( ClassLoader.class,
"getPlatformClassLoader" );
if ( mthd != null )
{
parent = (ClassLoader) mthd.invoke( null );
}
else
{
parent = ClassLoader.getSystemClassLoader();
}
return parent;
}
{code}
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
> Labels: jigsaw
> Attachments: j9test.tar
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[ https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399151#comment-15399151 ] Michael Musgrove commented on SUREFIRE-1265: The root cause is most likely because the IsolatedClassLoader is bypassing the jdk-9 platform class loader which is responsible for loading module code that is not in java.base (for example java.sql is module code). I did try various combinations of the useSystemClassLoader and useManifestOnlyJar surefire configuration properties without success. I also built the maven-surefire-plugin version 3.0-SNAPSHOT from source but the issue is still present. Do you have any further thoughts or advice on what I can try next? > reuseForks=false fails on jdk-9-ea builds > - > > Key: SUREFIRE-1265 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1265 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 2.19.1 >Reporter: Michael Musgrove > Labels: jigsaw > Attachments: j9test.tar > > > When I run any surefire test (with reuseForks=false) that uses java.sql > classes on recent jdk-9 ea builds it fails with: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on > project maven-surefire-plugin-example: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed: > java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException > -> [Help 1] > If I run it with reuseForks=true it works fine. > This problem was introduced in jdk build 9-ea+122 > (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw > team addressed: > d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (SUREFIRE-1265) reuseForks=false fails on jdk-9-ea builds
[
https://issues.apache.org/jira/browse/SUREFIRE-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15395962#comment-15395962
]
Robert Scholte commented on SUREFIRE-1265:
--
{noformat}
Caused by: java.lang.ClassNotFoundException: java.sql.SQLException
at
java.net.URLClassLoader.findClass(java.base@9-ea/URLClassLoader.java:384)
at java.lang.ClassLoader.loadClass(java.base@9-ea/ClassLoader.java:486)
at java.lang.ClassLoader.loadClass(java.base@9-ea/ClassLoader.java:419)
at
org.apache.maven.surefire.booter.IsolatedClassLoader.loadClass(IsolatedClassLoader.java:97)
... 49 more
{noformat}
A quick view suggest that you can't find this class anymore via {{
ClassLoader.getSystemClassLoader(); }}
> reuseForks=false fails on jdk-9-ea builds
> -
>
> Key: SUREFIRE-1265
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1265
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.19.1
>Reporter: Michael Musgrove
> Attachments: j9test.tar
>
>
> When I run any surefire test (with reuseForks=false) that uses java.sql
> classes on recent jdk-9 ea builds it fails with:
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on
> project maven-surefire-plugin-example: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test failed:
> java.lang.NoClassDefFoundError: java/sql/SQLException: java.sql.SQLException
> -> [Help 1]
> If I run it with reuseForks=true it works fine.
> This problem was introduced in jdk build 9-ea+122
> (http://download.java.net/java/jdk9/changes/jdk-9+122.html) when the jigsaw
> team addressed:
> d20279be77d9 8154189 Deprivilege java.sql and java.sql.rowset module
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
