Jon Zeolla created METRON-1744:
--
Summary: CEF testPaloAltoCEF test using a confusing variable name
Key: METRON-1744
URL: https://issues.apache.org/jira/browse/METRON-1744
Project: Metron
Issue
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212342518
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-packet-line/pcap-packet-line.component.spec.ts
---
@@ -143,38 +132,4 @@
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1171
Thanks @liuy-tnz!
Does anyone else have a panos firewall that they can test this against?
---
Jon Zeolla created METRON-1746:
--
Summary: CEF lacks an ES template
Key: METRON-1746
URL: https://issues.apache.org/jira/browse/METRON-1746
Project: Metron
Issue Type: Sub-task
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212341861
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts
---
@@ -179,19 +172,6 @@
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590339#comment-16590339
]
ASF GitHub Bot commented on METRON-1724:
Github user merrimanr commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Zeolla updated METRON-1742:
---
Priority: Minor (was: Major)
> Improve CEF log management throughout
>
[
https://issues.apache.org/jira/browse/METRON-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590393#comment-16590393
]
ASF GitHub Bot commented on METRON-1740:
Github user nickwallen commented on the issue:
Jon Zeolla created METRON-1743:
--
Summary: CEF test confusing URL
Key: METRON-1743
URL: https://issues.apache.org/jira/browse/METRON-1743
Project: Metron
Issue Type: Sub-task
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590341#comment-16590341
]
ASF GitHub Bot commented on METRON-1724:
Github user merrimanr commented on a diff in the pull
Jon Zeolla created METRON-1742:
--
Summary: Improve CEF log management throughout
Key: METRON-1742
URL: https://issues.apache.org/jira/browse/METRON-1742
Project: Metron
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/METRON-1745?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Zeolla updated METRON-1745:
---
Description:
Jon Zeolla created METRON-1745:
--
Summary: CEF runTest test isn't properly leveraging an explicit
json sample
Key: METRON-1745
URL: https://issues.apache.org/jira/browse/METRON-1745
Project: Metron
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590434#comment-16590434
]
ASF GitHub Bot commented on METRON-1724:
Github user tiborm commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590449#comment-16590449
]
Simon Elliston Ball commented on METRON-1746:
-
One thing to think about here is that it
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212383664
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts
---
@@ -179,19 +172,6 @@ describe('PcapFiltersComponent',
[
https://issues.apache.org/jira/browse/METRON-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Zeolla reassigned METRON-1743:
--
Assignee: Jon Zeolla
> CEF test confusing URL
> --
>
>
[
https://issues.apache.org/jira/browse/METRON-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Zeolla updated METRON-1743:
---
Description:
[
https://issues.apache.org/jira/browse/METRON-1746?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590479#comment-16590479
]
Otto Fowler commented on METRON-1746:
-
I think that is a good point [~simonellistonball], but would
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590564#comment-16590564
]
ASF GitHub Bot commented on METRON-1724:
Github user merrimanr commented on the issue:
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1172
I found one small bug. Here's how to reproduce:
1. Set the FROM date to be greater than the TO date. A validation message
should appear as expected.
2. Set the TO date to be in the
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1174
METRON-1748 Improve Storm Profiler Integration Test
Improved the Storm Profiler integration tests based on improvements I made
for the Spark Profiler feature branch.
* Validate the
[
https://issues.apache.org/jira/browse/METRON-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Nick Allen updated METRON-1748:
---
Description: We should use the Profiler Client, like PROFILE_GET, to
validate the output of the
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212369764
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-packet-line/pcap-packet-line.component.spec.ts
---
@@ -143,38 +132,4 @@
[
https://issues.apache.org/jira/browse/METRON-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590552#comment-16590552
]
ASF GitHub Bot commented on METRON-1743:
GitHub user JonZeolla opened a pull request:
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron/pull/1173
METRON-1743: CEF test confusing URL
## Contributor Comments
Trivial variable rename.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Nick Allen created METRON-1748:
--
Summary: Improve Storm Profiler Integration Test
Key: METRON-1748
URL: https://issues.apache.org/jira/browse/METRON-1748
Project: Metron
Issue Type: Bug
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1172
As a result of the followup discussion about the placing of the transform
functions, I moved them back to the filter component.
---
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590532#comment-16590532
]
ASF GitHub Bot commented on METRON-1724:
Github user tiborm commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Zeolla updated METRON-1743:
---
Summary: CEF testPaloAltoCEF test using a confusing variable name (was:
CEF test runTest doesn't
[
https://issues.apache.org/jira/browse/METRON-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Zeolla updated METRON-1743:
---
Summary: CEF test runTest doesn't consider targetJson (was: CEF test
confusing URL)
> CEF test
[
https://issues.apache.org/jira/browse/METRON-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Zeolla updated METRON-1744:
---
Description:
[
https://issues.apache.org/jira/browse/METRON-1744?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Zeolla updated METRON-1744:
---
Summary: CEF test runTest doesn't consider targetJson (was: CEF
testPaloAltoCEF test using a
[
https://issues.apache.org/jira/browse/METRON-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jon Zeolla updated METRON-1743:
---
Description: A confusing test URL
[
https://issues.apache.org/jira/browse/METRON-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590666#comment-16590666
]
ASF GitHub Bot commented on METRON-1748:
GitHub user nickwallen opened a pull request:
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590529#comment-16590529
]
ASF GitHub Bot commented on METRON-1724:
Github user tiborm commented on a diff in the pull
Jon Zeolla created METRON-1747:
--
Summary: CEF has no integration tests
Key: METRON-1747
URL: https://issues.apache.org/jira/browse/METRON-1747
Project: Metron
Issue Type: Sub-task
Github user liuy-tnz commented on the issue:
https://github.com/apache/metron/pull/1171
@JonZeolla Thank you first. Let me try to list the testing steps as I
haven't done it before.
Reproduce steps
1. setup the panos firewall (v6.1, v7.0 or v8.0)
2. setup Metron with
[
https://issues.apache.org/jira/browse/METRON-1740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591019#comment-16591019
]
ASF GitHub Bot commented on METRON-1740:
Github user liuy-tnz commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590840#comment-16590840
]
Simon Elliston Ball commented on METRON-1016:
-
I agree that this would be a great step.
[
https://issues.apache.org/jira/browse/METRON-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590850#comment-16590850
]
Otto Fowler commented on METRON-1016:
-
Well, this would govern the install of snort, bro and yaf
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1171
I can. Testing steps would help me get this done tomorrow otherwise I'm
not sure when I'll get a chance to.
---
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1150
I was able to understand everything by following
BatchProfilerIntegrationTest. Looks like a great start to me. +1
---
[
https://issues.apache.org/jira/browse/METRON-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590854#comment-16590854
]
ASF GitHub Bot commented on METRON-1748:
Github user nickwallen commented on the issue:
Github user nickwallen closed the pull request at:
https://github.com/apache/metron/pull/1150
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1150
Thanks for the review guys! I merged this one into the feature branch.
For those reviewers wanting further punishment, #1161 is the next PR to
review for this feature branch.
---
[
https://issues.apache.org/jira/browse/METRON-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590862#comment-16590862
]
ASF GitHub Bot commented on METRON-1707:
Github user nickwallen closed the pull request at:
[
https://issues.apache.org/jira/browse/METRON-1707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590861#comment-16590861
]
ASF GitHub Bot commented on METRON-1707:
Github user nickwallen commented on the issue:
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212196734
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589824#comment-16589824
]
ASF GitHub Bot commented on METRON-1724:
Github user ruffle1986 commented on a diff in the pull
Github user ruffle1986 commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212205588
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589819#comment-16589819
]
ASF GitHub Bot commented on METRON-1724:
Github user ruffle1986 commented on a diff in the pull
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589817#comment-16589817
]
ASF GitHub Bot commented on METRON-1724:
Github user ruffle1986 commented on a diff in the pull
Github user ruffle1986 commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212204263
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest {
-
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/
Thanks for the catches Ryan.
My objective around metron-rest was to try and leave it as little changed
as possible in this effort, since the ticket is more around the ui hosts,
[
https://issues.apache.org/jira/browse/METRON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589896#comment-16589896
]
ASF GitHub Bot commented on METRON-1665:
Github user simonellistonball commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589767#comment-16589767
]
ASF GitHub Bot commented on METRON-1724:
Github user tiborm commented on a diff in the pull
Github user ruffle1986 commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212205052
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest {
-
[
https://issues.apache.org/jira/browse/METRON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590093#comment-16590093
]
ASF GitHub Bot commented on METRON-1665:
Github user simonellistonball commented on a diff in
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/#discussion_r212270804
--- Diff: metron-interface/metron-rest-client/bin/pom.xml ---
@@ -0,0 +1,52 @@
+
--- End diff --
Yes. Will remove.
---
Github user JonZeolla commented on the issue:
https://github.com/apache/metron/pull/1014
I wonder if it's good enough just to keep `:=` and `=` around, but not have
that affect the format of `++`, `+=`, etc.
---
[
https://issues.apache.org/jira/browse/METRON-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590166#comment-16590166
]
ASF GitHub Bot commented on METRON-1563:
Github user JonZeolla commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590090#comment-16590090
]
ASF GitHub Bot commented on METRON-1665:
Github user simonellistonball commented on a diff in
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/#discussion_r212225176
--- Diff: metron-interface/metron-ui-host/pom.xml ---
@@ -0,0 +1,142 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
[
https://issues.apache.org/jira/browse/METRON-1665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590116#comment-16590116
]
ASF GitHub Bot commented on METRON-1665:
Github user simonellistonball commented on a diff in
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/#discussion_r212275406
--- Diff:
metron-interface/metron-alerts-host/src/main/scripts/metron-alerts.sh ---
@@ -0,0 +1,55 @@
+#!/usr/bin/env bash
+#
+#
Github user tiborm commented on the issue:
https://github.com/apache/metron/pull/1172
@sardell @ruffle1986 I made the following changes based on your feedback:
- default values for the timestamps removed
- DEFAULT_START_TIME and DEFAULT_END_TIME moved to constants.ts
[
https://issues.apache.org/jira/browse/METRON-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590192#comment-16590192
]
ASF GitHub Bot commented on METRON-1724:
Github user tiborm commented on the issue:
68 matches
Mail list logo
