SatwikBhandiwad opened a new pull request #3257: Nifi 5435
URL: https://github.com/apache/nifi/pull/3257
NIFI-5435 Prometheus /metrics http endpoint for monitoring integration
In order to streamline the review of the contribution we ask you
to ensure the following steps have been
apiri commented on a change in pull request #465: MINIFICPP-700: Add MSI
Support via CPACK
URL: https://github.com/apache/nifi-minifi-cpp/pull/465#discussion_r246754831
##
File path: msi/LICENSE.txt
##
@@ -0,0 +1,1633 @@
+
Review comment:
Created
[
https://issues.apache.org/jira/browse/NIFI-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739390#comment-16739390
]
Gideon Korir commented on NIFI-5946:
[Similar
Gideon Korir created NIFI-5946:
--
Summary: Hive3Streaming memory leak
Key: NIFI-5946
URL: https://issues.apache.org/jira/browse/NIFI-5946
Project: Apache NiFi
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/NIFI-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739392#comment-16739392
]
Pierre Villard commented on NIFI-5946:
--
[~korir] - Isn't it related to NIFI-5841?
> Hive3Streaming
Aldrin Piri created MINIFICPP-708:
-
Summary: License should incorporate selected modules for generated
binaries
Key: MINIFICPP-708
URL: https://issues.apache.org/jira/browse/MINIFICPP-708
Project:
MAliNaqvi commented on issue #144: NIFIREG-209 Rebuild metadata DB from
FlowPersistenceProvider when emp…
URL: https://github.com/apache/nifi-registry/pull/144#issuecomment-453100613
Also I am finding that restoring from git, then creating a commit, changes
all group ids and makes
[
https://issues.apache.org/jira/browse/NIFI-5943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739396#comment-16739396
]
Alex Savitsky commented on NIFI-5943:
-
[~markap14] all the information to do the conversions is there,
[
https://issues.apache.org/jira/browse/MINIFICPP-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739422#comment-16739422
]
Mr TheSegfault commented on MINIFICPP-708:
--
Does "built by the user" mean only those that are
zisisp commented on issue #2743: NIFI-5226: Implement a Record API based
PutInfluxDB processor
URL: https://github.com/apache/nifi/pull/2743#issuecomment-453112046
Hello, what is the status of this? is it going to be merged?
SavtechSolutions commented on issue #3133: NIFI-5790: Exposes 6 commons-dbcp
options in DBCPConnectionPool
URL: https://github.com/apache/nifi/pull/3133#issuecomment-453113733
@colindean you might want to have another look at the
DBCPServiceTest.testIdle(), as it's failing the whole build
SavtechSolutions opened a new pull request #3258: NiFi-5943 support conversions
from List to Avro ARRAY and from Map to Avro RECORD
URL: https://github.com/apache/nifi/pull/3258
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the
[
https://issues.apache.org/jira/browse/NIFI-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739420#comment-16739420
]
Gideon Korir commented on NIFI-5946:
[~pvillard] closing the issue as duplicate, sorry I only searched
bbende commented on issue #144: NIFIREG-209 Rebuild metadata DB from
FlowPersistenceProvider when emp…
URL: https://github.com/apache/nifi-registry/pull/144#issuecomment-453105411
@MAliNaqvi the use-case for this feature wasn't really to keep two registry
instances in-sync by using git in
[
https://issues.apache.org/jira/browse/NIFI-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-5944:
-
Fix Version/s: 1.9.0
Status: Patch Available (was: Open)
> When NiFi restarts, if a component
[
https://issues.apache.org/jira/browse/NIFI-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739412#comment-16739412
]
Gideon Korir commented on NIFI-5946:
Question: why do we need to add a shutdown hook given that
[
https://issues.apache.org/jira/browse/NIFI-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gideon Korir resolved NIFI-5946.
Resolution: Duplicate
Fix Version/s: 1.9.0
> Hive3Streaming memory leak
>
markap14 opened a new pull request #3259: NIFI-5944: When components are
started on NiFi startup, if they are i…
URL: https://github.com/apache/nifi/pull/3259
…nvalid, don't fail immediately and give up. Instead, keep attempting to
start the component when it becomes valid.
Thank
[
https://issues.apache.org/jira/browse/NIFI-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739297#comment-16739297
]
Pierre Villard commented on NIFI-5841:
--
[~kei_miyauchi] - is there a JIRA on Hive's side you're aware
SavtechSolutions opened a new pull request #3260: NIFI-5790 removed the last
test as it's causing a race condition intermittently
URL: https://github.com/apache/nifi/pull/3260
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the
apiri commented on issue #465: MINIFICPP-700: Add MSI Support via CPACK
URL: https://github.com/apache/nifi-minifi-cpp/pull/465#issuecomment-453131114
@phrocker could you please rebase and resolve the conflicts?
This is an
mcgilman commented on issue #3259: NIFI-5944: When components are started on
NiFi startup, if they are i…
URL: https://github.com/apache/nifi/pull/3259#issuecomment-453136706
Will review...
This is an automated message from
[
https://issues.apache.org/jira/browse/NIFI-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Gilman updated NIFI-5944:
--
Resolution: Fixed
Status: Resolved (was: Patch Available)
> When NiFi restarts, if a component
mattyb149 commented on issue #3256: NIFI-5945 Add support for password login to
kerberos code in nifi-sec…
URL: https://github.com/apache/nifi/pull/3256#issuecomment-453143186
Getting a Solr unit test error now:
```[ERROR] Tests run: 18, Failures: 1, Errors: 0, Skipped: 0, Time
erichanson5 commented on issue #3248: NIFI-3611: Added ability to set
Transaction Isolation Level on Database connections for QueryDatabaseTable
processor
URL: https://github.com/apache/nifi/pull/3248#issuecomment-453155820
@ijokarumawak thanks for the assistance. I updated the branch
mcgilman commented on issue #3259: NIFI-5944: When components are started on
NiFi startup, if they are i…
URL: https://github.com/apache/nifi/pull/3259#issuecomment-453155662
Thanks @markap14! Verified behavior with local cluster. Code looks good.
Merged.
patricker commented on issue #3248: NIFI-3611: Added ability to set Transaction
Isolation Level on Database connections for QueryDatabaseTable processor
URL: https://github.com/apache/nifi/pull/3248#issuecomment-453160029
This sounds like a good general feature for a few SQL processors,
bdesert opened a new pull request #3261: NIFI-5869 Support Reconnection for JMS
URL: https://github.com/apache/nifi/pull/3261
Resets worker if it doesn't work anymore for any reason. this will add
"reconnect" capabilities. Will solve issues for following use cases:
- authentication
joewitt commented on issue #2743: NIFI-5226: Implement a Record API based
PutInfluxDB processor
URL: https://github.com/apache/nifi/pull/2743#issuecomment-453142531
@zisisp the challenge with integrations like this is having people familiar
with the source/target system which in this case
Alex Savitsky created NIFI-5947:
---
Summary: Elasticsearch lookup service that can work with
LookupAttribute
Key: NIFI-5947
URL: https://issues.apache.org/jira/browse/NIFI-5947
Project: Apache NiFi
cemeyer2 commented on issue #3253: NIFI-5938: Added ability to infer record
schema on read from JsonTree…
URL: https://github.com/apache/nifi/pull/3253#issuecomment-453135878
Hi @markap14
I have a use case that this might cover and wanted to get feedback to see if
this PR would
[
https://issues.apache.org/jira/browse/NIFI-5941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739545#comment-16739545
]
Michael Moser commented on NIFI-5941:
-
You're correct [~coffeethulhu], it's not a good user experience
bbende commented on issue #3256: NIFI-5945 Add support for password login to
kerberos code in nifi-sec…
URL: https://github.com/apache/nifi/pull/3256#issuecomment-453152151
@mattyb149 good catch, pushed up a commit to fix
asfgit closed pull request #3259: NIFI-5944: When components are started on
NiFi startup, if they are i…
URL: https://github.com/apache/nifi/pull/3259
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
[
https://issues.apache.org/jira/browse/NIFI-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739572#comment-16739572
]
ASF subversion and git services commented on NIFI-5944:
---
Commit
[
https://issues.apache.org/jira/browse/NIFI-5869?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ed Berezitsky updated NIFI-5869:
Fix Version/s: (was: 1.8.0)
Attachment: 3261.patch.txt
Status: Patch Available
phrocker opened a new pull request #471: MINIFICPP-709: Add timeout
URL: https://github.com/apache/nifi-minifi-cpp/pull/471
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following
arpadboda commented on a change in pull request #472: MINIFICPP-710 - Fix
errors in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246847908
##
File path: libminifi/src/c2/protocols/RESTProtocol.cpp
##
@@ -129,7 +129,7
Juan Pablo Converso created NIFI-5948:
-
Summary: Cannot list users when a ldap user that belongs to a
group is deleted
Key: NIFI-5948
URL: https://issues.apache.org/jira/browse/NIFI-5948
Project:
[
https://issues.apache.org/jira/browse/NIFI-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juan Pablo Converso updated NIFI-5948:
--
Description:
I configured Nifi to use LDAP to provide users. Then in Nifi using the UI
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246858533
##
File path: libminifi/test/unit/PropertyTests.cpp
##
@@ -107,3 +107,28 @@
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246858533
##
File path: libminifi/test/unit/PropertyTests.cpp
##
@@ -107,3 +107,28 @@
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246858533
##
File path: libminifi/test/unit/PropertyTests.cpp
##
@@ -107,3 +107,28 @@
[
https://issues.apache.org/jira/browse/NIFI-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juan Pablo Converso updated NIFI-5948:
--
Description:
I configured Nifi to use LDAP to provide users. Then in Nifi, using the
[
https://issues.apache.org/jira/browse/NIFI-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juan Pablo Converso updated NIFI-5948:
--
Attachment: nifi.properties
login-identity-providers.xml
[
https://issues.apache.org/jira/browse/NIFI-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739654#comment-16739654
]
Juan Pablo Converso commented on NIFI-5948:
---
Thanks for the message!
Yes I'm using the LDAP
MAliNaqvi commented on issue #144: NIFIREG-209 Rebuild metadata DB from
FlowPersistenceProvider when emp…
URL: https://github.com/apache/nifi-registry/pull/144#issuecomment-453185968
@bbende Thanks, I was able to use the REST endpoint to compute the diff.
[
https://issues.apache.org/jira/browse/NIFI-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juan Pablo Converso updated NIFI-5948:
--
Priority: Major (was: Blocker)
> Cannot list users when a ldap user that belongs to a
[
https://issues.apache.org/jira/browse/NIFI-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juan Pablo Converso updated NIFI-5948:
--
Priority: Blocker (was: Major)
> Cannot list users when a ldap user that belongs to a
[
https://issues.apache.org/jira/browse/NIFI-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739650#comment-16739650
]
Matt Gilman commented on NIFI-5948:
---
[~jpconver] Thanks for filing the JIRA. Can you please provide some
[
https://issues.apache.org/jira/browse/NIFI-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739654#comment-16739654
]
Juan Pablo Converso edited comment on NIFI-5948 at 1/10/19 6:17 PM:
[
https://issues.apache.org/jira/browse/NIFI-5948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739654#comment-16739654
]
Juan Pablo Converso edited comment on NIFI-5948 at 1/10/19 6:17 PM:
Mr TheSegfault created MINIFICPP-709:
Summary: RPG should use connection timeout
Key: MINIFICPP-709
URL: https://issues.apache.org/jira/browse/MINIFICPP-709
Project: NiFi MiNiFi C++
arpadboda opened a new pull request #472: MINIFICPP-710 - Fix errors in
Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution
Arpad Boda created MINIFICPP-710:
Summary: Fix errors in Property StringToInt conversion
Key: MINIFICPP-710
URL: https://issues.apache.org/jira/browse/MINIFICPP-710
Project: NiFi MiNiFi C++
arpadboda commented on a change in pull request #472: MINIFICPP-710 - Fix
errors in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246847713
##
File path: libminifi/test/unit/PropertyTests.cpp
##
@@ -107,3 +107,28 @@
asfgit closed pull request #471: MINIFICPP-709: Add timeout
URL: https://github.com/apache/nifi-minifi-cpp/pull/471
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull
[
https://issues.apache.org/jira/browse/MINIFICPP-709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aldrin Piri resolved MINIFICPP-709.
---
Resolution: Fixed
Fix Version/s: 0.6.0
> RPG should use connection timeout
>
phrocker commented on issue #467: MINIFICPP-703 - UUID generation in C
URL: https://github.com/apache/nifi-minifi-cpp/pull/467#issuecomment-453203763
reviewing
This is an automated message from the Apache Git Service.
To
asfgit closed pull request #467: MINIFICPP-703 - UUID generation in C
URL: https://github.com/apache/nifi-minifi-cpp/pull/467
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign
[
https://issues.apache.org/jira/browse/MINIFICPP-707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mr TheSegfault updated MINIFICPP-707:
-
Description: We need to look at how this can and will impact configuration
of the
patricker closed pull request #3260: NIFI-5790 removed the last test as it's
causing a race condition intermittently
URL: https://github.com/apache/nifi/pull/3260
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake
[
https://issues.apache.org/jira/browse/NIFI-5790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739698#comment-16739698
]
ASF subversion and git services commented on NIFI-5790:
---
Commit
colindean commented on issue #3260: NIFI-5790 removed the last test as it's
causing a race condition intermittently
URL: https://github.com/apache/nifi/pull/3260#issuecomment-453234007
I unfortunately won't have bandwidth to investigate for the foreseeable
future.
mattyb149 commented on issue #3256: NIFI-5945 Add support for password login to
kerberos code in nifi-sec…
URL: https://github.com/apache/nifi/pull/3256#issuecomment-453234815
Travis builds failed for other reasons not related to this PR. I ran the
relevant unit and integration tests, all
asfgit closed pull request #3256: NIFI-5945 Add support for password login to
kerberos code in nifi-sec…
URL: https://github.com/apache/nifi/pull/3256
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
[
https://issues.apache.org/jira/browse/NIFI-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739741#comment-16739741
]
ASF subversion and git services commented on NIFI-5945:
---
Commit
[
https://issues.apache.org/jira/browse/NIFI-5945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Burgess updated NIFI-5945:
---
Resolution: Fixed
Fix Version/s: 1.9.0
Status: Resolved (was: Patch Available)
>
patricker edited a comment on issue #3260: NIFI-5790 removed the last test as
it's causing a race condition intermittently
URL: https://github.com/apache/nifi/pull/3260#issuecomment-453241832
@colindean We went ahead and removed the very last test. This still leaves
in most of the testing
patricker commented on issue #3260: NIFI-5790 removed the last test as it's
causing a race condition intermittently
URL: https://github.com/apache/nifi/pull/3260#issuecomment-453241832
@colindean We went ahead and removed the very last test. This still leaves
in most of the testing of
[
https://issues.apache.org/jira/browse/NIFI-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne reopened NIFI-5944:
--
> When NiFi restarts, if a component is expected to be running but is invalid,
> it never starts, even if
Kevin Doran created NIFI-5950:
-
Summary: Error updating flow version if input port has been
removed and re-added with the same name.
Key: NIFI-5950
URL: https://issues.apache.org/jira/browse/NIFI-5950
markap14 opened a new pull request #3263: NIFI-5944: If processor is no longer
scheduled to run after a failed …
URL: https://github.com/apache/nifi/pull/3263
…trigger of @OnScheduled, ensure that we set scheduled status to STOPPED
Thank you for submitting a contribution to Apache
[
https://issues.apache.org/jira/browse/NIFI-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739801#comment-16739801
]
Mark Payne commented on NIFI-5944:
--
[~mcgilman] thanks for reviewing. Unfortunately, I found a slight bug
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246972159
##
File path: libminifi/include/core/TypedValues.h
##
@@ -141,6 +141,47 @@
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246974404
##
File path: libminifi/test/unit/PropertyTests.cpp
##
@@ -107,3 +107,28 @@
bednar commented on issue #2743: NIFI-5226: Implement a Record API based
PutInfluxDB processor
URL: https://github.com/apache/nifi/pull/2743#issuecomment-453393896
Hi @joewitt,
Thanks for your detail information. Is there anything else how we can help
you (or other reviewers) with
Koji Kawamura created NIFI-5952:
---
Summary: RAW Site-to-Site fails with
java.nio.channels.IllegalBlockingModeException
Key: NIFI-5952
URL: https://issues.apache.org/jira/browse/NIFI-5952
Project: Apache
[
https://issues.apache.org/jira/browse/NIFI-3698?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739794#comment-16739794
]
Anthony Mastrean commented on NIFI-3698:
I was _just_ beginning to explore using Apache Nifi for
AnthonyMastrean commented on issue #2814: NIFI-539 and NIFI-3698: Add SCP and
SSH Processors
URL: https://github.com/apache/nifi/pull/2814#issuecomment-453259003
@patricker can you show us the new PRs or branches or whatever you have
open. I'm really interested in this feature!
[
https://issues.apache.org/jira/browse/NIFI-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Doran updated NIFI-5950:
--
Description:
Originally reported on the users@nifi mailing list on this thread:
[
https://issues.apache.org/jira/browse/NIFI-5944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-5944:
-
Status: Patch Available (was: Reopened)
> When NiFi restarts, if a component is expected to be running
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246971930
##
File path: libminifi/test/unit/PropertyTests.cpp
##
@@ -107,3 +107,28 @@
mans2singh commented on issue #2956: NIFI-5537 Create Neo4J cypher execution
processor
URL: https://github.com/apache/nifi/pull/2956#issuecomment-453352680
@MikeThomsen -
I will check the pointers you've (mongodb, hbase) and will get back to you.
Thanks
Mans
Mark Payne created NIFI-5949:
Summary: PutKudu Error Handling needs to be cleaned up
Key: NIFI-5949
URL: https://issues.apache.org/jira/browse/NIFI-5949
Project: Apache NiFi
Issue Type: Bug
[
https://issues.apache.org/jira/browse/NIFI-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kevin Doran updated NIFI-5950:
--
Description:
Originally reported on the users@nifi mailing list on this thread:
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246970833
##
File path: libminifi/include/core/TypedValues.h
##
@@ -141,6 +141,47 @@
Koji Kawamura created NIFI-5951:
---
Summary: PutHiveQL can miss logging error message if
rollback-on-failure is enabled
Key: NIFI-5951
URL: https://issues.apache.org/jira/browse/NIFI-5951
Project: Apache
ijokarumawak opened a new pull request #3264: NIFI-5951 Fix error logging with
rollback on failure
URL: https://github.com/apache/nifi/pull/3264
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the
[
https://issues.apache.org/jira/browse/NIFI-5951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Kawamura updated NIFI-5951:
Description:
if rollback-on-failure is enabled and a failure occurred after processing some
mcgilman commented on issue #3263: NIFI-5944: If processor is no longer
scheduled to run after a failed …
URL: https://github.com/apache/nifi/pull/3263#issuecomment-453264189
Good catch, will review...
This is an automated
[
https://issues.apache.org/jira/browse/NIFI-5841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16739893#comment-16739893
]
Kei Miyauchi commented on NIFI-5841:
[~pvillard] yes, please see
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246971618
##
File path: libminifi/include/core/TypedValues.h
##
@@ -141,6 +141,47 @@
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246971581
##
File path: libminifi/include/core/TypedValues.h
##
@@ -141,6 +141,47 @@
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246971559
##
File path: libminifi/src/c2/protocols/RESTProtocol.cpp
##
@@ -129,7 +129,7
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246858533
##
File path: libminifi/test/unit/PropertyTests.cpp
##
@@ -107,3 +107,28 @@
markap14 commented on issue #3262: NIFI-5949: Addressed problematic error
handling logic in PutKudu. Als…
URL: https://github.com/apache/nifi/pull/3262#issuecomment-453260165
@jtstorck any chance you can take a look at this and make sure that I didn't
break anything? :)
markap14 opened a new pull request #3262: NIFI-5949: Addressed problematic
error handling logic in PutKudu. Als…
URL: https://github.com/apache/nifi/pull/3262
…o removed AbstractKudu and moved all logic into PutKudu, as the abstract
class was clearly designed to be extended only by
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246969665
##
File path: libminifi/test/unit/PropertyTests.cpp
##
@@ -107,3 +107,28 @@
phrocker commented on a change in pull request #472: MINIFICPP-710 - Fix errors
in Property StringToInt conversion
URL: https://github.com/apache/nifi-minifi-cpp/pull/472#discussion_r246971275
##
File path: libminifi/include/core/TypedValues.h
##
@@ -163,7 +204,11 @@
1 - 100 of 121 matches
Mail list logo