[GitHub] ottobackwards commented on issue #3233: NIFI-5892 Wait timestamp lingers, potentially messing up downstream w…

2018-12-27 Thread GitBox
ottobackwards commented on issue #3233: NIFI-5892 Wait timestamp lingers, potentially messing up downstream w… URL: https://github.com/apache/nifi/pull/3233#issuecomment-450209139 @ijokarumawak , thank you for the review, I have addressed your comments, and re-run the full build with

[GitHub] asfgit closed pull request #3233: NIFI-5892 Wait timestamp lingers, potentially messing up downstream w…

2018-12-27 Thread GitBox
asfgit closed pull request #3233: NIFI-5892 Wait timestamp lingers, potentially messing up downstream w… URL: https://github.com/apache/nifi/pull/3233 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] ijokarumawak commented on issue #3233: NIFI-5892 Wait timestamp lingers, potentially messing up downstream w…

2018-12-27 Thread GitBox
ijokarumawak commented on issue #3233: NIFI-5892 Wait timestamp lingers, potentially messing up downstream w… URL: https://github.com/apache/nifi/pull/3233#issuecomment-450268496 @ottobackwards Thanks for the updates. LGTM +1. Merging to master!

[GitHub] ijokarumawak opened a new pull request #3237: NIFI-5917 Fix TestSelectHiveQL.testNoTimeLimit

2018-12-27 Thread GitBox
ijokarumawak opened a new pull request #3237: NIFI-5917 Fix TestSelectHiveQL.testNoTimeLimit URL: https://github.com/apache/nifi/pull/3237 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the

[GitHub] sbgoodm opened a new pull request #3239: NIFI-5920: Unit tests and functionality for tagging an object in S3.

2019-01-01 Thread GitBox
sbgoodm opened a new pull request #3239: NIFI-5920: Unit tests and functionality for tagging an object in S3. URL: https://github.com/apache/nifi/pull/3239 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to

[GitHub] sbgoodm commented on issue #3239: NIFI-5920: Unit tests and functionality for tagging an object in S3.

2019-01-01 Thread GitBox
sbgoodm commented on issue #3239: NIFI-5920: Unit tests and functionality for tagging an object in S3. URL: https://github.com/apache/nifi/pull/3239#issuecomment-450756346 Need PR #3237 merged to resolve failing HiveQL unit tests breaking the Travis build.

[GitHub] MikeThomsen commented on issue #2956: NIFI-5537 Create Neo4J cypher execution processor

2019-01-02 Thread GitBox
MikeThomsen commented on issue #2956: NIFI-5537 Create Neo4J cypher execution processor URL: https://github.com/apache/nifi/pull/2956#issuecomment-450922155 @alopresto @ottobackwards @mans2singh @mattyb149 Anyone still tracking this ticket? I have some ideas on refactoring this

[GitHub] alopresto commented on issue #2956: NIFI-5537 Create Neo4J cypher execution processor

2019-01-02 Thread GitBox
alopresto commented on issue #2956: NIFI-5537 Create Neo4J cypher execution processor URL: https://github.com/apache/nifi/pull/2956#issuecomment-450963345 I believe the conversations around TLS security came to a consensus, but I have not seen new code related to that.

[GitHub] MAliNaqvi commented on issue #144: NIFIREG-209 Rebuild metadata DB from FlowPersistenceProvider when emp…

2019-01-02 Thread GitBox
MAliNaqvi commented on issue #144: NIFIREG-209 Rebuild metadata DB from FlowPersistenceProvider when emp… URL: https://github.com/apache/nifi-registry/pull/144#issuecomment-450919552 @ijokarumawak how did you point the nifi registry to different branches? I am using docker-compose:

[GitHub] peter-gergely-horvath commented on issue #3165: NIFI-5318 Implement NiFi test harness

2019-01-02 Thread GitBox
peter-gergely-horvath commented on issue #3165: NIFI-5318 Implement NiFi test harness URL: https://github.com/apache/nifi/pull/3165#issuecomment-450983342 @MikeThomsen this issue has now been fixed. Please review / try it again: now it works properly.

[GitHub] asfgit closed pull request #463: MINIFICPP-698: Fix spacing issue

2019-01-02 Thread GitBox
asfgit closed pull request #463: MINIFICPP-698: Fix spacing issue URL: https://github.com/apache/nifi-minifi-cpp/pull/463 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] apiri commented on issue #463: MINIFICPP-676: Fix spacing issue

2019-01-02 Thread GitBox
apiri commented on issue #463: MINIFICPP-676: Fix spacing issue URL: https://github.com/apache/nifi-minifi-cpp/pull/463#issuecomment-450917918 Looks to fix our problem with builds. Verified each of the 4 jobs is running.

[GitHub] arpadboda commented on issue #463: MINIFICPP-676: Fix spacing issue

2019-01-02 Thread GitBox
arpadboda commented on issue #463: MINIFICPP-676: Fix spacing issue URL: https://github.com/apache/nifi-minifi-cpp/pull/463#issuecomment-450918795 Wrong Jira ID! This is an automated message from the Apache Git Service. To

[GitHub] ottobackwards commented on issue #2956: NIFI-5537 Create Neo4J cypher execution processor

2019-01-02 Thread GitBox
ottobackwards commented on issue #2956: NIFI-5537 Create Neo4J cypher execution processor URL: https://github.com/apache/nifi/pull/2956#issuecomment-450941692 I'll look at whatever, progress kind of stopped here apparently

[GitHub] MAliNaqvi edited a comment on issue #144: NIFIREG-209 Rebuild metadata DB from FlowPersistenceProvider when emp…

2019-01-02 Thread GitBox
MAliNaqvi edited a comment on issue #144: NIFIREG-209 Rebuild metadata DB from FlowPersistenceProvider when emp… URL: https://github.com/apache/nifi-registry/pull/144#issuecomment-450919552 @ijokarumawak how did you point the nifi registry to different branches? I am using

[GitHub] arpadboda edited a comment on issue #463: MINIFICPP-676: Fix spacing issue

2019-01-02 Thread GitBox
arpadboda edited a comment on issue #463: MINIFICPP-676: Fix spacing issue URL: https://github.com/apache/nifi-minifi-cpp/pull/463#issuecomment-450918795 Wrong Jira ID! Meant to be MINIFICPP-698 This is an automated

[GitHub] SamHjelmfelt commented on a change in pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows

2019-01-04 Thread GitBox
SamHjelmfelt commented on a change in pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows URL: https://github.com/apache/nifi/pull/3241#discussion_r245452803 ## File path: nifi-fn/pom.xml ## @@ -0,0 +1,159 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] SamHjelmfelt commented on a change in pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows

2019-01-04 Thread GitBox
SamHjelmfelt commented on a change in pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows URL: https://github.com/apache/nifi/pull/3241#discussion_r245452832 ## File path: nifi-fn/pom.xml ## @@ -0,0 +1,145 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] SamHjelmfelt commented on issue #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows

2019-01-02 Thread GitBox
SamHjelmfelt commented on issue #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows URL: https://github.com/apache/nifi/pull/3241#issuecomment-451039727 Here is a Apache OpenWhisk quick-start that comes preconfigured for NiFi-Fn. I will work to improve the documentation of

[GitHub] SamHjelmfelt commented on a change in pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows

2019-01-02 Thread GitBox
SamHjelmfelt commented on a change in pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows URL: https://github.com/apache/nifi/pull/3241#discussion_r244901599 ## File path: nifi-fn/pom.xml ## @@ -0,0 +1,145 @@ + +http://maven.apache.org/POM/4.0.0;

[GitHub] SamHjelmfelt commented on a change in pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows

2019-01-02 Thread GitBox
SamHjelmfelt commented on a change in pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows URL: https://github.com/apache/nifi/pull/3241#discussion_r244901605 ## File path: nifi-fn/.gitignore ## @@ -0,0 +1 @@ +target/ Review comment: Makes

[GitHub] SamHjelmfelt opened a new pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows

2019-01-02 Thread GitBox
SamHjelmfelt opened a new pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows URL: https://github.com/apache/nifi/pull/3241 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] SamHjelmfelt commented on issue #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows

2019-01-02 Thread GitBox
SamHjelmfelt commented on issue #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows URL: https://github.com/apache/nifi/pull/3241#issuecomment-451035944 A pre-built docker image can be found here: samhjelmfelt/nifi-fn:latest

[GitHub] SamHjelmfelt edited a comment on issue #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows

2019-01-02 Thread GitBox
SamHjelmfelt edited a comment on issue #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows URL: https://github.com/apache/nifi/pull/3241#issuecomment-451035944 A pre-built docker image can be found on docker hub with this tag: samhjelmfelt/nifi-fn:latest

[GitHub] alopresto commented on a change in pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows

2019-01-02 Thread GitBox
alopresto commented on a change in pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows URL: https://github.com/apache/nifi/pull/3241#discussion_r244899012 ## File path: nifi-fn/.gitignore ## @@ -0,0 +1 @@ +target/ Review comment: I think

[GitHub] bdesert closed pull request #3183: NIFI-5826 Fix to escaped backslash

2019-01-02 Thread GitBox
bdesert closed pull request #3183: NIFI-5826 Fix to escaped backslash URL: https://github.com/apache/nifi/pull/3183 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] alopresto commented on a change in pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows

2019-01-02 Thread GitBox
alopresto commented on a change in pull request #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows URL: https://github.com/apache/nifi/pull/3241#discussion_r244899214 ## File path: nifi-fn/pom.xml ## @@ -0,0 +1,145 @@ + +http://maven.apache.org/POM/4.0.0; +

[GitHub] bdesert commented on issue #3183: NIFI-5826 Fix to escaped backslash

2019-01-02 Thread GitBox
bdesert commented on issue #3183: NIFI-5826 Fix to escaped backslash URL: https://github.com/apache/nifi/pull/3183#issuecomment-451053508 Closing this PR. Please refer to [PR 3200](https://github.com/apache/nifi/pull/3200) with better solution.

[GitHub] pvillard31 commented on issue #3237: NIFI-5917 Fix TestSelectHiveQL.testNoTimeLimit

2019-01-03 Thread GitBox
pvillard31 commented on issue #3237: NIFI-5917 Fix TestSelectHiveQL.testNoTimeLimit URL: https://github.com/apache/nifi/pull/3237#issuecomment-451106403 Merged to master, thanks @ijokarumawak This is an automated message

[GitHub] asfgit closed pull request #3237: NIFI-5917 Fix TestSelectHiveQL.testNoTimeLimit

2019-01-03 Thread GitBox
asfgit closed pull request #3237: NIFI-5917 Fix TestSelectHiveQL.testNoTimeLimit URL: https://github.com/apache/nifi/pull/3237 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] asfgit closed pull request #3238: NIFI-5919: Addressed a race condition that can exist if adding FlowFi…

2019-01-03 Thread GitBox
asfgit closed pull request #3238: NIFI-5919: Addressed a race condition that can exist if adding FlowFi… URL: https://github.com/apache/nifi/pull/3238 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] pvillard31 commented on issue #3238: NIFI-5919: Addressed a race condition that can exist if adding FlowFi…

2019-01-03 Thread GitBox
pvillard31 commented on issue #3238: NIFI-5919: Addressed a race condition that can exist if adding FlowFi… URL: https://github.com/apache/nifi/pull/3238#issuecomment-451107088 Merged to master, thanks @markap14 This is an

[GitHub] tomerghelber commented on issue #3234: NIFI-5933 Removed sun usage

2019-01-06 Thread GitBox
tomerghelber commented on issue #3234: NIFI-5933 Removed sun usage URL: https://github.com/apache/nifi/pull/3234#issuecomment-451728302 Hello, I have a single case where I fail: JDK: openjdk8 JavaUSER_LANGUAGE=fr USER_REGION=FR' The fail is in test

[GitHub] MikeThomsen commented on issue #2546: NIFI-4975 Add GridFS processors

2019-01-05 Thread GitBox
MikeThomsen commented on issue #2546: NIFI-4975 Add GridFS processors URL: https://github.com/apache/nifi/pull/2546#issuecomment-451690328 @zenfenan @mattyb149 any chance we could close this one? It's been sitting here for almost a year and hits some big Mongo functionality.

[GitHub] ottobackwards commented on issue #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows

2019-01-05 Thread GitBox
ottobackwards commented on issue #3241: NIFI-5922: NiFi-Fn, an alternative runtime for NiFi flows URL: https://github.com/apache/nifi/pull/3241#issuecomment-451712623 Is there any design documentation on this? There is no javadoc

[GitHub] MikeThomsen commented on issue #2956: NIFI-5537 Create Neo4J cypher execution processor

2019-01-06 Thread GitBox
MikeThomsen commented on issue #2956: NIFI-5537 Create Neo4J cypher execution processor URL: https://github.com/apache/nifi/pull/2956#issuecomment-451783633 @mans2singh The OpenCypher team released a Neo4J-style driver that uses Gremlin behind the scenes. It appears to be API-compatible

[GitHub] mans2singh commented on issue #2956: NIFI-5537 Create Neo4J cypher execution processor

2019-01-06 Thread GitBox
mans2singh commented on issue #2956: NIFI-5537 Create Neo4J cypher execution processor URL: https://github.com/apache/nifi/pull/2956#issuecomment-451776733 @ottobackwards @alopresto I would like to continue working on this but am not sure how to generalize neo4j and open cypher

[GitHub] peter-gergely-horvath commented on issue #3165: NIFI-5318 Implement NiFi test harness

2019-01-16 Thread GitBox
peter-gergely-horvath commented on issue #3165: NIFI-5318 Implement NiFi test harness URL: https://github.com/apache/nifi/pull/3165#issuecomment-454760992 You should be able to fish out the failed test's output from the following files; maybe that helps. If not, please post their content

[GitHub] MikeThomsen commented on issue #3165: NIFI-5318 Implement NiFi test harness

2019-01-16 Thread GitBox
MikeThomsen commented on issue #3165: NIFI-5318 Implement NiFi test harness URL: https://github.com/apache/nifi/pull/3165#issuecomment-454757333 Any ideas? Got this after rerunning: ``` [INFO] [INFO] --- maven-surefire-plugin:2.20.1:test (default-test) @ nifi-testharness ---

[GitHub] MikeThomsen commented on a change in pull request #3041: NIFI-5224 Added SolrClientService.

2019-01-15 Thread GitBox
MikeThomsen commented on a change in pull request #3041: NIFI-5224 Added SolrClientService. URL: https://github.com/apache/nifi/pull/3041#discussion_r247924264 ## File path: nifi-nar-bundles/nifi-solr-bundle/nifi-solr-processors/pom.xml ## @@ -147,6 +147,12 @@

[GitHub] TranceMaster86 commented on issue #2901: NIFI-4246 - Client Credentials Grant based OAuth2 Controller Service

2019-01-16 Thread GitBox
TranceMaster86 commented on issue #2901: NIFI-4246 - Client Credentials Grant based OAuth2 Controller Service URL: https://github.com/apache/nifi/pull/2901#issuecomment-454848707 When will it be fixed? We need that also This

[GitHub] ivankudibal commented on issue #2743: NIFI-5226: Implement a Record API based PutInfluxDB processor

2019-01-17 Thread GitBox
ivankudibal commented on issue #2743: NIFI-5226: Implement a Record API based PutInfluxDB processor URL: https://github.com/apache/nifi/pull/2743#issuecomment-455316972 We will create the independent repo with influxdata nar, builds, examples and other docs for Nifi users. This gives us

[GitHub] joewitt commented on issue #2743: NIFI-5226: Implement a Record API based PutInfluxDB processor

2019-01-17 Thread GitBox
joewitt commented on issue #2743: NIFI-5226: Implement a Record API based PutInfluxDB processor URL: https://github.com/apache/nifi/pull/2743#issuecomment-455319115 Cool sounds good. Can you please close out this PR and the JIRA with that information. Please feel free to let the

[GitHub] mattyb149 commented on issue #3264: NIFI-5951 Fix error logging with rollback on failure

2019-01-17 Thread GitBox
mattyb149 commented on issue #3264: NIFI-5951 Fix error logging with rollback on failure URL: https://github.com/apache/nifi/pull/3264#issuecomment-455351369 +1 LGTM, thanks for this improvement! Merging to master This is an

[GitHub] asfgit closed pull request #3264: NIFI-5951 Fix error logging with rollback on failure

2019-01-17 Thread GitBox
asfgit closed pull request #3264: NIFI-5951 Fix error logging with rollback on failure URL: https://github.com/apache/nifi/pull/3264 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] bbende opened a new pull request #3271: NIFI-5961 Fixing bug where the name of a versioned process group gets…

2019-01-18 Thread GitBox
bbende opened a new pull request #3271: NIFI-5961 Fixing bug where the name of a versioned process group gets… URL: https://github.com/apache/nifi/pull/3271 … incorrectly reset Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the

[GitHub] bbende commented on issue #3254: NIFI-4915 Adding HBase 2.x service bundle

2019-01-18 Thread GitBox
bbende commented on issue #3254: NIFI-4915 Adding HBase 2.x service bundle URL: https://github.com/apache/nifi/pull/3254#issuecomment-455596366 @MikeThomsen was wondering if you had any cycles to look at this, the code is all the same from the 1.1.2 bundle, just using the 2.x client.

[GitHub] phrocker commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-18 Thread GitBox
phrocker commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r249102304 ## File path: libminifi/include/sitetosite/SiteToSiteClient.h ## @@ -221,12 +221,8 @@

[GitHub] phrocker commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-18 Thread GitBox
phrocker commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r249102672 ## File path: libminifi/src/sitetosite/RawSocketProtocol.cpp ## @@ -394,98 +394,12 @@

[GitHub] ambition119 commented on issue #3178: NIFI-4914: Add Apache Pulsar processors

2019-01-18 Thread GitBox
ambition119 commented on issue #3178: NIFI-4914: Add Apache Pulsar processors URL: https://github.com/apache/nifi/pull/3178#issuecomment-455487547 Hopefully nifi will support pulsar. This is an automated message from the

[GitHub] bbende opened a new pull request #3270: NIFI-5962 protecting against null Configuration in AbstractHadoopProc…

2019-01-18 Thread GitBox
bbende opened a new pull request #3270: NIFI-5962 protecting against null Configuration in AbstractHadoopProc… URL: https://github.com/apache/nifi/pull/3270 …essor onStopped Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the

[GitHub] markap14 commented on issue #3253: NIFI-5938: Added ability to infer record schema on read from JsonTree…

2019-01-18 Thread GitBox
markap14 commented on issue #3253: NIFI-5938: Added ability to infer record schema on read from JsonTree… URL: https://github.com/apache/nifi/pull/3253#issuecomment-455547047 @cemeyer2 yes, you will likely be able to do that with just UpdateRecord once this PR is merged.

[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-18 Thread GitBox
arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r249233347 ## File path: libminifi/include/sitetosite/SiteToSiteClient.h ## @@ -221,12 +221,8 @@

[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-18 Thread GitBox
arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r249233347 ## File path: libminifi/include/sitetosite/SiteToSiteClient.h ## @@ -221,12 +221,8 @@

[GitHub] bdesert edited a comment on issue #3261: NIFI-5869 Support Reconnection for JMS

2019-01-18 Thread GitBox
bdesert edited a comment on issue #3261: NIFI-5869 Support Reconnection for JMS URL: https://github.com/apache/nifi/pull/3261#issuecomment-455739284 @mosermw, addressed your findings, improved reset connection from both PublishJMS and ConsumeJMS. Tested with live JNDI and two JMS servers.

[GitHub] bdesert commented on issue #3261: NIFI-5869 Support Reconnection for JMS

2019-01-18 Thread GitBox
bdesert commented on issue #3261: NIFI-5869 Support Reconnection for JMS URL: https://github.com/apache/nifi/pull/3261#issuecomment-455739284 Improved reset connection. Tested with live JNDI and two JMS servers. Steps to test described in [JIRA

[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-18 Thread GitBox
arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r249233347 ## File path: libminifi/include/sitetosite/SiteToSiteClient.h ## @@ -221,12 +221,8 @@

[GitHub] MikeThomsen commented on issue #3041: NIFI-5224 Added SolrClientService.

2019-01-15 Thread GitBox
MikeThomsen commented on issue #3041: NIFI-5224 Added SolrClientService. URL: https://github.com/apache/nifi/pull/3041#issuecomment-454442393 @patricker @bbende I think we're good to go now. This is an automated message from

[GitHub] SavtechSolutions commented on a change in pull request #3268: NIFI-5947 Elasticsearch lookup service compatible with LookupAttribute

2019-01-15 Thread GitBox
SavtechSolutions commented on a change in pull request #3268: NIFI-5947 Elasticsearch lookup service compatible with LookupAttribute URL: https://github.com/apache/nifi/pull/3268#discussion_r248008053 ## File path:

[GitHub] asfgit closed pull request #473: MINIFICPP-711 Adjust display name of proxy username for InvokeHTTP

2019-01-15 Thread GitBox
asfgit closed pull request #473: MINIFICPP-711 Adjust display name of proxy username for InvokeHTTP URL: https://github.com/apache/nifi-minifi-cpp/pull/473 As this is a foreign pull request (from a fork), the diff has been sent to your commit mailing list, comm...@nifi.apache.org

[GitHub] SavtechSolutions commented on a change in pull request #3268: NIFI-5947 Elasticsearch lookup service compatible with LookupAttribute

2019-01-14 Thread GitBox
SavtechSolutions commented on a change in pull request #3268: NIFI-5947 Elasticsearch lookup service compatible with LookupAttribute URL: https://github.com/apache/nifi/pull/3268#discussion_r247727219 ## File path:

[GitHub] SavtechSolutions commented on a change in pull request #3268: NIFI-5947 Elasticsearch lookup service compatible with LookupAttribute

2019-01-14 Thread GitBox
SavtechSolutions commented on a change in pull request #3268: NIFI-5947 Elasticsearch lookup service compatible with LookupAttribute URL: https://github.com/apache/nifi/pull/3268#discussion_r247727966 ## File path:

[GitHub] MikeThomsen commented on a change in pull request #3041: NIFI-5224 Added SolrClientService.

2019-01-14 Thread GitBox
MikeThomsen commented on a change in pull request #3041: NIFI-5224 Added SolrClientService. URL: https://github.com/apache/nifi/pull/3041#discussion_r247736507 ## File path:

[GitHub] MikeThomsen commented on issue #3041: NIFI-5224 Added SolrClientService.

2019-01-14 Thread GitBox
MikeThomsen commented on issue #3041: NIFI-5224 Added SolrClientService. URL: https://github.com/apache/nifi/pull/3041#issuecomment-454233247 @patricker @bbende going to try to get back in on this over the next day or two, time permitting.

[GitHub] MikeThomsen commented on a change in pull request #3268: NIFI-5947 Elasticsearch lookup service compatible with LookupAttribute

2019-01-14 Thread GitBox
MikeThomsen commented on a change in pull request #3268: NIFI-5947 Elasticsearch lookup service compatible with LookupAttribute URL: https://github.com/apache/nifi/pull/3268#discussion_r247724572 ## File path:

[GitHub] MikeThomsen commented on a change in pull request #3268: NIFI-5947 Elasticsearch lookup service compatible with LookupAttribute

2019-01-14 Thread GitBox
MikeThomsen commented on a change in pull request #3268: NIFI-5947 Elasticsearch lookup service compatible with LookupAttribute URL: https://github.com/apache/nifi/pull/3268#discussion_r247724627 ## File path:

[GitHub] MikeThomsen commented on a change in pull request #3268: NIFI-5947 Elasticsearch lookup service compatible with LookupAttribute

2019-01-14 Thread GitBox
MikeThomsen commented on a change in pull request #3268: NIFI-5947 Elasticsearch lookup service compatible with LookupAttribute URL: https://github.com/apache/nifi/pull/3268#discussion_r247724378 ## File path:

[GitHub] SavtechSolutions commented on a change in pull request #3268: NIFI-5947 Elasticsearch lookup service compatible with LookupAttribute

2019-01-14 Thread GitBox
SavtechSolutions commented on a change in pull request #3268: NIFI-5947 Elasticsearch lookup service compatible with LookupAttribute URL: https://github.com/apache/nifi/pull/3268#discussion_r247727219 ## File path:

[GitHub] asfgit closed pull request #3248: NIFI-3611: Added ability to set Transaction Isolation Level on Database connections for QueryDatabaseTable processor

2019-01-21 Thread GitBox
asfgit closed pull request #3248: NIFI-3611: Added ability to set Transaction Isolation Level on Database connections for QueryDatabaseTable processor URL: https://github.com/apache/nifi/pull/3248 This is an automated

[GitHub] ijokarumawak commented on issue #3248: NIFI-3611: Added ability to set Transaction Isolation Level on Database connections for QueryDatabaseTable processor

2019-01-21 Thread GitBox
ijokarumawak commented on issue #3248: NIFI-3611: Added ability to set Transaction Isolation Level on Database connections for QueryDatabaseTable processor URL: https://github.com/apache/nifi/pull/3248#issuecomment-455984064 The update LGTM, +1. Merging to master. Thanks @erichanson5!

[GitHub] phrocker opened a new pull request #475: MINIFICPP-718: Fix issue with docker verify with docker API changes

2019-01-22 Thread GitBox
phrocker opened a new pull request #475: MINIFICPP-718: Fix issue with docker verify with docker API changes URL: https://github.com/apache/nifi-minifi-cpp/pull/475 Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of the

[GitHub] jtstorck commented on issue #3262: NIFI-5949: Addressed problematic error handling logic in PutKudu. Als…

2019-01-22 Thread GitBox
jtstorck commented on issue #3262: NIFI-5949: Addressed problematic error handling logic in PutKudu. Als… URL: https://github.com/apache/nifi/pull/3262#issuecomment-456562465 Reviewing... This is an automated message from

[GitHub] thenatog opened a new pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …

2019-01-22 Thread GitBox
thenatog opened a new pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273 …HTTP headers using Jetty Filters. Added some tests. Thank you for submitting a contribution to Apache NiFi. In order

[GitHub] apiri commented on issue #475: MINIFICPP-718: Fix issue with docker verify with docker API changes

2019-01-22 Thread GitBox
apiri commented on issue #475: MINIFICPP-718: Fix issue with docker verify with docker API changes URL: https://github.com/apache/nifi-minifi-cpp/pull/475#issuecomment-456595693 reviewing This is an automated message from

[GitHub] thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …

2019-01-23 Thread GitBox
thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r250238788 ## File path:

[GitHub] thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …

2019-01-23 Thread GitBox
thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r250236583 ## File path:

[GitHub] alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …

2019-01-22 Thread GitBox
alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r250031372 ## File path:

[GitHub] apiri commented on issue #475: MINIFICPP-718: Fix issue with docker verify with docker API changes

2019-01-22 Thread GitBox
apiri commented on issue #475: MINIFICPP-718: Fix issue with docker verify with docker API changes URL: https://github.com/apache/nifi-minifi-cpp/pull/475#issuecomment-456651084 `FAILED ../docker/test/integration/test_zero_file.py::test_minifi_to_nifi INFO:root:Creating tmp test input

[GitHub] phrocker commented on issue #475: MINIFICPP-718: Fix issue with docker verify with docker API changes

2019-01-22 Thread GitBox
phrocker commented on issue #475: MINIFICPP-718: Fix issue with docker verify with docker API changes URL: https://github.com/apache/nifi-minifi-cpp/pull/475#issuecomment-456652571 Thanks. I will do a make clean to ensure I have a clean environment. I imagine I didn't see the issues

[GitHub] alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …

2019-01-22 Thread GitBox
alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r250045088 ## File path:

[GitHub] alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …

2019-01-22 Thread GitBox
alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r250028850 ## File path:

[GitHub] apiri commented on issue #475: MINIFICPP-718: Fix issue with docker verify with docker API changes

2019-01-22 Thread GitBox
apiri commented on issue #475: MINIFICPP-718: Fix issue with docker verify with docker API changes URL: https://github.com/apache/nifi-minifi-cpp/pull/475#issuecomment-456639337 @phrocker I have been bad about verifying this continuously on builds. Your changes definitely improved the

[GitHub] alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …

2019-01-22 Thread GitBox
alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r250033568 ## File path:

[GitHub] alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …

2019-01-22 Thread GitBox
alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r250033755 ## File path:

[GitHub] alopresto commented on issue #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …

2019-01-22 Thread GitBox
alopresto commented on issue #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#issuecomment-456621134 Reviewing... This is an automated message from

[GitHub] alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …

2019-01-22 Thread GitBox
alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r250029389 ## File path:

[GitHub] alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …

2019-01-22 Thread GitBox
alopresto commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r250029252 ## File path:

[GitHub] thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …

2019-01-23 Thread GitBox
thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r250238788 ## File path:

[GitHub] thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …

2019-01-23 Thread GitBox
thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r250238788 ## File path:

[GitHub] mcgilman opened a new pull request #3274: NIFI-5972: LdapUserGroupProvider logging

2019-01-23 Thread GitBox
mcgilman opened a new pull request #3274: NIFI-5972: LdapUserGroupProvider logging URL: https://github.com/apache/nifi/pull/3274 NIFI-5972: - Converting some warning log messages to debug as they could possibly be due to a valid scenario like NiFi users belonging to a group that is not

[GitHub] SavtechSolutions opened a new pull request #3269: NIFI-5960 add compatibility rating to RECORD schemas

2019-01-17 Thread GitBox
SavtechSolutions opened a new pull request #3269: NIFI-5960 add compatibility rating to RECORD schemas URL: https://github.com/apache/nifi/pull/3269 Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure

[GitHub] MikeThomsen commented on issue #3254: NIFI-4915 Adding HBase 2.x service bundle

2019-01-19 Thread GitBox
MikeThomsen commented on issue #3254: NIFI-4915 Adding HBase 2.x service bundle URL: https://github.com/apache/nifi/pull/3254#issuecomment-455811169 I can try to find some time this week. This is an automated message from the

[GitHub] arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication

2019-01-23 Thread GitBox
arpadboda commented on a change in pull request #470: MINIFICPP-706 - RawSiteToSite: remove code duplication URL: https://github.com/apache/nifi-minifi-cpp/pull/470#discussion_r249948870 ## File path: libminifi/src/sitetosite/RawSocketProtocol.cpp ## @@ -395,97 +395,37 @@

[GitHub] phrocker commented on issue #475: MINIFICPP-718: Fix issue with docker verify with docker API changes

2019-01-22 Thread GitBox
phrocker commented on issue #475: MINIFICPP-718: Fix issue with docker verify with docker API changes URL: https://github.com/apache/nifi-minifi-cpp/pull/475#issuecomment-456647138 @apiri Which test(s) failed? This is an

[GitHub] phrocker edited a comment on issue #475: MINIFICPP-718: Fix issue with docker verify with docker API changes

2019-01-23 Thread GitBox
phrocker edited a comment on issue #475: MINIFICPP-718: Fix issue with docker verify with docker API changes URL: https://github.com/apache/nifi-minifi-cpp/pull/475#issuecomment-456652571 Thanks. I will do a make clean to ensure I have a clean environment. I imagine I didn't see the

[GitHub] apiri commented on issue #475: MINIFICPP-718: Fix issue with docker verify with docker API changes

2019-01-23 Thread GitBox
apiri commented on issue #475: MINIFICPP-718: Fix issue with docker verify with docker API changes URL: https://github.com/apache/nifi-minifi-cpp/pull/475#issuecomment-456822386 @phrocker Sorry for the false alarm. It does not seem the script pulls the latest image, so I'm assuming I

[GitHub] asfgit closed pull request #475: MINIFICPP-718: Fix issue with docker verify with docker API changes

2019-01-23 Thread GitBox
asfgit closed pull request #475: MINIFICPP-718: Fix issue with docker verify with docker API changes URL: https://github.com/apache/nifi-minifi-cpp/pull/475 This is an automated message from the Apache Git Service. To

[GitHub] thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security …

2019-01-23 Thread GitBox
thenatog commented on a change in pull request #3273: NIFI-5968 - Added the X-XSS-Protection and Strict-Transport-Security … URL: https://github.com/apache/nifi/pull/3273#discussion_r250225707 ## File path:

[GitHub] kevdoran closed pull request #3129: NIFI-5748 Fixed proxy header support to use X-Forwarded-Host instead …

2018-12-17 Thread GitBox
kevdoran closed pull request #3129: NIFI-5748 Fixed proxy header support to use X-Forwarded-Host instead … URL: https://github.com/apache/nifi/pull/3129 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] alopresto commented on issue #3220: NIFI-5898: Updated the display name for ACCESS_KEY & SECRET_KEY

2018-12-17 Thread GitBox
alopresto commented on issue #3220: NIFI-5898: Updated the display name for ACCESS_KEY & SECRET_KEY URL: https://github.com/apache/nifi/pull/3220#issuecomment-447971302 Reviewing... This is an automated message from the

  1   2   3   4   5   6   7   8   9   10   >