[GitHub] nifi issue #1497: NIFI-3454 Tests should consistently use the FileNameFilter...

2017-02-10 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/1497 Sorry, will do next time. Your Jira is different from my other apache project On February 10, 2017 at 19:10:28, Koji Kawamura (notificati...@github.com) wrote

[GitHub] nifi issue #1497: NIFI-3454 Tests should consistently use the FileNameFilter...

2017-02-10 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/1497 Will do later tonight On February 10, 2017 at 19:10:28, Koji Kawamura (notificati...@github.com) wrote: > @ottobackwards <https://github.com/ottobackwards> Sorry,

[GitHub] nifi pull request #1497: NIFI-3454 Tests should consistently use the FileNam...

2017-02-10 Thread ottobackwards
Github user ottobackwards closed the pull request at: https://github.com/apache/nifi/pull/1497 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] nifi-maven pull request #2: NIFI-3628 allow override additions for extention...

2017-03-31 Thread ottobackwards
Github user ottobackwards closed the pull request at: https://github.com/apache/nifi-maven/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] nifi-maven pull request #2: NIFI-3628 allow override additions for extention...

2017-03-20 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/nifi-maven/pull/2 NIFI-3628 allow override additions for extention and id prefixes This PR introduces the ability to change the extension name though changing the type property as well as specifying

[GitHub] nifi issue #2691: NIFI-5170 Upgrad Grok to version 0.1.9

2018-05-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2691 Thanks for the review @MikeThomsen ---

[GitHub] nifi pull request #2698: NIFI-5077 ExtractGrok support for `keep empty captu...

2018-05-14 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/nifi/pull/2698 NIFI-5077 ExtractGrok support for `keep empty captures` Support for the new option to keep empty captures. I did not add to the GrokReader because I am not sure of the effect

[GitHub] nifi issue #2672: NIFI-5145 Made MockPropertyValue.evaluateExpressionLanguag...

2018-05-14 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2672 I think making this consistent for testing is a good idea. The fact that the Mock classes in nifi can replicate the runtime behavior is very important to implementors. I think

[GitHub] nifi pull request #2699: [NIFI-5192] allow expression language in Schema Fil...

2018-05-14 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2699#discussion_r188064016 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateXml.java

[GitHub] nifi pull request #2691: NIFI-5170 Upgrad Grok to version 0.1.9

2018-05-09 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/nifi/pull/2691 NIFI-5170 Upgrad Grok to version 0.1.9 Upgrade to the new java-grok release and update for changes in the library. This includes: - Changes to the namespace from io.thekraken

[GitHub] nifi issue #2588: NIFI-5022 InvokeAWSGatewayApi processor

2018-04-28 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2588 @zenfenan any chance for a review? ---

[GitHub] nifi pull request #2691: NIFI-5170 Upgrad Grok to version 0.1.9

2018-05-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2691#discussion_r187774759 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/resources/default-grok-patterns.txt --- @@ -0,0 +1,115

[GitHub] nifi pull request #2691: NIFI-5170 Upgrad Grok to version 0.1.9

2018-05-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2691#discussion_r187774270 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java

[GitHub] nifi pull request #2691: NIFI-5170 Upgrad Grok to version 0.1.9

2018-05-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2691#discussion_r187774740 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java

[GitHub] nifi pull request #2675: NIFI-5113 Add XMLRecordSetWriter

2018-05-11 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2675#discussion_r187591727 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache

[GitHub] nifi pull request #2705: NIFI-5169 Upgrade to JSONPath 2.4

2018-05-15 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2705#discussion_r188281072 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractJsonPathProcessor.java

[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

2018-05-18 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2704 Should the tests for InvokeHTTP be updated to test with the changes? ---

[GitHub] nifi issue #2588: NIFI-5022 InvokeAWSGatewayApi processor

2018-05-18 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2588 @mattyb149 no word on that pr. @jvwing any chance you may be able to review? ---

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-05-19 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2723 This is cool, I will definitely make an aws web api version of this after it and my pr lands. I think that any rest service needs to support the options that InvokeHttp supports. Proxies

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-05-19 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2723 Don't I know it. If you want to do this as a 'series' of prs, I think you should document that in jira with tasks representing each PR and note it clearly in the pr. That will set

[GitHub] nifi issue #1955: NIFI-4136 Add a failure option to unmatch behavior options...

2018-05-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/1955 @MikeThomsen This change is not related to my pr's. It is concerned with Nifi behavior when the grok's do not match not with grok behavior itself. It is still required in as much as it ever was. ---

[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

2018-05-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2704 How will this work with the AWS components? They have proxy as well ( although there is a PR for full support ), but a different builder I think ---

[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

2018-05-16 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2704 @ijokarumawak I'm talking about passing around an HttpClientBuilder when not everyone uses that. ---

[GitHub] nifi issue #2698: NIFI-5077 ExtractGrok support for `keep empty captures`

2018-05-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2698 Thanks for the review guys ---

[GitHub] nifi pull request #2698: NIFI-5077 ExtractGrok support for `keep empty captu...

2018-05-15 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2698#discussion_r188355616 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java

[GitHub] nifi pull request #2698: NIFI-5077 ExtractGrok support for `keep empty captu...

2018-05-15 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2698#discussion_r188355650 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java

[GitHub] nifi issue #2705: NIFI-5169 Upgrade to JSONPath 2.4

2018-05-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2705 LGTM, +1 FWIW ---

[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

2018-05-21 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2704 Once I prove out my fix and update my pr, I'll guess I'll do a PR against master with that fix? ---

[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

2018-05-21 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2704 I found a bug in this in the aws implementation, I am not sure how you would see it in the other processors, I found it when bringing this code into my Gateway Api PR. The issue

[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

2018-05-21 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2704 https://issues.apache.org/jira/browse/NIFI-5220 ---

[GitHub] nifi issue #2588: NIFI-5022 InvokeAWSGatewayApi processor

2018-05-21 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2588 bump, any takers? ---

[GitHub] nifi pull request #2727: NIFI-5220 add aws abstract processor validation for...

2018-05-21 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/nifi/pull/2727 NIFI-5220 add aws abstract processor validation for proxy host and password, and tests Thank you for submitting a contribution to Apache NiFi. In order to streamline the review

[GitHub] nifi issue #2727: NIFI-5220 add aws abstract processor validation for proxy ...

2018-05-21 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2727 @MikeThomsen @ijokarumawak ---

[GitHub] nifi issue #2704: NIFI-4199: Consistent proxy support across components

2018-05-21 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2704 https://github.com/apache/nifi/pull/2727 ---

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-05-21 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2723 I almost wonder if there should be an http rest connection service ---

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-05-21 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2723 @MikeThomsen I agree. I haven't seen any conversation on it, but it seems more and more obvious, given the way things are going right? ---

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-05-21 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r189554878 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-05-21 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r189554397 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup

[GitHub] nifi issue #2723: NIFI-5214 Added REST LookupService

2018-05-21 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2723 @MikeThomsen Here are the properties exposed for configuration of InvokeHttp: ```java public static final List PROPERTIES = Collections.unmodifiableList(Arrays.asList

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190273915 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190271982 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java

[GitHub] nifi pull request #2734: NIFI-5230: Fixed NPE in InvokeScriptedProcessor on ...

2018-05-23 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2734#discussion_r190263349 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java

[GitHub] nifi pull request #2734: NIFI-5230: Fixed NPE in InvokeScriptedProcessor on ...

2018-05-23 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2734#discussion_r190267071 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-05-25 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r190990529 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-05-25 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r190990605 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java

[GitHub] nifi issue #2737: NIFI-5231 Added RecordStats processor.

2018-05-24 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2737 That makes sense, just thinking it through, and obviously I don't understand everything as well ;) I guess I never thought of provenance as including perf and stats stuff, so it seems like

[GitHub] nifi issue #2737: NIFI-5231 Added RecordStats processor.

2018-05-24 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2737 @MikeThomsen this is cool. The only thing it makes me wonder is if this kind of data can't be automatically generated and sent to a repository, almost like a new ( or actual

[GitHub] nifi issue #2737: NIFI-5231 Added RecordStats processor.

2018-05-24 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2737 prob the reader and write would have to get some context passed where they can track states or increment stats, then be configured with a 'reporting' task to send the stats from a given context to ---

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-05-24 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r190721904 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-05-24 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r190714515 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java

[GitHub] nifi pull request #2737: NIFI-5231 Added RecordStats processor.

2018-05-24 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2737#discussion_r190723484 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java

[GitHub] nifi pull request #2698: NIFI-5077 ExtractGrok support for `keep empty captu...

2018-05-15 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2698#discussion_r188354997 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java

[GitHub] nifi pull request #2734: NIFI-5230: Fixed NPE in InvokeScriptedProcessor on ...

2018-05-23 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2734#discussion_r190284675 --- Diff: nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java

[GitHub] nifi pull request #2711: NIFI-1705 - Adding AttributesToCSV processor

2018-05-23 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2711#discussion_r190291470 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java

[GitHub] nifi pull request #2748: NIFI-4272 ReplaceText support multiple captures whe...

2018-06-06 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2748#discussion_r193368464 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ReplaceText.java

[GitHub] nifi pull request #2778: NIFI-5288 Quietly convert Java arrays to Lists so t...

2018-06-09 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2778#discussion_r194239526 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongoRecord.java

[GitHub] nifi issue #2777: NIFI-5287 Made LookupRecord able to take in flowfile attri...

2018-06-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2777 Maybe there should be a `Context` interface, and there can be support for implementations that support more than one map or type of backing. I think the limitation here is using a literal Map

[GitHub] nifi issue #2777: NIFI-5287 Made LookupRecord able to take in flowfile attri...

2018-06-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2777 It may be overkill, that is true. But if you have to keep adding new functions to account for different scenarios that isn't great either and may suggest something like that would be good

[GitHub] nifi pull request #2787: NIFI-5252 - support arbitrary headers in PutEmail p...

2018-06-12 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2787#discussion_r194700389 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java --- @@ -319,6

[GitHub] nifi issue #2768: NIFI-5278: fixes JSON escaping of code parameter in Execut...

2018-06-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2768 Is there a test that should be created or updated for this change? ---

[GitHub] nifi issue #2767: NIFI-5274 avoid rollback on uncaught errors in ReplaceText

2018-06-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2767 Can you point out the recursive code you are referencing? ---

[GitHub] nifi issue #2767: NIFI-5274 avoid rollback on uncaught errors in ReplaceText

2018-06-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2767 Thanks for the info @mosermw ---

[GitHub] nifi pull request #2802: NIFI-5147 Add CalculateAttributeHash processor

2018-06-18 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/nifi/pull/2802 NIFI-5147 Add CalculateAttributeHash processor Created the new processor per jira requirements. Might need a better description or more documentation. ### For all changes

[GitHub] nifi issue #2802: NIFI-5147 Add CalculateAttributeHash processor

2018-06-18 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2802 @alopresto is this what you had in mind? ---

[GitHub] nifi pull request #2802: NIFI-5147 Add CalculateAttributeHash processor

2018-06-18 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2802#discussion_r196148072 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/CalculateAttributeHash.java

[GitHub] nifi issue #2801: NIFI-5319 Utilize NiFi Registry 0.2.0 client

2018-06-18 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2801 Np, I am watching 5319 and got excited for a minute ;) ---

[GitHub] nifi issue #2801: NIFI-5139 Utilize NiFi Registry 0.2.0 client

2018-06-18 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2801 I think you have the wrong jira ---

[GitHub] nifi issue #2777: NIFI-5287 Made LookupRecord able to take in flowfile attri...

2018-06-12 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2777 @markap14 that certainly makes sense, thanks for taking the time to respond ---

[GitHub] nifi issue #2787: NIFI-5252 - support arbitrary headers in PutEmail processo...

2018-06-15 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2787 The changes to the encoding looks good. Thanks for the contribution! +1 ---

[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2800 Yikes, sorry. ---

[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2800 This looks good, just two comments. 1. If we are going to add support for non-ascii, the test should test non-ascii, can we add that? 2. We now have a pattern of use in two places

[GitHub] nifi pull request #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2800#discussion_r195934504 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java --- @@ -320,6

[GitHub] nifi pull request #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2800#discussion_r195934550 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java

[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2800 +1 LGTM, mvn install and contrib-check pass, use of MineType utility per best practices. ---

[GitHub] nifi pull request #2588: NIFI-5022 InvokeAWSGatewayApi processor

2018-06-11 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2588#discussion_r194368856 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/wag/client/Validate.java

[GitHub] nifi pull request #2588: NIFI-5022 InvokeAWSGatewayApi processor

2018-06-11 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2588#discussion_r194380548 --- Diff: nifi-nar-bundles/nifi-aws-bundle/nifi-aws-abstract-processors/src/main/java/org/apache/nifi/processors/aws/wag/client

[GitHub] nifi issue #2588: NIFI-5022 InvokeAWSGatewayApi processor

2018-06-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2588 @joewitt I added the headers because the code was already apache lic. in the project, I thought that would be the proper thing to do. I ( possibly or probably wrongly ) thought

[GitHub] nifi issue #2588: NIFI-5022 InvokeAWSGatewayApi processor

2018-06-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2588 Do I need to add ratcheck exceptions if I remove the headers? ---

[GitHub] nifi issue #2588: NIFI-5022 InvokeAWSGatewayApi processor

2018-06-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2588 Thanks @joewitt for clearing that up. I'll get right to it. ---

[GitHub] nifi issue #2588: NIFI-5022 InvokeAWSGatewayApi processor

2018-06-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2588 @joewitt requested changes are in ---

[GitHub] nifi issue #2588: NIFI-5022 InvokeAWSGatewayApi processor

2018-06-11 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2588 Thanks everybody! ---

[GitHub] nifi pull request #2748: NIFI-4272 support multiple captures when el is pres...

2018-05-30 Thread ottobackwards
GitHub user ottobackwards opened a pull request: https://github.com/apache/nifi/pull/2748 NIFI-4272 support multiple captures when el is present From the Jira Statement: ``` I am using the ReplaceText processor to take a string input (example:   {"name&qu

[GitHub] nifi issue #2747: NIFI-5249 Dockerfile enhancements

2018-05-31 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2747 Can you add explicit steps to test and verify, for those of use who don't work with docker as much? ---

[GitHub] nifi issue #2747: NIFI-5249 Dockerfile enhancements

2018-05-31 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2747 Thanks, I'd like to try this and help with the review ---

[GitHub] nifi issue #2742: NIFI-5244 Fixed a bug in MockSchemaRegistry that prevented...

2018-05-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2742 +1 looks good to me ---

[GitHub] nifi pull request #2723: NIFI-5214 Added REST LookupService

2018-06-04 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2723#discussion_r192722395 --- Diff: nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup

[GitHub] nifi issue #2747: NIFI-5249 Dockerfile enhancements

2018-06-01 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2747 So to test this? - mvn package - mvn package -P docker from nifi-docker - ??? - docker run --rm -ti --entrypoint /bin/bash apache/nifi -c "env | grep NIFI" ? from nifi-

[GitHub] nifi issue #2747: NIFI-5249 Dockerfile enhancements

2018-06-01 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2747 +1 fwiw|lgtm. Ran the above steps to build and test the image from the maven snapshots ( not built locally ). Everything ran fine. Your integration test is awesome. I'm totally

[GitHub] nifi pull request #2760: NIFI-5266: Sanitize ES parameters in PutElasticsear...

2018-06-05 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2760#discussion_r193132253 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2760: NIFI-5266: Sanitize ES parameters in PutElasticsear...

2018-06-05 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2760#discussion_r193132823 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2760: NIFI-5266: Sanitize ES parameters in PutElasticsear...

2018-06-05 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2760#discussion_r193133584 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2760: NIFI-5266: Sanitize ES parameters in PutElasticsear...

2018-06-05 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2760#discussion_r193133140 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi issue #2588: NIFI-5022 InvokeAWSGatewayApi processor

2018-06-05 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2588 I can provide the reviewers with access to my PETSTORE endpoint for testing and we can work out how not to overload it, if that helps get this going ---

[GitHub] nifi issue #2760: NIFI-5266: Sanitize ES parameters in PutElasticsearchHttp ...

2018-06-05 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2760 +1 (non-binding), contrib-check build looks good, tests updated. ---

[GitHub] nifi pull request #2760: NIFI-5266: Sanitize ES parameters in PutElasticsear...

2018-06-05 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2760#discussion_r193183815 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2760: NIFI-5266: Sanitize ES parameters in PutElasticsear...

2018-06-05 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2760#discussion_r193189510 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch

[GitHub] nifi pull request #2748: NIFI-4272 ReplaceText support multiple captures whe...

2018-06-06 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2748#discussion_r193428577 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java

[GitHub] nifi pull request #2748: NIFI-4272 ReplaceText support multiple captures whe...

2018-06-06 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2748#discussion_r193423188 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java

[GitHub] nifi pull request #2748: NIFI-4272 ReplaceText support multiple captures whe...

2018-06-06 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2748#discussion_r193371373 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java

[GitHub] nifi pull request #2748: NIFI-4272 ReplaceText support multiple captures whe...

2018-06-06 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2748#discussion_r193422077 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestReplaceText.java

  1   2   3   4   >