GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/1497
NIFI-3454 Tests should consistently use the FileNameFilter when reading
file names from directories
Tests that work with getting files from directories ( either doing listings
or building
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/1497
Sorry, will do next time. Your Jira is different from my other apache
project
On February 10, 2017 at 19:10:28, Koji Kawamura (notificati...@github.com)
wrote
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/1497
Will do later tonight
On February 10, 2017 at 19:10:28, Koji Kawamura (notificati...@github.com)
wrote:
> @ottobackwards <https://github.com/ottobackwards> Sorry,
Github user ottobackwards closed the pull request at:
https://github.com/apache/nifi/pull/1497
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi-maven/pull/2
NIFI-3628 allow override additions for extention and id prefixes
This PR introduces the ability to change the extension name though changing
the type property as well as specifying the
Github user ottobackwards closed the pull request at:
https://github.com/apache/nifi-maven/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2598
Are there any tests for this that need updating?
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2601
NIFI-3576 Support for QueryInfo relationship, useful for nohit queries
This pr adds a new relationship, and a property/strategy for when it is
used.
The new relationship has an empty flow
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2601
I apologize, I had thought I ran contrib-check, but I obviously didn't
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r178637480
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2601
Added checkstyle fixes
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r178821673
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r178822510
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r178822326
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r178839932
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r179217708
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2609
Should there be a test for just the INSERT mode that corresponds to the
problem too?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2609
I apologize, I miss read it as a test for one thing, not multiple. I
missed the top part. Please excuse me
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2609
mvn install with contrib-check runs fine, tests look good.
+1 ( fwiw)
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2617
Looks good to me
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2016
in https://github.com/apache/nifi/pull/2588 I have done this as well, but
only in my processor ( scope ). I would like to see this land. What can be
done to move this forward?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r180783317
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2517
If you are building and skipping the tests use -DskipTests=true. You can
also do to do at least one mvn install run as well so that your local repo has
everything.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
@MikeThomsen @pvillard31 @mattyb149 @mans2singh Anyone up for a code review?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
https://docs.aws.amazon.com/apigateway/latest/developerguide/api-gateway-create-api-from-example.html
If you can do this you can test with the pet store sample
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2630
It looks like the downloads are taking so long in travis that it is filling
the log and causing the build to be terminated.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2517
Are there best practices for handling paging? I think the ES processors
handle this differently. Does it matter?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2517
My comment is more about the way you work with the ES vs. the Solr
processors and if there is or should be an expectation that there is some
commonality between them. Like how this relates to
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2634
Is there a test to go along with this?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2517
@JohannesDaniel If there are no results from a page request, does that mean
there is no output? I ask because I have a PR for that use case with
QueryElasticsearchHttp.
https://github.com
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2517
If you are building Nifi, and need to get things working after merging in
the new version poms, you can do a mvn clean install -DskipTests and that
should populate your local repo with the
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2517
how are you building? Like what command line?
if you are using -Dmaven.test.skip=true you will have this problem
if you want to skip tests use -DskipTests
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2601
@MikeThomsen This isn't my use case. I am just helping with the work.
Please refer to the jira
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2601
bump
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r182499545
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r182582965
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r182592328
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/test/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r183427371
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r183461688
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2601#discussion_r183491100
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-processors/src/main/java/org/apache/nifi/processors/elasticsearch
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2601
Thanks for the review time!
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2016
@trixpan can you de-conflict?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
@zenfenan any chance for a review?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2668#discussion_r185276958
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2668#discussion_r185277171
--- Diff:
nifi-nar-bundles/nifi-extension-utils/nifi-hadoop-utils/src/main/java/org/apache/nifi/processors/hadoop/AbstractHadoopProcessor.java
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2668
Is there a test case with the original ML user's issue that can have a test
done? What would also be nice if these things that you changed had a 'report'
method, kind of lik
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
It would be better if we would just use RPGreen's maven dep instead off
bringing in the classes. I have a pr against his repo to upgrade to the same
aws package we use. When that is take
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
https://github.com/rpgreen/apigateway-generic-java-sdk/pull/8
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2691
NIFI-5170 Upgrad Grok to version 0.1.9
Upgrade to the new java-grok release and update for changes in the library.
This includes:
- Changes to the namespace from io.thekraken to
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2675#discussion_r187591727
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/main/java/org/apache
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2691#discussion_r187774270
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2691#discussion_r187774740
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2691#discussion_r187774759
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/resources/default-grok-patterns.txt
---
@@ -0,0 +1,115
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2691
Thanks for the review @MikeThomsen
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2672
I think making this consistent for testing is a good idea. The fact that
the Mock classes in nifi can replicate the runtime behavior is very important
to implementors.
I think that
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2698
NIFI-5077 ExtractGrok support for `keep empty captures`
Support for the new option to keep empty captures. I did not add to the
GrokReader because I am not sure of the effect on
the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2699#discussion_r188064016
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ValidateXml.java
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/1955
@MikeThomsen This change is not related to my pr's. It is concerned with
Nifi behavior when the grok's do not match not with grok behavior itself. It
is still required in as much
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2704
How will this work with the AWS components? They have proxy as well (
although there is a PR for full support ), but a different builder I think
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2705#discussion_r188281072
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractJsonPathProcessor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2698#discussion_r188354997
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2698#discussion_r188355616
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2698#discussion_r188355650
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ExtractGrok.java
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2698
Thanks for the review guys
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2705
LGTM, +1 FWIW
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2704
@ijokarumawak I'm talking about passing around an HttpClientBuilder when
not everyone uses that.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
@mattyb149 no word on that pr. @jvwing any chance you may be able to
review?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2704
Should the tests for InvokeHTTP be updated to test with the changes?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2723
This is cool, I will definitely make an aws web api version of this after
it and my pr lands.
I think that any rest service needs to support the options that InvokeHttp
supports. Proxies
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2723
Don't I know it. If you want to do this as a 'series' of prs, I think you
should document that in jira with tasks representing each PR and note it
clearly in the pr.
Th
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2723#discussion_r189554878
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2723#discussion_r189554397
--- Diff:
nifi-nar-bundles/nifi-standard-services/nifi-lookup-services-bundle/nifi-lookup-services/src/main/java/org/apache/nifi/lookup
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2723
@MikeThomsen
Here are the properties exposed for configuration of InvokeHttp:
```java
public static final List PROPERTIES =
Collections.unmodifiableList(Arrays.asList
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2723
I almost wonder if there should be an http rest connection service
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2723
@MikeThomsen I agree. I haven't seen any conversation on it, but it seems
more and more obvious, given the way things are going right?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2704
I found a bug in this in the aws implementation, I am not sure how you
would see it in the other processors, I found it when bringing this code into
my Gateway Api PR.
The issue is
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2704
Once I prove out my fix and update my pr, I'll guess I'll do a PR against
master with that fix?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2704
https://issues.apache.org/jira/browse/NIFI-5220
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2727
NIFI-5220 add aws abstract processor validation for proxy host and
password, and tests
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2727
@MikeThomsen @ijokarumawak
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2704
https://github.com/apache/nifi/pull/2727
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2588
bump, any takers?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2734#discussion_r190263349
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2734#discussion_r190267071
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2711#discussion_r190271982
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2711#discussion_r190273915
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2734#discussion_r190284675
--- Diff:
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/src/main/java/org/apache/nifi/processors/script/InvokeScriptedProcessor.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2711#discussion_r190291470
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AttributesToCSV.java
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2737
@MikeThomsen this is cool.
The only thing it makes me wonder is if this kind of data can't be
automatically generated and sent to a repository, almost like a new ( or a
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2737
prob the reader and write would have to get some context passed where they
can track states or increment stats, then be configured with a 'reporting' task
to send the stats from a giv
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2737
That makes sense, just thinking it through, and obviously I don't
understand everything as well ;)
I guess I never thought of provenance as including perf and stats stuff, so
it seems
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2737#discussion_r190721904
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2737#discussion_r190714515
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2737#discussion_r190723484
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2737#discussion_r190990529
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2737#discussion_r190990605
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/RecordStats.java
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2742
So the issue was passing the optional instead of the value and never
finding the schema?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2742
+1 looks good to me
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/nifi/pull/2748
NIFI-4272 support multiple captures when el is present
From the Jira Statement:
```
I am using the ReplaceText processor to take a string input (example:ââ
{"name&qu
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2747
Can you add explicit steps to test and verify, for those of use who don't
work with docker as much?
---
1 - 100 of 347 matches
Mail list logo
