[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r440097068 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -204,52 +418,78 @@ void TailFile::parseStateFileLine(char *buf) { }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439433613 ## File path: extensions/standard-processors/tests/unit/TailFileTests.cpp ## @@ -652,46 +872,606 @@

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439393349 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -335,170 +563,210 @@ bool TailFile::storeState(const std::shared_ptr&

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439393096 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -40,60 +35,283 @@ #include #include +#include "io/CRCStream.h"

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439392365 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -40,60 +35,283 @@ #include #include +#include "io/CRCStream.h"

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439392365 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -40,60 +35,283 @@ #include #include +#include "io/CRCStream.h"

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439390975 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -40,60 +35,283 @@ #include #include +#include "io/CRCStream.h"

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439391205 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -40,60 +35,283 @@ #include #include +#include "io/CRCStream.h"

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439390114 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -40,60 +35,283 @@ #include #include +#include "io/CRCStream.h"

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439388761 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -335,170 +563,210 @@ bool TailFile::storeState(const std::shared_ptr&

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439385766 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -335,170 +563,210 @@ bool TailFile::storeState(const std::shared_ptr&

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439386010 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -335,170 +563,210 @@ bool TailFile::storeState(const std::shared_ptr&

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439385828 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -335,170 +563,210 @@ bool TailFile::storeState(const std::shared_ptr&

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439385627 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -204,52 +418,78 @@ void TailFile::parseStateFileLine(char *buf) { }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439385943 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -335,170 +563,210 @@ bool TailFile::storeState(const std::shared_ptr&

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439385438 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -40,60 +35,283 @@ #include #include +#include "io/CRCStream.h"

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439384441 ## File path: libminifi/test/unit/StringUtilsTests.cpp ## @@ -338,3 +338,30 @@ TEST_CASE("TestStringUtils::testJoinPackNegative", "[test

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439382655 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -40,60 +35,283 @@ #include #include +#include "io/CRCStream.h"

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439382107 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -40,60 +35,283 @@ #include #include +#include "io/CRCStream.h"

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r439379651 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -17,19 +17,14 @@ * See the License for the specific language

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r438233905 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -469,6 +470,14 @@ void ProcessSession::import(std::string source, const

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r438229933 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -403,102 +403,141 @@ void TailFile::onTrigger(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r436862565 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -403,102 +435,136 @@ void TailFile::onTrigger(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435329784 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -204,52 +230,65 @@ void TailFile::parseStateFileLine(char *buf) { }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435325700 ## File path: extensions/standard-processors/tests/unit/TailFileTests.cpp ## @@ -47,7 +47,33 @@ static std::string NEWLINE_FILE = "" // NOLINT

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435325310 ## File path: libminifi/test/unit/FileUtilsTests.cpp ## @@ -178,3 +179,157 @@ TEST_CASE("TestFileUtils::getFullPath", "[TestGetFullPath]") {

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435323181 ## File path: libminifi/src/utils/file/FileUtils.cpp ## @@ -0,0 +1,58 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435322591 ## File path: libminifi/src/utils/file/FileUtils.cpp ## @@ -0,0 +1,58 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435321877 ## File path: libminifi/src/utils/RegexUtils.cpp ## @@ -158,6 +158,16 @@ const std::vector& Regex::getResult() const { return results_; }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435321877 ## File path: libminifi/src/utils/RegexUtils.cpp ## @@ -158,6 +158,16 @@ const std::vector& Regex::getResult() const { return results_; }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435320644 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -469,6 +470,14 @@ void ProcessSession::import(std::string source, const

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435320821 ## File path: libminifi/src/core/ProcessSession.cpp ## @@ -574,15 +589,16 @@ void ProcessSession::import(const std::string& source,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435319933 ## File path: extensions/standard-processors/processors/TailFile.h ## @@ -33,38 +33,40 @@ namespace nifi { namespace minifi { namespace

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435318031 ## File path: libminifi/include/io/CRCStream.h ## @@ -45,6 +45,7 @@ class CRCStream : public BaseStream { * it will exceed our lifetime.

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435316889 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -403,102 +435,136 @@ void TailFile::onTrigger(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435311535 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -403,102 +435,136 @@ void TailFile::onTrigger(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435310291 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -403,102 +435,136 @@ void TailFile::onTrigger(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435309190 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -204,52 +249,78 @@ void TailFile::parseStateFileLine(char *buf) { }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435308461 ## File path: libminifi/src/utils/file/PathUtils.cpp ## @@ -84,6 +108,19 @@ std::string PathUtils::getFullPath(const std::string& path) { #endif

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435308929 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -335,65 +387,45 @@ bool TailFile::storeState(const std::shared_ptr&

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435306719 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -204,52 +249,78 @@ void TailFile::parseStateFileLine(char *buf) { }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r435306612 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -58,42 +47,108 @@ #define S_ISDIR(mode) (((mode) & S_IFMT) ==

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r429847276 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -403,102 +403,141 @@ void TailFile::onTrigger(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r429359617 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -403,102 +403,141 @@ void TailFile::onTrigger(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r429328320 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -120,56 +158,42 @@ void TailFile::onSchedule(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r429326546 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -204,52 +230,65 @@ void TailFile::parseStateFileLine(char *buf) { }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r429326546 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -204,52 +230,65 @@ void TailFile::parseStateFileLine(char *buf) { }

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r429323720 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -120,56 +158,42 @@ void TailFile::onSchedule(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r429323576 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -120,56 +158,42 @@ void TailFile::onSchedule(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r428757113 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -120,56 +158,42 @@ void TailFile::onSchedule(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r428755248 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -120,56 +158,42 @@ void TailFile::onSchedule(const std::shared_ptr ,

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #791: MINIFICPP-1177 Improvements to the TailFile processor

fgerlits commented on a change in pull request #791: URL: https://github.com/apache/nifi-minifi-cpp/pull/791#discussion_r428752891 ## File path: extensions/standard-processors/processors/TailFile.cpp ## @@ -120,56 +158,42 @@ void TailFile::onSchedule(const std::shared_ptr ,