[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2020-02-03 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r374277101 ## File path: nanofi/include/coap/c2payload.h ## @@ -0,0 +1,95 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2020-02-03 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r374274196 ## File path: nanofi/include/coap/c2payload.h ## @@ -0,0 +1,95 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2020-01-27 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r371380715 ## File path: nanofi/src/coap/c2protocol.c ## @@ -0,0 +1,403 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2020-01-27 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r371381093 ## File path: nanofi/src/coap/c2protocol.c ## @@ -0,0 +1,403 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-05 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r354605574 ## File path: extensions/coap/nanofi/coap_server.c ## @@ -25,6 +25,7 @@ CoapServerContext * const

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-05 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r354592916 ## File path: nanofi/ecu/c2_client.c ## @@ -0,0 +1,235 @@ +#ifdef __cplusplus +extern "C" { +#endif

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-05 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r354560956 ## File path: nanofi/ecu/c2_client.c ## @@ -0,0 +1,235 @@ +#ifdef __cplusplus +extern "C" { +#endif

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-05 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r354560732 ## File path: nanofi/ecu/c2_client.c ## @@ -0,0 +1,235 @@ +#ifdef __cplusplus +extern "C" { +#endif

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-05 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r354553542 ## File path: extensions/coap/nanofi/coap_functions.c ## @@ -105,12 +117,18 @@ int

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-05 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r354408834 ## File path: nanofi/ecu/coap_server.c ## @@ -0,0 +1,138 @@ +#include Review comment: This file

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-04 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r354092593 ## File path: nanofi/src/processors/file_input.c ## @@ -0,0 +1,406 @@ +/* + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-04 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r354092654 ## File path: nanofi/src/processors/file_input.c ## @@ -0,0 +1,406 @@ +/* + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-04 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r353996883 ## File path: nanofi/src/coap/c2agent.c ## @@ -0,0 +1,481 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-04 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r353986510 ## File path: nanofi/src/c2_api/c2api.c ## @@ -0,0 +1,180 @@ +/* + * Licensed to the Apache Software

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-04 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r353959353 ## File path: nanofi/src/processors/file_input.c ## @@ -0,0 +1,406 @@ +/* + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-04 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r353847896 ## File path: nanofi/src/coap/c2protocol.c ## @@ -0,0 +1,1204 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-04 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r353847448 ## File path: nanofi/src/coap/c2protocol.c ## @@ -0,0 +1,1204 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-04 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r353846456 ## File path: nanofi/src/coap/c2protocol.c ## @@ -0,0 +1,1204 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-12-03 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r353292604 ## File path: nanofi/src/ecu_api/ecuapi.c ## @@ -0,0 +1,835 @@ +/** Review comment: Could you

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-26 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r350955688 ## File path: nanofi/src/processors/file_input.c ## @@ -0,0 +1,406 @@ +/* + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-26 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r350932411 ## File path: nanofi/src/coap/c2agent.c ## @@ -0,0 +1,481 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-26 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r350929531 ## File path: nanofi/src/ecu_api/ecuapi.c ## @@ -0,0 +1,835 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-26 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r350929190 ## File path: nanofi/CMakeLists.txt ## @@ -23,32 +23,67 @@ IF(POLICY CMP0048) CMAKE_POLICY(SET

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-26 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r350929190 ## File path: nanofi/CMakeLists.txt ## @@ -23,32 +23,67 @@ IF(POLICY CMP0048) CMAKE_POLICY(SET

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-26 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r350915606 ## File path: nanofi/src/coap/c2protocol.c ## @@ -0,0 +1,1204 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-26 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r350914362 ## File path: nanofi/src/coap/c2protocol.c ## @@ -0,0 +1,1204 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-26 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r350903892 ## File path: nanofi/src/coap/c2protocol.c ## @@ -0,0 +1,1204 @@ +/** + * + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-26 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r350902736 ## File path: nanofi/CMakeLists.txt ## @@ -23,32 +23,67 @@ IF(POLICY CMP0048) CMAKE_POLICY(SET

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-26 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r350899685 ## File path: CMakeLists.txt ## @@ -469,7 +467,7 @@ if (ENABLE_ALL OR ENABLE_GPS)

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-07 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r343746873 ## File path: nanofi/src/processors/site2site_output.c ## @@ -0,0 +1,169 @@ +/* + * Licensed to the

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-07 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r343746498 ## File path: nanofi/include/ecu_api/ecuapi.h ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-07 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r343740056 ## File path: nanofi/src/processors/site2site_output.c ## @@ -0,0 +1,169 @@ +/* + * Licensed to the

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-07 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r343740696 ## File path: nanofi/include/c2_api/c2api.h ## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-07 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r343739651 ## File path: nanofi/include/ecu_api/ecuapi.h ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-07 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r343740056 ## File path: nanofi/src/processors/site2site_output.c ## @@ -0,0 +1,169 @@ +/* + * Licensed to the

[GitHub] [nifi-minifi-cpp] msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration.

2019-11-07 Thread GitBox
msharee9 commented on a change in pull request #674: Minificpp 1007 - ECU C2 integration. URL: https://github.com/apache/nifi-minifi-cpp/pull/674#discussion_r343739651 ## File path: nanofi/include/ecu_api/ecuapi.h ## @@ -0,0 +1,105 @@ +/* + * Licensed to the Apache