Github user minifirocks commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/295
@phrocker so if that's the case, we can remove the below meta info when the
meta info container was constructed and just provide the framework, if user
want to use that, they can create
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/295
@minifirocks per your comment twelve days ago you mentioned that you didn't
want to use a processor because you're putting this on every flow file. That's
pretty reasonable, but why do we n
Github user minifirocks commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/295
@phrocker please let me know whether you have more comments. Thanks.
---
Github user minifirocks commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/295
@phrocker please review
change shared_ptr to unique ptr
use agent.version and flow.version for meta info
---
Github user minifirocks commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/295
@phrocker the reason that i do not want to use processor is that meta info
below to flow which is generated by the any processor. we provide a framework
let user to write their own meta
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/295
I've been thinking more about this @minifirocks . I'm curious about the
inception of this idea. I see that there is coupling amongst components that
probably don't have a need to know for t
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/295
@minifirocks that script is used with cmake to provide that information in
a codified, statically defined way, to the code base. It's built at compile
time and provides the agent with the i
Github user minifirocks commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/295
@phrocker Thanks for the review. the PR is not only for version, it provide
a flexible framework to add other meta info also. also in the cmake file, we
already specify major/minor/patch
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/295
`#ifndef AGENT_BUILD_H
#define AGENT_BUILD_H
#include
namespace org {
namespace apache {
namespace nifi {
namespace minifi {
class AgentBuild {