Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/296
---
Github user achristianson commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/296#discussion_r180521508
--- Diff: extensions/http-curl/CMakeLists.txt ---
@@ -42,9 +42,9 @@ if(CMAKE_THREAD_LIBS_INIT)
endif()
if (CURL_FOUND)
-
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/296#discussion_r180264700
--- Diff: main/CMakeLists.txt ---
@@ -66,7 +66,7 @@ else ()
target_link_libraries (minifiexe -Wl,--whole-archive minifi
-Wl,--no-whole-arch
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/296#discussion_r180265512
--- Diff: extensions/http-curl/CMakeLists.txt ---
@@ -42,9 +42,9 @@ if(CMAKE_THREAD_LIBS_INIT)
endif()
if (CURL_FOUND)
-
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/296#discussion_r180264480
--- Diff: CMakeLists.txt ---
@@ -117,6 +118,49 @@ else ()
message( FATAL_ERROR "OpenSSL was not found. Please install OpenSSL" )
endif (
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/296
MINIFICPP-449 Add cURL external project build with static linking
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the
