Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2162
Hi @patricker
I have rebased your PR against the latest master and fixed the unit test
failures. And created another PR based on yours. Would you take a look on this?
#2618 Would you cl
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2162
@patricker Thanks for the update, and sorry for my delayed response. I just
got the chance to review this today.
This has a conflict with #2504 . I can fix compilation level conflict by
Github user ijokarumawak commented on the issue:
https://github.com/apache/nifi/pull/2162
@patricker Thanks for the updates! It mostly looks good to me. Did you
notice my latest comment?
https://github.com/apache/nifi/pull/2162#discussion_r166504892
I forgot to mention you from
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/2162
@ijokarumawak Updated.
---
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/2162
Yes, sorry for the delay, got swamped
---
Github user patricker commented on the issue:
https://github.com/apache/nifi/pull/2162
@mattyb149 Can you take another look? I think I've addressed all of your
concerns.
---
