Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2607
@mcgilman this is a great feature that I think will make a lot of people's
lives easier. Thanks for updating the UI to support this! Also thanks to
@scottyaslan and @moranr for your feedback and test
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/2607
Looks good!
---
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/2607
Thanks @mcgilman, looks good. Could go either way on the Terminate v
Terminate threads menu, so unless anyone has a strong opinion for adding
"threads," I understand your logic for not making the chang
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/2607
@moranr @scottyaslan @markap14 I've addressed the PR feedback above. Please
have a look at my most recent commit. A couple notes:
- I also found and addressed an issue when replicating the te
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2607
After testing, all looks good to me. I'm a +1 to merge if you want to make
those format changes suggested by Rob and optionally the class refactoring that
I suggested in the FlowController. Thanks! T
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/2607
+1 to @moranr's suggestion for formatting, also.
---
Github user scottyaslan commented on the issue:
https://github.com/apache/nifi/pull/2607
@mcgilman I have reviewed the client side code and I am a +1 to merge once
you have made the updates to the messages as @moranr suggested. Thanks for this
contribution!
---
Github user moranr commented on the issue:
https://github.com/apache/nifi/pull/2607
@mcgilman , I was thinking about some suggestions to the formatting and
tooltip labeling used on these. I think we're using the '/' (forward slash)
inconsistently which could be a bit confusing.
