Github user markobean commented on the issue:
https://github.com/apache/nifi/pull/2617
Changes committed to master. Closing PR.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2617
That's correct @markobean - it has been merged into master with
274ed46d923e7d080b57ed121596b4ecfa997a2c.
---
Github user markobean commented on the issue:
https://github.com/apache/nifi/pull/2617
So, does this PR need to be manually closed with the "Close and comment"
button?
---
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2617
@pvillard31 Thanks. I finally figured it out after doing a second one today.
---
Github user pvillard31 commented on the issue:
https://github.com/apache/nifi/pull/2617
@MikeThomsen - just fyi, while merging a PR it's highly recommended to
amend the commit message to include the magic words that will automatically
close the github PR. The commands I usually execut
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2617
@markobean You close the PR now. I merged the change.
---
Github user markobean commented on the issue:
https://github.com/apache/nifi/pull/2617
Updated to use assertTrue and assertFalse. I had simply borrowed
assertEquals from the previous unit test. So, while updating, I updated that
test to use assertTrue as well. Commit, squashed and pus
Github user ottobackwards commented on the issue:
https://github.com/apache/nifi/pull/2617
Looks good to me
---
