[jira] [Commented] (NIFI-4889) Logout not working properly with OIDC
[ https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545244#comment-16545244 ] ASF GitHub Bot commented on NIFI-4889: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2830 Looks good @Trojan295. Thanks! This has been merged to master. > Logout not working properly with OIDC > - > > Key: NIFI-4889 > URL: https://issues.apache.org/jira/browse/NIFI-4889 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) >Reporter: Federico Michele Facca >Priority: Critical > > Click on logout, i would expect to logout and getting redirect to the auth > page. But given that the session is not closed on the oauth provider, i get > logged in again. > I suppose the solution would be to invoke the end_session_endpoint provided > in the openid discovery configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4889) Logout not working properly with OIDC
[ https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545243#comment-16545243 ] ASF subversion and git services commented on NIFI-4889: --- Commit ec7f1316021841a67303a56218eb61d5828eda2e in nifi's branch refs/heads/master from [~trojan295] [ https://git-wip-us.apache.org/repos/asf?p=nifi.git;h=ec7f131 ] NIFI-4889: Logout not working properly with OIDC - Redirect user agent to end session endpoint on the OIDC provider - This closes #2830 > Logout not working properly with OIDC > - > > Key: NIFI-4889 > URL: https://issues.apache.org/jira/browse/NIFI-4889 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) >Reporter: Federico Michele Facca >Priority: Critical > > Click on logout, i would expect to logout and getting redirect to the auth > page. But given that the session is not closed on the oauth provider, i get > logged in again. > I suppose the solution would be to invoke the end_session_endpoint provided > in the openid discovery configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4889) Logout not working properly with OIDC
[ https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545245#comment-16545245 ] ASF GitHub Bot commented on NIFI-4889: -- Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2830 > Logout not working properly with OIDC > - > > Key: NIFI-4889 > URL: https://issues.apache.org/jira/browse/NIFI-4889 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) >Reporter: Federico Michele Facca >Priority: Critical > > Click on logout, i would expect to logout and getting redirect to the auth > page. But given that the session is not closed on the oauth provider, i get > logged in again. > I suppose the solution would be to invoke the end_session_endpoint provided > in the openid discovery configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4889) Logout not working properly with OIDC
[ https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16544275#comment-16544275 ] ASF GitHub Bot commented on NIFI-4889: -- Github user Trojan295 commented on the issue: https://github.com/apache/nifi/pull/2830 I added a fallback to simply redirect back to NiFi in case the end session endpoint isn't present. Tricky thing is, that NiFi automatically starts an login attempt, when an unauthenticated user accesses NiFi. In case of an IDP like Keycloak, which has the end session endpoint, then after logout the user is redirected back to Keycloaks login page. In case of Google OpenID he gets redirected to them and the SSO mechanism logs the user again... > Logout not working properly with OIDC > - > > Key: NIFI-4889 > URL: https://issues.apache.org/jira/browse/NIFI-4889 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) >Reporter: Federico Michele Facca >Priority: Critical > > Click on logout, i would expect to logout and getting redirect to the auth > page. But given that the session is not closed on the oauth provider, i get > logged in again. > I suppose the solution would be to invoke the end_session_endpoint provided > in the openid discovery configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4889) Logout not working properly with OIDC
[ https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543572#comment-16543572 ] ASF GitHub Bot commented on NIFI-4889: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2830 @Trojan295 Thanks for the PR! The code looks good but I ran into an issue when attempting to log out. Despite being a required field in the openid spec [1], it appears that at least in practice [2] the `end_session_endpoint` field is not guaranteed to be present. I think we may need to account for this possibility in the logout endpoint. [1] https://openid.net/specs/openid-connect-session-1_0.html#OPMetadata [2] https://accounts.google.com/.well-known/openid-configuration > Logout not working properly with OIDC > - > > Key: NIFI-4889 > URL: https://issues.apache.org/jira/browse/NIFI-4889 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) >Reporter: Federico Michele Facca >Priority: Critical > > Click on logout, i would expect to logout and getting redirect to the auth > page. But given that the session is not closed on the oauth provider, i get > logged in again. > I suppose the solution would be to invoke the end_session_endpoint provided > in the openid discovery configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4889) Logout not working properly with OIDC
[ https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16543388#comment-16543388 ] ASF GitHub Bot commented on NIFI-4889: -- Github user mcgilman commented on the issue: https://github.com/apache/nifi/pull/2830 Will review... > Logout not working properly with OIDC > - > > Key: NIFI-4889 > URL: https://issues.apache.org/jira/browse/NIFI-4889 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) >Reporter: Federico Michele Facca >Priority: Critical > > Click on logout, i would expect to logout and getting redirect to the auth > page. But given that the session is not closed on the oauth provider, i get > logged in again. > I suppose the solution would be to invoke the end_session_endpoint provided > in the openid discovery configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4889) Logout not working properly with OIDC
[ https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16542118#comment-16542118 ] ASF GitHub Bot commented on NIFI-4889: -- Github user Trojan295 commented on the issue: https://github.com/apache/nifi/pull/2830 Rebased from current master > Logout not working properly with OIDC > - > > Key: NIFI-4889 > URL: https://issues.apache.org/jira/browse/NIFI-4889 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) >Reporter: Federico Michele Facca >Priority: Critical > > Click on logout, i would expect to logout and getting redirect to the auth > page. But given that the session is not closed on the oauth provider, i get > logged in again. > I suppose the solution would be to invoke the end_session_endpoint provided > in the openid discovery configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4889) Logout not working properly with OIDC
[ https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541566#comment-16541566 ] ASF GitHub Bot commented on NIFI-4889: -- Github user pvillard31 commented on the issue: https://github.com/apache/nifi/pull/2830 @Trojan295 - NiFi 1.7.0 has been released, I'd recommend you to rebase against master (so that all the pom files are updated to 1.8.0-SNAPSHOT) and do a full build to have a clean local maven repo (you shouldn't have 1.7.0-SNAPSHOT anymore). All the Travis builds are OK for your PR so it sounds OK to me. Regarding the PR itself, I'll let someone like @mcgilman having a look ;) > Logout not working properly with OIDC > - > > Key: NIFI-4889 > URL: https://issues.apache.org/jira/browse/NIFI-4889 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) >Reporter: Federico Michele Facca >Priority: Critical > > Click on logout, i would expect to logout and getting redirect to the auth > page. But given that the session is not closed on the oauth provider, i get > logged in again. > I suppose the solution would be to invoke the end_session_endpoint provided > in the openid discovery configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4889) Logout not working properly with OIDC
[ https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541470#comment-16541470 ] ASF GitHub Bot commented on NIFI-4889: -- Github user Trojan295 commented on the issue: https://github.com/apache/nifi/pull/2830 When running the test suite locally I have problems with an dependency: ``` [ERROR] Failed to execute goal on project nifi-hive-processors: Could not resolve dependencies for project org.apache.nifi:nifi-hive-processors:jar:1.7.0-SNAPSHOT: Could not find artifact org.pentaho:pentaho-aggdesigner-algorithm:jar:5.1.5-jhyde in central (https://repo1.maven.org/maven2) -> [Help 1] ``` I had to add an additional repository to make it work, although I didn't commit it: ``` spring-plugins http://repo.spring.io/plugins-release false true ``` Could it be, that the artifact was in Maven Central and was moved, but the CI on Travis as it cached in the local repo? > Logout not working properly with OIDC > - > > Key: NIFI-4889 > URL: https://issues.apache.org/jira/browse/NIFI-4889 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) >Reporter: Federico Michele Facca >Priority: Critical > > Click on logout, i would expect to logout and getting redirect to the auth > page. But given that the session is not closed on the oauth provider, i get > logged in again. > I suppose the solution would be to invoke the end_session_endpoint provided > in the openid discovery configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4889) Logout not working properly with OIDC
[ https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16541438#comment-16541438 ] ASF GitHub Bot commented on NIFI-4889: -- GitHub user Trojan295 reopened a pull request: https://github.com/apache/nifi/pull/2830 NIFI-4889: Logout not working properly with OIDC - Redirect user agent to end session endpoint on the OIDC provider Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Trojan295/nifi NIFI-4889 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2830.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2830 commit e679e2391dea018854f823d6546e8f2821cacd31 Author: Damian Czaja Date: 2018-07-02T11:35:03Z NIFI-4889: Logout not working properly with OIDC - Redirect user agent to end session endpoint on the OIDC provider > Logout not working properly with OIDC > - > > Key: NIFI-4889 > URL: https://issues.apache.org/jira/browse/NIFI-4889 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) >Reporter: Federico Michele Facca >Priority: Critical > > Click on logout, i would expect to logout and getting redirect to the auth > page. But given that the session is not closed on the oauth provider, i get > logged in again. > I suppose the solution would be to invoke the end_session_endpoint provided > in the openid discovery configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4889) Logout not working properly with OIDC
[ https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16531472#comment-16531472 ] ASF GitHub Bot commented on NIFI-4889: -- Github user Trojan295 closed the pull request at: https://github.com/apache/nifi/pull/2830 > Logout not working properly with OIDC > - > > Key: NIFI-4889 > URL: https://issues.apache.org/jira/browse/NIFI-4889 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) >Reporter: Federico Michele Facca >Priority: Critical > > Click on logout, i would expect to logout and getting redirect to the auth > page. But given that the session is not closed on the oauth provider, i get > logged in again. > I suppose the solution would be to invoke the end_session_endpoint provided > in the openid discovery configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFI-4889) Logout not working properly with OIDC
[ https://issues.apache.org/jira/browse/NIFI-4889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529751#comment-16529751 ] ASF GitHub Bot commented on NIFI-4889: -- GitHub user Trojan295 opened a pull request: https://github.com/apache/nifi/pull/2830 NIFI-4889: Logout not working properly with OIDC - Redirect user agent to end session endpoint on the OIDC provider Thank you for submitting a contribution to Apache NiFi. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Does your PR title start with NIFI- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)? - [ ] Is your initial contribution a single, squashed commit? ### For code changes: - [ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly? - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly? - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered? ### Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Trojan295/nifi NIFI-4889 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi/pull/2830.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2830 commit fba6497948d12a272b4a593e8eb8c469badbfdf5 Author: Damian Czaja Date: 2018-07-02T11:35:03Z NIFI-4889: Logout not working properly with OIDC - Redirect user agent to end session endpoint on the OIDC provider > Logout not working properly with OIDC > - > > Key: NIFI-4889 > URL: https://issues.apache.org/jira/browse/NIFI-4889 > Project: Apache NiFi > Issue Type: Bug > Components: Core UI >Affects Versions: 1.5.0 > Environment: Browser: Chrome / Firefox > Configuration of NiFi: > - SSL certificate for the server (no client auth) > - OIDC configuration including end_session_endpoint (see the link > https://auth.s.orchestracities.com/auth/realms/default/.well-known/openid-configuration) >Reporter: Federico Michele Facca >Priority: Critical > > Click on logout, i would expect to logout and getting redirect to the auth > page. But given that the session is not closed on the oauth provider, i get > logged in again. > I suppose the solution would be to invoke the end_session_endpoint provided > in the openid discovery configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
