[jira] [Commented] (NIFIREG-215) Extension Bundle Improvements
[ https://issues.apache.org/jira/browse/NIFIREG-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720471#comment-16720471 ] ASF GitHub Bot commented on NIFIREG-215: Github user asfgit closed the pull request at: https://github.com/apache/nifi-registry/pull/149 > Extension Bundle Improvements > - > > Key: NIFIREG-215 > URL: https://issues.apache.org/jira/browse/NIFIREG-215 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Labels: Extension_Registry > Fix For: 0.4.0 > > > This ticket is to implement some additional improvements to the work done in > NIFIREG-211. > * Store file size of a bundle in the DB and make it available in retrieved > objects > * Provide a method to check if a bundle exists (true or false) > * Provide an option to allow uploading and overwriting an existing bundle > * Consider making snapshots a special version that can always be overridden -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-215) Extension Bundle Improvements
[ https://issues.apache.org/jira/browse/NIFIREG-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720472#comment-16720472 ] ASF GitHub Bot commented on NIFIREG-215: Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/149 Thanks, @bbende! +1, merged to master. > Extension Bundle Improvements > - > > Key: NIFIREG-215 > URL: https://issues.apache.org/jira/browse/NIFIREG-215 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Labels: Extension_Registry > Fix For: 0.4.0 > > > This ticket is to implement some additional improvements to the work done in > NIFIREG-211. > * Store file size of a bundle in the DB and make it available in retrieved > objects > * Provide a method to check if a bundle exists (true or false) > * Provide an option to allow uploading and overwriting an existing bundle > * Consider making snapshots a special version that can always be overridden -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-215) Extension Bundle Improvements
[ https://issues.apache.org/jira/browse/NIFIREG-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16720274#comment-16720274 ] ASF GitHub Bot commented on NIFIREG-215: Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/149 @kevdoran I pushed up a commit to update the filter params documentation. I decided not to do anything with the lastModified value on the bundle table because technically nothing on that row is ever changing, it is really the entries in the version table which are changing, and this will have new create dates when redeploying any version. Let me know if there is anything else. > Extension Bundle Improvements > - > > Key: NIFIREG-215 > URL: https://issues.apache.org/jira/browse/NIFIREG-215 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Labels: Extension_Registry > Fix For: 0.4.0 > > > This ticket is to implement some additional improvements to the work done in > NIFIREG-211. > * Store file size of a bundle in the DB and make it available in retrieved > objects > * Provide a method to check if a bundle exists (true or false) > * Provide an option to allow uploading and overwriting an existing bundle > * Consider making snapshots a special version that can always be overridden -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-215) Extension Bundle Improvements
[ https://issues.apache.org/jira/browse/NIFIREG-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719533#comment-16719533 ] ASF GitHub Bot commented on NIFIREG-215: Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/149#discussion_r241217517 --- Diff: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/bucket/Bucket.java --- @@ -41,6 +41,8 @@ private String description; +private Boolean allowExtensionBundleRedeploy; --- End diff -- Ok, I’m not familiar with Nexus’s configuration options, but I’m in favor of keeping consistencies/parallels with that. I’m good with leaving this as-is. > Extension Bundle Improvements > - > > Key: NIFIREG-215 > URL: https://issues.apache.org/jira/browse/NIFIREG-215 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Labels: Extension_Registry > Fix For: 0.4.0 > > > This ticket is to implement some additional improvements to the work done in > NIFIREG-211. > * Store file size of a bundle in the DB and make it available in retrieved > objects > * Provide a method to check if a bundle exists (true or false) > * Provide an option to allow uploading and overwriting an existing bundle > * Consider making snapshots a special version that can always be overridden -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-215) Extension Bundle Improvements
[ https://issues.apache.org/jira/browse/NIFIREG-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719462#comment-16719462 ] ASF GitHub Bot commented on NIFIREG-215: Github user bbende commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/149#discussion_r241191410 --- Diff: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/bucket/Bucket.java --- @@ -41,6 +41,8 @@ private String description; +private Boolean allowExtensionBundleRedeploy; --- End diff -- Right now the way it is implemented, SNAPSHOTS are treated special and always allow redeployment, so the boolean is really just for whether or not "released" artifacts (i.e. non-snapshot) can be redeployed. Maybe there is a better name for the field though? I was mostly thinking of how Nexus has some kind of global checkbox that lets you say whether you can redeploy released artifacts to the given Nexus instance. > Extension Bundle Improvements > - > > Key: NIFIREG-215 > URL: https://issues.apache.org/jira/browse/NIFIREG-215 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Labels: Extension_Registry > Fix For: 0.4.0 > > > This ticket is to implement some additional improvements to the work done in > NIFIREG-211. > * Store file size of a bundle in the DB and make it available in retrieved > objects > * Provide a method to check if a bundle exists (true or false) > * Provide an option to allow uploading and overwriting an existing bundle > * Consider making snapshots a special version that can always be overridden -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-215) Extension Bundle Improvements
[ https://issues.apache.org/jira/browse/NIFIREG-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719463#comment-16719463 ] ASF GitHub Bot commented on NIFIREG-215: Github user bbende commented on the issue: https://github.com/apache/nifi-registry/pull/149 Thanks for the review, I'll look into that lastModified timestamp issue as well. > Extension Bundle Improvements > - > > Key: NIFIREG-215 > URL: https://issues.apache.org/jira/browse/NIFIREG-215 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Labels: Extension_Registry > Fix For: 0.4.0 > > > This ticket is to implement some additional improvements to the work done in > NIFIREG-211. > * Store file size of a bundle in the DB and make it available in retrieved > objects > * Provide a method to check if a bundle exists (true or false) > * Provide an option to allow uploading and overwriting an existing bundle > * Consider making snapshots a special version that can always be overridden -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-215) Extension Bundle Improvements
[
https://issues.apache.org/jira/browse/NIFIREG-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719452#comment-16719452
]
ASF GitHub Bot commented on NIFIREG-215:
Github user bbende commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/149#discussion_r241190389
--- Diff:
nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/ExtensionResource.java
---
@@ -93,15 +94,25 @@ public ExtensionResource(final RegistryService
registryService,
responseContainer = "List"
)
@ApiResponses({ @ApiResponse(code = 401, message =
HttpStatusMessages.MESSAGE_401) })
-public Response getExtensionBundles() {
+public Response getExtensionBundles(
+@QueryParam("groupId")
+@ApiParam("Optional groupId to filter results. The value may
be an exact match, or a trailing wildcard, " +
+"such as 'com.%' to select all bundles where the
groupId starts with 'com.'.")
+final String groupId,
+@QueryParam("artifactId")
+@ApiParam("Optional artifactId to filter results. The value
may be an exact match, or a trailing wildcard, " +
+"such as 'nifi-%' to select all bundles where the
artifactId starts with 'nifi-'.")
+final String artifactId) {
--- End diff --
Good call, I hadn't really thought about how the SQL 'LIKE' was working and
I was only really testing trailing wildcards, but you're right, I can remove
that from the docs.
> Extension Bundle Improvements
> -
>
> Key: NIFIREG-215
> URL: https://issues.apache.org/jira/browse/NIFIREG-215
> Project: NiFi Registry
> Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
> Labels: Extension_Registry
> Fix For: 0.4.0
>
>
> This ticket is to implement some additional improvements to the work done in
> NIFIREG-211.
> * Store file size of a bundle in the DB and make it available in retrieved
> objects
> * Provide a method to check if a bundle exists (true or false)
> * Provide an option to allow uploading and overwriting an existing bundle
> * Consider making snapshots a special version that can always be overridden
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFIREG-215) Extension Bundle Improvements
[ https://issues.apache.org/jira/browse/NIFIREG-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719429#comment-16719429 ] ASF GitHub Bot commented on NIFIREG-215: Github user kevdoran commented on a diff in the pull request: https://github.com/apache/nifi-registry/pull/149#discussion_r241166717 --- Diff: nifi-registry-core/nifi-registry-data-model/src/main/java/org/apache/nifi/registry/bucket/Bucket.java --- @@ -41,6 +41,8 @@ private String description; +private Boolean allowExtensionBundleRedeploy; --- End diff -- Instead of a boolean flag here. I'm wondering if this would be better as a Enum for something like "redeploy policy" with values such as "NEVER, SNAPSHOTS, ALWAYS" or something like that? > Extension Bundle Improvements > - > > Key: NIFIREG-215 > URL: https://issues.apache.org/jira/browse/NIFIREG-215 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Labels: Extension_Registry > Fix For: 0.4.0 > > > This ticket is to implement some additional improvements to the work done in > NIFIREG-211. > * Store file size of a bundle in the DB and make it available in retrieved > objects > * Provide a method to check if a bundle exists (true or false) > * Provide an option to allow uploading and overwriting an existing bundle > * Consider making snapshots a special version that can always be overridden -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-215) Extension Bundle Improvements
[
https://issues.apache.org/jira/browse/NIFIREG-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719430#comment-16719430
]
ASF GitHub Bot commented on NIFIREG-215:
Github user kevdoran commented on a diff in the pull request:
https://github.com/apache/nifi-registry/pull/149#discussion_r241172387
--- Diff:
nifi-registry-core/nifi-registry-web-api/src/main/java/org/apache/nifi/registry/web/api/ExtensionResource.java
---
@@ -93,15 +94,25 @@ public ExtensionResource(final RegistryService
registryService,
responseContainer = "List"
)
@ApiResponses({ @ApiResponse(code = 401, message =
HttpStatusMessages.MESSAGE_401) })
-public Response getExtensionBundles() {
+public Response getExtensionBundles(
+@QueryParam("groupId")
+@ApiParam("Optional groupId to filter results. The value may
be an exact match, or a trailing wildcard, " +
+"such as 'com.%' to select all bundles where the
groupId starts with 'com.'.")
+final String groupId,
+@QueryParam("artifactId")
+@ApiParam("Optional artifactId to filter results. The value
may be an exact match, or a trailing wildcard, " +
+"such as 'nifi-%' to select all bundles where the
artifactId starts with 'nifi-'.")
+final String artifactId) {
--- End diff --
These parameters are nice to have, and work as expected for me. One thing I
noticed is that the documentation says _"... a trailing wildcard ..."_, which
indicates wildcards can only be used at the end of the value. However in
testing, I was able to use them anywhere in the value (at the beginning or
middle of the value) and it worked (with the expected results as well).
So maybe just update the documentation to remove the work "trailing"?
> Extension Bundle Improvements
> -
>
> Key: NIFIREG-215
> URL: https://issues.apache.org/jira/browse/NIFIREG-215
> Project: NiFi Registry
> Issue Type: Improvement
>Reporter: Bryan Bende
>Assignee: Bryan Bende
>Priority: Minor
> Labels: Extension_Registry
> Fix For: 0.4.0
>
>
> This ticket is to implement some additional improvements to the work done in
> NIFIREG-211.
> * Store file size of a bundle in the DB and make it available in retrieved
> objects
> * Provide a method to check if a bundle exists (true or false)
> * Provide an option to allow uploading and overwriting an existing bundle
> * Consider making snapshots a special version that can always be overridden
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (NIFIREG-215) Extension Bundle Improvements
[ https://issues.apache.org/jira/browse/NIFIREG-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719369#comment-16719369 ] ASF GitHub Bot commented on NIFIREG-215: Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/149 Reviewing... > Extension Bundle Improvements > - > > Key: NIFIREG-215 > URL: https://issues.apache.org/jira/browse/NIFIREG-215 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Labels: Extension_Registry > Fix For: 0.4.0 > > > This ticket is to implement some additional improvements to the work done in > NIFIREG-211. > * Store file size of a bundle in the DB and make it available in retrieved > objects > * Provide a method to check if a bundle exists (true or false) > * Provide an option to allow uploading and overwriting an existing bundle > * Consider making snapshots a special version that can always be overridden -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (NIFIREG-215) Extension Bundle Improvements
[ https://issues.apache.org/jira/browse/NIFIREG-215?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16717426#comment-16717426 ] ASF GitHub Bot commented on NIFIREG-215: GitHub user bbende opened a pull request: https://github.com/apache/nifi-registry/pull/149 NIFIREG-215 Extension Bundle Improvements I left the changes as separate commits in order to more easily review each change on it's own, but feel free to squash upon merging. You can merge this pull request into a Git repository by running: $ git pull https://github.com/bbende/nifi-registry NIFIREG-215 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/nifi-registry/pull/149.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #149 commit dee999b3224240af4292d1a81d2f1a9f2cfe59d7 Author: Bryan Bende Date: 2018-12-03T19:22:15Z NIFIREG-215 Adding content size field extension bundle version commit 8fced330880f90fe431a50332c9e0a3b378d29a1 Author: Bryan Bende Date: 2018-12-04T17:03:34Z NIFIREG-215 Adding optional filters to the get all bundles end-point commit f884a79ce0b5a369f0fd370d1a5858d50d569f9d Author: Bryan Bende Date: 2018-12-04T17:13:07Z NIFIREG-215 Bumping minor versions of spring boot and spring security commit 45955c66416be86a352387d251d55b139399a4fb Author: Bryan Bende Date: 2018-12-04T19:28:19Z NIFIREG-215 Adding /bundles/versions with filter params commit f3bed26efb6e06bd7c78bc20186a15be08a22d2d Author: Bryan Bende Date: 2018-12-04T20:25:28Z NIFIREG-215 Added new client method to return an optional checksum for a given group, artifact, and version commit 52a84bfc99fe09b91e9eef824aa9536205d3784c Author: Bryan Bende Date: 2018-12-10T21:51:38Z NIFIREG-215 - Adding support for SNAPSHOT versions commit 3bbb4890a2ee9e7b3c2421a56ca6f2c5106bc6b5 Author: Bryan Bende Date: 2018-12-11T15:41:08Z NIFIREG-215 Adding flag on buckets to indicate if redeploying extension bundle versions is allowed > Extension Bundle Improvements > - > > Key: NIFIREG-215 > URL: https://issues.apache.org/jira/browse/NIFIREG-215 > Project: NiFi Registry > Issue Type: Improvement >Reporter: Bryan Bende >Assignee: Bryan Bende >Priority: Minor > Labels: Extension_Registry > Fix For: 0.4.0 > > > This ticket is to implement some additional improvements to the work done in > NIFIREG-211. > * Store file size of a bundle in the DB and make it available in retrieved > objects > * Provide a method to check if a bundle exists (true or false) > * Provide an option to allow uploading and overwriting an existing bundle > * Consider making snapshots a special version that can always be overridden -- This message was sent by Atlassian JIRA (v7.6.3#76005)
