Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

szaszm closed pull request #1698: MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC URL: https://github.com/apache/nifi-minifi-cpp/pull/1698 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

lordgamez commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1453461616 ## extensions/grafana-loki/PushGrafanaLoki.cpp: ## @@ -0,0 +1,249 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

szaszm commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1453403835 ## extensions/grafana-loki/PushGrafanaLoki.cpp: ## @@ -0,0 +1,249 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

lordgamez commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1452556325 ## extensions/grafana-loki/protos/grafana-loki-push.proto: ## Review Comment: Added reference in 407abbc65a8900dc9937dc0587c52d68693335ff -- This is

Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

lordgamez commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1452556096 ## .dockerignore: ## @@ -57,6 +57,11 @@ extensions/expression-language/Scanner.cpp extensions/expression-language/location.hh

Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

lordgamez commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1452555861 ## extensions/grafana-loki/CMakeLists.txt: ## @@ -16,20 +16,46 @@ # specific language governing permissions and limitations # under the License. # - if

Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

lordgamez commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1452554318 ## cmake/MiNiFiOptions.cmake: ## @@ -122,6 +122,7 @@ add_minifi_option(ENABLE_KUBERNETES "Enables the Kubernetes extensions." ON)

Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

lordgamez commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1452482580 ## LICENSE: ## @@ -2442,52 +2443,6 @@ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT OF THIS SOFTWARE, EVEN IF ADVISED OF THE

Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

lordgamez commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1452480781 ## extensions/grafana-loki/protos/grafana-loki-push.proto: ## Review Comment: This file defines the grpc service and the protobuf messages structures

Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

szaszm commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1452235982 ## extensions/grafana-loki/protos/grafana-loki-push.proto: ## Review Comment: Is this file coming from somewhere else? We should include the source, and

Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

szaszm commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1452228611 ## extensions/grafana-loki/CMakeLists.txt: ## @@ -16,20 +16,46 @@ # specific language governing permissions and limitations # under the License. # - if (NOT

Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

szaszm commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1446385712 ## LICENSE: ## @@ -2442,52 +2443,6 @@ THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY

Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

adamdebreceni commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1447307752 ## extensions/grafana-loki/CMakeLists.txt: ## @@ -16,20 +16,46 @@ # specific language governing permissions and limitations # under the License. # -

Re: [PR] MINIFICPP-2262 Add processor to push logs to Grafana Loki through gRPC [nifi-minifi-cpp]

martinzink commented on code in PR #1698: URL: https://github.com/apache/nifi-minifi-cpp/pull/1698#discussion_r1418662196 ## cmake/MiNiFiOptions.cmake: ## @@ -122,6 +122,7 @@ add_minifi_option(ENABLE_KUBERNETES "Enables the Kubernetes extensions." ON)