Re: [PR] NIFI-12417: Process Group Configuration [nifi]

2023-11-29 Thread via GitHub


rfellows merged PR #8075:
URL: https://github.com/apache/nifi/pull/8075


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12417: Process Group Configuration [nifi]

2023-11-29 Thread via GitHub


mcgilman commented on PR #8075:
URL: https://github.com/apache/nifi/pull/8075#issuecomment-1832650893

   > Per our offline discussion about moving the Controller Service listing out 
of the Process Group configuration dialog... I think we can now update the 
logic in `canvat-utils.service.ts#isConfigurable` to not blindly allow the pg 
configuration screen to be opened. Not positive and correct me if I'm wrong, 
but I suspect the original intent here was that we couldn't prevent the user 
from seeing the controller services of a process group if the user didn't have 
read access to the PG itself. Now that we plan to have a different dialog for 
this, we don't need to support a read-only mode for the pg configuration.
   
   This is correct. Previously users could have access to Services within the 
Process Group but not the Process Group itself. By pulling the service listing 
into its own page we no longer need to _always_ support configuring the Process 
Group. I'll update the `CanvasUtils` accordingly.
   
   This PR does not currently allow the user to configure the current Process 
Group. I'll update this PR to guard against this case so there are no errors 
but actually supporting configuring the current Process Group will come in a 
follow-up effort. I've already begun creating the service listing and 
introducing a new route for configuring the current Process Group would 
conflict with those changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12417: Process Group Configuration [nifi]

2023-11-29 Thread via GitHub


mcgilman commented on code in PR #8075:
URL: https://github.com/apache/nifi/pull/8075#discussion_r1409766288


##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/styles.scss:
##
@@ -293,6 +293,15 @@ a:hover {
 min-width: 760px;
 }
 
+.full-screen-dialog {
+position: absolute !important;
+top: 25px;
+bottom: 25px;
+right: 25px;
+left: 25px;
+max-width: none !important;
+}
+

Review Comment:
   You're correct that is not used right now. I was originally going to put the 
service listing with the process group configuration. However, that is being 
moved into its own view so this is currently unused. I thought about removing 
it but left it in place because I suspected we'd need it for other features in 
the future (docs, custom ui, etc). We are also not using all the other types of 
dialogs currently.
   
   That said, I'm happy to remove this and we can reintroduce it once it's 
needed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] NIFI-12417: Process Group Configuration [nifi]

2023-11-29 Thread via GitHub


rfellows commented on code in PR #8075:
URL: https://github.com/apache/nifi/pull/8075#discussion_r1409527869


##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/canvas/ui/process-group/edit-process-group/edit-process-group.component.ts:
##
@@ -0,0 +1,227 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import { Component, EventEmitter, Inject, Input, Output } from '@angular/core';
+import { MAT_DIALOG_DATA, MatDialogModule } from '@angular/material/dialog';
+import { FormBuilder, FormControl, FormGroup, FormsModule, 
ReactiveFormsModule, Validators } from '@angular/forms';
+import { MatInputModule } from '@angular/material/input';
+import { MatCheckboxModule } from '@angular/material/checkbox';
+import { MatButtonModule } from '@angular/material/button';
+import { AsyncPipe, NgForOf, NgIf } from '@angular/common';
+import { MatTabsModule } from '@angular/material/tabs';
+import { MatOptionModule } from '@angular/material/core';
+import { MatSelectModule } from '@angular/material/select';
+import { Observable } from 'rxjs';
+import { SelectOption, TextTipInput } from '../../../../../state/shared';
+import { Client } from '../../../../../service/client.service';
+import { EditComponentDialogRequest } from '../../../state/flow';
+import { PropertyTable } from 
'../../../../../ui/common/property-table/property-table.component';
+import { NifiSpinnerDirective } from 
'../../../../../ui/common/spinner/nifi-spinner.directive';
+import { NifiTooltipDirective } from 
'../../../../../ui/common/tooltips/nifi-tooltip.directive';
+import { TextTip } from 
'../../../../../ui/common/tooltips/text-tip/text-tip.component';
+import { ParameterContextEntity } from 
'../../../../parameter-contexts/state/parameter-context-listing';
+import { ControllerServiceTable } from 
'../../../../../ui/common/controller-service/controller-service-table/controller-service-table.component';
+
+@Component({
+selector: 'edit-process-group',
+standalone: true,
+templateUrl: './edit-process-group.component.html',
+imports: [
+ReactiveFormsModule,
+MatDialogModule,
+MatInputModule,
+MatCheckboxModule,
+MatButtonModule,
+NgIf,
+MatTabsModule,
+MatOptionModule,
+MatSelectModule,
+NgForOf,
+AsyncPipe,
+PropertyTable,
+NifiSpinnerDirective,
+NifiTooltipDirective,
+FormsModule,
+ControllerServiceTable
+],
+styleUrls: ['./edit-process-group.component.scss']
+})
+export class EditProcessGroup {
+@Input() set parameterContexts(parameterContexts: 
ParameterContextEntity[]) {
+parameterContexts.forEach((parameterContext) => {
+if (parameterContext.permissions.canRead) {
+this.parameterContextsOptions.push({
+text: parameterContext.component.name,
+value: parameterContext.id,
+description: parameterContext.component.description
+});
+}
+});
+
+if (this.request.entity.component.parameterContext) {
+this.editProcessGroupForm.addControl(
+'parameterContext',
+new 
FormControl(this.request.entity.component.parameterContext.id)
+);
+} else {
+this.editProcessGroupForm.addControl('parameterContext', new 
FormControl(null));
+}
+}
+@Input() saving$!: Observable;
+@Output() editProcessGroup: EventEmitter = new EventEmitter();
+
+protected readonly TextTip = TextTip;
+
+editProcessGroupForm: FormGroup;
+parameterContextsOptions: SelectOption[] = [];
+
+executionEngineOptions: SelectOption[] = [
+{
+text: 'Inherited',
+value: 'INHERITED',
+description: 'Use whichever Execution Engine the parent Process 
Group is configured to use.'
+},
+{
+text: 'Standard',
+value: 'STANDARD',
+description: 'Use the Standard NiFi Execution Engine. See the User 
Guide for additional details.'
+},
+{
+text: 'Stateless',
+   

Re: [PR] NIFI-12417: Process Group Configuration [nifi]

2023-11-29 Thread via GitHub


rfellows commented on PR #8075:
URL: https://github.com/apache/nifi/pull/8075#issuecomment-1832126268

   Reviewing...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org