[GitHub] rabbah commented on issue #3219: Kubernetes ContainerFactoryProvider implementation

2018-02-06 Thread GitBox
rabbah commented on issue #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#issuecomment-363500499 nice! thanks for sharing it, I hadn't see that yet.

[GitHub] tardieu commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
tardieu commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166397435 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] tardieu commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
tardieu commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166395783 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] houshengbo opened a new pull request #714: Add .txt as suffix to LICENSE, NOTICE and CHANGELOG

2018-02-06 Thread GitBox
houshengbo opened a new pull request #714: Add .txt as suffix to LICENSE, NOTICE and CHANGELOG URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/714 This is an automated message from the Apache Git Service.

[GitHub] jasonpet opened a new pull request #156: adding test case for writing a new document when overwrite=true

2018-02-06 Thread GitBox
jasonpet opened a new pull request #156: adding test case for writing a new document when overwrite=true URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/156 adding a test case for PR #155 This is an

[GitHub] rabbah commented on a change in pull request #155: #112 Adding feature to insert document when overwrite and putIfAbsent?

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#discussion_r166391680 ## File path: actions/database-actions/write-document.js

[GitHub] tardieu commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
tardieu commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166395783 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] mrutkows closed pull request #714: Add .txt as suffix to LICENSE, NOTICE and CHANGELOG

2018-02-06 Thread GitBox
mrutkows closed pull request #714: Add .txt as suffix to LICENSE, NOTICE and CHANGELOG URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/714 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] jasonpet commented on issue #156: adding test case for writing a new document when overwrite=true

2018-02-06 Thread GitBox
jasonpet commented on issue #156: adding test case for writing a new document when overwrite=true URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/156#issuecomment-363528996 @rabbah - fyi This is an

[GitHub] rabbah commented on a change in pull request #155: #112 Adding feature to insert document when overwrite and putIfAbsent?

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#discussion_r166390087 ## File path: actions/database-actions/write-document.js

[GitHub] vipulkashyap111 commented on a change in pull request #155: #112 Adding feature to insert document when overwrite and putIfAbsent?

2018-02-06 Thread GitBox
vipulkashyap111 commented on a change in pull request #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#discussion_r166391898 ## File path:

[GitHub] vipulkashyap111 commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent?

2018-02-06 Thread GitBox
vipulkashyap111 commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#issuecomment-363454271 @jasonpet @rabbah This is for #112. Added putIfAbsent flag which if set to

[GitHub] rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent?

2018-02-06 Thread GitBox
rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#issuecomment-363455802 It would be nice to add a unit test similar to the one here

[GitHub] mrutkows opened a new issue #710: Actions: Web (export): Support "final" annotation

2018-02-06 Thread GitBox
mrutkows opened a new issue #710: Actions: Web (export): Support "final" annotation URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/710 See: https://github.com/apache/incubator-openwhisk/blob/master/docs/annotations.md

[GitHub] jasonpet commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent?

2018-02-06 Thread GitBox
jasonpet commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#issuecomment-363494615 I guess only a test is needed now since we are not adding a new parameter. No

[GitHub] rabbah commented on a change in pull request #3219: Kubernetes ContainerFactoryProvider implementation

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#discussion_r166353578 ## File path:

[GitHub] vipulkashyap111 commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent?

2018-02-06 Thread GitBox
vipulkashyap111 commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#issuecomment-363510190 Removed putIfAbsent flag, document is inserted if overwrite=true and it does

[GitHub] jasonpet commented on a change in pull request #155: #112 Adding feature to insert document when overwrite and putIfAbsent?

2018-02-06 Thread GitBox
jasonpet commented on a change in pull request #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#discussion_r166390965 ## File path: actions/database-actions/write-document.js

[GitHub] dubeejw commented on issue #3254: Do not disable rule when it is updated

2018-02-06 Thread GitBox
dubeejw commented on issue #3254: Do not disable rule when it is updated URL: https://github.com/apache/incubator-openwhisk/pull/3254#issuecomment-363529863 Tried to do a unit test originally, but had trouble since the Rule route also needs access to the Trigger route. I'll give it

[GitHub] markusthoemmes commented on issue #3219: Kubernetes ContainerFactoryProvider implementation

2018-02-06 Thread GitBox
markusthoemmes commented on issue #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#issuecomment-363500118 Regarding credits for all committers: Github introduced

[GitHub] houshengbo opened a new issue #221: Trigger tests failed on the latest code of openwhisk

2018-02-06 Thread GitBox
houshengbo opened a new issue #221: Trigger tests failed on the latest code of openwhisk URL: https://github.com/apache/incubator-openwhisk-cli/issues/221 system.basic.WskBasicTests > Wsk Activation CLI should create a trigger, and fire a trigger to get its individual fields from an

[GitHub] vipulkashyap111 commented on a change in pull request #155: #112 Adding feature to insert document when overwrite and putIfAbsent?

2018-02-06 Thread GitBox
vipulkashyap111 commented on a change in pull request #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#discussion_r166394354 ## File path:

[GitHub] daisy-ycguo commented on issue #709: Add Apache License

2018-02-06 Thread GitBox
daisy-ycguo commented on issue #709: Add Apache License URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/709#issuecomment-363363295 This PR is based on the changes by Apache RAT. After Apache RAT makes changes, I also made a few changes manually: - Some file mode are

[GitHub] daisy-ycguo commented on issue #709: Add Apache License

2018-02-06 Thread GitBox
daisy-ycguo commented on issue #709: Add Apache License URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/709#issuecomment-363363295 This PR is based on the changes by Apache RAT. After Apache RAT makes changes, I also made a few changes manually: - Some file mode are

[GitHub] markusthoemmes commented on issue #2943: revert LoadBalancerData to be synchronous

2018-02-06 Thread GitBox
markusthoemmes commented on issue #2943: revert LoadBalancerData to be synchronous URL: https://github.com/apache/incubator-openwhisk/pull/2943#issuecomment-363366279 WDYT about the possibility of not using state-sharing at all but instead shard the invokers to avoid collisions as laid

[GitHub] rabbah commented on a change in pull request #3253: Efficiently parse CompletionMessage.

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3253: Efficiently parse CompletionMessage. URL: https://github.com/apache/incubator-openwhisk/pull/3253#discussion_r166241465 ## File path: common/scala/src/main/scala/whisk/core/connector/Message.scala ## @@ -95,6 +95,20 @@

[GitHub] rabbah commented on a change in pull request #3254: Do not disable rule when it is updated

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3254: Do not disable rule when it is updated URL: https://github.com/apache/incubator-openwhisk/pull/3254#discussion_r166241911 ## File path: tests/src/test/scala/system/basic/WskRuleTests.scala ## @@ -88,6 +88,40 @@ abstract

[GitHub] markusthoemmes commented on issue #3254: Do not disable rule when it is updated

2018-02-06 Thread GitBox
markusthoemmes commented on issue #3254: Do not disable rule when it is updated URL: https://github.com/apache/incubator-openwhisk/pull/3254#issuecomment-363375154 I agree, this should be moved to be a Unit test instead.

[GitHub] rabbah commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r166259516 ## File path: docs/parameters.md ## @@ -0,0 +1,180 @@ +# Working with

[GitHub] rabbah commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r166258207 ## File path: docs/parameters.md ## @@ -0,0 +1,181 @@ +# Working with

[GitHub] rabbah commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r166258717 ## File path: docs/parameters.md ## @@ -0,0 +1,181 @@ +# Working with

[GitHub] rabbah commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r166257869 ## File path: docs/parameters.md ## @@ -0,0 +1,181 @@ +# Working with

[GitHub] rabbah commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r166259175 ## File path: docs/parameters.md ## @@ -0,0 +1,181 @@ +# Working with

[GitHub] rabbah commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#discussion_r166259871 ## File path: docs/parameters.md ## @@ -0,0 +1,181 @@ +# Working with

[GitHub] rabbah commented on issue #3244: Move parameter docs to separate page, add package params docs

2018-02-06 Thread GitBox
rabbah commented on issue #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#issuecomment-363390478 Im wondering if we should leave a short blurb in the actions.md about passing parameters to an action under

[GitHub] lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs

2018-02-06 Thread GitBox
lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#issuecomment-363392611 I _thought_ I had linked to the parameters doc from everywhere where there already was (or I thought there

[GitHub] tymanoj closed issue #3248: Unable to connect to controller0 while running openwhisk.yml (local deployment)

2018-02-06 Thread GitBox
tymanoj closed issue #3248: Unable to connect to controller0 while running openwhisk.yml (local deployment) URL: https://github.com/apache/incubator-openwhisk/issues/3248 This is an automated message from the Apache Git

[GitHub] tymanoj commented on issue #3248: Unable to connect to controller0 while running openwhisk.yml (local deployment)

2018-02-06 Thread GitBox
tymanoj commented on issue #3248: Unable to connect to controller0 while running openwhisk.yml (local deployment) URL: https://github.com/apache/incubator-openwhisk/issues/3248#issuecomment-363392855 Hi, I am able to fix it. Cause: Docker Engine was not installed properly.

[GitHub] rabbah commented on issue #3244: Move parameter docs to separate page, add package params docs

2018-02-06 Thread GitBox
rabbah commented on issue #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#issuecomment-363398507 You did but I thought a quick one liner: here?s how you invoke and pass a parameter. For more go to this

[GitHub] daisy-ycguo commented on issue #709: Add Apache License

2018-02-06 Thread GitBox
daisy-ycguo commented on issue #709: Add Apache License URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/709#issuecomment-363363295 This PR is auto created by Apache RAT. I made a few changes manually: - Some file mode are changed by Apache RAT. I need to change them

[GitHub] daisy-ycguo commented on issue #709: Add Apache License

2018-02-06 Thread GitBox
daisy-ycguo commented on issue #709: Add Apache License URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/709#issuecomment-363363295 This PR is based on the changes by Apache RAT. I made a few changes manually: - Some file mode are changed by Apache RAT. I need to change

[GitHub] lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs

2018-02-06 Thread GitBox
lornajane commented on issue #3244: Move parameter docs to separate page, add package params docs URL: https://github.com/apache/incubator-openwhisk/pull/3244#issuecomment-363378267 What a lovely thorough review! Changes made as requested.

[GitHub] cbickel opened a new pull request #3255: Only log outgoing requests.

2018-02-06 Thread GitBox
cbickel opened a new pull request #3255: Only log outgoing requests. URL: https://github.com/apache/incubator-openwhisk/pull/3255 This commit removes the logging of incoming requests. The information of these logs are moved to the log of the outgoing requests. This results in a small

[GitHub] rabbah commented on issue #3255: Only log outgoing requests.

2018-02-06 Thread GitBox
rabbah commented on issue #3255: Only log outgoing requests. URL: https://github.com/apache/incubator-openwhisk/pull/3255#issuecomment-363382347 Can we enable this for debug log levels instead of removing completely?

[GitHub] cbickel closed pull request #3255: Only log outgoing requests.

2018-02-06 Thread GitBox
cbickel closed pull request #3255: Only log outgoing requests. URL: https://github.com/apache/incubator-openwhisk/pull/3255 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] cbickel closed pull request #3186: Rework some tests.

2018-02-06 Thread GitBox
cbickel closed pull request #3186: Rework some tests. URL: https://github.com/apache/incubator-openwhisk/pull/3186 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] l2fprod opened a new issue #85: Support Push Notifications service in other regions than ng

2018-02-06 Thread GitBox
l2fprod opened a new issue #85: Support Push Notifications service in other regions than ng URL: https://github.com/apache/incubator-openwhisk-package-pushnotifications/issues/85 It looks like

[GitHub] rabbah commented on issue #3219: Kubernetes ContainerFactoryProvider implementation

2018-02-06 Thread GitBox
rabbah commented on issue #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#issuecomment-363592517 With the git enhancement linked by Markus you don?t need to squash at all. We can just amend the commit message when

[GitHub] mrutkows commented on issue #715: Adding support for export managed project back to manifest

2018-02-06 Thread GitBox
mrutkows commented on issue #715: Adding support for export managed project back to manifest URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/715#issuecomment-363579218 @kpavel yes, agreed these are some known issues that any resolution might involve enhancing the

[GitHub] jasonpet commented on issue #156: adding test case for writing a new document when overwrite=true

2018-02-06 Thread GitBox
jasonpet commented on issue #156: adding test case for writing a new document when overwrite=true URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/156#issuecomment-363583392 it doesn't for me This is

[GitHub] jasonpet commented on issue #156: adding test case for writing a new document when overwrite=true

2018-02-06 Thread GitBox
jasonpet commented on issue #156: adding test case for writing a new document when overwrite=true URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/156#issuecomment-363583392 it doesn't for me. did you run it? no tests run as part of travis for this repo.

[GitHub] markusthoemmes commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
markusthoemmes commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166489546 ## File path:

[GitHub] jcrossley3 commented on issue #3219: Kubernetes ContainerFactoryProvider implementation

2018-02-06 Thread GitBox
jcrossley3 commented on issue #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#issuecomment-363591586 @rabbah do you want all of this PR's commits squashed into a single one? Or just those pushed in response to

[GitHub] rabbah commented on issue #156: adding test case for writing a new document when overwrite=true

2018-02-06 Thread GitBox
rabbah commented on issue #156: adding test case for writing a new document when overwrite=true URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/156#issuecomment-363584018 fooled by the green checkmark - i thought that meant travis; sorry wasn't looking closely

[GitHub] tardieu commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
tardieu commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166486764 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] rabbah commented on issue #3254: Do not disable rule when it is updated

2018-02-06 Thread GitBox
rabbah commented on issue #3254: Do not disable rule when it is updated URL: https://github.com/apache/incubator-openwhisk/pull/3254#issuecomment-363546451 Thanks for the kick - same comment as here: https://github.com/apache/incubator-openwhisk/pull/3187#issuecomment-363464521

[GitHub] rabbah commented on issue #156: adding test case for writing a new document when overwrite=true

2018-02-06 Thread GitBox
rabbah commented on issue #156: adding test case for writing a new document when overwrite=true URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/156#issuecomment-363549296 hmm why does this test pass already?

[GitHub] rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent?

2018-02-06 Thread GitBox
rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#issuecomment-363549896 @csantanapr changes updated, can you update your review?

[GitHub] kpavel opened a new pull request #715: Adding support for export managed project back to manifest

2018-02-06 Thread GitBox
kpavel opened a new pull request #715: Adding support for export managed project back to manifest URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/715 Introducing command to export managed project into manifest file using `wskdeploy export -p `-m Project assets will

[GitHub] rabbah commented on issue #2638: Preserve rule status on update according to #1840.

2018-02-06 Thread GitBox
rabbah commented on issue #2638: Preserve rule status on update according to #1840. URL: https://github.com/apache/incubator-openwhisk/pull/2638#issuecomment-363546914 Closing for #3254. This is an automated message from

[GitHub] rabbah commented on a change in pull request #3254: Do not disable rule when it is updated

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3254: Do not disable rule when it is updated URL: https://github.com/apache/incubator-openwhisk/pull/3254#discussion_r166427497 ## File path: core/controller/src/main/scala/whisk/core/controller/Rules.scala ## @@ -313,7

[GitHub] rabbah commented on a change in pull request #3254: Do not disable rule when it is updated

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3254: Do not disable rule when it is updated URL: https://github.com/apache/incubator-openwhisk/pull/3254#discussion_r166427986 ## File path: core/controller/src/main/scala/whisk/core/controller/Rules.scala ## @@ -313,7

[GitHub] rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent?

2018-02-06 Thread GitBox
rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#issuecomment-363454906 Thanks for submitting the PR. Do you have an Apache ICLA on file?

[GitHub] rabbah commented on issue #3187: reduce rule activation records

2018-02-06 Thread GitBox
rabbah commented on issue #3187: reduce rule activation records URL: https://github.com/apache/incubator-openwhisk/pull/3187#issuecomment-363464521 A note on the API test - I had missed an important detail. The actions are activated via the REST API. So this will not work with the unit

[GitHub] rabbah commented on issue #3187: reduce rule activation records

2018-02-06 Thread GitBox
rabbah commented on issue #3187: reduce rule activation records URL: https://github.com/apache/incubator-openwhisk/pull/3187#issuecomment-363464521 A note on the API unit test - I had missed an important detail. The actions are activated via the REST API. So this will not work with the

[GitHub] houshengbo opened a new pull request #25: Add the support to git clone all source code based on configurations

2018-02-06 Thread GitBox
houshengbo opened a new pull request #25: Add the support to git clone all source code based on configurations URL: https://github.com/apache/incubator-openwhisk-release/pull/25 This is an automated message from the Apache

[GitHub] jcrossley3 commented on a change in pull request #3219: Kubernetes ContainerFactoryProvider implementation

2018-02-06 Thread GitBox
jcrossley3 commented on a change in pull request #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#discussion_r166361954 ## File path:

[GitHub] mhenke1 closed pull request #2968: add additional metrics and logs

2018-02-06 Thread GitBox
mhenke1 closed pull request #2968: add additional metrics and logs URL: https://github.com/apache/incubator-openwhisk/pull/2968 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] mhenke1 opened a new pull request #2968: add additional metrics and logs

2018-02-06 Thread GitBox
mhenke1 opened a new pull request #2968: add additional metrics and logs URL: https://github.com/apache/incubator-openwhisk/pull/2968 This PR ads two additional metrics: - loadbalancer_activations__count : counter for activation starts in load balancer - invoker_container_start

[GitHub] rabbah commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166344146 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] jcrossley3 commented on issue #3219: Kubernetes ContainerFactoryProvider implementation

2018-02-06 Thread GitBox
jcrossley3 commented on issue #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#issuecomment-363469757 Ok, PR has been rebased against current master and unit tests have been added. There are 2 pending ones in there

[GitHub] dubeejw closed pull request #3252: bump docker runtime for large input, perl

2018-02-06 Thread GitBox
dubeejw closed pull request #3252: bump docker runtime for large input, perl URL: https://github.com/apache/incubator-openwhisk/pull/3252 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent?

2018-02-06 Thread GitBox
rabbah commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#issuecomment-363493141 @csantanapr I generally agree the intended behavior is to just update. The concern

[GitHub] vipulkashyap111 commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent?

2018-02-06 Thread GitBox
vipulkashyap111 commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#issuecomment-363486395 Added a new variable to provide backward compatibility. I'll update the code

[GitHub] markusthoemmes commented on a change in pull request #3253: Efficiently parse CompletionMessage.

2018-02-06 Thread GitBox
markusthoemmes commented on a change in pull request #3253: Efficiently parse CompletionMessage. URL: https://github.com/apache/incubator-openwhisk/pull/3253#discussion_r166370532 ## File path: common/scala/src/main/scala/whisk/core/connector/Message.scala ## @@ -95,6

[GitHub] mrutkows opened a new issue #711: Action: Web (export): Support web-custom-options annotation

2018-02-06 Thread GitBox
mrutkows opened a new issue #711: Action: Web (export): Support web-custom-options annotation URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/711 See: https://github.com/apache/incubator-openwhisk/blob/master/docs/annotations.md

[GitHub] jasonpet commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent?

2018-02-06 Thread GitBox
jasonpet commented on issue #155: #112 Adding feature to insert document when overwrite and putIfAbsent? URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/155#issuecomment-363461659 I can add a test and update the documentation. I will open a separate PR

[GitHub] rabbah commented on a change in pull request #3219: Kubernetes ContainerFactoryProvider implementation

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#discussion_r166353657 ## File path:

[GitHub] dubeejw closed pull request #3251: Refactor List Limit Error Message

2018-02-06 Thread GitBox
dubeejw closed pull request #3251: Refactor List Limit Error Message URL: https://github.com/apache/incubator-openwhisk/pull/3251 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] markusthoemmes opened a new pull request #3256: Refactor some bits of the triggers API.

2018-02-06 Thread GitBox
markusthoemmes opened a new pull request #3256: Refactor some bits of the triggers API. URL: https://github.com/apache/incubator-openwhisk/pull/3256 Some bits of the triggers API did include duplicated code. Didn't get around to post comments to the specific PRs so here are my proposed

[GitHub] markusthoemmes commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
markusthoemmes commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166334570 ## File path:

[GitHub] markusthoemmes commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
markusthoemmes commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166334482 ## File path:

[GitHub] markusthoemmes commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
markusthoemmes commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166335942 ## File path:

[GitHub] mrutkows opened a new issue #712: Action: Web (action): Support the require-whisk-auth annotation

2018-02-06 Thread GitBox
mrutkows opened a new issue #712: Action: Web (action): Support the require-whisk-auth annotation URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/712 See: https://github.com/apache/incubator-openwhisk/blob/master/docs/annotations.md

[GitHub] houshengbo opened a new pull request #220: WIP: test travis

2018-02-06 Thread GitBox
houshengbo opened a new pull request #220: WIP: test travis URL: https://github.com/apache/incubator-openwhisk-cli/pull/220 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] rabbah commented on issue #3219: Kubernetes ContainerFactoryProvider implementation

2018-02-06 Thread GitBox
rabbah commented on issue #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#issuecomment-363498105 @jcrossley3 I know you want to preserve the history in this PR so when @markusthoemmes approves/dismisses his review,

[GitHub] rabbah commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166511928 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] rabbah commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166512012 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] tardieu commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
tardieu commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166514700 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] mrutkows closed pull request #25: Add the support to git clone all source code based on configurations

2018-02-06 Thread GitBox
mrutkows closed pull request #25: Add the support to git clone all source code based on configurations URL: https://github.com/apache/incubator-openwhisk-release/pull/25 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] tardieu commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
tardieu commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166511485 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] rabbah commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166512487 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] rabbah commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166512487 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] rabbah commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166510927 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] tardieu commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
tardieu commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166511280 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] rabbah commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
rabbah commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r16650 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] tardieu commented on a change in pull request #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
tardieu commented on a change in pull request #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#discussion_r166512248 ## File path: core/controller/src/main/scala/whisk/core/controller/actions/PrimitiveActions.scala

[GitHub] markusthoemmes commented on issue #3219: Kubernetes ContainerFactoryProvider implementation

2018-02-06 Thread GitBox
markusthoemmes commented on issue #3219: Kubernetes ContainerFactoryProvider implementation URL: https://github.com/apache/incubator-openwhisk/pull/3219#issuecomment-363654647 @jcrossley3 since all feedback seems to be addressed, it'd still be good if you can squash down or at least

[GitHub] daisy-ycguo opened a new issue #716: Add

2018-02-06 Thread GitBox
daisy-ycguo opened a new issue #716: Add URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/716 In order to compliance with Apache release policy, every artifact distributed MUST contain appropriately licensed code. I used Apache Rat to check this repository and find

[GitHub] tardieu commented on issue #3202: Support action continuations in the controller

2018-02-06 Thread GitBox
tardieu commented on issue #3202: Support action continuations in the controller URL: https://github.com/apache/incubator-openwhisk/pull/3202#issuecomment-363658304 I agree that the code with a future is simpler than the code with a promise so I am ok with the change. But, FWIW, there was

  1   2   >