[GitHub] klcodanr opened a new pull request #113: Improve Maven/Java Tooling

2018-04-12 Thread GitBox
klcodanr opened a new pull request #113: Improve Maven/Java Tooling URL: https://github.com/apache/incubator-openwhisk-devtools/pull/113 I added some new features to improve the Java tooling for OpenWhisk: - Annotations which indicate Actions, Packages, Rules and Triggers at a Class

[GitHub] yumeforever commented on issue #1825: Support triggers and rules under package?

2018-04-12 Thread GitBox
yumeforever commented on issue #1825: Support triggers and rules under package? URL: https://github.com/apache/incubator-openwhisk/issues/1825#issuecomment-380799052 Any news on this thread? Any other suggested threads to follow?

[GitHub] houshengbo commented on issue #106: Check the LICENSE of achieved files in source codes

2018-04-12 Thread GitBox
houshengbo commented on issue #106: Check the LICENSE of achieved files in source codes URL: https://github.com/apache/incubator-openwhisk-release/issues/106#issuecomment-380849370 @daisy-ycguo @mrutkows In my opinion, all the license concerns raised in this issue come from the license

[GitHub] houshengbo commented on issue #108: Some files in openwhisk-apigateway still have bad headers

2018-04-12 Thread GitBox
houshengbo commented on issue #108: Some files in openwhisk-apigateway still have bad headers URL: https://github.com/apache/incubator-openwhisk-release/issues/108#issuecomment-380850409 I opened the same issue for apigateway repo:

[GitHub] houshengbo commented on issue #108: Some files in openwhisk-apigateway still have bad headers

2018-04-12 Thread GitBox
houshengbo commented on issue #108: Some files in openwhisk-apigateway still have bad headers URL: https://github.com/apache/incubator-openwhisk-release/issues/108#issuecomment-380850409 I opened the same issue for apigateway repo:

[GitHub] houshengbo commented on issue #106: Check the LICENSE of achieved files in source codes

2018-04-12 Thread GitBox
houshengbo commented on issue #106: Check the LICENSE of achieved files in source codes URL: https://github.com/apache/incubator-openwhisk-release/issues/106#issuecomment-380849370 @daisy-ycguo @mrutkows In my opinion, all the license concerns raised in this issue come from the files of

[GitHub] csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose

2018-04-12 Thread GitBox
csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#discussion_r181151539 ## File path: README.md ## @@ -25,15 +25,27 @@ OpenWhisk is a cloud-first distributed

[GitHub] ddragosd commented on issue #114: docker-compose doesn't work unless I close chrome

2018-04-12 Thread GitBox
ddragosd commented on issue #114: docker-compose doesn't work unless I close chrome URL: https://github.com/apache/incubator-openwhisk-devtools/issues/114#issuecomment-380884869 Thanks @csantanapr . One idea I have here is to check on which IP is the PORT bound to, in order to avoid this

[GitHub] csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose

2018-04-12 Thread GitBox
csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#discussion_r181151734 ## File path: README.md ## @@ -25,15 +25,27 @@ OpenWhisk is a cloud-first distributed

[GitHub] mrutkows commented on issue #106: Check the LICENSE of achieved files in source codes

2018-04-12 Thread GitBox
mrutkows commented on issue #106: Check the LICENSE of achieved files in source codes URL: https://github.com/apache/incubator-openwhisk-release/issues/106#issuecomment-380886204 @daisy-ycguo @houshengbo We should use the issues already created to track by repo. IMO. **Issues:**

[GitHub] dubee commented on issue #3537: Add activation logs integration test

2018-04-12 Thread GitBox
dubee commented on issue #3537: Add activation logs integration test URL: https://github.com/apache/incubator-openwhisk/pull/3537#issuecomment-380888759 @markusthoemmes, anything else? This is an automated message from the

[GitHub] houshengbo commented on issue #109: Update LICENSE files to append license information of dependencies

2018-04-12 Thread GitBox
houshengbo commented on issue #109: Update LICENSE files to append license information of dependencies URL: https://github.com/apache/incubator-openwhisk-release/issues/109#issuecomment-380852528 @daisy-ycguo Sure. If we decided to remove the files of test cases from the source code

[GitHub] mcdan commented on issue #3541: Point Getting Started to docker-compose

2018-04-12 Thread GitBox
mcdan commented on issue #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#issuecomment-380861354 @chetanmeh currently getting a windows VM running so I can check on that for you.

[GitHub] csantanapr commented on issue #114: docker-compose doesn't work unless I close chrome

2018-04-12 Thread GitBox
csantanapr commented on issue #114: docker-compose doesn't work unless I close chrome URL: https://github.com/apache/incubator-openwhisk-devtools/issues/114#issuecomment-380891891 Side question any posiblity of having the Makefile work on Windows even if required bash on Windows ?

[GitHub] csantanapr commented on issue #114: docker-compose doesn't work unless I close chrome

2018-04-12 Thread GitBox
csantanapr commented on issue #114: docker-compose doesn't work unless I close chrome URL: https://github.com/apache/incubator-openwhisk-devtools/issues/114#issuecomment-380891891 Side question any posiblity of having the male file work on Windows even if required bash on Windows ?

[GitHub] dubee closed pull request #3538: Code clean up in test suites

2018-04-12 Thread GitBox
dubee closed pull request #3538: Code clean up in test suites URL: https://github.com/apache/incubator-openwhisk/pull/3538 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] mhamann commented on issue #288: Apache release does not allow to have private license as the header

2018-04-12 Thread GitBox
mhamann commented on issue #288: Apache release does not allow to have private license as the header URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/288#issuecomment-380951190 @ddragosd I think that between Adobe and IBM, we own the original copyright to these files.

[GitHub] mhamann commented on issue #288: Apache release does not allow to have private license as the header

2018-04-12 Thread GitBox
mhamann commented on issue #288: Apache release does not allow to have private license as the header URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/288#issuecomment-380951190 @ddragosd I think that between Adobe and IBM, we own the original copyright to these files.

[GitHub] drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate

2018-04-12 Thread GitBox
drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270#issuecomment-380957183 I've created https://github.com/apache/incubator-openwhisk/pull/3545 to add it back. I am also removing

[GitHub] gorkem commented on issue #113: Improve Maven/Java Tooling

2018-04-12 Thread GitBox
gorkem commented on issue #113: Improve Maven/Java Tooling URL: https://github.com/apache/incubator-openwhisk-devtools/pull/113#issuecomment-380962083 @ddragosd sure, looking at it This is an automated message from the

[GitHub] csantanapr opened a new issue #115: make docker failes with Project 'swift3Action' not found in project ':core'.

2018-04-12 Thread GitBox
csantanapr opened a new issue #115: make docker failes with Project 'swift3Action' not found in project ':core'. URL: https://github.com/apache/incubator-openwhisk-devtools/issues/115 Docker for Mac steps to replicate ```  $ make docker building the docker images ...

[GitHub] csantanapr commented on issue #3544: make docker failes with Project 'swift3Action' not found in project ':core'.

2018-04-12 Thread GitBox
csantanapr commented on issue #3544: make docker failes with Project 'swift3Action' not found in project ':core'. URL: https://github.com/apache/incubator-openwhisk/issues/3544#issuecomment-380953550 wrong repo, correct place ->

[GitHub] drcariel opened a new pull request #3545: add timeout.js back

2018-04-12 Thread GitBox
drcariel opened a new pull request #3545: add timeout.js back URL: https://github.com/apache/incubator-openwhisk/pull/3545 needed for https://github.com/apache/incubator-openwhisk-cli/pull/270 to pass ## Description ## Related issue and scope - [ ] I opened an

[GitHub] pritidesai commented on a change in pull request #862: Documentation for the export feature

2018-04-12 Thread GitBox
pritidesai commented on a change in pull request #862: Documentation for the export feature URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/862#discussion_r181238677 ## File path: docs/export.md ## @@ -0,0 +1,300 @@ +# Using `wskdeploy` for exporting

[GitHub] drcariel closed pull request #270: use utils from open and rename duplicate tests to be accurate

2018-04-12 Thread GitBox
drcariel closed pull request #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of

[GitHub] drcariel opened a new pull request #270: use utils from open and rename duplicate tests to be accurate

2018-04-12 Thread GitBox
drcariel opened a new pull request #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270 - Gets rid of TestCLIUtils entirely to rely on TestUtils in open repo. - Moves timestamp method to sed TestUtils -

[GitHub] yadavvipinsonu commented on issue #2317: wsk api authentication issues

2018-04-12 Thread GitBox
yadavvipinsonu commented on issue #2317: wsk api authentication issues URL: https://github.com/apache/incubator-openwhisk/issues/2317#issuecomment-38097 @mdeuser thansk for your response ! Based on your comments i tried to install routemgmt.yml file and got below error

[GitHub] drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate

2018-04-12 Thread GitBox
drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270#issuecomment-380957183 I've created https://github.com/apache/incubator-openwhisk/pull/3545 to add it back. I am also removing

[GitHub] drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate

2018-04-12 Thread GitBox
drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270#issuecomment-380957183 I've created https://github.com/apache/incubator-openwhisk/pull/3545 to add it back. I am also removing

[GitHub] tysonnorris opened a new issue #3542: wsk action get --save should work for docker actions

2018-04-12 Thread GitBox
tysonnorris opened a new issue #3542: wsk action get --save should work for docker actions URL: https://github.com/apache/incubator-openwhisk/issues/3542 ## Environment details: * local deployment ## Steps to reproduce the issue: 1. create a docker action

[GitHub] dubee closed pull request #3531: More test clean up

2018-04-12 Thread GitBox
dubee closed pull request #3531: More test clean up URL: https://github.com/apache/incubator-openwhisk/pull/3531 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

[GitHub] csantanapr opened a new issue #3544: make docker failes with Project 'swift3Action' not found in project ':core'.

2018-04-12 Thread GitBox
csantanapr opened a new issue #3544: make docker failes with Project 'swift3Action' not found in project ':core'. URL: https://github.com/apache/incubator-openwhisk/issues/3544 Docker for Mac steps to replicate ```  $ make docker building the docker images ... Starting a

[GitHub] csantanapr commented on issue #118: Errors on start-docker-compose

2018-04-12 Thread GitBox
csantanapr commented on issue #118: Errors on start-docker-compose URL: https://github.com/apache/incubator-openwhisk-devtools/issues/118#issuecomment-380964539 I was able to fix this by running `docker-compose up` and I got prompted and type `y` ``` ERROR: The image for the

[GitHub] csantanapr closed issue #118: Errors on start-docker-compose

2018-04-12 Thread GitBox
csantanapr closed issue #118: Errors on start-docker-compose URL: https://github.com/apache/incubator-openwhisk-devtools/issues/118 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] ddragosd commented on issue #113: Improve Maven/Java Tooling

2018-04-12 Thread GitBox
ddragosd commented on issue #113: Improve Maven/Java Tooling URL: https://github.com/apache/incubator-openwhisk-devtools/pull/113#issuecomment-380949388 @klcodanr this looks really nice. One thought I have is regarding the deploy process. Are you familiar with

[GitHub] csantanapr closed issue #3544: make docker failes with Project 'swift3Action' not found in project ':core'.

2018-04-12 Thread GitBox
csantanapr closed issue #3544: make docker failes with Project 'swift3Action' not found in project ':core'. URL: https://github.com/apache/incubator-openwhisk/issues/3544 This is an automated message from the Apache Git

[GitHub] csantanapr commented on issue #3543: [discuss] docker compose make quick start hangs

2018-04-12 Thread GitBox
csantanapr commented on issue #3543: [discuss] docker compose make quick start hangs URL: https://github.com/apache/incubator-openwhisk/issues/3543#issuecomment-380953753 wrong repo, correct place https://github.com/apache/incubator-openwhisk-devtools/issues/116

[GitHub] csantanapr opened a new issue #116: docker compose make quick start hangs

2018-04-12 Thread GitBox
csantanapr opened a new issue #116: docker compose make quick start hangs URL: https://github.com/apache/incubator-openwhisk-devtools/issues/116 This is a problem I keep hitting. After a while, I would have an old version of `openwhisk/controller:latest` locally. When running

[GitHub] csantanapr closed issue #3543: [discuss] docker compose make quick start hangs

2018-04-12 Thread GitBox
csantanapr closed issue #3543: [discuss] docker compose make quick start hangs URL: https://github.com/apache/incubator-openwhisk/issues/3543 This is an automated message from the Apache Git Service. To respond to the

[GitHub] csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose

2018-04-12 Thread GitBox
csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#discussion_r181243430 ## File path: .project ## @@ -5,6 +5,11 @@ + +

[GitHub] csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose

2018-04-12 Thread GitBox
csantanapr commented on a change in pull request #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#discussion_r181243225 ## File path: mesos.env ## @@ -0,0 +1 @@ +CONFIG_whisk_mesos_master-url = "http://m1.dcos;

[GitHub] drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate

2018-04-12 Thread GitBox
drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270#issuecomment-380955318 ugh, so I should go add timeout.js back to `incubator-openwhisk`? or just not make any changes to

[GitHub] drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate

2018-04-12 Thread GitBox
drcariel commented on issue #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270#issuecomment-380955318 ugh, so I should go add timeout.js back to `incubator-openwhisk`? or just not make any changes to

[GitHub] rabbah commented on issue #270: use utils from open and rename duplicate tests to be accurate

2018-04-12 Thread GitBox
rabbah commented on issue #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270#issuecomment-380969762 Oh never mind this is the cli repo. Good move.

[GitHub] rabbah commented on issue #3545: add timeout.js back

2018-04-12 Thread GitBox
rabbah commented on issue #3545: add timeout.js back URL: https://github.com/apache/incubator-openwhisk/pull/3545#issuecomment-380970064 Rather than add this back can you adapt the dependent test to use the new version that Sven added?

[GitHub] ddragosd commented on issue #113: Improve Maven/Java Tooling

2018-04-12 Thread GitBox
ddragosd commented on issue #113: Improve Maven/Java Tooling URL: https://github.com/apache/incubator-openwhisk-devtools/pull/113#issuecomment-380950703 @kameshsampath @gorkem may I ask for your help reviewing this PR, since you made the initial java contributions ?

[GitHub] csantanapr opened a new issue #3543: [discuss] docker compose make quick start hangs

2018-04-12 Thread GitBox
csantanapr opened a new issue #3543: [discuss] docker compose make quick start hangs URL: https://github.com/apache/incubator-openwhisk/issues/3543 This is a problem I keep hitting. After a while, I would have an old version of `openwhisk/controller:latest` locally. When

[GitHub] csantanapr opened a new pull request #117: do docker pull for quick start

2018-04-12 Thread GitBox
csantanapr opened a new pull request #117: do docker pull for quick start URL: https://github.com/apache/incubator-openwhisk-devtools/pull/117 Closes #116 Closes #115 This is an automated message from the Apache Git

[GitHub] rabbah commented on issue #270: use utils from open and rename duplicate tests to be accurate

2018-04-12 Thread GitBox
rabbah commented on issue #270: use utils from open and rename duplicate tests to be accurate URL: https://github.com/apache/incubator-openwhisk-cli/pull/270#issuecomment-380969610 Wait - why are all the samples being deleted here?

[GitHub] csantanapr opened a new issue #118: Errors on start-docker-compose

2018-04-12 Thread GitBox
csantanapr opened a new issue #118: Errors on start-docker-compose URL: https://github.com/apache/incubator-openwhisk-devtools/issues/118 I get this error when running docker compose ``` waiting for the database to come up ... on 9.27.118.111 Starting openwhisk_redis_1 ... done

[GitHub] chetanmeh commented on issue #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation

2018-04-12 Thread GitBox
chetanmeh commented on issue #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#issuecomment-381031566 @rabbah Currently there is a ignored test `count with skip` in `ArtifactStoreQueryBehaviors` as

[GitHub] pulasthi opened a new issue #180: accessing the couchdb instance separately

2018-04-12 Thread GitBox
pulasthi opened a new issue #180: accessing the couchdb instance separately URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/180 Hi Devs, I have a openwhisk cluster deployed, and for my application, I want to access the internal couchDB database 1. From within

[GitHub] chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation

2018-04-12 Thread GitBox
chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181288290 ## File path:

[GitHub] pritidesai opened a new pull request #268: WIP: adding whisk deploy manifests

2018-04-12 Thread GitBox
pritidesai opened a new pull request #268: WIP: adding whisk deploy manifests URL: https://github.com/apache/incubator-openwhisk-catalog/pull/268 Closes #267 This is an automated message from the Apache Git Service. To

[GitHub] bbrowning commented on issue #2855: Cache database attachments

2018-04-12 Thread GitBox
bbrowning commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-381009037 Another update - the tests can be fixed by just removing the "completed uploading attachment..." lines from the expected output checks in

[GitHub] chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation

2018-04-12 Thread GitBox
chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181289802 ## File path:

[GitHub] bbrowning commented on issue #2855: Cache database attachments

2018-04-12 Thread GitBox
bbrowning commented on issue #2855: Cache database attachments URL: https://github.com/apache/incubator-openwhisk/pull/2855#issuecomment-380986882 I've observed some very poor performance for Java actions and with the help of @rabbah I think I've narrowed it down to the Invokers fetching

[GitHub] rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation

2018-04-12 Thread GitBox
rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r179639389 ## File path:

[GitHub] rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation

2018-04-12 Thread GitBox
rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181276164 ## File path:

[GitHub] rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation

2018-04-12 Thread GitBox
rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181275972 ## File path:

[GitHub] rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation

2018-04-12 Thread GitBox
rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r180482957 ## File path:

[GitHub] rabbah commented on issue #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation

2018-04-12 Thread GitBox
rabbah commented on issue #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#issuecomment-381007908 @dubee @csantanapr @markusthoemmes  a pg to be safe although I expect Travis to be sufficient.

[GitHub] rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation

2018-04-12 Thread GitBox
rabbah commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181275606 ## File path:

[GitHub] chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation

2018-04-12 Thread GitBox
chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181287479 ## File path:

[GitHub] chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation

2018-04-12 Thread GitBox
chetanmeh commented on a change in pull request #3517: MemoryArtifactStore for unit testing and ArtifactStore SPI Validation URL: https://github.com/apache/incubator-openwhisk/pull/3517#discussion_r181288490 ## File path:

[GitHub] pritidesai opened a new pull request #870: WIP: Introducing package level parameters

2018-04-12 Thread GitBox
pritidesai opened a new pull request #870: WIP: Introducing package level parameters URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/870 Closes #803 This is an automated message from the Apache Git

[GitHub] rabbah commented on issue #3502: Immutable attachments via putAndAttach

2018-04-12 Thread GitBox
rabbah commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-381006472 @dubee @csantanapr @markusthoemmes needs a pg. This is an automated

[GitHub] rabbah commented on issue #3502: Immutable attachments via putAndAttach

2018-04-12 Thread GitBox
rabbah commented on issue #3502: Immutable attachments via putAndAttach URL: https://github.com/apache/incubator-openwhisk/pull/3502#issuecomment-381006472 @dubee @csantanapr @markusthoemmes needs a pg.  This is an

[GitHub] tysonnorris commented on issue #3211: implement ContainerFactory.cpuShare to fix #3110

2018-04-12 Thread GitBox
tysonnorris commented on issue #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#issuecomment-381027426 hopefully this will do it This is an automated

[GitHub] csantanapr opened a new issue #114: docker-compose doesn't work unless I close chrome

2018-04-12 Thread GitBox
csantanapr opened a new issue #114: docker-compose doesn't work unless I close chrome URL: https://github.com/apache/incubator-openwhisk-devtools/issues/114 ## environment OS: MacOS 10.13.4 Docker for Mac:version 18.03.0-ce-mac59 (23608) ## Steps to replicate: ```

[GitHub] mcdan opened a new pull request #3541: Point Getting Started to docker-compose

2018-04-12 Thread GitBox
mcdan opened a new pull request #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541 ## Description ## Related issue and scope - [ ] I opened an issue to propose and discuss this change (#) ## My

[GitHub] houshengbo opened a new issue #288: Apache release does not allow to have private license as the header

2018-04-12 Thread GitBox
houshengbo opened a new issue #288: Apache release does not allow to have private license as the header URL: https://github.com/apache/incubator-openwhisk-apigateway/issues/288 We have MIT license and adobe copyright in below files: ``` MIT

[GitHub] houshengbo commented on issue #107: Do we need to add LICENSE header to binary files?

2018-04-12 Thread GitBox
houshengbo commented on issue #107: Do we need to add LICENSE header to binary files? URL: https://github.com/apache/incubator-openwhisk-release/issues/107#issuecomment-380843723 @daisy-ycguo @mrutkows To me, these files can be left without Apache headers, and we can document it in the

[GitHub] ddragosd commented on issue #3541: Point Getting Started to docker-compose

2018-04-12 Thread GitBox
ddragosd commented on issue #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#issuecomment-380845787 LGTM. We can decide later about the state of Vagrant. This is an

[GitHub] chetanmeh commented on issue #3541: Point Getting Started to docker-compose

2018-04-12 Thread GitBox
chetanmeh commented on issue #3541: Point Getting Started to docker-compose URL: https://github.com/apache/incubator-openwhisk/pull/3541#issuecomment-380848697 Would be helpful to also validate if docker compose based setup works fine on Windows or not and see what minimum Windows version

[GitHub] pritidesai opened a new pull request #869: WIP: converting json blob to its own supported types in annotations

2018-04-12 Thread GitBox
pritidesai opened a new pull request #869: WIP: converting json blob to its own supported types in annotations URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/869 This is an automated message from the

[GitHub] markusthoemmes commented on a change in pull request #3537: Add activation logs integration test

2018-04-12 Thread GitBox
markusthoemmes commented on a change in pull request #3537: Add activation logs integration test URL: https://github.com/apache/incubator-openwhisk/pull/3537#discussion_r180973156 ## File path: tests/src/test/scala/system/basic/WskActivationTests.scala ## @@ -0,0 +1,51